* [PATCH] util-linux: create util-linux-runuser package
@ 2015-11-09 14:01 Ioan-Adrian Ratiu
2015-11-09 21:15 ` Richard Tollerton
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-11-09 14:01 UTC (permalink / raw)
To: openembedded-core
Split runuser into its own package (previously provided by util-linux).
Since runuser is compiled only when DISTRO_FEATURES includes pam,
the creation of util-linux-runuser is also constrainted by this.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
meta/recipes-core/util-linux/util-linux.inc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 594108f..10a1ded 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
util-linux-partx ${PN}-bash-completion util-linux-hwclock \
util-linux-findfs util-linux-getopt util-linux-sulogin"
PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
+PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
PACKAGES_DYNAMIC = "^util-linux-lib.*"
@@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
FILES_util-linux-findfs = "${sbindir}/findfs"
FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
+FILES_util-linux-runuser = "${sbindir}/runuser"
FILES_util-linux-pylibmount = "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \
${libdir}/${PYTHON_DIR}/dist-packages/libmount/__init__.*"
@@ -106,6 +108,8 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
# reset calls 'tput'
RDEPENDS_util-linux-reset += "ncurses"
+RDEPENDS_util-linux-runuser += "libpam"
+
RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] util-linux: create util-linux-runuser package
2015-11-09 14:01 [PATCH] util-linux: create util-linux-runuser package Ioan-Adrian Ratiu
@ 2015-11-09 21:15 ` Richard Tollerton
2015-11-10 8:31 ` Ioan-Adrian Ratiu
2015-11-10 8:50 ` [PATCH v2] " Ioan-Adrian Ratiu
2015-11-11 8:48 ` [PATCH v3] " Ioan-Adrian Ratiu
2 siblings, 1 reply; 7+ messages in thread
From: Richard Tollerton @ 2015-11-09 21:15 UTC (permalink / raw)
To: Ioan-Adrian Ratiu, openembedded-core
Ioan-Adrian Ratiu <adrian.ratiu@ni.com> writes:
> RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
> RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
Should we add util-linux-runuser to either RDEPENDS or RRECOMMENDS?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] util-linux: create util-linux-runuser package
2015-11-09 21:15 ` Richard Tollerton
@ 2015-11-10 8:31 ` Ioan-Adrian Ratiu
0 siblings, 0 replies; 7+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-11-10 8:31 UTC (permalink / raw)
To: Richard Tollerton; +Cc: openembedded-core
On Mon, 9 Nov 2015 15:15:54 -0600
Richard Tollerton <rich.tollerton@ni.com> wrote:
> Ioan-Adrian Ratiu <adrian.ratiu@ni.com> writes:
>
> > RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
> > RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
>
> Should we add util-linux-runuser to either RDEPENDS or RRECOMMENDS?
Yes, definitely to RDEPENDS since users of util-linux might expect
runuser as it was provided by default. Thanks for spotting this.
I also missed the commit message typo, fixed in v2.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] util-linux: create util-linux-runuser package
2015-11-09 14:01 [PATCH] util-linux: create util-linux-runuser package Ioan-Adrian Ratiu
2015-11-09 21:15 ` Richard Tollerton
@ 2015-11-10 8:50 ` Ioan-Adrian Ratiu
2015-11-10 14:48 ` Mike Looijmans
2015-11-11 8:48 ` [PATCH v3] " Ioan-Adrian Ratiu
2 siblings, 1 reply; 7+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-11-10 8:50 UTC (permalink / raw)
To: openembedded-core
Split runuser into its own package (previously provided by util-linux).
Since runuser is compiled only when DISTRO_FEATURES includes pam,
the creation of util-linux-runuser is also constrained by this.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
meta/recipes-core/util-linux/util-linux.inc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 594108f..dc460e7 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
util-linux-partx ${PN}-bash-completion util-linux-hwclock \
util-linux-findfs util-linux-getopt util-linux-sulogin"
PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
+PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
PACKAGES_DYNAMIC = "^util-linux-lib.*"
@@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
FILES_util-linux-findfs = "${sbindir}/findfs"
FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
+FILES_util-linux-runuser = "${sbindir}/runuser"
FILES_util-linux-pylibmount = "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \
${libdir}/${PYTHON_DIR}/dist-packages/libmount/__init__.*"
@@ -106,7 +108,9 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
# reset calls 'tput'
RDEPENDS_util-linux-reset += "ncurses"
-RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
+RDEPENDS_util-linux-runuser += "libpam"
+
+RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-runuser"
RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
RRECOMMENDS_${PN}_class-native = ""
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] util-linux: create util-linux-runuser package
2015-11-10 8:50 ` [PATCH v2] " Ioan-Adrian Ratiu
@ 2015-11-10 14:48 ` Mike Looijmans
2015-11-10 14:54 ` Paul Eggleton
0 siblings, 1 reply; 7+ messages in thread
From: Mike Looijmans @ 2015-11-10 14:48 UTC (permalink / raw)
To: Ioan-Adrian Ratiu, openembedded-core
On 10-11-15 09:50, Ioan-Adrian Ratiu wrote:
> Split runuser into its own package (previously provided by util-linux).
> Since runuser is compiled only when DISTRO_FEATURES includes pam,
> the creation of util-linux-runuser is also constrained by this.
>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
> meta/recipes-core/util-linux/util-linux.inc | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
> index 594108f..dc460e7 100644
> --- a/meta/recipes-core/util-linux/util-linux.inc
> +++ b/meta/recipes-core/util-linux/util-linux.inc
> @@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
> util-linux-partx ${PN}-bash-completion util-linux-hwclock \
> util-linux-findfs util-linux-getopt util-linux-sulogin"
> PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
> +PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
>
> PACKAGES_DYNAMIC = "^util-linux-lib.*"
>
> @@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
> FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
> FILES_util-linux-findfs = "${sbindir}/findfs"
> FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
> +FILES_util-linux-runuser = "${sbindir}/runuser"
>
> FILES_util-linux-pylibmount = "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \
> ${libdir}/${PYTHON_DIR}/dist-packages/libmount/__init__.*"
> @@ -106,7 +108,9 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
> # reset calls 'tput'
> RDEPENDS_util-linux-reset += "ncurses"
>
> -RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
> +RDEPENDS_util-linux-runuser += "libpam"
> +
> +RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin util-linux-runuser"
I think that will need to be conditional. Without pam, you won't be able to
install util-linux because of the missing util-linux-runuser dependency.
> RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
>
> RRECOMMENDS_${PN}_class-native = ""
>
Kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
Telefax: +31 (0) 499 33 69 70
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com
Please consider the environment before printing this e-mail
Visit us at : Aerospace Electrical Systems Expo Europe which will be held from 17.11.2015 till 19.11.2015, Findorffstrasse 101 Bremen, Germany, Hall 5, stand number C65
http://www.aesexpo.eu
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] util-linux: create util-linux-runuser package
2015-11-10 14:48 ` Mike Looijmans
@ 2015-11-10 14:54 ` Paul Eggleton
0 siblings, 0 replies; 7+ messages in thread
From: Paul Eggleton @ 2015-11-10 14:54 UTC (permalink / raw)
To: Ioan-Adrian Ratiu; +Cc: Mike Looijmans, openembedded-core
On Tuesday 10 November 2015 15:48:59 Mike Looijmans wrote:
> On 10-11-15 09:50, Ioan-Adrian Ratiu wrote:
> > Split runuser into its own package (previously provided by util-linux).
> > Since runuser is compiled only when DISTRO_FEATURES includes pam,
> > the creation of util-linux-runuser is also constrained by this.
> >
> > Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> > ---
> >
> > meta/recipes-core/util-linux/util-linux.inc | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/util-linux/util-linux.inc
> > b/meta/recipes-core/util-linux/util-linux.inc index 594108f..dc460e7
> > 100644
> > --- a/meta/recipes-core/util-linux/util-linux.inc
> > +++ b/meta/recipes-core/util-linux/util-linux.inc
> > @@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk
> > util-linux-cfdisk util-linux-sfd>
> > util-linux-partx ${PN}-bash-completion util-linux-hwclock \
> > util-linux-findfs util-linux-getopt util-linux-sulogin"
> >
> > PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount',
> > 'util-linux-pylibmount', '', d)}">
> > +PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam',
> > 'util-linux-runuser', '', d)}">
> > PACKAGES_DYNAMIC = "^util-linux-lib.*"
> >
> > @@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
> >
> > FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
> > FILES_util-linux-findfs = "${sbindir}/findfs"
> > FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
> >
> > +FILES_util-linux-runuser = "${sbindir}/runuser"
> >
> > FILES_util-linux-pylibmount =
> > "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \>
> > ${libdir}/${PYTHON_DIR}/dist-packages/lib
> > mount/__init__.*"
> >
> > @@ -106,7 +108,9 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
> >
> > # reset calls 'tput'
> > RDEPENDS_util-linux-reset += "ncurses"
> >
> > -RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff
> > util-linux-losetup util-linux-sulogin" +RDEPENDS_util-linux-runuser +=
> > "libpam"
> > +
> > +RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff
> > util-linux-losetup util-linux-sulogin util-linux-runuser"
>
> I think that will need to be conditional. Without pam, you won't be able to
> install util-linux because of the missing util-linux-runuser dependency.
Not to mention you'll get a build time warning because pam is being built
without the feature enabled.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] util-linux: create util-linux-runuser package
2015-11-09 14:01 [PATCH] util-linux: create util-linux-runuser package Ioan-Adrian Ratiu
2015-11-09 21:15 ` Richard Tollerton
2015-11-10 8:50 ` [PATCH v2] " Ioan-Adrian Ratiu
@ 2015-11-11 8:48 ` Ioan-Adrian Ratiu
2 siblings, 0 replies; 7+ messages in thread
From: Ioan-Adrian Ratiu @ 2015-11-11 8:48 UTC (permalink / raw)
To: openembedded-core; +Cc: mike.looijmans, paul.eggleton
Split runuser into its own package (previously provided by util-linux).
Since runuser is compiled only when DISTRO_FEATURES includes pam,
the creation of util-linux-runuser is also constrained by this.
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
meta/recipes-core/util-linux/util-linux.inc | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc
index 594108f..f84a415 100644
--- a/meta/recipes-core/util-linux/util-linux.inc
+++ b/meta/recipes-core/util-linux/util-linux.inc
@@ -34,6 +34,7 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd
util-linux-partx ${PN}-bash-completion util-linux-hwclock \
util-linux-findfs util-linux-getopt util-linux-sulogin"
PACKAGES += "${@bb.utils.contains('PACKAGECONFIG', 'pylibmount', 'util-linux-pylibmount', '', d)}"
+PACKAGES =+ "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
PACKAGES_DYNAMIC = "^util-linux-lib.*"
@@ -85,6 +86,7 @@ FILES_util-linux-partx = "${sbindir}/partx"
FILES_util-linux-hwclock = "${base_sbindir}/hwclock.${BPN}"
FILES_util-linux-findfs = "${sbindir}/findfs"
FILES_util-linux-getopt = "${base_bindir}/getopt.${BPN}"
+FILES_util-linux-runuser = "${sbindir}/runuser"
FILES_util-linux-pylibmount = "${libdir}/${PYTHON_DIR}/dist-packages/libmount/pylibmount.so \
${libdir}/${PYTHON_DIR}/dist-packages/libmount/__init__.*"
@@ -106,7 +108,11 @@ RREPLACES_util-linux-blkid = "e2fsprogs-blkid"
# reset calls 'tput'
RDEPENDS_util-linux-reset += "ncurses"
+RDEPENDS_util-linux-runuser += "libpam"
+
RDEPENDS_${PN} = "util-linux-umount util-linux-swaponoff util-linux-losetup util-linux-sulogin"
+RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'util-linux-runuser', '', d)}"
+
RRECOMMENDS_${PN} = "util-linux-fdisk util-linux-cfdisk util-linux-sfdisk util-linux-mount util-linux-readprofile util-linux-mkfs "
RRECOMMENDS_${PN}_class-native = ""
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-11 8:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-09 14:01 [PATCH] util-linux: create util-linux-runuser package Ioan-Adrian Ratiu
2015-11-09 21:15 ` Richard Tollerton
2015-11-10 8:31 ` Ioan-Adrian Ratiu
2015-11-10 8:50 ` [PATCH v2] " Ioan-Adrian Ratiu
2015-11-10 14:48 ` Mike Looijmans
2015-11-10 14:54 ` Paul Eggleton
2015-11-11 8:48 ` [PATCH v3] " Ioan-Adrian Ratiu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.