* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
@ 2015-11-12 17:23 Philipp Rosenberger
2015-11-12 18:12 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Philipp Rosenberger @ 2015-11-12 17:23 UTC (permalink / raw)
To: u-boot
The Cyclone V Hard Processor System Technical Reference Manual in the
chapter about the Reset Manager Module Address Map stats that the offset
of the tstscratch register ist 0x54 not 0x24.
Cyclone V Hard Processor System Technical Reference Manual cv_5v4 2015.11.02
page 3-17 Reset Manager Module Address Map
Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
---
arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h b/arch/arm/mach-socfpga/include/mach/reset_manager.h
index 8e59578..6eb6011 100644
--- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
+++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
@@ -25,6 +25,7 @@ struct socfpga_reset_manager {
u32 per2_mod_reset;
u32 brg_mod_reset;
u32 misc_mod_reset;
+ u32 padding2[12];
u32 tstscratch;
};
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-12 17:23 [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register Philipp Rosenberger
@ 2015-11-12 18:12 ` Marek Vasut
2015-11-12 21:58 ` Marek Vasut
2015-11-13 6:11 ` Stefan Roese
2 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2015-11-12 18:12 UTC (permalink / raw)
To: u-boot
On Thursday, November 12, 2015 at 06:23:10 PM, Philipp Rosenberger wrote:
> The Cyclone V Hard Processor System Technical Reference Manual in the
> chapter about the Reset Manager Module Address Map stats that the offset
> of the tstscratch register ist 0x54 not 0x24.
>
> Cyclone V Hard Processor System Technical Reference Manual cv_5v4
> 2015.11.02 page 3-17 Reset Manager Module Address Map
>
> Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
Acked-by: Marek Vasut <marex@denx.de>
Thanks for spotting this!
> ---
> arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> b/arch/arm/mach-socfpga/include/mach/reset_manager.h index
> 8e59578..6eb6011 100644
> --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
> u32 per2_mod_reset;
> u32 brg_mod_reset;
> u32 misc_mod_reset;
> + u32 padding2[12];
> u32 tstscratch;
> };
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-12 17:23 [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register Philipp Rosenberger
2015-11-12 18:12 ` Marek Vasut
@ 2015-11-12 21:58 ` Marek Vasut
2015-11-13 6:11 ` Stefan Roese
2 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2015-11-12 21:58 UTC (permalink / raw)
To: u-boot
On Thursday, November 12, 2015 at 06:23:10 PM, Philipp Rosenberger wrote:
> The Cyclone V Hard Processor System Technical Reference Manual in the
> chapter about the Reset Manager Module Address Map stats that the offset
> of the tstscratch register ist 0x54 not 0x24.
>
> Cyclone V Hard Processor System Technical Reference Manual cv_5v4
> 2015.11.02 page 3-17 Reset Manager Module Address Map
>
> Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
Applied, thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-12 17:23 [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register Philipp Rosenberger
2015-11-12 18:12 ` Marek Vasut
2015-11-12 21:58 ` Marek Vasut
@ 2015-11-13 6:11 ` Stefan Roese
2015-11-13 7:13 ` Marek Vasut
2 siblings, 1 reply; 7+ messages in thread
From: Stefan Roese @ 2015-11-13 6:11 UTC (permalink / raw)
To: u-boot
Hi Philipp,
On 12.11.2015 18:23, Philipp Rosenberger wrote:
> The Cyclone V Hard Processor System Technical Reference Manual in the
> chapter about the Reset Manager Module Address Map stats that the offset
> of the tstscratch register ist 0x54 not 0x24.
>
> Cyclone V Hard Processor System Technical Reference Manual cv_5v4 2015.11.02
> page 3-17 Reset Manager Module Address Map
>
> Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
> ---
> arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> index 8e59578..6eb6011 100644
> --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
> u32 per2_mod_reset;
> u32 brg_mod_reset;
> u32 misc_mod_reset;
> + u32 padding2[12];
> u32 tstscratch;
> };
Thanks. But usually such padding things are added as "u8" (1 byte)
variables. This makes it easier to calculate the offsets. In this
case:
+ u8 padding2[0x30];
which I would prefer.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-13 6:11 ` Stefan Roese
@ 2015-11-13 7:13 ` Marek Vasut
2015-11-13 8:02 ` Philipp Rosenberger
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2015-11-13 7:13 UTC (permalink / raw)
To: u-boot
On Friday, November 13, 2015 at 07:11:18 AM, Stefan Roese wrote:
> Hi Philipp,
>
> On 12.11.2015 18:23, Philipp Rosenberger wrote:
> > The Cyclone V Hard Processor System Technical Reference Manual in the
> > chapter about the Reset Manager Module Address Map stats that the offset
> > of the tstscratch register ist 0x54 not 0x24.
> >
> > Cyclone V Hard Processor System Technical Reference Manual cv_5v4
> > 2015.11.02 page 3-17 Reset Manager Module Address Map
> >
> > Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
> > ---
> >
> > arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > b/arch/arm/mach-socfpga/include/mach/reset_manager.h index
> > 8e59578..6eb6011 100644
> > --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> > @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
> >
> > u32 per2_mod_reset;
> > u32 brg_mod_reset;
> > u32 misc_mod_reset;
> >
> > + u32 padding2[12];
> >
> > u32 tstscratch;
> >
> > };
>
> Thanks. But usually such padding things are added as "u8" (1 byte)
> variables. This makes it easier to calculate the offsets. In this
> case:
>
> + u8 padding2[0x30];
>
> which I would prefer.
I don't mind either way, I can amend the patch (if you don't mind),
so let's hear Dinh's final word.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-13 7:13 ` Marek Vasut
@ 2015-11-13 8:02 ` Philipp Rosenberger
2015-11-13 8:04 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Philipp Rosenberger @ 2015-11-13 8:02 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 13.11.2015 08:13, Marek Vasut wrote:
> On Friday, November 13, 2015 at 07:11:18 AM, Stefan Roese wrote:
>> Hi Philipp,
>>
>> On 12.11.2015 18:23, Philipp Rosenberger wrote:
>>> The Cyclone V Hard Processor System Technical Reference Manual in the
>>> chapter about the Reset Manager Module Address Map stats that the offset
>>> of the tstscratch register ist 0x54 not 0x24.
>>>
>>> Cyclone V Hard Processor System Technical Reference Manual cv_5v4
>>> 2015.11.02 page 3-17 Reset Manager Module Address Map
>>>
>>> Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
>>> ---
>>>
>>> arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h
>>> b/arch/arm/mach-socfpga/include/mach/reset_manager.h index
>>> 8e59578..6eb6011 100644
>>> --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
>>> +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
>>> @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
>>>
>>> u32 per2_mod_reset;
>>> u32 brg_mod_reset;
>>> u32 misc_mod_reset;
>>>
>>> + u32 padding2[12];
>>>
>>> u32 tstscratch;
>>>
>>> };
>>
>> Thanks. But usually such padding things are added as "u8" (1 byte)
>> variables. This makes it easier to calculate the offsets. In this
>> case:
>>
>> + u8 padding2[0x30];
>>
>> which I would prefer.
>
> I don't mind either way, I can amend the patch (if you don't mind),
> so let's hear Dinh's final word.
If we use u8 in the place we should change the padding1 in the same
struct as well.
Best Regards
Philipp Rosenberger
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register
2015-11-13 8:02 ` Philipp Rosenberger
@ 2015-11-13 8:04 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2015-11-13 8:04 UTC (permalink / raw)
To: u-boot
On Friday, November 13, 2015 at 09:02:43 AM, Philipp Rosenberger wrote:
> Hi Marek,
>
> On 13.11.2015 08:13, Marek Vasut wrote:
> > On Friday, November 13, 2015 at 07:11:18 AM, Stefan Roese wrote:
> >> Hi Philipp,
> >>
> >> On 12.11.2015 18:23, Philipp Rosenberger wrote:
> >>> The Cyclone V Hard Processor System Technical Reference Manual in the
> >>> chapter about the Reset Manager Module Address Map stats that the
> >>> offset of the tstscratch register ist 0x54 not 0x24.
> >>>
> >>> Cyclone V Hard Processor System Technical Reference Manual cv_5v4
> >>> 2015.11.02 page 3-17 Reset Manager Module Address Map
> >>>
> >>> Signed-off-by: Philipp Rosenberger <ilu@linutronix.de>
> >>> ---
> >>>
> >>> arch/arm/mach-socfpga/include/mach/reset_manager.h | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> >>> b/arch/arm/mach-socfpga/include/mach/reset_manager.h index
> >>> 8e59578..6eb6011 100644
> >>> --- a/arch/arm/mach-socfpga/include/mach/reset_manager.h
> >>> +++ b/arch/arm/mach-socfpga/include/mach/reset_manager.h
> >>> @@ -25,6 +25,7 @@ struct socfpga_reset_manager {
> >>>
> >>> u32 per2_mod_reset;
> >>> u32 brg_mod_reset;
> >>> u32 misc_mod_reset;
> >>>
> >>> + u32 padding2[12];
> >>>
> >>> u32 tstscratch;
> >>>
> >>> };
> >>
> >> Thanks. But usually such padding things are added as "u8" (1 byte)
> >> variables. This makes it easier to calculate the offsets. In this
> >> case:
> >>
> >> + u8 padding2[0x30];
> >>
> >> which I would prefer.
> >
> > I don't mind either way, I can amend the patch (if you don't mind),
> > so let's hear Dinh's final word.
>
> If we use u8 in the place we should change the padding1 in the same
> struct as well.
In that case, we keep it as-is . Subsequent patch is welcome if anyone cares.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-13 8:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 17:23 [U-Boot] [PATCH] arm: socfpga: reset: FIX address of tstscratch register Philipp Rosenberger
2015-11-12 18:12 ` Marek Vasut
2015-11-12 21:58 ` Marek Vasut
2015-11-13 6:11 ` Stefan Roese
2015-11-13 7:13 ` Marek Vasut
2015-11-13 8:02 ` Philipp Rosenberger
2015-11-13 8:04 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.