All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn
@ 2015-11-12 18:33 Eric Blake
  2015-11-13  2:27 ` Stefan Hajnoczi
  2015-11-13 10:26 ` Stefan Hajnoczi
  0 siblings, 2 replies; 5+ messages in thread
From: Eric Blake @ 2015-11-12 18:33 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, stefanha

Commit 6c6f312d added a new test, but did not mark it for
exclusion in .gitignore.

Signed-off-by: Eric Blake <eblake@redhat.com>
---

Yeah, I know this affects only non-VPATH builds, which we don't
recommend, but we might as well be consistent.

 tests/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/.gitignore b/tests/.gitignore
index e96f569..de5e793 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -9,6 +9,7 @@ check-qom-proplist
 rcutorture
 test-aio
 test-bitops
+test-blockjob-txn
 test-coroutine
 test-crypto-cipher
 test-crypto-hash
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn
  2015-11-12 18:33 [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn Eric Blake
@ 2015-11-13  2:27 ` Stefan Hajnoczi
  2015-11-13  3:43   ` Eric Blake
  2015-11-13 10:26 ` Stefan Hajnoczi
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2015-11-13  2:27 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-trivial, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote:
> Commit 6c6f312d added a new test, but did not mark it for
> exclusion in .gitignore.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Yeah, I know this affects only non-VPATH builds, which we don't
> recommend, but we might as well be consistent.
> 
>  tests/.gitignore | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn
  2015-11-13  2:27 ` Stefan Hajnoczi
@ 2015-11-13  3:43   ` Eric Blake
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2015-11-13  3:43 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-trivial, qemu-devel

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

On 11/12/2015 07:27 PM, Stefan Hajnoczi wrote:
> On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote:
>> Commit 6c6f312d added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>
>> Yeah, I know this affects only non-VPATH builds, which we don't
>> recommend, but we might as well be consistent.
>>
>>  tests/.gitignore | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Another one popped up: bd797fc1 introduced test-timed-average. I'll just
respin a v2 of this, although the subject line will change.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn
  2015-11-12 18:33 [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn Eric Blake
  2015-11-13  2:27 ` Stefan Hajnoczi
@ 2015-11-13 10:26 ` Stefan Hajnoczi
  2015-11-13 14:55   ` Eric Blake
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2015-11-13 10:26 UTC (permalink / raw)
  To: Eric Blake; +Cc: qemu-trivial, qemu-devel, stefanha

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote:
> Commit 6c6f312d added a new test, but did not mark it for
> exclusion in .gitignore.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> Yeah, I know this affects only non-VPATH builds, which we don't
> recommend, but we might as well be consistent.

I'm a non-VPATH diehard too :)

>  tests/.gitignore | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn
  2015-11-13 10:26 ` Stefan Hajnoczi
@ 2015-11-13 14:55   ` Eric Blake
  0 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2015-11-13 14:55 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-trivial, qemu-devel, stefanha

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On 11/13/2015 03:26 AM, Stefan Hajnoczi wrote:
> On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote:
>> Commit 6c6f312d added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>
>> Yeah, I know this affects only non-VPATH builds, which we don't
>> recommend, but we might as well be consistent.
> 
> I'm a non-VPATH diehard too :)
> 
>>  tests/.gitignore | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

Did you want to apply v2 instead?
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03214.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-11-13 14:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 18:33 [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn Eric Blake
2015-11-13  2:27 ` Stefan Hajnoczi
2015-11-13  3:43   ` Eric Blake
2015-11-13 10:26 ` Stefan Hajnoczi
2015-11-13 14:55   ` Eric Blake

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.