All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH 1/5] canutils: rdep on iproute2
@ 2015-11-12 20:17 Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-12 20:17 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

busybox ip fails to configure can interfaces, so we need iproute2 to do so.
See also http://www.armadeus.com/wiki/index.php?title=CAN_bus_Linux_driver.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb b/meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb
index c220ead..e1508af 100644
--- a/meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb
+++ b/meta-oe/recipes-extended/socketcan/canutils_4.0.6.bb
@@ -15,3 +15,6 @@ SRC_URI = "git://git.pengutronix.de/git/tools/canutils.git;protocol=git \
 S = "${WORKDIR}/git"
 
 inherit autotools pkgconfig
+
+# Busybox ip doesn't support can interface configuration, use the real thing
+RDEPENDS_${PN} += "iproute2"
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr
  2015-11-12 20:17 [meta-oe][PATCH 1/5] canutils: rdep on iproute2 Christopher Larson
@ 2015-11-12 20:17 ` Christopher Larson
  2015-11-13  2:48   ` [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: " Huang, Jie (Jackie)
  2015-11-13  9:38   ` Jens Rehsack
  2015-11-12 20:17 ` [meta-oe][PATCH 3/5] lowpan-tools: add missing flex/bison deps Christopher Larson
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-12 20:17 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

These will depend on libattr if it's available, and we need deterministic
builds. This fixes a build-deps failure which occurs when attr is built before
them. There's currently no configuration option to explicitly control this
dependency, and I don't know enough about waf to add such an option, so
unconditionally dep on it for now.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
 meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
 meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
index 0b9e1f2..e349187 100644
--- a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
+++ b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
@@ -1,6 +1,7 @@
 SUMMARY = "The tdb library"
 SECTION = "libs"
 LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"
 
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
                     file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
diff --git a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
index f297f30..c37eeb3 100644
--- a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
+++ b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
@@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
 SECTION = "libs"
 LICENSE = "LGPLv3+"
 
-DEPENDS += "talloc libcap"
+DEPENDS += "talloc libcap attr"
 RDEPENDS_${PN} += "libtalloc"
 RDEPENDS_python-tevent = "python"
 
diff --git a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
index 89c390f..7931374 100644
--- a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
+++ b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
@@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with destructors"
 HOMEPAGE = "http://talloc.samba.org"
 SECTION = "libs"
 LICENSE = "LGPL-3.0+ & GPL-3.0+"
+DEPENDS += "attr"
 
 SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [meta-oe][PATCH 3/5] lowpan-tools: add missing flex/bison deps
  2015-11-12 20:17 [meta-oe][PATCH 1/5] canutils: rdep on iproute2 Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
@ 2015-11-12 20:17 ` Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 4/5] ctdb: rdep on bash Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 5/5] gpsd: also support bluez5 Christopher Larson
  3 siblings, 0 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-12 20:17 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb b/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb
index f57df5d..b1bd926 100644
--- a/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb
+++ b/meta-networking/recipes-support/lowpan-tools/lowpan-tools_git.bb
@@ -5,7 +5,7 @@ SECTION = "net"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-DEPENDS = "libnl python"
+DEPENDS = "flex-native bison-native libnl python"
 
 PV = "0.3.1+git${SRCPV}"
 SRC_URI = "git://git.code.sf.net/p/linux-zigbee/linux-zigbee \
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [meta-oe][PATCH 4/5] ctdb: rdep on bash
  2015-11-12 20:17 [meta-oe][PATCH 1/5] canutils: rdep on iproute2 Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 3/5] lowpan-tools: add missing flex/bison deps Christopher Larson
@ 2015-11-12 20:17 ` Christopher Larson
  2015-11-12 20:17 ` [meta-oe][PATCH 5/5] gpsd: also support bluez5 Christopher Larson
  3 siblings, 0 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-12 20:17 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

onnode is a shell script with bashisms and bash #!.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb b/meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb
index 3731efd..5718c5f 100644
--- a/meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb
+++ b/meta-oe/recipes-support/ctdb/ctdb_2.5.1.bb
@@ -41,3 +41,6 @@ do_install_append() {
 SYSTEMD_SERVICE_${PN} = "ctdb.service"
 
 FILES_${PN} += "/run"
+
+# onnode is a shell script with bashisms and bash #!
+RDEPENDS_${PN} += "bash"
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [meta-oe][PATCH 5/5] gpsd: also support bluez5
  2015-11-12 20:17 [meta-oe][PATCH 1/5] canutils: rdep on iproute2 Christopher Larson
                   ` (2 preceding siblings ...)
  2015-11-12 20:17 ` [meta-oe][PATCH 4/5] ctdb: rdep on bash Christopher Larson
@ 2015-11-12 20:17 ` Christopher Larson
  3 siblings, 0 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-12 20:17 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson

From: Christopher Larson <chris_larson@mentor.com>

gpsd uses libbluetooth, not the dbus interface, so it can work with bluez5 as
well, as the library is compatible.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
index dae39c2..6ae2f30 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
@@ -34,8 +34,8 @@ SYSTEMD_OESCONS = "${@base_contains('DISTRO_FEATURES', 'systemd', 'true', 'false
 export STAGING_INCDIR
 export STAGING_LIBDIR
 
-PACKAGECONFIG ??= "qt ${@base_contains('DISTRO_FEATURES', 'bluetooth', '${BLUEZ}', '', d)}"
-PACKAGECONFIG[bluez4] = "bluez='true',bluez='false',bluez4"
+PACKAGECONFIG ??= "qt ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)}"
+PACKAGECONFIG[bluez] = "bluez='true',bluez='false',${BLUEZ}"
 PACKAGECONFIG[qt] = "qt='yes',qt='no',qt4-x11-free"
 EXTRA_OESCONS = " \
     sysroot=${STAGING_DIR_TARGET} \
-- 
2.2.1



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
@ 2015-11-13  2:48   ` Huang, Jie (Jackie)
  2015-11-13  3:20     ` Christopher Larson
  2015-11-18 17:48     ` Jens Rehsack
  2015-11-13  9:38   ` Jens Rehsack
  1 sibling, 2 replies; 11+ messages in thread
From: Huang, Jie (Jackie) @ 2015-11-13  2:48 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> Sent: Friday, November 13, 2015 4:17 AM
> To: openembedded-devel@lists.openembedded.org
> Cc: Christopher Larson
> Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr
> 
> From: Christopher Larson <chris_larson@mentor.com>
> 
> These will depend on libattr if it's available, and we need deterministic
> builds. This fixes a build-deps failure which occurs when attr is built before
> them. There's currently no configuration option to explicitly control this
> dependency, and I don't know enough about waf to add such an option, so
> unconditionally dep on it for now.

I added depends on libcap  for libtevent for the same reason days ago, but it really concern
me now, the 'libreplace' in these waf based packages check many packages(I see
libbsd, libcap, libacl for now) existence then build with them if found, and there
is no configure option to disable them, does anyone has a better idea how to
make waf build in deterministic way? Maybe we should disable the built-in
libraries 'libreplace' or add a PACKAGECONFIG for it?

Thanks,
Jackie

> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
>  meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
>  meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb b/meta-oe/recipes-
> support/libtdb/libtdb_1.3.0.bb
> index 0b9e1f2..e349187 100644
> --- a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> +++ b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> @@ -1,6 +1,7 @@
>  SUMMARY = "The tdb library"
>  SECTION = "libs"
>  LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
>  LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-
> 3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
>                      file://${COREBASE}/meta/files/common-licenses/GPL-
> 3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
> diff --git a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb b/meta-oe/recipes-
> support/libtevent/libtevent_0.9.21.bb
> index f297f30..c37eeb3 100644
> --- a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> +++ b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
>  SECTION = "libs"
>  LICENSE = "LGPLv3+"
> 
> -DEPENDS += "talloc libcap"
> +DEPENDS += "talloc libcap attr"
>  RDEPENDS_${PN} += "libtalloc"
>  RDEPENDS_python-tevent = "python"
> 
> diff --git a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb b/meta-oe/recipes-
> support/talloc/talloc_2.1.1.bb
> index 89c390f..7931374 100644
> --- a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> +++ b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> @@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with
> destructors"
>  HOMEPAGE = "http://talloc.samba.org"
>  SECTION = "libs"
>  LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
>  SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-
> 3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
> --
> 2.2.1
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-13  2:48   ` [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: " Huang, Jie (Jackie)
@ 2015-11-13  3:20     ` Christopher Larson
  2015-11-13  3:43       ` Huang, Jie (Jackie)
  2015-11-18 17:48     ` Jens Rehsack
  1 sibling, 1 reply; 11+ messages in thread
From: Christopher Larson @ 2015-11-13  3:20 UTC (permalink / raw)
  To: Openembedded Discussion

On Thu, Nov 12, 2015 at 7:48 PM, Huang, Jie (Jackie) <
Jackie.Huang@windriver.com> wrote:

> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org [mailto:
> openembedded-devel-
> > bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> > Sent: Friday, November 13, 2015 4:17 AM
> > To: openembedded-devel@lists.openembedded.org
> > Cc: Christopher Larson
> > Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on
> attr
> >
> > From: Christopher Larson <chris_larson@mentor.com>
> >
> > These will depend on libattr if it's available, and we need deterministic
> > builds. This fixes a build-deps failure which occurs when attr is built
> before
> > them. There's currently no configuration option to explicitly control
> this
> > dependency, and I don't know enough about waf to add such an option, so
> > unconditionally dep on it for now.
>
> I added depends on libcap  for libtevent for the same reason days ago, but
> it really concern
> me now, the 'libreplace' in these waf based packages check many packages(I
> see
> libbsd, libcap, libacl for now) existence then build with them if found,
> and there
> is no configure option to disable them, does anyone has a better idea how
> to
> make waf build in deterministic way? Maybe we should disable the built-in
> libraries 'libreplace' or add a PACKAGECONFIG for it?


I don't think PACKAGECONFIG will help unless we have a way to explicitly
disable or enable the dependency with waf, otherwise it'd still be
non-deterministic. But I think that would be ideal, that's how we handle
these things in autoconf, add an argument to let us explicitly
enable/disable it. Hopefully someone else on the list knows enough about
waf to be able to do so.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-13  3:20     ` Christopher Larson
@ 2015-11-13  3:43       ` Huang, Jie (Jackie)
  0 siblings, 0 replies; 11+ messages in thread
From: Huang, Jie (Jackie) @ 2015-11-13  3:43 UTC (permalink / raw)
  To: openembedded-devel



> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> Sent: Friday, November 13, 2015 11:20 AM
> To: Openembedded Discussion
> Subject: Re: [oe] [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
> 
> On Thu, Nov 12, 2015 at 7:48 PM, Huang, Jie (Jackie) <
> Jackie.Huang@windriver.com> wrote:
> 
> > > -----Original Message-----
> > > From: openembedded-devel-bounces@lists.openembedded.org [mailto:
> > openembedded-devel-
> > > bounces@lists.openembedded.org] On Behalf Of Christopher Larson
> > > Sent: Friday, November 13, 2015 4:17 AM
> > > To: openembedded-devel@lists.openembedded.org
> > > Cc: Christopher Larson
> > > Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on
> > attr
> > >
> > > From: Christopher Larson <chris_larson@mentor.com>
> > >
> > > These will depend on libattr if it's available, and we need deterministic
> > > builds. This fixes a build-deps failure which occurs when attr is built
> > before
> > > them. There's currently no configuration option to explicitly control
> > this
> > > dependency, and I don't know enough about waf to add such an option, so
> > > unconditionally dep on it for now.
> >
> > I added depends on libcap  for libtevent for the same reason days ago, but
> > it really concern
> > me now, the 'libreplace' in these waf based packages check many packages(I
> > see
> > libbsd, libcap, libacl for now) existence then build with them if found,
> > and there
> > is no configure option to disable them, does anyone has a better idea how
> > to
> > make waf build in deterministic way? Maybe we should disable the built-in
> > libraries 'libreplace' or add a PACKAGECONFIG for it?
> 
> 
> I don't think PACKAGECONFIG will help unless we have a way to explicitly

You're right, a quick try show me that it doesn't help.

Thanks,
Jackie

> disable or enable the dependency with waf, otherwise it'd still be
> non-deterministic. But I think that would be ideal, that's how we handle
> these things in autoconf, add an argument to let us explicitly
> enable/disable it. Hopefully someone else on the list knows enough about
> waf to be able to do so.
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
  2015-11-13  2:48   ` [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: " Huang, Jie (Jackie)
@ 2015-11-13  9:38   ` Jens Rehsack
  2015-11-13 14:47     ` Christopher Larson
  1 sibling, 1 reply; 11+ messages in thread
From: Jens Rehsack @ 2015-11-13  9:38 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Christopher Larson


> Am 12.11.2015 um 21:17 schrieb Christopher Larson <kergoth@gmail.com>:
> 
> From: Christopher Larson <chris_larson@mentor.com>
> 
> These will depend on libattr if it's available, and we need deterministic
> builds. This fixes a build-deps failure which occurs when attr is built before
> them. There's currently no configuration option to explicitly control this
> dependency, and I don't know enough about waf to add such an option, so
> unconditionally dep on it for now.
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
> meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
> meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
> meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> index 0b9e1f2..e349187 100644
> --- a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> +++ b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> @@ -1,6 +1,7 @@
> SUMMARY = "The tdb library"
> SECTION = "libs"
> LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
>                     file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
> diff --git a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> index f297f30..c37eeb3 100644
> --- a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> +++ b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
> SECTION = "libs"
> LICENSE = "LGPLv3+"
> 
> -DEPENDS += "talloc libcap"
> +DEPENDS += "talloc libcap attr"
> RDEPENDS_${PN} += "libtalloc"
> RDEPENDS_python-tevent = "python"
> 
> diff --git a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> index 89c390f..7931374 100644
> --- a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> +++ b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> @@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool system with destructors"
> HOMEPAGE = "http://talloc.samba.org"
> SECTION = "libs"
> LICENSE = "LGPL-3.0+ & GPL-3.0+"
> +DEPENDS += "attr"
> 
> SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b \
> -- 
> 2.2.1

RDEPENDS is wrong for deterministic builds, since they leave a race condition open that attr is build parallel to libtevent
and 2nd build is different to first build.

If you want, I handle that better in a patchy way I discussed with JaMa yesterday in #yocto (patch check out depending on PACKAGECONFIG)

Cheers
-- 
Jens Rehsack - rehsack@gmail.com



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-13  9:38   ` Jens Rehsack
@ 2015-11-13 14:47     ` Christopher Larson
  0 siblings, 0 replies; 11+ messages in thread
From: Christopher Larson @ 2015-11-13 14:47 UTC (permalink / raw)
  To: Openembedded Discussion

On Fri, Nov 13, 2015 at 2:38 AM, Jens Rehsack <rehsack@gmail.com> wrote:

> > Am 12.11.2015 um 21:17 schrieb Christopher Larson <kergoth@gmail.com>:
> >
> > From: Christopher Larson <chris_larson@mentor.com>
> >
> > These will depend on libattr if it's available, and we need deterministic
> > builds. This fixes a build-deps failure which occurs when attr is built
> before
> > them. There's currently no configuration option to explicitly control
> this
> > dependency, and I don't know enough about waf to add such an option, so
> > unconditionally dep on it for now.
> >
> > Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> > ---
> > meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb        | 1 +
> > meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb | 2 +-
> > meta-oe/recipes-support/talloc/talloc_2.1.1.bb        | 1 +
> > 3 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> > index 0b9e1f2..e349187 100644
> > --- a/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> > +++ b/meta-oe/recipes-support/libtdb/libtdb_1.3.0.bb
> > @@ -1,6 +1,7 @@
> > SUMMARY = "The tdb library"
> > SECTION = "libs"
> > LICENSE = "LGPL-3.0+ & GPL-3.0+"
> > +DEPENDS += "attr"
> >
> > LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b
> \
> >
>  file://${COREBASE}/meta/files/common-licenses/GPL-3.0;md5=c79ff39f19dfec6d293b95dea7b07891"
> > diff --git a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> > index f297f30..c37eeb3 100644
> > --- a/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> > +++ b/meta-oe/recipes-support/libtevent/libtevent_0.9.21.bb
> > @@ -3,7 +3,7 @@ HOMEPAGE = "http://tevent.samba.org"
> > SECTION = "libs"
> > LICENSE = "LGPLv3+"
> >
> > -DEPENDS += "talloc libcap"
> > +DEPENDS += "talloc libcap attr"
> > RDEPENDS_${PN} += "libtalloc"
> > RDEPENDS_python-tevent = "python"
> >
> > diff --git a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> > index 89c390f..7931374 100644
> > --- a/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> > +++ b/meta-oe/recipes-support/talloc/talloc_2.1.1.bb
> > @@ -2,6 +2,7 @@ SUMMARY = "Hierarchical, reference counted memory pool
> system with destructors"
> > HOMEPAGE = "http://talloc.samba.org"
> > SECTION = "libs"
> > LICENSE = "LGPL-3.0+ & GPL-3.0+"
> > +DEPENDS += "attr"
> >
> > SRC_URI = "http://samba.org/ftp/${BPN}/${BPN}-${PV}.tar.gz"
> > LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/LGPL-3.0;md5=bfccfe952269fff2b407dd11f2f3083b
> \
> > --
> > 2.2.1
>
> RDEPENDS is wrong for deterministic builds, since they leave a race
> condition open that attr is build parallel to libtevent
> and 2nd build is different to first build.
>
> If you want, I handle that better in a patchy way I discussed with JaMa
> yesterday in #yocto (patch check out depending on PACKAGECONFIG)


I don't believe anyone said anything about rdepending on attr. This patch
certainly doesn't, it adds to DEPENDS. But as was said earlier in the
thread, a way to explicitly enable/disable the dep in the underlying
buildsystem would be better.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: depend on attr
  2015-11-13  2:48   ` [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: " Huang, Jie (Jackie)
  2015-11-13  3:20     ` Christopher Larson
@ 2015-11-18 17:48     ` Jens Rehsack
  1 sibling, 0 replies; 11+ messages in thread
From: Jens Rehsack @ 2015-11-18 17:48 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Volker Moesker, Tobias Theophile, Christopher Larson


> Am 13.11.2015 um 03:48 schrieb Huang, Jie (Jackie) <Jackie.Huang@windriver.com>:
> 
> 
> 
>> -----Original Message-----
>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
>> bounces@lists.openembedded.org] On Behalf Of Christopher Larson
>> Sent: Friday, November 13, 2015 4:17 AM
>> To: openembedded-devel@lists.openembedded.org
>> Cc: Christopher Larson
>> Subject: [oe] [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr
>> 
>> From: Christopher Larson <chris_larson@mentor.com>
>> 
>> These will depend on libattr if it's available, and we need deterministic
>> builds. This fixes a build-deps failure which occurs when attr is built before
>> them. There's currently no configuration option to explicitly control this
>> dependency, and I don't know enough about waf to add such an option, so
>> unconditionally dep on it for now.
> 
> I added depends on libcap  for libtevent for the same reason days ago, but it really concern
> me now, the 'libreplace' in these waf based packages check many packages(I see
> libbsd, libcap, libacl for now) existence then build with them if found, and there
> is no configure option to disable them, does anyone has a better idea how to
> make waf build in deterministic way? Maybe we should disable the built-in
> libraries 'libreplace' or add a PACKAGECONFIG for it?

I dug for it (libcap) since I couldn't find any reference in wscript & co and finally a 
$ for l in tmp/sysroots/curie/usr/lib/lib*.so; do tmp/sysroots/x86_64-linux/usr/libexec/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/4.9.3/arm-poky-linux-gnueabi-objdump -x $l; done | less
pointed the origins:

* libldap_r.so
* libsmbconf.so

Think it shouldn't be a dependency in tevent, but in openldap ...

I add it to my patch series - just wanted to let you know.

Wrt. libbsd - if libbsd is found, stdlcat etc. is used from there, otherwise own implementation via lib/replace is provided, similar for some attr calls - but they aren't used in tevent/talloc ...
Looks as if lib/replace is a poor maintained libnbcompat alike :)

Cheers
-- 
Jens Rehsack - rehsack@gmail.com



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2015-11-18 17:48 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 20:17 [meta-oe][PATCH 1/5] canutils: rdep on iproute2 Christopher Larson
2015-11-12 20:17 ` [meta-oe][PATCH 2/5] talloc,libtevent,libtdb: depend on attr Christopher Larson
2015-11-13  2:48   ` [meta-oe][PATCH 2/5] talloc, libtevent, libtdb: " Huang, Jie (Jackie)
2015-11-13  3:20     ` Christopher Larson
2015-11-13  3:43       ` Huang, Jie (Jackie)
2015-11-18 17:48     ` Jens Rehsack
2015-11-13  9:38   ` Jens Rehsack
2015-11-13 14:47     ` Christopher Larson
2015-11-12 20:17 ` [meta-oe][PATCH 3/5] lowpan-tools: add missing flex/bison deps Christopher Larson
2015-11-12 20:17 ` [meta-oe][PATCH 4/5] ctdb: rdep on bash Christopher Larson
2015-11-12 20:17 ` [meta-oe][PATCH 5/5] gpsd: also support bluez5 Christopher Larson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.