All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd
@ 2015-11-14  6:21 wenzong.fan
  2015-11-14  8:23 ` Martin Jansa
  0 siblings, 1 reply; 5+ messages in thread
From: wenzong.fan @ 2015-11-14  6:21 UTC (permalink / raw)
  To: openembedded-core

From: Wenzong Fan <wenzong.fan@windriver.com>

Disable uvch264 to remove the dependency to libgudev which has been
removed from systemd project.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
index cdedb60..863925d 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
@@ -20,7 +20,8 @@ PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \
-    orc curl uvch264 neon sndfile \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '', 'uvch264', d)} \
+    orc curl neon sndfile \
     hls sbc dash bz2 smoothstreaming \
     "
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd
  2015-11-14  6:21 [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd wenzong.fan
@ 2015-11-14  8:23 ` Martin Jansa
  2015-11-14  9:19   ` wenzong fan
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2015-11-14  8:23 UTC (permalink / raw)
  To: Wenzong Fan; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

NAK, see
http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112685.html

On Sat, Nov 14, 2015 at 7:21 AM, <wenzong.fan@windriver.com> wrote:

> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> Disable uvch264 to remove the dependency to libgudev which has been
> removed from systemd project.
>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> index cdedb60..863925d 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> @@ -20,7 +20,8 @@ PACKAGECONFIG ??= " \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}
> \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)}
> \
>      ${@bb.utils.contains('DISTRO_FEATURES', 'directfb', 'directfb', '',
> d)} \
> -    orc curl uvch264 neon sndfile \
> +    ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '', 'uvch264', d)}
> \
> +    orc curl neon sndfile \
>      hls sbc dash bz2 smoothstreaming \
>      "
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2531 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd
  2015-11-14  8:23 ` Martin Jansa
@ 2015-11-14  9:19   ` wenzong fan
  2015-11-14  9:49     ` Martin Jansa
  0 siblings, 1 reply; 5+ messages in thread
From: wenzong fan @ 2015-11-14  9:19 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer

On 11/14/2015 04:23 PM, Martin Jansa wrote:
> NAK, see
> http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112685.html

Hi Martin

Thanks for your reply.

If we build oe-core + systemd only (without meta-oe), it will fail with:

ERROR: Nothing PROVIDES 'libgudev' (but 
/path/to/poky/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb 
DEPENDS on or otherwise requires it)
ERROR: udev PROVIDES libgudev but was skipped: 'systemd' in DISTRO_FEATURES
ERROR: Required build target 'gstreamer1.0-plugins-bad' has no buildable 
providers.
Missing or unbuildable dependency chain was: 
['gstreamer1.0-plugins-bad', 'libgudev']

We should not get oe-core depends on meta-oe, I incline to disable 
libgudev for systemd by default.

Does it make sense?

Thanks
Wenzong

>
> On Sat, Nov 14, 2015 at 7:21 AM, <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>> wrote:
>
>     From: Wenzong Fan <wenzong.fan@windriver.com
>     <mailto:wenzong.fan@windriver.com>>
>
>     Disable uvch264 to remove the dependency to libgudev which has been
>     removed from systemd project.
>
>     Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com
>     <mailto:wenzong.fan@windriver.com>>
>     ---
>       meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 3 ++-
>       1 file changed, 2 insertions(+), 1 deletion(-)
>
>     diff --git
>     a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>     b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>     index cdedb60..863925d 100644
>     --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>     +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>     @@ -20,7 +20,8 @@ PACKAGECONFIG ??= " \
>           ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland',
>     '', d)} \
>           ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez',
>     '', d)} \
>           ${@bb.utils.contains('DISTRO_FEATURES', 'directfb',
>     'directfb', '', d)} \
>     -    orc curl uvch264 neon sndfile \
>     +    ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '',
>     'uvch264', d)} \
>     +    orc curl neon sndfile \
>           hls sbc dash bz2 smoothstreaming \
>           "
>
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd
  2015-11-14  9:19   ` wenzong fan
@ 2015-11-14  9:49     ` Martin Jansa
  2015-11-14 10:07       ` wenzong fan
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2015-11-14  9:49 UTC (permalink / raw)
  To: wenzong fan; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 3212 bytes --]

On Sat, Nov 14, 2015 at 05:19:03PM +0800, wenzong fan wrote:
> On 11/14/2015 04:23 PM, Martin Jansa wrote:
> > NAK, see
> > http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112685.html
> 
> Hi Martin
> 
> Thanks for your reply.
> 
> If we build oe-core + systemd only (without meta-oe), it will fail with:
> 
> ERROR: Nothing PROVIDES 'libgudev' (but 
> /path/to/poky/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb 
> DEPENDS on or otherwise requires it)
> ERROR: udev PROVIDES libgudev but was skipped: 'systemd' in DISTRO_FEATURES
> ERROR: Required build target 'gstreamer1.0-plugins-bad' has no buildable 
> providers.
> Missing or unbuildable dependency chain was: 
> ['gstreamer1.0-plugins-bad', 'libgudev']
> 
> We should not get oe-core depends on meta-oe, I incline to disable 
> libgudev for systemd by default.

udev should provide libgudev for oe-core, but I see it was skipped:
ERROR: udev PROVIDES libgudev but was skipped: 'systemd' in DISTRO_FEATURES

How is that supposed to work when systemd is enabled as well as udev?

Does the sysvinit image nowadays use udev package from systemd recipe?

Regards,

> Does it make sense?
> 
> Thanks
> Wenzong
> 
> >
> > On Sat, Nov 14, 2015 at 7:21 AM, <wenzong.fan@windriver.com
> > <mailto:wenzong.fan@windriver.com>> wrote:
> >
> >     From: Wenzong Fan <wenzong.fan@windriver.com
> >     <mailto:wenzong.fan@windriver.com>>
> >
> >     Disable uvch264 to remove the dependency to libgudev which has been
> >     removed from systemd project.
> >
> >     Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com
> >     <mailto:wenzong.fan@windriver.com>>
> >     ---
> >       meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 3 ++-
> >       1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >     diff --git
> >     a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> >     b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> >     index cdedb60..863925d 100644
> >     --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> >     +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
> >     @@ -20,7 +20,8 @@ PACKAGECONFIG ??= " \
> >           ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland',
> >     '', d)} \
> >           ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez',
> >     '', d)} \
> >           ${@bb.utils.contains('DISTRO_FEATURES', 'directfb',
> >     'directfb', '', d)} \
> >     -    orc curl uvch264 neon sndfile \
> >     +    ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '',
> >     'uvch264', d)} \
> >     +    orc curl neon sndfile \
> >           hls sbc dash bz2 smoothstreaming \
> >           "
> >
> >     --
> >     1.9.1
> >
> >     --
> >     _______________________________________________
> >     Openembedded-core mailing list
> >     Openembedded-core@lists.openembedded.org
> >     <mailto:Openembedded-core@lists.openembedded.org>
> >     http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd
  2015-11-14  9:49     ` Martin Jansa
@ 2015-11-14 10:07       ` wenzong fan
  0 siblings, 0 replies; 5+ messages in thread
From: wenzong fan @ 2015-11-14 10:07 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer

On 11/14/2015 05:49 PM, Martin Jansa wrote:
> On Sat, Nov 14, 2015 at 05:19:03PM +0800, wenzong fan wrote:
>> On 11/14/2015 04:23 PM, Martin Jansa wrote:
>>> NAK, see
>>> http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112685.html
>>
>> Hi Martin
>>
>> Thanks for your reply.
>>
>> If we build oe-core + systemd only (without meta-oe), it will fail with:
>>
>> ERROR: Nothing PROVIDES 'libgudev' (but
>> /path/to/poky/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb
>> DEPENDS on or otherwise requires it)
>> ERROR: udev PROVIDES libgudev but was skipped: 'systemd' in DISTRO_FEATURES
>> ERROR: Required build target 'gstreamer1.0-plugins-bad' has no buildable
>> providers.
>> Missing or unbuildable dependency chain was:
>> ['gstreamer1.0-plugins-bad', 'libgudev']
>>
>> We should not get oe-core depends on meta-oe, I incline to disable
>> libgudev for systemd by default.
>
> udev should provide libgudev for oe-core, but I see it was skipped:
> ERROR: udev PROVIDES libgudev but was skipped: 'systemd' in DISTRO_FEATURES
>
> How is that supposed to work when systemd is enabled as well as udev?
>
> Does the sysvinit image nowadays use udev package from systemd recipe?

No, sysvinit image uses the independent "udev" package. But systemd 
image used the one from itself.

It may conflicts build both systemd and independent udev package:

commit e07e0f80d6c794adf154be74eca503d191c35cc6
Author: Ross Burton <ross.burton@intel.com>
Date:   Mon Jan 21 12:15:31 2013 +0000

     udev: skip in systemd distros, to fix world builds

     (From OE-Core rev: 1179e43d67c96367480e563a36684d550d83fcbe)

     Signed-off-by: Ross Burton <ross.burton@intel.com>
     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-core/udev/udev.inc 
b/meta/recipes-core/udev/udev.inc
index 9f60b17..facad0c 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -99,3 +99,9 @@ do_install_append () {

         echo 'udev_run="/var/run/udev"' >> ${D}${sysconfdir}/udev/udev.conf
  }
+
+# As systemd also builds udev, skip this package if we're doing a 
systemd build.
+python () {
+    if oe.utils.contains ('DISTRO_FEATURES', 'systemd', True, False, d):
+        raise bb.parse.SkipPackage("'systemd' in DISTRO_FEATURES")
+}


Thanks
Wenzong

>
> Regards,
>
>> Does it make sense?
>>
>> Thanks
>> Wenzong
>>
>>>
>>> On Sat, Nov 14, 2015 at 7:21 AM, <wenzong.fan@windriver.com
>>> <mailto:wenzong.fan@windriver.com>> wrote:
>>>
>>>      From: Wenzong Fan <wenzong.fan@windriver.com
>>>      <mailto:wenzong.fan@windriver.com>>
>>>
>>>      Disable uvch264 to remove the dependency to libgudev which has been
>>>      removed from systemd project.
>>>
>>>      Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com
>>>      <mailto:wenzong.fan@windriver.com>>
>>>      ---
>>>        meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc | 3 ++-
>>>        1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>>      diff --git
>>>      a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>>>      b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>>>      index cdedb60..863925d 100644
>>>      --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>>>      +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad.inc
>>>      @@ -20,7 +20,8 @@ PACKAGECONFIG ??= " \
>>>            ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland',
>>>      '', d)} \
>>>            ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez',
>>>      '', d)} \
>>>            ${@bb.utils.contains('DISTRO_FEATURES', 'directfb',
>>>      'directfb', '', d)} \
>>>      -    orc curl uvch264 neon sndfile \
>>>      +    ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '',
>>>      'uvch264', d)} \
>>>      +    orc curl neon sndfile \
>>>            hls sbc dash bz2 smoothstreaming \
>>>            "
>>>
>>>      --
>>>      1.9.1
>>>
>>>      --
>>>      _______________________________________________
>>>      Openembedded-core mailing list
>>>      Openembedded-core@lists.openembedded.org
>>>      <mailto:Openembedded-core@lists.openembedded.org>
>>>      http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>>
>


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-11-14 10:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-14  6:21 [PATCH] gstreamer1.0-plugins-bad: disable uvch264 for systemd wenzong.fan
2015-11-14  8:23 ` Martin Jansa
2015-11-14  9:19   ` wenzong fan
2015-11-14  9:49     ` Martin Jansa
2015-11-14 10:07       ` wenzong fan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.