All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] doc/adapter-api: Use correct signal name
@ 2015-11-16 20:58 Łukasz Rymanowski
  2015-11-16 20:58 ` [PATCH 2/2] test/test-discovery: Remove dead code Łukasz Rymanowski
  2015-11-17 14:07 ` [PATCH 1/2] doc/adapter-api: Use correct signal name Luiz Augusto von Dentz
  0 siblings, 2 replies; 3+ messages in thread
From: Łukasz Rymanowski @ 2015-11-16 20:58 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Łukasz Rymanowski

---
 doc/adapter-api.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index cf7169f..284214e 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -167,7 +167,7 @@ Properties	string Address [readonly]
 			value will fail.
 
 			When changing the Powered property the new state of
-			this property will be updated via a PropertyChanged
+			this property will be updated via a PropertiesChanged
 			signal.
 
 			For any new adapter this settings defaults to false.
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] test/test-discovery: Remove dead code
  2015-11-16 20:58 [PATCH 1/2] doc/adapter-api: Use correct signal name Łukasz Rymanowski
@ 2015-11-16 20:58 ` Łukasz Rymanowski
  2015-11-17 14:07 ` [PATCH 1/2] doc/adapter-api: Use correct signal name Luiz Augusto von Dentz
  1 sibling, 0 replies; 3+ messages in thread
From: Łukasz Rymanowski @ 2015-11-16 20:58 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Łukasz Rymanowski

PropertyChanged is left over from BlueZ 4.x now it is PropertiesChanged.
However in this test it does not make sense to register for this signal
as StopDiscovery is never called from this test.
---
 test/test-discovery | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/test/test-discovery b/test/test-discovery
index 73b8161..9a2c6b9 100755
--- a/test/test-discovery
+++ b/test/test-discovery
@@ -107,10 +107,6 @@ def properties_changed(interface, changed, invalidated, path):
 	else:
 		print_normal(address, devices[path])
 
-def property_changed(name, value):
-	if (name == "Discovering" and not value):
-		mainloop.quit()
-
 if __name__ == '__main__':
 	dbus.mainloop.glib.DBusGMainLoop(set_as_default=True)
 
@@ -141,10 +137,6 @@ if __name__ == '__main__':
 			arg0 = "org.bluez.Device1",
 			path_keyword = "path")
 
-	bus.add_signal_receiver(property_changed,
-					dbus_interface = "org.bluez.Adapter1",
-					signal_name = "PropertyChanged")
-
 	om = dbus.Interface(bus.get_object("org.bluez", "/"),
 				"org.freedesktop.DBus.ObjectManager")
 	objects = om.GetManagedObjects()
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] doc/adapter-api: Use correct signal name
  2015-11-16 20:58 [PATCH 1/2] doc/adapter-api: Use correct signal name Łukasz Rymanowski
  2015-11-16 20:58 ` [PATCH 2/2] test/test-discovery: Remove dead code Łukasz Rymanowski
@ 2015-11-17 14:07 ` Luiz Augusto von Dentz
  1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2015-11-17 14:07 UTC (permalink / raw)
  To: Łukasz Rymanowski; +Cc: linux-bluetooth

Hi Lukasz,

On Mon, Nov 16, 2015 at 10:58 PM, Łukasz Rymanowski
<lukasz.rymanowski@codecoup.pl> wrote:
> ---
>  doc/adapter-api.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index cf7169f..284214e 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -167,7 +167,7 @@ Properties  string Address [readonly]
>                         value will fail.
>
>                         When changing the Powered property the new state of
> -                       this property will be updated via a PropertyChanged
> +                       this property will be updated via a PropertiesChanged
>                         signal.
>
>                         For any new adapter this settings defaults to false.
> --
> 2.5.0

Applied, thanks.


-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-17 14:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 20:58 [PATCH 1/2] doc/adapter-api: Use correct signal name Łukasz Rymanowski
2015-11-16 20:58 ` [PATCH 2/2] test/test-discovery: Remove dead code Łukasz Rymanowski
2015-11-17 14:07 ` [PATCH 1/2] doc/adapter-api: Use correct signal name Luiz Augusto von Dentz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.