* [PATCH] tools/hotplug: quote all variables in vif-bridge
@ 2015-11-19 8:32 Olaf Hering
2015-11-24 16:53 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2015-11-19 8:32 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, Olaf Hering, Ian Jackson, Ian Campbell, Stefano Stabellini
Cosmetics: most of the variables used in vif-bridge are already quoted.
Add quoting also to the remaining shell variables.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/hotplug/Linux/vif-bridge | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge
index 3d72ca4..6956dea 100644
--- a/tools/hotplug/Linux/vif-bridge
+++ b/tools/hotplug/Linux/vif-bridge
@@ -68,7 +68,7 @@ else
fi
RET=0
-ip link show dev $bridge 1>/dev/null 2>&1 || RET=1
+ip link show dev "$bridge" 1>/dev/null 2>&1 || RET=1
if [ "$RET" -eq 1 ]
then
fatal "Could not find bridge device $bridge"
@@ -77,7 +77,7 @@ fi
case "$command" in
online)
setup_virtual_bridge_port "$dev"
- set_mtu $bridge $dev
+ set_mtu "$bridge" "$dev"
add_to_bridge "$bridge" "$dev"
;;
@@ -88,7 +88,7 @@ case "$command" in
add)
setup_virtual_bridge_port "$dev"
- set_mtu $bridge $dev
+ set_mtu "$bridge" "$dev"
add_to_bridge "$bridge" "$dev"
;;
esac
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/hotplug: quote all variables in vif-bridge
2015-11-19 8:32 [PATCH] tools/hotplug: quote all variables in vif-bridge Olaf Hering
@ 2015-11-24 16:53 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-11-24 16:53 UTC (permalink / raw)
To: Olaf Hering, xen-devel; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini
On Thu, 2015-11-19 at 08:32 +0000, Olaf Hering wrote:
> Cosmetics: most of the variables used in vif-bridge are already quoted.
> Add quoting also to the remaining shell variables.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Ian Campbell <ian.campbell@citrix.com.
(I imagine much hilarity would ensue all over the place if a Linux netdev
actually had a name with a space in it...)
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/hotplug/Linux/vif-bridge | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-
> bridge
> index 3d72ca4..6956dea 100644
> --- a/tools/hotplug/Linux/vif-bridge
> +++ b/tools/hotplug/Linux/vif-bridge
> @@ -68,7 +68,7 @@ else
> fi
>
> RET=0
> -ip link show dev $bridge 1>/dev/null 2>&1 || RET=1
> +ip link show dev "$bridge" 1>/dev/null 2>&1 || RET=1
> if [ "$RET" -eq 1 ]
> then
> fatal "Could not find bridge device $bridge"
> @@ -77,7 +77,7 @@ fi
> case "$command" in
> online)
> setup_virtual_bridge_port "$dev"
> - set_mtu $bridge $dev
> + set_mtu "$bridge" "$dev"
> add_to_bridge "$bridge" "$dev"
> ;;
>
> @@ -88,7 +88,7 @@ case "$command" in
>
> add)
> setup_virtual_bridge_port "$dev"
> - set_mtu $bridge $dev
> + set_mtu "$bridge" "$dev"
> add_to_bridge "$bridge" "$dev"
> ;;
> esac
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 8:32 [PATCH] tools/hotplug: quote all variables in vif-bridge Olaf Hering
2015-11-24 16:53 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.