* [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2
@ 2015-11-19 13:45 John Keeping
[not found] ` <1447940731-5672-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: John Keeping @ 2015-11-19 13:45 UTC (permalink / raw)
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Sjoerd Simons, John Keeping, Heiko Stuebner
Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
---
arch/arm/boot/dts/rk3288-rock2-som.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
index 1813b7c3..1ece66f 100644
--- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
+++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
@@ -109,6 +109,7 @@
act8846: act8846@5a {
compatible = "active-semi,act8846";
reg = <0x5a>;
+ system-power-controller;
inl1-supply = <&vcc_io>;
inl2-supply = <&vcc_sys>;
inl3-supply = <&vcc_20>;
--
2.6.3.462.gbe2c914
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2
[not found] ` <1447940731-5672-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
@ 2015-11-19 21:19 ` Heiko Stuebner
2015-11-19 22:05 ` John Keeping
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2015-11-19 21:19 UTC (permalink / raw)
To: John Keeping
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sjoerd Simons
Hi John,
Am Donnerstag, 19. November 2015, 13:45:31 schrieb John Keeping:
> Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
please always provide at least a short patch description too.
I've applied the patch but reworded it to
ARM: dts: rockchip: set system-power-controller property on rk3288-rock2
The act8846 on rock2 boards controls the system power, so add the
appropriate property to allow turning off the board.
Please holler if you disagree and want it described differently :-) .
Thanks
Heiko
> ---
> arch/arm/boot/dts/rk3288-rock2-som.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> index 1813b7c3..1ece66f 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> @@ -109,6 +109,7 @@
> act8846: act8846@5a {
> compatible = "active-semi,act8846";
> reg = <0x5a>;
> + system-power-controller;
> inl1-supply = <&vcc_io>;
> inl2-supply = <&vcc_sys>;
> inl3-supply = <&vcc_20>;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2
2015-11-19 21:19 ` Heiko Stuebner
@ 2015-11-19 22:05 ` John Keeping
0 siblings, 0 replies; 3+ messages in thread
From: John Keeping @ 2015-11-19 22:05 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sjoerd Simons
On Thu, Nov 19, 2015 at 10:19:32PM +0100, Heiko Stuebner wrote:
> Am Donnerstag, 19. November 2015, 13:45:31 schrieb John Keeping:
> > Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
>
> please always provide at least a short patch description too.
> I've applied the patch but reworded it to
>
> ARM: dts: rockchip: set system-power-controller property on rk3288-rock2
>
> The act8846 on rock2 boards controls the system power, so add the
> appropriate property to allow turning off the board.
>
> Please holler if you disagree and want it described differently :-) .
No objections here, that sounds great.
Thanks,
John
> > ---
> > arch/arm/boot/dts/rk3288-rock2-som.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> > index 1813b7c3..1ece66f 100644
> > --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> > +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi
> > @@ -109,6 +109,7 @@
> > act8846: act8846@5a {
> > compatible = "active-semi,act8846";
> > reg = <0x5a>;
> > + system-power-controller;
> > inl1-supply = <&vcc_io>;
> > inl2-supply = <&vcc_sys>;
> > inl3-supply = <&vcc_20>;
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-19 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 13:45 [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2 John Keeping
[not found] ` <1447940731-5672-1-git-send-email-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2015-11-19 21:19 ` Heiko Stuebner
2015-11-19 22:05 ` John Keeping
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.