* [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev
@ 2015-11-24 9:03 Peng Fan
2015-11-24 19:04 ` Simon Glass
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Peng Fan @ 2015-11-24 9:03 UTC (permalink / raw)
To: u-boot
The entry name of mii_dev is an array not pointer, so
no need to check.
Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
common/miiphyutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/miiphyutil.c b/common/miiphyutil.c
index e499b58..0811e09 100644
--- a/common/miiphyutil.c
+++ b/common/miiphyutil.c
@@ -159,7 +159,7 @@ void mdio_free(struct mii_dev *bus)
int mdio_register(struct mii_dev *bus)
{
- if (!bus || !bus->name || !bus->read || !bus->write)
+ if (!bus || !bus->read || !bus->write)
return -1;
/* check if we have unique name */
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev
2015-11-24 9:03 [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev Peng Fan
@ 2015-11-24 19:04 ` Simon Glass
2015-11-24 20:38 ` Joe Hershberger
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2015-11-24 19:04 UTC (permalink / raw)
To: u-boot
On 24 November 2015 at 02:03, Peng Fan <Peng.Fan@freescale.com> wrote:
> The entry name of mii_dev is an array not pointer, so
> no need to check.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> ---
> common/miiphyutil.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev
2015-11-24 9:03 [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev Peng Fan
2015-11-24 19:04 ` Simon Glass
@ 2015-11-24 20:38 ` Joe Hershberger
2015-11-25 1:52 ` Bin Meng
2015-12-06 22:06 ` [U-Boot] " Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2015-11-24 20:38 UTC (permalink / raw)
To: u-boot
Hi Peng,
On Tue, Nov 24, 2015 at 3:03 AM, Peng Fan <Peng.Fan@freescale.com> wrote:
> The entry name of mii_dev is an array not pointer, so
> no need to check.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev
2015-11-24 9:03 [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev Peng Fan
2015-11-24 19:04 ` Simon Glass
2015-11-24 20:38 ` Joe Hershberger
@ 2015-11-25 1:52 ` Bin Meng
2015-12-06 22:06 ` [U-Boot] " Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Bin Meng @ 2015-11-25 1:52 UTC (permalink / raw)
To: u-boot
On Tue, Nov 24, 2015 at 5:03 PM, Peng Fan <Peng.Fan@freescale.com> wrote:
> The entry name of mii_dev is an array not pointer, so
> no need to check.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> ---
> common/miiphyutil.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/miiphyutil.c b/common/miiphyutil.c
> index e499b58..0811e09 100644
> --- a/common/miiphyutil.c
> +++ b/common/miiphyutil.c
> @@ -159,7 +159,7 @@ void mdio_free(struct mii_dev *bus)
>
> int mdio_register(struct mii_dev *bus)
> {
> - if (!bus || !bus->name || !bus->read || !bus->write)
> + if (!bus || !bus->read || !bus->write)
> return -1;
>
> /* check if we have unique name */
> --
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] common: miiphyutil: no need to check name of mii_dev
2015-11-24 9:03 [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev Peng Fan
` (2 preceding siblings ...)
2015-11-25 1:52 ` Bin Meng
@ 2015-12-06 22:06 ` Tom Rini
3 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2015-12-06 22:06 UTC (permalink / raw)
To: u-boot
On Tue, Nov 24, 2015 at 05:03:47PM +0800, Peng Fan wrote:
> The entry name of mii_dev is an array not pointer, so
> no need to check.
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151206/31259e7f/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-06 22:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24 9:03 [U-Boot] [PATCH] common: miiphyutil: no need to check name of mii_dev Peng Fan
2015-11-24 19:04 ` Simon Glass
2015-11-24 20:38 ` Joe Hershberger
2015-11-25 1:52 ` Bin Meng
2015-12-06 22:06 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.