* [PATCH] libext2fs: fix tst_badblocks buffer overrun
@ 2015-11-24 21:50 Andreas Dilger
2015-11-30 17:10 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Dilger @ 2015-11-24 21:50 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Andreas Dilger
The test2[] array is not 0-terminated and the create_test_list() for
loop does not terminate properly at the end of this array, but
continues until it hits the 0 at the end of test3[].
Reported-by: Hanno Boeck <hanno@hboeck.de>
Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=104311
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
lib/ext2fs/tst_badblocks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ext2fs/tst_badblocks.c b/lib/ext2fs/tst_badblocks.c
index 3b39ef1..c685f33 100644
--- a/lib/ext2fs/tst_badblocks.c
+++ b/lib/ext2fs/tst_badblocks.c
@@ -30,11 +30,11 @@
#define DEL_BLK 0x0002
blk_t test1[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 0 };
-blk_t test2[] = { 11, 10, 9, 8, 7, 6, 5, 4, 3, 3, 2, 1 };
+blk_t test2[] = { 11, 10, 9, 8, 7, 6, 5, 4, 3, 3, 2, 1, 0 };
blk_t test3[] = { 3, 1, 4, 5, 9, 2, 7, 10, 5, 6, 10, 8, 0 };
blk_t test4[] = { 20, 50, 12, 17, 13, 2, 66, 23, 56, 0 };
blk_t test4a[] = {
- 20, 1,
+ 20, 1,
50, 1,
3, 0,
17, 1,
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libext2fs: fix tst_badblocks buffer overrun
2015-11-24 21:50 [PATCH] libext2fs: fix tst_badblocks buffer overrun Andreas Dilger
@ 2015-11-30 17:10 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2015-11-30 17:10 UTC (permalink / raw)
To: Andreas Dilger; +Cc: linux-ext4
On Tue, Nov 24, 2015 at 02:50:10PM -0700, Andreas Dilger wrote:
> The test2[] array is not 0-terminated and the create_test_list() for
> loop does not terminate properly at the end of this array, but
> continues until it hits the 0 at the end of test3[].
>
> Reported-by: Hanno Boeck <hanno@hboeck.de>
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=104311
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] libext2fs: fix tst_badblocks buffer overrun
@ 2015-09-10 0:01 Andreas Dilger
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Dilger @ 2015-09-10 0:01 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Andreas Dilger
The test2[] array is not 0-terminated and the create_test_list() for
loop does not terminate properly at the end of this array, but
continues until it hits the 0 at the end of test3[].
Reported-by: Hanno Boeck <hanno@hboeck.de>
Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=104311
Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
lib/ext2fs/tst_badblocks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ext2fs/tst_badblocks.c b/lib/ext2fs/tst_badblocks.c
index 3b39ef1..c685f33 100644
--- a/lib/ext2fs/tst_badblocks.c
+++ b/lib/ext2fs/tst_badblocks.c
@@ -30,11 +30,11 @@
#define DEL_BLK 0x0002
blk_t test1[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 0 };
-blk_t test2[] = { 11, 10, 9, 8, 7, 6, 5, 4, 3, 3, 2, 1 };
+blk_t test2[] = { 11, 10, 9, 8, 7, 6, 5, 4, 3, 3, 2, 1, 0 };
blk_t test3[] = { 3, 1, 4, 5, 9, 2, 7, 10, 5, 6, 10, 8, 0 };
blk_t test4[] = { 20, 50, 12, 17, 13, 2, 66, 23, 56, 0 };
blk_t test4a[] = {
- 20, 1,
+ 20, 1,
50, 1,
3, 0,
17, 1,
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-30 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-24 21:50 [PATCH] libext2fs: fix tst_badblocks buffer overrun Andreas Dilger
2015-11-30 17:10 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2015-09-10 0:01 Andreas Dilger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.