* [PATCH v2] powerpc: Append linux_banner to exception information in xmon.
@ 2015-11-25 2:46 Rashmica Gupta
2015-11-25 8:15 ` Denis Kirjanov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rashmica Gupta @ 2015-11-25 2:46 UTC (permalink / raw)
To: linuxppc-dev
Currently if you are in xmon without an oops etc. to view the kernel
version you have to type "d $linux_banner" - not necessarily obvious. As
this is useful information, append to the output of "e" command.
Example output:
$mon> e
cpu 0x1: Vector: 0 at [c0000000f879ba80]
pc: c000000000081718: sysrq_handle_xmon+0x68/0x80
lr: c000000000081718: sysrq_handle_xmon+0x68/0x80
sp: c0000000f879bbe0
msr: 8000000000009033
current = 0xc0000000f604d5c0
paca = 0xc00000000fdc0480 softe: 0 irq_happened: 0x01
pid = 2467, comm = bash
Linux version 4.4.0-rc2-00008-gc51af91c3ab3-dirty (rashmica@circle) (gcc
version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
Signed-off-by: Rashmica Gupta <rashmicy@gmail.com>
---
Added example output and word wrapping.
arch/powerpc/xmon/xmon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index df05bd2fca07..6d3d9d031aea 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1528,6 +1528,8 @@ static void excprint(struct pt_regs *fp)
if (trap == 0x700)
print_bug_trap(fp);
+
+ printf(linux_banner);
}
static void prregs(struct pt_regs *fp)
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.
2015-11-25 2:46 [PATCH v2] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
@ 2015-11-25 8:15 ` Denis Kirjanov
2015-11-25 11:15 ` Michael Ellerman
2015-12-02 22:43 ` Stewart Smith
2015-12-15 11:27 ` [v2] " Michael Ellerman
2 siblings, 1 reply; 5+ messages in thread
From: Denis Kirjanov @ 2015-11-25 8:15 UTC (permalink / raw)
To: Rashmica Gupta; +Cc: linuxppc-dev
On 11/25/15, Rashmica Gupta <rashmicy@gmail.com> wrote:
> Currently if you are in xmon without an oops etc. to view the kernel
> version you have to type "d $linux_banner" - not necessarily obvious. As
> this is useful information, append to the output of "e" command.
>
> Example output:
> $mon> e
> cpu 0x1: Vector: 0 at [c0000000f879ba80]
> pc: c000000000081718: sysrq_handle_xmon+0x68/0x80
> lr: c000000000081718: sysrq_handle_xmon+0x68/0x80
> sp: c0000000f879bbe0
> msr: 8000000000009033
> current = 0xc0000000f604d5c0
> paca = 0xc00000000fdc0480 softe: 0 irq_happened: 0x01
> pid = 2467, comm = bash
> Linux version 4.4.0-rc2-00008-gc51af91c3ab3-dirty (rashmica@circle) (gcc
> version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
>
> Signed-off-by: Rashmica Gupta <rashmicy@gmail.com>
You forgot to update the subject line
> ---
> Added example output and word wrapping.
>
> arch/powerpc/xmon/xmon.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> index df05bd2fca07..6d3d9d031aea 100644
> --- a/arch/powerpc/xmon/xmon.c
> +++ b/arch/powerpc/xmon/xmon.c
> @@ -1528,6 +1528,8 @@ static void excprint(struct pt_regs *fp)
>
> if (trap == 0x700)
> print_bug_trap(fp);
> +
> + printf(linux_banner);
> }
>
> static void prregs(struct pt_regs *fp)
> --
> 2.5.0
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.
2015-11-25 8:15 ` Denis Kirjanov
@ 2015-11-25 11:15 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2015-11-25 11:15 UTC (permalink / raw)
To: Denis Kirjanov, Rashmica Gupta; +Cc: linuxppc-dev
On 25 November 2015 7:15:46 pm AEDT, Denis Kirjanov <kda@linux-powerpc.org> wrote:
>You forgot to update the subject line
That's OK I will fix it up when I apply it.
cheers
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] powerpc: Append linux_banner to exception information in xmon.
2015-11-25 2:46 [PATCH v2] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
2015-11-25 8:15 ` Denis Kirjanov
@ 2015-12-02 22:43 ` Stewart Smith
2015-12-15 11:27 ` [v2] " Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Stewart Smith @ 2015-12-02 22:43 UTC (permalink / raw)
To: Rashmica Gupta, linuxppc-dev
Rashmica Gupta <rashmicy@gmail.com> writes:
> Currently if you are in xmon without an oops etc. to view the kernel
> version you have to type "d $linux_banner" - not necessarily obvious. As
> this is useful information, append to the output of "e" command.
>
> Example output:
> $mon> e
> cpu 0x1: Vector: 0 at [c0000000f879ba80]
> pc: c000000000081718: sysrq_handle_xmon+0x68/0x80
> lr: c000000000081718: sysrq_handle_xmon+0x68/0x80
> sp: c0000000f879bbe0
> msr: 8000000000009033
> current = 0xc0000000f604d5c0
> paca = 0xc00000000fdc0480 softe: 0 irq_happened: 0x01
> pid = 2467, comm = bash
> Linux version 4.4.0-rc2-00008-gc51af91c3ab3-dirty (rashmica@circle) (gcc
> version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
>
> Signed-off-by: Rashmica Gupta <rashmicy@gmail.com>
+10,245,789
Acked-by: Stewart Smith <stewart@linux.vnet.ibm.com>
If I had a dollar for every time this would have helped *this morning*,
I'd at least be buying you enough coffee for it to be problematic.
I'd be keen in it heading to stable@ fixing the actual problem of
"people can't actually include the damn kernel version in their bug
report" - but maybe somebody else can work out if this is something
that's likely to be accepted.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2] powerpc: Append linux_banner to exception information in xmon.
2015-11-25 2:46 [PATCH v2] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
2015-11-25 8:15 ` Denis Kirjanov
2015-12-02 22:43 ` Stewart Smith
@ 2015-12-15 11:27 ` Michael Ellerman
2 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2015-12-15 11:27 UTC (permalink / raw)
To: Rashmica Gupta, linuxppc-dev
On Wed, 2015-25-11 at 02:46:25 UTC, Rashmica Gupta wrote:
> Currently if you are in xmon without an oops etc. to view the kernel
> version you have to type "d $linux_banner" - not necessarily obvious. As
> this is useful information, append to the output of "e" command.
>
> Example output:
> $mon> e
> cpu 0x1: Vector: 0 at [c0000000f879ba80]
> pc: c000000000081718: sysrq_handle_xmon+0x68/0x80
> lr: c000000000081718: sysrq_handle_xmon+0x68/0x80
> sp: c0000000f879bbe0
> msr: 8000000000009033
> current = 0xc0000000f604d5c0
> paca = 0xc00000000fdc0480 softe: 0 irq_happened: 0x01
> pid = 2467, comm = bash
> Linux version 4.4.0-rc2-00008-gc51af91c3ab3-dirty (rashmica@circle) (gcc
> version 5.1.1 20150629 (GCC) ) #45 SMP Wed Nov 25 10:25:12 AEDT 2015
>
> Signed-off-by: Rashmica Gupta <rashmicy@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/eb925d64604991095b6e9476
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-15 11:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-25 2:46 [PATCH v2] powerpc: Append linux_banner to exception information in xmon Rashmica Gupta
2015-11-25 8:15 ` Denis Kirjanov
2015-11-25 11:15 ` Michael Ellerman
2015-12-02 22:43 ` Stewart Smith
2015-12-15 11:27 ` [v2] " Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.