All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaedon Shin <jaedon.shin@gmail.com>
To: Tejun Heo <tj@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-ide@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Dragan Stancevic <dragan.stancevic@gmail.com>,
	Jaedon Shin <jaedon.shin@gmail.com>
Subject: [v6 2/7] ata: ahci_brcmstb: disable NCQ for MIPS-based platforms
Date: Thu, 26 Nov 2015 11:56:30 +0900	[thread overview]
Message-ID: <1448506595-4981-3-git-send-email-jaedon.shin@gmail.com> (raw)
In-Reply-To: <1448506595-4981-1-git-send-email-jaedon.shin@gmail.com>

The most MIPS-based platforms need to disable NCQ while have the NCQ
capability in HOST_CAP, and several ARM-based platforms (eg. BCM7349A0,
BCM7445A0, BCM7445B0) need to disable too.

Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Brian Norris <computersforpeace@gmail.com>
---
 drivers/ata/ahci_brcmstb.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
index 73e3b0b2a3c2..e62e02de71d0 100644
--- a/drivers/ata/ahci_brcmstb.c
+++ b/drivers/ata/ahci_brcmstb.c
@@ -69,10 +69,15 @@
 	(DATA_ENDIAN << DMADESC_ENDIAN_SHIFT) |		\
 	(MMIO_ENDIAN << MMIO_ENDIAN_SHIFT))
 
+enum brcm_ahci_quirks {
+	BRCM_AHCI_QUIRK_NO_NCQ		= BIT(0),
+};
+
 struct brcm_ahci_priv {
 	struct device *dev;
 	void __iomem *top_ctrl;
 	u32 port_mask;
+	u32 quirks;
 };
 
 static const struct ata_port_info ahci_brcm_port_info = {
@@ -256,6 +261,9 @@ static int brcm_ahci_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->top_ctrl))
 		return PTR_ERR(priv->top_ctrl);
 
+	if (of_device_is_compatible(dev->of_node, "brcm,bcm7425-ahci"))
+		priv->quirks |= BRCM_AHCI_QUIRK_NO_NCQ;
+
 	brcm_sata_init(priv);
 
 	priv->port_mask = brcm_ahci_get_portmask(pdev, priv);
@@ -273,6 +281,9 @@ static int brcm_ahci_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
+	if (priv->quirks & BRCM_AHCI_QUIRK_NO_NCQ)
+		hpriv->flags |= AHCI_HFLAG_NO_NCQ;
+
 	ret = ahci_platform_init_host(pdev, hpriv, &ahci_brcm_port_info,
 				      &ahci_platform_sht);
 	if (ret)
-- 
2.6.3


  parent reply	other threads:[~2015-11-26  2:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26  2:56 [v6 0/7] add support SATA for BMIPS_GENERIC Jaedon Shin
2015-11-26  2:56 ` [v6 1/7] ata: ahci_brcmstb: add support for MIPS-based platforms Jaedon Shin
2015-11-26  2:56 ` Jaedon Shin [this message]
2015-11-26  2:56 ` [v6 3/7] ata: ahci_brcmstb: add a quirk " Jaedon Shin
2015-11-26  2:56 ` [v6 4/7] ata: ahci_brcmstb: remove unused definitions Jaedon Shin
2015-11-30 14:58   ` Tejun Heo
2015-11-26  2:56 ` [v6 5/7] phy: phy_brcmstb_sata: remove duplicate definitions Jaedon Shin
2015-11-26  2:56 ` [v6 6/7] phy: phy_brcmstb_sata: add data for phy version Jaedon Shin
2015-11-26 11:05   ` Sergei Shtylyov
2015-12-15 10:46     ` Kishon Vijay Abraham I
2015-12-15 11:23       ` Jaedon Shin
2015-12-17  0:46         ` Florian Fainelli
2015-11-26  2:56 ` [v6 7/7] phy: phy_brcmstb_sata: add support for MIPS-based platforms Jaedon Shin
2015-12-20 12:01 ` [v6 0/7] add support SATA for BMIPS_GENERIC Kishon Vijay Abraham I
2015-12-24 17:52   ` Florian Fainelli
2015-12-28 15:56     ` Tejun Heo
2016-01-01  2:21       ` Tejun Heo
2016-01-01  2:34         ` Jaedon Shin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448506595-4981-3-git-send-email-jaedon.shin@gmail.com \
    --to=jaedon.shin@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dragan.stancevic@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=robh+dt@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.