All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] of/address: fix typo in comment block of of_translate_one()
@ 2015-11-30  6:22 Masahiro Yamada
  2015-12-06 20:43   ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2015-11-30  6:22 UTC (permalink / raw)
  To: devicetree
  Cc: Masahiro Yamada, Frank Rowand, Rob Herring, linux-kernel, Grant Likely

Remove the "not" before "cannot".

I am fixing the comment block style while I am here.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/of/address.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/of/address.c b/drivers/of/address.c
index 5289c80..91a469d 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -485,9 +485,10 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
 	int rone;
 	u64 offset = OF_BAD_ADDR;
 
-	/* Normally, an absence of a "ranges" property means we are
+	/*
+	 * Normally, an absence of a "ranges" property means we are
 	 * crossing a non-translatable boundary, and thus the addresses
-	 * below the current not cannot be converted to CPU physical ones.
+	 * below the current cannot be converted to CPU physical ones.
 	 * Unfortunately, while this is very clear in the spec, it's not
 	 * what Apple understood, and they do have things like /uni-n or
 	 * /ht nodes with no "ranges" property and a lot of perfectly
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] of/address: fix typo in comment block of of_translate_one()
@ 2015-12-06 20:43   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2015-12-06 20:43 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: devicetree, Frank Rowand, linux-kernel, Grant Likely

On Mon, Nov 30, 2015 at 12:22 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Remove the "not" before "cannot".
>
> I am fixing the comment block style while I am here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied for 4.4. Thanks.

Rob

> ---
>
>  drivers/of/address.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 5289c80..91a469d 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -485,9 +485,10 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
>         int rone;
>         u64 offset = OF_BAD_ADDR;
>
> -       /* Normally, an absence of a "ranges" property means we are
> +       /*
> +        * Normally, an absence of a "ranges" property means we are
>          * crossing a non-translatable boundary, and thus the addresses
> -        * below the current not cannot be converted to CPU physical ones.
> +        * below the current cannot be converted to CPU physical ones.
>          * Unfortunately, while this is very clear in the spec, it's not
>          * what Apple understood, and they do have things like /uni-n or
>          * /ht nodes with no "ranges" property and a lot of perfectly
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of/address: fix typo in comment block of of_translate_one()
@ 2015-12-06 20:43   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2015-12-06 20:43 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Frank Rowand,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Grant Likely

On Mon, Nov 30, 2015 at 12:22 AM, Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> wrote:
> Remove the "not" before "cannot".
>
> I am fixing the comment block style while I am here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>

Applied for 4.4. Thanks.

Rob

> ---
>
>  drivers/of/address.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index 5289c80..91a469d 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -485,9 +485,10 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
>         int rone;
>         u64 offset = OF_BAD_ADDR;
>
> -       /* Normally, an absence of a "ranges" property means we are
> +       /*
> +        * Normally, an absence of a "ranges" property means we are
>          * crossing a non-translatable boundary, and thus the addresses
> -        * below the current not cannot be converted to CPU physical ones.
> +        * below the current cannot be converted to CPU physical ones.
>          * Unfortunately, while this is very clear in the spec, it's not
>          * what Apple understood, and they do have things like /uni-n or
>          * /ht nodes with no "ranges" property and a lot of perfectly
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-06 20:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30  6:22 [PATCH] of/address: fix typo in comment block of of_translate_one() Masahiro Yamada
2015-12-06 20:43 ` Rob Herring
2015-12-06 20:43   ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.