All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 21/28] net: pch_gbe: mark Minnow PHY reset GPIO active low
Date: Mon, 30 Nov 2015 16:21:46 +0000	[thread overview]
Message-ID: <1448900513-20856-22-git-send-email-paul.burton@imgtec.com> (raw)
In-Reply-To: <1448900513-20856-1-git-send-email-paul.burton@imgtec.com>

The Minnow PHY reset GPIO is set to 0 to enter reset & 1 to leave reset
- that is, it is an active low GPIO. In order to allow for the code to
be made more generic by further patches, indicate to the GPIO subsystem
that the GPIO is active low & invert the values it is set to such that
they reflect logically whether the device is being reset or not.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 3b98b263b..fde4c11 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2717,7 +2717,8 @@ err_free_netdev:
  */
 static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)
 {
-	unsigned long flags = GPIOF_DIR_OUT | GPIOF_INIT_HIGH | GPIOF_EXPORT;
+	unsigned long flags = GPIOF_DIR_OUT | GPIOF_INIT_LOW |
+		GPIOF_EXPORT | GPIOF_ACTIVE_LOW;
 	unsigned gpio = MINNOW_PHY_RESET_GPIO;
 	int ret;
 
@@ -2729,10 +2730,10 @@ static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)
 		return ret;
 	}
 
-	gpio_set_value(gpio, 0);
-	usleep_range(1250, 1500);
 	gpio_set_value(gpio, 1);
 	usleep_range(1250, 1500);
+	gpio_set_value(gpio, 0);
+	usleep_range(1250, 1500);
 
 	return ret;
 }
-- 
2.6.2


WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 21/28] net: pch_gbe: mark Minnow PHY reset GPIO active low
Date: Mon, 30 Nov 2015 16:21:46 +0000	[thread overview]
Message-ID: <1448900513-20856-22-git-send-email-paul.burton@imgtec.com> (raw)
Message-ID: <20151130162146.nS3i_7pgNG2jMsvjCa0EFKFDNcX7oLoO2ytRvXIg408@z> (raw)
In-Reply-To: <1448900513-20856-1-git-send-email-paul.burton@imgtec.com>

The Minnow PHY reset GPIO is set to 0 to enter reset & 1 to leave reset
- that is, it is an active low GPIO. In order to allow for the code to
be made more generic by further patches, indicate to the GPIO subsystem
that the GPIO is active low & invert the values it is set to such that
they reflect logically whether the device is being reset or not.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 3b98b263b..fde4c11 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2717,7 +2717,8 @@ err_free_netdev:
  */
 static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)
 {
-	unsigned long flags = GPIOF_DIR_OUT | GPIOF_INIT_HIGH | GPIOF_EXPORT;
+	unsigned long flags = GPIOF_DIR_OUT | GPIOF_INIT_LOW |
+		GPIOF_EXPORT | GPIOF_ACTIVE_LOW;
 	unsigned gpio = MINNOW_PHY_RESET_GPIO;
 	int ret;
 
@@ -2729,10 +2730,10 @@ static int pch_gbe_minnow_platform_init(struct pci_dev *pdev)
 		return ret;
 	}
 
-	gpio_set_value(gpio, 0);
-	usleep_range(1250, 1500);
 	gpio_set_value(gpio, 1);
 	usleep_range(1250, 1500);
+	gpio_set_value(gpio, 0);
+	usleep_range(1250, 1500);
 
 	return ret;
 }
-- 
2.6.2

  parent reply	other threads:[~2015-11-30 16:27 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 16:21 [PATCH 00/28] MIPS Boston board support Paul Burton
2015-11-30 16:21 ` Paul Burton
2015-11-30 16:21 ` Paul Burton
2015-11-30 16:21 ` Paul Burton
2015-11-30 16:21 ` [rtc-linux] " Paul Burton
2015-11-30 16:21 ` [PATCH 01/28] serial: earlycon: allow MEM32 I/O for DT earlycon Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 22:52   ` Rob Herring
2015-11-30 22:52     ` Rob Herring
2015-12-02 23:38     ` Peter Hurley
2015-11-30 16:21 ` [PATCH 02/28] dt-bindings: ascii-lcd: Document a binding for simple ASCII LCDs Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 18:57   ` Rob Herring
2015-11-30 18:57     ` Rob Herring
2015-11-30 16:21 ` [PATCH 03/28] auxdisplay: driver for simple memory mapped ASCII LCD displays Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 04/28] MIPS: PCI: compatibility with ARM-like PCI host drivers Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 05/28] PCI: xilinx: keep references to both IRQ domains Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-04 18:17   ` Bjorn Helgaas
2015-12-04 18:17     ` Bjorn Helgaas
2015-11-30 16:21 ` [PATCH 06/28] PCI: xilinx: unify INTx & MSI interrupt FIFO decode Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 07/28] PCI: xilinx: always clear interrupt decode register Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 08/28] PCI: xilinx: fix INTX irq dispatch Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 09/28] PCI: xilinx: allow build on MIPS platforms Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 10/28] misc: pch_phub: " Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 11/28] dmaengine: pch_dma: " Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-10  3:49   ` Vinod Koul
2015-11-30 16:21 ` [PATCH 12/28] gpio: pch: " Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-10 16:23   ` Linus Walleij
2015-11-30 16:21 ` [PATCH 13/28] gpio: pch: allow use from device tree Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-10 16:25   ` Linus Walleij
2015-11-30 16:21 ` [PATCH 14/28] i2c: eg20t: allow build on MIPS platforms Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-03 21:05   ` Wolfram Sang
2015-11-30 16:21 ` [PATCH 15/28] i2c: eg20t: set i2c_adapter->dev.of_node Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-03 21:06   ` Wolfram Sang
2015-11-30 16:21 ` [PATCH 16/28] rtc: m41t80: add devicetree probe support Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` [rtc-linux] " Paul Burton
2015-11-30 16:56   ` Alexandre Belloni
2015-11-30 16:56     ` [rtc-linux] " Alexandre Belloni
2015-11-30 16:21 ` [PATCH 17/28] spi: topcliff-pch: allow build for MIPS platforms Paul Burton
2015-11-30 16:21   ` Paul Burton
     [not found]   ` <1448900513-20856-18-git-send-email-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-11-30 16:39     ` Applied "spi: topcliff-pch: allow build for MIPS platforms" to the spi tree Mark Brown
2015-11-30 16:21 ` [PATCH 18/28] ptp: pch: allow build on MIPS platforms Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-01  8:32   ` Richard Cochran
2015-11-30 16:21 ` [PATCH 19/28] net: pch_gbe: " Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 20/28] net: pch_gbe: clear interrupt FIFO during probe Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-01  1:48   ` Florian Fainelli
2015-12-01  1:48     ` Florian Fainelli
2015-11-30 16:21 ` Paul Burton [this message]
2015-11-30 16:21   ` [PATCH 21/28] net: pch_gbe: mark Minnow PHY reset GPIO active low Paul Burton
2015-11-30 16:21 ` [PATCH 22/28] net: pch_gbe: pull PHY GPIO handling out of Minnow code Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 23/28] net: pch_gbe: always reset PHY along with MAC Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 24/28] net: pch_gbe: add device tree support Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-12-13  1:22   ` Andy Shevchenko
2015-11-30 16:21 ` [PATCH 25/28] net: pch_gbe: allow longer for resets Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 26/28] MIPS: support for generating FIT (.itb) images Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:21 ` [PATCH 27/28] dt-bindings: mips: img,boston: Document img,boston binding Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 18:34   ` Rob Herring
2015-11-30 16:21 ` [PATCH 28/28] MIPS: Boston board support Paul Burton
2015-11-30 16:21   ` Paul Burton
2015-11-30 16:34 ` [PATCH 00/28] MIPS " Mark Brown
2015-11-30 16:34   ` Mark Brown
2015-11-30 16:34   ` [rtc-linux] " Mark Brown
2015-12-10 16:26   ` Linus Walleij
2015-12-10 16:26     ` Linus Walleij
2015-12-10 16:26     ` [rtc-linux] " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448900513-20856-22-git-send-email-paul.burton@imgtec.com \
    --to=paul.burton@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.