From: kan.liang@intel.com To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, davem@davemloft.net Cc: jesse.brandeburg@intel.com, andi@firstfloor.org, jeffrey.t.kirsher@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com, john.r.fastabend@intel.com, ogerlitz@mellanox.com, edumazet@google.com, jiri@mellanox.com, sfeldma@gmail.com, gospo@cumulusnetworks.com, sasha.levin@oracle.com, f.fainelli@gmail.com, dsahern@gmail.com, tj@kernel.org, cascardo@redhat.com, corbet@lwn.net, Kan Liang <kan.liang@intel.com> Subject: [RFC 3/4] net: support per queue rx_usecs in sysfs Date: Tue, 1 Dec 2015 08:01:31 +0000 [thread overview] Message-ID: <1448956892-15509-3-git-send-email-kan.liang@intel.com> (raw) In-Reply-To: <1448956892-15509-1-git-send-email-kan.liang@intel.com> From: Kan Liang <kan.liang@intel.com> Network devices usually have many queues. Each queue has its own rx_usecs options. Currently, we can only set all the queues with same value by ethtool. This patch expose the rx_usecs in sysfs. So the user can set/get per queue coalesce parameter rx_usecs by sysfs. Signed-off-by: Kan Liang <kan.liang@intel.com> --- Documentation/networking/scaling.txt | 4 ++++ include/linux/netdevice.h | 8 ++++++++ net/core/net-sysfs.c | 36 ++++++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) diff --git a/Documentation/networking/scaling.txt b/Documentation/networking/scaling.txt index 636192d..218429c 100644 --- a/Documentation/networking/scaling.txt +++ b/Documentation/networking/scaling.txt @@ -440,6 +440,10 @@ TX queue absolute delay timer can be set to a microseconds value with /sys/class/net/<dev>/queues/tx-<n>/tx_usecs +RX queue absolute delay timer can be set to a microseconds value with + +/sys/class/net/<dev>/queues/rx-<n>/rx_usecs + For the device which doesn't support per queue interrupt moderation, it shows "N/A". diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9db5c57..45a0054 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1063,6 +1063,10 @@ typedef u16 (*select_queue_fallback_t)(struct net_device *dev, * int index, u32 val); * void (*ndo_get_per_queue_tx_usecs)(struct net_device *dev, int index); * This function is used to set/get per queue coalesce parameter tx_usecs. + * void (*ndo_set_per_queue_rx_usecs)(struct net_device *dev, + * int index, u32 val); + * void (*ndo_get_per_queue_rx_usecs)(struct net_device *dev, int index); + * This function is used to set/get per queue coalesce parameter rx_usecs. * */ struct net_device_ops { @@ -1244,6 +1248,10 @@ struct net_device_ops { int index, u32 val); u32 (*ndo_get_per_queue_tx_usecs)(struct net_device *dev, int index); + void (*ndo_set_per_queue_rx_usecs)(struct net_device *dev, + int index, u32 val); + u32 (*ndo_get_per_queue_rx_usecs)(struct net_device *dev, + int index); }; /** diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 48016b8..ab08b2b 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -831,11 +831,47 @@ static struct rx_queue_attribute rps_dev_flow_table_cnt_attribute = show_rps_dev_flow_table_cnt, store_rps_dev_flow_table_cnt); #endif /* CONFIG_RPS */ +static ssize_t rx_usecs_show(struct netdev_rx_queue *queue, + struct rx_queue_attribute *attribute, char *buf) +{ + struct net_device *dev = queue->dev; + int index = queue - dev->_rx; + u32 val; + + if (dev->netdev_ops->ndo_get_per_queue_rx_usecs) { + val = dev->netdev_ops->ndo_get_per_queue_rx_usecs(dev, index); + return sprintf(buf, "%u\n", val); + } + return sprintf(buf, "N/A\n"); +} + +static ssize_t rx_usecs_store(struct netdev_rx_queue *queue, + struct rx_queue_attribute *attribute, + const char *buf, size_t len) +{ + struct net_device *dev = queue->dev; + int index = queue - dev->_rx; + u32 val, ret; + + ret = kstrtouint(buf, 0, &val); + if (ret < 0) + return -EINVAL; + + if (dev->netdev_ops->ndo_set_per_queue_rx_usecs) + dev->netdev_ops->ndo_set_per_queue_rx_usecs(dev, index, val); + + return len; +} + +static struct rx_queue_attribute rx_usecs_attribute = + __ATTR(rx_usecs, S_IRUGO | S_IWUSR, rx_usecs_show, rx_usecs_store); + static struct attribute *rx_queue_default_attrs[] = { #ifdef CONFIG_RPS &rps_cpus_attribute.attr, &rps_dev_flow_table_cnt_attribute.attr, #endif + &rx_usecs_attribute.attr, NULL }; -- 1.7.11.7
WARNING: multiple messages have this Message-ID (diff)
From: kan.liang@intel.com <kan.liang@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [RFC 3/4] net: support per queue rx_usecs in sysfs Date: Tue, 1 Dec 2015 08:01:31 +0000 [thread overview] Message-ID: <1448956892-15509-3-git-send-email-kan.liang@intel.com> (raw) In-Reply-To: <1448956892-15509-1-git-send-email-kan.liang@intel.com> From: Kan Liang <kan.liang@intel.com> Network devices usually have many queues. Each queue has its own rx_usecs options. Currently, we can only set all the queues with same value by ethtool. This patch expose the rx_usecs in sysfs. So the user can set/get per queue coalesce parameter rx_usecs by sysfs. Signed-off-by: Kan Liang <kan.liang@intel.com> --- Documentation/networking/scaling.txt | 4 ++++ include/linux/netdevice.h | 8 ++++++++ net/core/net-sysfs.c | 36 ++++++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) diff --git a/Documentation/networking/scaling.txt b/Documentation/networking/scaling.txt index 636192d..218429c 100644 --- a/Documentation/networking/scaling.txt +++ b/Documentation/networking/scaling.txt @@ -440,6 +440,10 @@ TX queue absolute delay timer can be set to a microseconds value with /sys/class/net/<dev>/queues/tx-<n>/tx_usecs +RX queue absolute delay timer can be set to a microseconds value with + +/sys/class/net/<dev>/queues/rx-<n>/rx_usecs + For the device which doesn't support per queue interrupt moderation, it shows "N/A". diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 9db5c57..45a0054 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1063,6 +1063,10 @@ typedef u16 (*select_queue_fallback_t)(struct net_device *dev, * int index, u32 val); * void (*ndo_get_per_queue_tx_usecs)(struct net_device *dev, int index); * This function is used to set/get per queue coalesce parameter tx_usecs. + * void (*ndo_set_per_queue_rx_usecs)(struct net_device *dev, + * int index, u32 val); + * void (*ndo_get_per_queue_rx_usecs)(struct net_device *dev, int index); + * This function is used to set/get per queue coalesce parameter rx_usecs. * */ struct net_device_ops { @@ -1244,6 +1248,10 @@ struct net_device_ops { int index, u32 val); u32 (*ndo_get_per_queue_tx_usecs)(struct net_device *dev, int index); + void (*ndo_set_per_queue_rx_usecs)(struct net_device *dev, + int index, u32 val); + u32 (*ndo_get_per_queue_rx_usecs)(struct net_device *dev, + int index); }; /** diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 48016b8..ab08b2b 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -831,11 +831,47 @@ static struct rx_queue_attribute rps_dev_flow_table_cnt_attribute = show_rps_dev_flow_table_cnt, store_rps_dev_flow_table_cnt); #endif /* CONFIG_RPS */ +static ssize_t rx_usecs_show(struct netdev_rx_queue *queue, + struct rx_queue_attribute *attribute, char *buf) +{ + struct net_device *dev = queue->dev; + int index = queue - dev->_rx; + u32 val; + + if (dev->netdev_ops->ndo_get_per_queue_rx_usecs) { + val = dev->netdev_ops->ndo_get_per_queue_rx_usecs(dev, index); + return sprintf(buf, "%u\n", val); + } + return sprintf(buf, "N/A\n"); +} + +static ssize_t rx_usecs_store(struct netdev_rx_queue *queue, + struct rx_queue_attribute *attribute, + const char *buf, size_t len) +{ + struct net_device *dev = queue->dev; + int index = queue - dev->_rx; + u32 val, ret; + + ret = kstrtouint(buf, 0, &val); + if (ret < 0) + return -EINVAL; + + if (dev->netdev_ops->ndo_set_per_queue_rx_usecs) + dev->netdev_ops->ndo_set_per_queue_rx_usecs(dev, index, val); + + return len; +} + +static struct rx_queue_attribute rx_usecs_attribute = + __ATTR(rx_usecs, S_IRUGO | S_IWUSR, rx_usecs_show, rx_usecs_store); + static struct attribute *rx_queue_default_attrs[] = { #ifdef CONFIG_RPS &rps_cpus_attribute.attr, &rps_dev_flow_table_cnt_attribute.attr, #endif + &rx_usecs_attribute.attr, NULL }; -- 1.7.11.7
next prev parent reply other threads:[~2015-12-01 19:43 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-01 8:01 [RFC 1/4] net: support per queue tx_usecs in sysfs kan.liang 2015-12-01 8:01 ` [Intel-wired-lan] " kan.liang 2015-12-01 8:01 ` [RFC 2/4] i40e: handle per queue tx_usecs setting kan.liang 2015-12-01 8:01 ` [Intel-wired-lan] " kan.liang 2015-12-01 8:01 ` kan.liang [this message] 2015-12-01 8:01 ` [Intel-wired-lan] [RFC 3/4] net: support per queue rx_usecs in sysfs kan.liang 2015-12-01 8:01 ` [RFC 4/4] i40e: handle per queue rx_usecs setting kan.liang 2015-12-01 8:01 ` [Intel-wired-lan] " kan.liang 2015-12-01 19:47 ` Stephen Hemminger 2015-12-01 19:47 ` [Intel-wired-lan] " Stephen Hemminger 2015-12-01 22:13 ` [RFC 1/4] net: support per queue tx_usecs in sysfs Florian Fainelli 2015-12-01 22:13 ` [Intel-wired-lan] " Florian Fainelli 2015-12-01 23:44 ` Jesse Brandeburg 2015-12-01 23:44 ` [Intel-wired-lan] " Jesse Brandeburg 2015-12-02 1:57 ` Alexander Duyck 2015-12-02 1:57 ` [Intel-wired-lan] " Alexander Duyck 2015-12-02 2:27 ` David Miller 2015-12-02 2:27 ` [Intel-wired-lan] " David Miller 2015-12-02 2:23 ` David Miller 2015-12-02 2:23 ` [Intel-wired-lan] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1448956892-15509-3-git-send-email-kan.liang@intel.com \ --to=kan.liang@intel.com \ --cc=andi@firstfloor.org \ --cc=carolyn.wyborny@intel.com \ --cc=cascardo@redhat.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=donald.c.skidmore@intel.com \ --cc=dsahern@gmail.com \ --cc=edumazet@google.com \ --cc=f.fainelli@gmail.com \ --cc=gospo@cumulusnetworks.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=jesse.brandeburg@intel.com \ --cc=jiri@mellanox.com \ --cc=john.r.fastabend@intel.com \ --cc=john.ronciak@intel.com \ --cc=matthew.vick@intel.com \ --cc=mitch.a.williams@intel.com \ --cc=netdev@vger.kernel.org \ --cc=ogerlitz@mellanox.com \ --cc=sasha.levin@oracle.com \ --cc=sfeldma@gmail.com \ --cc=shannon.nelson@intel.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.