All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/panel: add kernel doc for size attributes in panel_desc
@ 2015-12-04 11:31 Ulrich Ölmann
  2015-12-16 15:20 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Ölmann @ 2015-12-04 11:31 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Ulrich Ölmann, kernel, dri-devel

Document that 'width' and 'height' are measured in millimeters.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ada97a0..8c194ed 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -44,6 +44,10 @@ struct panel_desc {
 
 	unsigned int bpc;
 
+	/**
+	 * @width: the width of the panel (in millimeters)
+	 * @height: the height of the panel (in millimeters)
+	 */
 	struct {
 		unsigned int width;
 		unsigned int height;
-- 
2.6.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/panel: add kernel doc for size attributes in panel_desc
  2015-12-04 11:31 [PATCH] drm/panel: add kernel doc for size attributes in panel_desc Ulrich Ölmann
@ 2015-12-16 15:20 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2015-12-16 15:20 UTC (permalink / raw)
  To: Ulrich Ölmann; +Cc: kernel, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]

On Fri, Dec 04, 2015 at 12:31:28PM +0100, Ulrich Ölmann wrote:
> Document that 'width' and 'height' are measured in millimeters.
> 
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 4 ++++
>  1 file changed, 4 insertions(+)

I've applied this, with a slightly reworded comment, to clarify that it
is the size of the active display area:

	/**
	 * @width: width (in millimeters) of the panel's active display area
	 * @height: height (in millimeters) of the panel's active display area
	 */

Thanks,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-16 15:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 11:31 [PATCH] drm/panel: add kernel doc for size attributes in panel_desc Ulrich Ölmann
2015-12-16 15:20 ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.