[PATCH OSSTEST v2] standalone: Log things we are running via with_logging

[PATCH OSSTEST v2] standalone: Log things we are running via with_logging

[Ian Campbell]

Turning on set -x generally in this script is too verbose, so run the
command in a subshell which sets -x.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: Use set -x in a sub shell
---
 standalone | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/standalone b/standalone
index c804b74..499cb6c 100755
--- a/standalone
+++ b/standalone
@@ -195,7 +195,7 @@ with_logging() {
     if command -v savelog >/dev/null ; then
         savelog -c 300 -n "$log" >/dev/null
     fi
-    "$@" 2>&1 | tee "$log"
+    ( set -x ; "$@" ) 2>&1 | tee "$log"
     rc=${PIPESTATUS[0]}
     if [ $rc -ne 0 ] ; then
 	echo "FAILED rc=${rc}" >&2
-- 
2.6.1

Re: [PATCH OSSTEST v2] standalone: Log things we are running via with_logging

[Ian Jackson]

Ian Campbell writes ("[PATCH OSSTEST v2] standalone: Log things we are running via with_logging"):
> Turning on set -x generally in this script is too verbose, so run the
> command in a subshell which sets -x.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

(I will pick this up into my queue)