* [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h
@ 2015-12-04 17:34 Peter Maydell
2016-01-11 8:13 ` Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2015-12-04 17:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Our use of glib is now pervasive across QEMU. Move the include of glib-compat.h
from qemu-common.h to osdep.h so that it is more widely accessible and doesn't
get forgotten by accident. (Failure to include it will result in build failure
on old versions of glib which is likely to be unnoticed by most developers.)
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/qemu-common.h | 1 -
include/qemu/osdep.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/qemu-common.h b/include/qemu-common.h
index 405364f..22b010c 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -22,7 +22,6 @@
#define TFR(expr) do { if ((expr) != -1) break; } while (errno == EINTR)
-#include "glib-compat.h"
#include "qemu/option.h"
#include "qemu/host-utils.h"
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 84e84ac..59a7f8d 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -69,6 +69,8 @@
#include "sysemu/os-posix.h"
#endif
+#include "glib-compat.h"
+
#include "qapi/error.h"
#if defined(CONFIG_SOLARIS) && CONFIG_SOLARIS_VERSION < 10
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h
2015-12-04 17:34 [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h Peter Maydell
@ 2016-01-11 8:13 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2016-01-11 8:13 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-trivial
04.12.2015 20:34, Peter Maydell wrote:
> Our use of glib is now pervasive across QEMU. Move the include of glib-compat.h
> from qemu-common.h to osdep.h so that it is more widely accessible and doesn't
> get forgotten by accident. (Failure to include it will result in build failure
> on old versions of glib which is likely to be unnoticed by most developers.)
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-11 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 17:34 [Qemu-devel] [PATCH] osdep.h: Include glib-compat.h in osdep.h rather than qemu-common.h Peter Maydell
2016-01-11 8:13 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.