All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HID: wacom: Apply lowres quirk to BAMBOO_TOUCH devices
@ 2015-12-04 22:45 Jason Gerecke
  2015-12-08 14:13 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Gerecke @ 2015-12-04 22:45 UTC (permalink / raw)
  To: linux-input
  Cc: Jiri Kosina, Ping Cheng, Aaron Skomra, Jason Gerecke, Jason Gerecke

When splitting the touch-only "BAMBOO_TOUCH" type out of the existing
"BAMBOO_PT" type in 3b164a00, the lowres quirk was not updated so that
it would continue to apply to these devices (effectively only the 0xD0).
The absence of this quirk does not significantly impact usability, but
is a correctness issue nonetheless.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
 drivers/hid/wacom_wac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 3953416..bec2300 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2421,7 +2421,7 @@ void wacom_setup_device_quirks(struct wacom *wacom)
 		features->quirks |= WACOM_QUIRK_BATTERY;
 
 	/* quirk for bamboo touch with 2 low res touches */
-	if (features->type == BAMBOO_PT &&
+	if ((features->type == BAMBOO_PT || features->type == BAMBOO_TOUCH) &&
 	    features->pktlen == WACOM_PKGLEN_BBTOUCH) {
 		features->x_max <<= 5;
 		features->y_max <<= 5;
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: wacom: Apply lowres quirk to BAMBOO_TOUCH devices
  2015-12-04 22:45 [PATCH] HID: wacom: Apply lowres quirk to BAMBOO_TOUCH devices Jason Gerecke
@ 2015-12-08 14:13 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2015-12-08 14:13 UTC (permalink / raw)
  To: Jason Gerecke; +Cc: linux-input, Ping Cheng, Aaron Skomra, Jason Gerecke

On Fri, 4 Dec 2015, Jason Gerecke wrote:

> When splitting the touch-only "BAMBOO_TOUCH" type out of the existing
> "BAMBOO_PT" type in 3b164a00, the lowres quirk was not updated so that
> it would continue to apply to these devices (effectively only the 0xD0).
> The absence of this quirk does not significantly impact usability, but
> is a correctness issue nonetheless.
> 
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>

Applied to for-4.5/wacom.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-08 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 22:45 [PATCH] HID: wacom: Apply lowres quirk to BAMBOO_TOUCH devices Jason Gerecke
2015-12-08 14:13 ` Jiri Kosina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.