* [PATCH v2] rtlwifi: fix memory leak for USB device
@ 2015-12-07 0:07 Peter Wu
2015-12-07 2:14 ` Larry Finger
2015-12-11 11:49 ` [v2] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Peter Wu @ 2015-12-07 0:07 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo, linux-wireless, netdev,
linux-kernel
Cc: stable
Free skb for received frames with a wrong checksum. This can happen
pretty rapidly, exhausting all memory.
This fixes a memleak (detected with kmemleak). Originally found while
using monitor mode, but it also appears during managed mode (once the
link is up).
Cc: stable@vger.kernel.org
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
---
v2: updated commit message based on Larry's feedback
v1: https://lkml.kernel.org/r/1449424677-3140-1-git-send-email-peter@lekensteyn.nl
Tested with v4.3, rebased on v4.4-rc3 (changed paths). The bug goes back
to its introduction in the v2.6.x kernel.
---
drivers/net/wireless/realtek/rtlwifi/usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 2721cf8..aac1ed3 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -531,6 +531,8 @@ static void _rtl_usb_rx_process_noagg(struct ieee80211_hw *hw,
ieee80211_rx(hw, skb);
else
dev_kfree_skb_any(skb);
+ } else {
+ dev_kfree_skb_any(skb);
}
}
--
2.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtlwifi: fix memory leak for USB device
2015-12-07 0:07 [PATCH v2] rtlwifi: fix memory leak for USB device Peter Wu
@ 2015-12-07 2:14 ` Larry Finger
2015-12-11 11:49 ` [v2] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2015-12-07 2:14 UTC (permalink / raw)
To: Peter Wu, Chaoming Li, Kalle Valo, linux-wireless, netdev, linux-kernel
Cc: stable
On 12/06/2015 06:07 PM, Peter Wu wrote:
> Free skb for received frames with a wrong checksum. This can happen
> pretty rapidly, exhausting all memory.
>
> This fixes a memleak (detected with kmemleak). Originally found while
> using monitor mode, but it also appears during managed mode (once the
> link is up).
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Wu <peter@lekensteyn.nl>
> ---
> v2: updated commit message based on Larry's feedback
> v1: https://lkml.kernel.org/r/1449424677-3140-1-git-send-email-peter@lekensteyn.nl
>
> Tested with v4.3, rebased on v4.4-rc3 (changed paths). The bug goes back
> to its introduction in the v2.6.x kernel.
> ---
> drivers/net/wireless/realtek/rtlwifi/usb.c | 2 ++
> 1 file changed, 2 insertions(+)
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
> index 2721cf8..aac1ed3 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/usb.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
> @@ -531,6 +531,8 @@ static void _rtl_usb_rx_process_noagg(struct ieee80211_hw *hw,
> ieee80211_rx(hw, skb);
> else
> dev_kfree_skb_any(skb);
> + } else {
> + dev_kfree_skb_any(skb);
> }
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] rtlwifi: fix memory leak for USB device
2015-12-07 0:07 [PATCH v2] rtlwifi: fix memory leak for USB device Peter Wu
2015-12-07 2:14 ` Larry Finger
@ 2015-12-11 11:49 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2015-12-11 11:49 UTC (permalink / raw)
To: Peter Wu
Cc: Larry Finger, Chaoming Li, linux-wireless, netdev, linux-kernel, stable
> Free skb for received frames with a wrong checksum. This can happen
> pretty rapidly, exhausting all memory.
>
> This fixes a memleak (detected with kmemleak). Originally found while
> using monitor mode, but it also appears during managed mode (once the
> link is up).
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Wu <peter@lekensteyn.nl>
> ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-11 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07 0:07 [PATCH v2] rtlwifi: fix memory leak for USB device Peter Wu
2015-12-07 2:14 ` Larry Finger
2015-12-11 11:49 ` [v2] " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.