* [PATCH v2] usb: host: iounmap before return
@ 2015-12-07 23:07 Geyslan G. Bem
0 siblings, 0 replies; only message in thread
From: Geyslan G. Bem @ 2015-12-07 23:07 UTC (permalink / raw)
To: peter.senna
Cc: Geyslan G. Bem, Mathias Nyman, Greg Kroah-Hartman, linux-usb,
linux-kernel
This patch fixes a 'quirk_usb_handoff_xhci()' branch return that
was not unmapping correctly.
Coccinelle: scripts/coccinelle/free/iounmap.cocci
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
drivers/usb/host/pci-quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..ee4426b 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -992,7 +992,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
if ((ext_cap_offset + sizeof(val)) > len) {
/* We're reading garbage from the controller */
dev_warn(&pdev->dev, "xHCI controller failing to respond");
- return;
+ goto out;
}
val = readl(base + ext_cap_offset);
@@ -1055,6 +1055,7 @@ hc_init:
XHCI_MAX_HALT_USEC, val);
}
+ out:
iounmap(base);
}
--
2.6.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-07 23:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07 23:07 [PATCH v2] usb: host: iounmap before return Geyslan G. Bem
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.