All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenyou Yang <wenyou.yang@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] drivers: usb: ohci-at91: clean up the PLLB code
Date: Wed, 9 Dec 2015 12:29:42 +0800	[thread overview]
Message-ID: <1449635383-8180-3-git-send-email-wenyou.yang@atmel.com> (raw)
In-Reply-To: <1449635383-8180-1-git-send-email-wenyou.yang@atmel.com>

Due to introducing the new PLLB clock handle functions,
use these functions to clean up the PLLB enable/disable code.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 drivers/usb/host/ohci-at91.c |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 6ae6959..6431802 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -9,20 +9,13 @@
 
 #if defined(CONFIG_USB_OHCI_NEW) && defined(CONFIG_SYS_USB_OHCI_CPU_INIT)
 
-#include <asm/io.h>
-#include <asm/arch/hardware.h>
-#include <asm/arch/at91_pmc.h>
 #include <asm/arch/clk.h>
 
 int usb_cpu_init(void)
 {
-	at91_pmc_t *pmc	= (at91_pmc_t *)ATMEL_BASE_PMC;
-
 #ifdef CONFIG_USB_ATMEL_CLK_SEL_PLLB
-	/* Enable PLLB */
-	writel(get_pllb_init(), &pmc->pllbr);
-	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
-		;
+	at91_pllb_clk_enable(get_pllb_init());
+
 #ifdef CONFIG_AT91SAM9N12
 	at91_usb_clk_init(AT91_PMC_USBS_USB_PLLB | AT91_PMC_USB_DIV_2);
 #endif
@@ -45,8 +38,6 @@ int usb_cpu_init(void)
 
 int usb_cpu_stop(void)
 {
-	at91_pmc_t *pmc	= (at91_pmc_t *)ATMEL_BASE_PMC;
-
 	at91_periph_clk_disable(ATMEL_ID_UHP);
 
 	at91_system_clk_disable(ATMEL_PMC_UHP);
@@ -58,10 +49,9 @@ int usb_cpu_stop(void)
 #ifdef CONFIG_AT91SAM9N12
 	at91_usb_clk_init(0);
 #endif
-	/* Disable PLLB */
-	writel(0, &pmc->pllbr);
-	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != 0)
-		;
+
+	at91_pllb_clk_disable();
+
 #elif defined(CONFIG_USB_ATMEL_CLK_SEL_UPLL)
 	if (at91_upll_clk_disable())
 		return -1;
-- 
1.7.9.5

  parent reply	other threads:[~2015-12-09  4:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  4:29 [U-Boot] [PATCH 0/3] ARM: at91: add PLLB handle functions Wenyou Yang
2015-12-09  4:29 ` [U-Boot] [PATCH 1/3] ARM: at91: clock: add PLLB enable/disable functions Wenyou Yang
2015-12-10  9:33   ` Heiko Schocher
2015-12-10 12:03     ` Yang, Wenyou
2016-01-26 15:35   ` Andreas Bießmann
2015-12-09  4:29 ` Wenyou Yang [this message]
2015-12-10  9:34   ` [U-Boot] [PATCH 2/3] drivers: usb: ohci-at91: clean up the PLLB code Heiko Schocher
2016-01-26 15:30   ` Andreas Bießmann
2015-12-09  4:29 ` [U-Boot] [PATCH 3/3] board: atmel: siemens: clean up " Wenyou Yang
2015-12-10  9:34   ` Heiko Schocher
2016-01-26 15:38   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449635383-8180-3-git-send-email-wenyou.yang@atmel.com \
    --to=wenyou.yang@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.