All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenyou Yang <wenyou.yang@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] board: atmel: siemens: clean up PLLB code
Date: Wed, 9 Dec 2015 12:29:43 +0800	[thread overview]
Message-ID: <1449635383-8180-4-git-send-email-wenyou.yang@atmel.com> (raw)
In-Reply-To: <1449635383-8180-1-git-send-email-wenyou.yang@atmel.com>

Due to introducing the new PLLB clock handle functions,
use these functions to clean up the PLLB enable code.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 board/siemens/smartweb/smartweb.c |    6 +-----
 board/siemens/taurus/taurus.c     |    6 +-----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/board/siemens/smartweb/smartweb.c b/board/siemens/smartweb/smartweb.c
index e7ee65c..47a60a7 100644
--- a/board/siemens/smartweb/smartweb.c
+++ b/board/siemens/smartweb/smartweb.c
@@ -115,12 +115,8 @@ static void smartweb_macb_hw_init(void)
 
 void at91_udp_hw_init(void)
 {
-	at91_pmc_t *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
-
 	/* Enable PLLB */
-	writel(get_pllb_init(), &pmc->pllbr);
-	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
-		;
+	at91_pllb_clk_enable(get_pllb_init());
 
 	/* Enable UDPCK clock, MCK is enabled in at91_clock_init() */
 	at91_periph_clk_enable(ATMEL_ID_UDP);
diff --git a/board/siemens/taurus/taurus.c b/board/siemens/taurus/taurus.c
index 9374064..b0385d8 100644
--- a/board/siemens/taurus/taurus.c
+++ b/board/siemens/taurus/taurus.c
@@ -289,12 +289,8 @@ void spi_cs_deactivate(struct spi_slave *slave)
 
 void at91_udp_hw_init(void)
 {
-	at91_pmc_t *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
-
 	/* Enable PLLB */
-	writel(get_pllb_init(), &pmc->pllbr);
-	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
-		;
+	at91_pllb_clk_enable(get_pllb_init());
 
 	/* Enable UDPCK clock, MCK is enabled in at91_clock_init() */
 	at91_periph_clk_enable(ATMEL_ID_UDP);
-- 
1.7.9.5

  parent reply	other threads:[~2015-12-09  4:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  4:29 [U-Boot] [PATCH 0/3] ARM: at91: add PLLB handle functions Wenyou Yang
2015-12-09  4:29 ` [U-Boot] [PATCH 1/3] ARM: at91: clock: add PLLB enable/disable functions Wenyou Yang
2015-12-10  9:33   ` Heiko Schocher
2015-12-10 12:03     ` Yang, Wenyou
2016-01-26 15:35   ` Andreas Bießmann
2015-12-09  4:29 ` [U-Boot] [PATCH 2/3] drivers: usb: ohci-at91: clean up the PLLB code Wenyou Yang
2015-12-10  9:34   ` Heiko Schocher
2016-01-26 15:30   ` Andreas Bießmann
2015-12-09  4:29 ` Wenyou Yang [this message]
2015-12-10  9:34   ` [U-Boot] [PATCH 3/3] board: atmel: siemens: clean up " Heiko Schocher
2016-01-26 15:38   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449635383-8180-4-git-send-email-wenyou.yang@atmel.com \
    --to=wenyou.yang@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.