All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Nowicki <tn@semihalf.com>
To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com,
	catalin.marinas@arm.com, rjw@rjwysocki.net,
	hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com,
	okaya@codeaurora.org, jiang.liu@linux.intel.com,
	Stefano.Stabellini@eu.citrix.com
Cc: robert.richter@caviumnetworks.com, mw@semihalf.com,
	Liviu.Dudau@arm.com, ddaney@caviumnetworks.com,
	tglx@linutronix.de, wangyijing@huawei.com,
	Suravee.Suthikulpanit@amd.com, msalter@redhat.com,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linaro-acpi@lists.linaro.org, jchandra@broadcom.com,
	jcm@redhat.com, Tomasz Nowicki <tn@semihalf.com>
Subject: [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation.
Date: Wed, 16 Dec 2015 16:16:26 +0100	[thread overview]
Message-ID: <1450278993-12664-17-git-send-email-tn@semihalf.com> (raw)
In-Reply-To: <1450278993-12664-1-git-send-email-tn@semihalf.com>

Arches in subject are the only one who use pcibios_{add|remove}_bus hooks
and implement it in the same way. Moreover ARM64 is going to do the same.
So it seams that acpi_pci_{add|remove}_bus is generic enough to be default
option for pcibios_{add|remove}_bus hooks. Also, it is always safe to run
acpi_pci_{add|remove}_bus as they have empty stubs for !ACPI case and
return if ACPI has been switched off in run time.

After all we can remove x86 and ia64 pcibios_{add|remove}_bus
implementation.

Signed-off-by: Tomasz Nowicki <tn@semihalf.com>
---
 arch/ia64/pci/pci.c   | 10 ----------
 arch/x86/pci/common.c | 10 ----------
 drivers/pci/probe.c   |  3 +++
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c
index fe96bc9..c1e8ed5 100644
--- a/arch/ia64/pci/pci.c
+++ b/arch/ia64/pci/pci.c
@@ -357,16 +357,6 @@ void pcibios_fixup_bus(struct pci_bus *b)
 	platform_pci_fixup_bus(b);
 }
 
-void pcibios_add_bus(struct pci_bus *bus)
-{
-	acpi_pci_add_bus(bus);
-}
-
-void pcibios_remove_bus(struct pci_bus *bus)
-{
-	acpi_pci_remove_bus(bus);
-}
-
 void pcibios_set_master (struct pci_dev *dev)
 {
 	/* No special bus mastering setup handling */
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index eccd4d9..ed3236d 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -171,16 +171,6 @@ void pcibios_fixup_bus(struct pci_bus *b)
 		pcibios_fixup_device_resources(dev);
 }
 
-void pcibios_add_bus(struct pci_bus *bus)
-{
-	acpi_pci_add_bus(bus);
-}
-
-void pcibios_remove_bus(struct pci_bus *bus)
-{
-	acpi_pci_remove_bus(bus);
-}
-
 /*
  * Only use DMI information to set this if nothing was passed
  * on the kernel command line (which was parsed earlier).
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index cad836f..2fbf840 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -12,6 +12,7 @@
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/cpumask.h>
+#include <linux/pci-acpi.h>
 #include <linux/pci-aspm.h>
 #include <linux/aer.h>
 #include <linux/acpi.h>
@@ -2067,10 +2068,12 @@ int __weak pcibios_root_bridge_prepare(struct pci_host_bridge *bridge)
 
 void __weak pcibios_add_bus(struct pci_bus *bus)
 {
+	acpi_pci_add_bus(bus);
 }
 
 void __weak pcibios_remove_bus(struct pci_bus *bus)
 {
+	acpi_pci_remove_bus(bus);
 }
 
 struct pci_bus *pci_create_root_bus(struct device *parent, int bus,
-- 
1.9.1


WARNING: multiple messages have this Message-ID (diff)
From: tn@semihalf.com (Tomasz Nowicki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation.
Date: Wed, 16 Dec 2015 16:16:26 +0100	[thread overview]
Message-ID: <1450278993-12664-17-git-send-email-tn@semihalf.com> (raw)
In-Reply-To: <1450278993-12664-1-git-send-email-tn@semihalf.com>

Arches in subject are the only one who use pcibios_{add|remove}_bus hooks
and implement it in the same way. Moreover ARM64 is going to do the same.
So it seams that acpi_pci_{add|remove}_bus is generic enough to be default
option for pcibios_{add|remove}_bus hooks. Also, it is always safe to run
acpi_pci_{add|remove}_bus as they have empty stubs for !ACPI case and
return if ACPI has been switched off in run time.

After all we can remove x86 and ia64 pcibios_{add|remove}_bus
implementation.

Signed-off-by: Tomasz Nowicki <tn@semihalf.com>
---
 arch/ia64/pci/pci.c   | 10 ----------
 arch/x86/pci/common.c | 10 ----------
 drivers/pci/probe.c   |  3 +++
 3 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c
index fe96bc9..c1e8ed5 100644
--- a/arch/ia64/pci/pci.c
+++ b/arch/ia64/pci/pci.c
@@ -357,16 +357,6 @@ void pcibios_fixup_bus(struct pci_bus *b)
 	platform_pci_fixup_bus(b);
 }
 
-void pcibios_add_bus(struct pci_bus *bus)
-{
-	acpi_pci_add_bus(bus);
-}
-
-void pcibios_remove_bus(struct pci_bus *bus)
-{
-	acpi_pci_remove_bus(bus);
-}
-
 void pcibios_set_master (struct pci_dev *dev)
 {
 	/* No special bus mastering setup handling */
diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index eccd4d9..ed3236d 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -171,16 +171,6 @@ void pcibios_fixup_bus(struct pci_bus *b)
 		pcibios_fixup_device_resources(dev);
 }
 
-void pcibios_add_bus(struct pci_bus *bus)
-{
-	acpi_pci_add_bus(bus);
-}
-
-void pcibios_remove_bus(struct pci_bus *bus)
-{
-	acpi_pci_remove_bus(bus);
-}
-
 /*
  * Only use DMI information to set this if nothing was passed
  * on the kernel command line (which was parsed earlier).
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index cad836f..2fbf840 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -12,6 +12,7 @@
 #include <linux/slab.h>
 #include <linux/module.h>
 #include <linux/cpumask.h>
+#include <linux/pci-acpi.h>
 #include <linux/pci-aspm.h>
 #include <linux/aer.h>
 #include <linux/acpi.h>
@@ -2067,10 +2068,12 @@ int __weak pcibios_root_bridge_prepare(struct pci_host_bridge *bridge)
 
 void __weak pcibios_add_bus(struct pci_bus *bus)
 {
+	acpi_pci_add_bus(bus);
 }
 
 void __weak pcibios_remove_bus(struct pci_bus *bus)
 {
+	acpi_pci_remove_bus(bus);
 }
 
 struct pci_bus *pci_create_root_bus(struct device *parent, int bus,
-- 
1.9.1

  parent reply	other threads:[~2015-12-16 15:18 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 15:16 [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki
2015-12-16 15:16 ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 01/23] x86, pci: Reorder logic of pci_mmconfig_insert() function Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 02/23] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 03/23] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 04/23] x86, pci: mmconfig_{32,64}.c code refactoring - remove code duplication Tomasz Nowicki
2015-12-16 15:16   ` [PATCH V2 04/23] x86, pci: mmconfig_{32, 64}.c " Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 05/23] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-17 10:25   ` Tomasz Nowicki
2015-12-17 10:25     ` Tomasz Nowicki
2015-12-17 10:40     ` Tomasz Nowicki
2015-12-17 10:40       ` Tomasz Nowicki
2015-12-21 18:12   ` Stefano Stabellini
2015-12-21 18:12     ` Stefano Stabellini
2015-12-21 18:12     ` Stefano Stabellini
2015-12-22  8:34     ` Tomasz Nowicki
2015-12-22  8:34       ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 07/23] pci, acpi, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 08/23] arm64, acpi: Use empty PCI config space accessors from mcfg.c file Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 09/23] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 10/23] x86, pci: Cleanup platform specific MCFG data using previously added ECAM hot_added flag Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 11/23] arm64, pci: Remove useless boot time IRQ assignment when booting with DT Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2016-01-12 13:50   ` Lorenzo Pieralisi
2016-01-12 13:50     ` Lorenzo Pieralisi
2016-01-12 16:13     ` Tomasz Nowicki
2016-01-12 16:13       ` Tomasz Nowicki
2016-01-12 17:56       ` David Daney
2016-01-12 17:56         ` David Daney
2016-01-12 17:56         ` David Daney
2016-01-13  9:43         ` Tomasz Nowicki
2016-01-13  9:43           ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 12/23] pci, acpi: Move ACPI host bridge device companion assignment to core code Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 13/23] x86, ia64, pci: Remove ACPI companion device from platform specific data Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 14/23] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 15/23] x86, ia64, pci: Convert arches to use PCI_DOMAINS_GENERIC Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` Tomasz Nowicki [this message]
2015-12-16 15:16   ` [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 17/23] acpi, mcfg: Implement two calls that might be used to inject/remove MCFG region Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 18/23] x86, acpi, pci: Use equivalent function introduced in previous patch Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 19/23] acpi, mcfg: Add default PCI config accessors implementation and initial support for related quirks Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 20/23] ACPI, PCI: Refine the way to handle translation_offset for ACPI resources Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-18 12:40   ` Arnd Bergmann
2015-12-18 12:40     ` Arnd Bergmann
2015-12-21 10:21     ` Tomasz Nowicki
2015-12-21 10:21       ` Tomasz Nowicki
2015-12-16 15:16 ` [PATCH V2 22/23] pci, acpi: Match PCI config space accessors against platfrom specific quirks Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-21 11:47   ` Gabriele Paoloni
2015-12-21 11:47     ` Gabriele Paoloni
2015-12-21 11:47     ` Gabriele Paoloni
2015-12-21 14:10     ` Arnd Bergmann
2015-12-21 14:10       ` Arnd Bergmann
2015-12-21 14:10       ` Arnd Bergmann
2015-12-21 14:10       ` Arnd Bergmann
2015-12-21 17:29       ` David Daney
2015-12-21 17:29         ` David Daney
2015-12-21 17:29         ` David Daney
2015-12-21 17:29         ` David Daney
2015-12-21 22:42         ` Arnd Bergmann
2015-12-21 22:42           ` Arnd Bergmann
2015-12-21 22:42           ` Arnd Bergmann
2015-12-21 22:42           ` Arnd Bergmann
2015-12-21 23:24           ` Jon Masters
2015-12-21 23:24             ` Jon Masters
2015-12-21 23:24             ` Jon Masters
2015-12-21 23:24             ` Jon Masters
2015-12-21 23:10       ` Jon Masters
2015-12-21 23:10         ` Jon Masters
2015-12-21 23:10         ` Jon Masters
2015-12-21 23:10         ` Jon Masters
2015-12-22  8:45         ` Tomasz Nowicki
2015-12-22  8:45           ` Tomasz Nowicki
2015-12-22  8:45           ` Tomasz Nowicki
2015-12-22  8:45           ` Tomasz Nowicki
2015-12-22  9:29         ` Gabriele Paoloni
2015-12-22  9:29           ` Gabriele Paoloni
2015-12-22  9:29           ` Gabriele Paoloni
2015-12-22  9:29           ` Gabriele Paoloni
2015-12-22 16:36           ` Jon Masters
2015-12-22 16:36             ` Jon Masters
2015-12-22 16:36             ` Jon Masters
2015-12-22 16:36             ` Jon Masters
2015-12-22 16:45             ` Jon Masters
2015-12-22 16:45               ` Jon Masters
2015-12-22 16:45               ` Jon Masters
2015-12-22 16:45               ` Jon Masters
2015-12-22 17:49               ` Gabriele Paoloni
2015-12-22 17:49                 ` Gabriele Paoloni
2015-12-22 17:49                 ` Gabriele Paoloni
2015-12-22 17:49                 ` Gabriele Paoloni
2015-12-22 10:20     ` Tomasz Nowicki
2015-12-22 10:20       ` Tomasz Nowicki
2015-12-22 10:20       ` Tomasz Nowicki
2015-12-22 14:48       ` Gabriele Paoloni
2015-12-22 14:48         ` Gabriele Paoloni
2015-12-22 14:48         ` Gabriele Paoloni
2015-12-23  9:38         ` Hanjun Guo
2015-12-23  9:38           ` Hanjun Guo
2015-12-23  9:38           ` Hanjun Guo
2016-01-08 14:16   ` Mark Salter
2016-01-08 14:16     ` Mark Salter
2016-01-08 14:36     ` Tomasz Nowicki
2016-01-08 14:36       ` Tomasz Nowicki
2016-01-08 14:51       ` Mark Salter
2016-01-08 14:51         ` Mark Salter
2016-01-08 14:42     ` Jeremy Linton
2016-01-08 14:42       ` Jeremy Linton
2016-01-08 14:42       ` Jeremy Linton
2016-01-08 15:01     ` Mark Rutland
2016-01-08 15:01       ` Mark Rutland
2016-01-08 15:01       ` Mark Rutland
2016-01-08 15:12       ` Mark Rutland
2016-01-08 15:12         ` Mark Rutland
2016-01-08 16:07         ` Mark Salter
2016-01-08 16:07           ` Mark Salter
2015-12-16 15:16 ` [PATCH V2 23/23] arm64, pci, acpi: Start using ACPI based PCI host bridge driver for ARM64 Tomasz Nowicki
2015-12-16 15:16   ` Tomasz Nowicki
2015-12-17 21:24 ` [PATCH V2 00/23] MMCONFIG refactoring and support for ARM64 PCI hostbridge init based on ACPI Sinan Kaya
2015-12-17 21:24   ` Sinan Kaya
2015-12-18 12:26   ` Tomasz Nowicki
2015-12-18 12:26     ` Tomasz Nowicki
2015-12-18 18:56     ` okaya
2015-12-18 18:56       ` okaya at codeaurora.org
2015-12-21 10:37       ` Tomasz Nowicki
2015-12-21 10:37         ` Tomasz Nowicki
2015-12-21 12:10       ` Lorenzo Pieralisi
2015-12-21 12:10         ` Lorenzo Pieralisi
2015-12-21 12:42         ` Tomasz Nowicki
2015-12-21 12:42           ` Tomasz Nowicki
2015-12-21 14:15           ` Arnd Bergmann
2015-12-21 14:15             ` Arnd Bergmann
2015-12-21 15:26             ` Okaya
2015-12-21 15:26               ` Okaya at codeaurora.org
2015-12-21 22:39               ` Arnd Bergmann
2015-12-21 22:39                 ` Arnd Bergmann
2016-01-11 15:39               ` Lorenzo Pieralisi
2016-01-11 15:39                 ` Lorenzo Pieralisi
2016-01-11 15:56                 ` Sinan Kaya
2016-01-11 15:56                   ` Sinan Kaya
2016-01-12 14:30                   ` Arnd Bergmann
2016-01-12 14:30                     ` Arnd Bergmann
2016-01-12 18:38                     ` Lorenzo Pieralisi
2016-01-12 18:38                       ` Lorenzo Pieralisi
2016-01-12 21:37                       ` Arnd Bergmann
2016-01-12 21:37                         ` Arnd Bergmann
2016-01-11 16:09             ` Lorenzo Pieralisi
2016-01-11 16:09               ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450278993-12664-17-git-send-email-tn@semihalf.com \
    --to=tn@semihalf.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=Suravee.Suthikulpanit@amd.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=hanjun.guo@linaro.org \
    --cc=jchandra@broadcom.com \
    --cc=jcm@redhat.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=mw@semihalf.com \
    --cc=okaya@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=robert.richter@caviumnetworks.com \
    --cc=tglx@linutronix.de \
    --cc=wangyijing@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.