All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "usb: gadget: pxa27x: fix suspend callback" has been added to the 4.3-stable tree
@ 2015-12-17 23:01 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-12-17 23:01 UTC (permalink / raw)
  To: balbi, gregkh, robert.jarzmik; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    usb: gadget: pxa27x: fix suspend callback

to the 4.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-gadget-pxa27x-fix-suspend-callback.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 391e6dcb37857d5659b53def2f41e2f56850d33c Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@ti.com>
Date: Wed, 18 Nov 2015 17:06:00 -0600
Subject: usb: gadget: pxa27x: fix suspend callback

From: Felipe Balbi <balbi@ti.com>

commit 391e6dcb37857d5659b53def2f41e2f56850d33c upstream.

pxa27x disconnects pullups on suspend but doesn't
notify the gadget driver about it, so gadget driver
can't disable the endpoints it was using.

This causes problems on resume because gadget core
will think endpoints are still enabled and just
ignore the following usb_ep_enable().

Fix this problem by calling
gadget_driver->disconnect().

Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/gadget/udc/pxa27x_udc.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -2536,6 +2536,9 @@ static int pxa_udc_suspend(struct platfo
 	udc->pullup_resume = udc->pullup_on;
 	dplus_pullup(udc, 0);
 
+	if (udc->driver)
+		udc->driver->disconnect(&udc->gadget);
+
 	return 0;
 }
 


Patches currently in stable-queue which might be from balbi@ti.com are

queue-4.3/usb-musb-usb_ti_cppi41_dma-requires-dmaengine-support.patch
queue-4.3/usb-gadget-pxa27x-fix-suspend-callback.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-12-17 23:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-17 23:01 Patch "usb: gadget: pxa27x: fix suspend callback" has been added to the 4.3-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.