Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"James E.J. Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Peter Hurley <peter@hurleysoftware.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Qipeng Zha <qipeng.zha@intel.com>,
	Desmond Liu <desmondl@broadcom.com>,
	Wang Long <long.wanglong@huawei.com>,
	Matt Redfearn <matt.redfearn@imgtec.com>,
	Paul Burton <paul.burton@imgtec.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Peter Hung <hpeter@gmail.com>,
	Soeren Grunewald <soeren.grunewald@desy.de>,
	Adam Lee <adam.lee@canonical.com>,
	"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	Mans Rullgard <mans@mansr.com>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-kernel@i4.cs.fau.de,
	Phillip Raffeck <phillip.raffeck@fau.de>
Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_*
Date: Fri, 18 Dec 2015 14:32:06 +0200	[thread overview]
Message-ID: <1450441926.30729.208.camel@linux.intel.com> (raw)
In-Reply-To: <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de>

On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote:

>  This comes with a slight change in behaviour as
> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas
> printk(KERN_DEBUG ...) is not.

--- a/drivers/tty/serial/8250/8250_pnp.c
> +++ b/drivers/tty/serial/8250/8250_pnp.c
> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const
> struct pnp_device_id *dev_id)
> =C2=A0		return -ENODEV;
> =C2=A0
> =C2=A0#ifdef SERIAL_DEBUG_PNP
> -	printk(KERN_DEBUG

I think it's not okay.

The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a
compilation with support of those messages independently on
DYNAMIC_DEBUG.

If you want to switch to DYNAMIC_DEBUG you have to carefully check what
is done under=C2=A0SERIAL_DEBUG_PNP.

git grep on current linux-next shows that SERIAL_DEBUG_PNP is an
orphan.

So, I would suggest to remove #ifdef.

> -		"Setup PNP port: port %x, mem 0x%lx, irq %d, type
> %d\n",
> -		=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uart.port.iobase, uart.p=
ort.mapbase,
> uart.port.irq, uart.port.iotype);
> +	pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type
> %d\n",
> +		=C2=A0uart.port.iobase, uart.port.mapbase,
> +		=C2=A0uart.port.irq, uart.port.iotype);
> =C2=A0#endif
>=20

--=20
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc"=
 in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html