All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery()
@ 2015-12-21  7:28 Andrew Donnellan
  2016-01-11  9:14 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Donnellan @ 2015-12-21  7:28 UTC (permalink / raw)
  To: linuxppc-dev

Fix off-by-one error in opal_mce_check_early_recovery() when checking
whether the NIP falls within OPAL space.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

---

Only very slightly more correct, but I'm fairly sure it's more correct...
---
 arch/powerpc/platforms/powernv/opal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 57cffb8..488b989 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -555,7 +555,7 @@ bool opal_mce_check_early_recovery(struct pt_regs *regs)
 		goto out;
 
 	if ((regs->nip >= opal.base) &&
-			(regs->nip <= (opal.base + opal.size)))
+			(regs->nip < (opal.base + opal.size)))
 		recover_addr = find_recovery_address(regs->nip);
 
 	/*
-- 
Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery()
  2015-12-21  7:28 [PATCH] powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery() Andrew Donnellan
@ 2016-01-11  9:14 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2016-01-11  9:14 UTC (permalink / raw)
  To: Andrew Donnellan, linuxppc-dev

On Mon, 2015-21-12 at 07:28:37 UTC, Andrew Donnellan wrote:
> Fix off-by-one error in opal_mce_check_early_recovery() when checking
> whether the NIP falls within OPAL space.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/dc3799bb9ab2666fa19081121f

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-11  9:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-21  7:28 [PATCH] powerpc/opal: fix minor off-by-one error in opal_mce_check_early_recovery() Andrew Donnellan
2016-01-11  9:14 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.