All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: tegra: Add chosen node for tegra132 norrin
@ 2015-12-21 13:22 ` Jon Hunter
  0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2015-12-21 13:22 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Stephen Warren, Thierry Reding, Alexandre Courbot, Jon Hunter,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-tegra-u79uwXL29TY76Z2rM5mHXA

The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
in the device-tree blob and it is not then it fails to boot the kernel.
Add the chosen node so we can boot the kernel on tegra132 norrin with
the nvtboot bootloader.

Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index 7dfe1c085966..62f33fc84e3e 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -12,6 +12,8 @@
 		rtc1 = "/rtc@0,7000e000";
 	};
 
+	chosen { };
+
 	memory {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x0 0x80000000>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM64: tegra: Add chosen node for tegra132 norrin
@ 2015-12-21 13:22 ` Jon Hunter
  0 siblings, 0 replies; 4+ messages in thread
From: Jon Hunter @ 2015-12-21 13:22 UTC (permalink / raw)
  To: linux-arm-kernel

The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
in the device-tree blob and it is not then it fails to boot the kernel.
Add the chosen node so we can boot the kernel on tegra132 norrin with
the nvtboot bootloader.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index 7dfe1c085966..62f33fc84e3e 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -12,6 +12,8 @@
 		rtc1 = "/rtc at 0,7000e000";
 	};
 
+	chosen { };
+
 	memory {
 		device_type = "memory";
 		reg = <0x0 0x80000000 0x0 0x80000000>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM64: tegra: Add chosen node for tegra132 norrin
  2015-12-21 13:22 ` Jon Hunter
@ 2016-01-25 13:57     ` Thierry Reding
  -1 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-01-25 13:57 UTC (permalink / raw)
  To: Jon Hunter
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Stephen Warren, Alexandre Courbot,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On Mon, Dec 21, 2015 at 01:22:51PM +0000, Jon Hunter wrote:
> The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
> in the device-tree blob and it is not then it fails to boot the kernel.

"if it is not"

> Add the chosen node so we can boot the kernel on tegra132 norrin with

"Tegra132 Norrin"

> the nvtboot bootloader.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
>  1 file changed, 2 insertions(+)

Otherwise looks good to me. Given that this is a fix for v4.5 material,
you might want to send it directly to arm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (and perhaps
mention that you'd like to have this applied to v4.5). With the above
two fixups:

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM64: tegra: Add chosen node for tegra132 norrin
@ 2016-01-25 13:57     ` Thierry Reding
  0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-01-25 13:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Dec 21, 2015 at 01:22:51PM +0000, Jon Hunter wrote:
> The NVIDIA bootloader, nvtboot, expects the "chosen" node to be present
> in the device-tree blob and it is not then it fails to boot the kernel.

"if it is not"

> Add the chosen node so we can boot the kernel on tegra132 norrin with

"Tegra132 Norrin"

> the nvtboot bootloader.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 2 ++
>  1 file changed, 2 insertions(+)

Otherwise looks good to me. Given that this is a fix for v4.5 material,
you might want to send it directly to arm at vger.kernel.org (and perhaps
mention that you'd like to have this applied to v4.5). With the above
two fixups:

Acked-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160125/1a6529b0/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-25 13:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-21 13:22 [PATCH] ARM64: tegra: Add chosen node for tegra132 norrin Jon Hunter
2015-12-21 13:22 ` Jon Hunter
     [not found] ` <1450704171-8345-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-25 13:57   ` Thierry Reding
2016-01-25 13:57     ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.