* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
@ 2015-12-22 8:25 Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 1/3] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed Frank Wang
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Frank Wang @ 2015-12-22 8:25 UTC (permalink / raw)
To: u-boot
[PATCH 1/3] Modified the check condition for max packet size of ep_in in high speed
[PATCH 2/3] Fixed the error that the last packet transmission could not be terminated
[PATCH 3/3] Add usb phy control to support fastboot for rk3036
Tested on RK3036 SDK board, it works Okay.
board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
drivers/usb/gadget/Makefile | 1 +
drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
drivers/usb/gadget/rk_otg_phy.c | 48 ++++++++++++++++++++++++++++
include/configs/rk3036_common.h | 20 ++++++++++++
7 files changed, 107 insertions(+), 3 deletions(-)
create mode 100644 drivers/usb/gadget/rk_otg_phy.c
--
1.7.9.5
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 1/3] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
@ 2015-12-22 8:25 ` Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 2/3] usb: gadget: dwc2_udc_otg: fixed the error that the last packet transmission could not be terminated Frank Wang
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Frank Wang @ 2015-12-22 8:25 UTC (permalink / raw)
To: u-boot
In current high speed fastboot, fs_ep_in.wMaxPacketSize is configurated 64 bytes
as default, as a result, it is failed to match the size at initialization tage in
usb controller.
Actually, hardware can support less than or equal to 512 bytes in high speed mode,
so I changed the condition from '!=' to '>' to fix this issue.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/usb/gadget/dwc2_udc_otg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/dwc2_udc_otg.c b/drivers/usb/gadget/dwc2_udc_otg.c
index ffe2952..cb20b00 100644
--- a/drivers/usb/gadget/dwc2_udc_otg.c
+++ b/drivers/usb/gadget/dwc2_udc_otg.c
@@ -557,8 +557,8 @@ static int dwc2_ep_enable(struct usb_ep *_ep,
}
/* hardware _could_ do smaller, but driver doesn't */
- if ((desc->bmAttributes == USB_ENDPOINT_XFER_BULK
- && le16_to_cpu(get_unaligned(&desc->wMaxPacketSize)) !=
+ if ((desc->bmAttributes == USB_ENDPOINT_XFER_BULK &&
+ le16_to_cpu(get_unaligned(&desc->wMaxPacketSize)) >
ep_maxpacket(ep)) || !get_unaligned(&desc->wMaxPacketSize)) {
debug("%s: bad %s maxpacket\n", __func__, _ep->name);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 2/3] usb: gadget: dwc2_udc_otg: fixed the error that the last packet transmission could not be terminated
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 1/3] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed Frank Wang
@ 2015-12-22 8:25 ` Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 3/3] usb: gadget: add usb phy control to support fastboot for rk3036 Frank Wang
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Frank Wang @ 2015-12-22 8:25 UTC (permalink / raw)
To: u-boot
When the actual length is less than request length in the last request,
the data transmission should be terminated, because the packet
transmission have alreay finished.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
index bce9c30..ce4d44d 100644
--- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
+++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
@@ -237,7 +237,7 @@ static void complete_rx(struct dwc2_udc *dev, u8 ep_num)
__func__, ep_num, req->req.actual, req->req.length,
is_short, ep_tsr, xfer_size);
- if (is_short || req->req.actual == req->req.length) {
+ if (is_short || req->req.actual <= req->req.length) {
if (ep_num == EP0_CON && dev->ep0state == DATA_STATE_RECV) {
debug_cond(DEBUG_OUT_EP != 0, " => Send ZLP\n");
dwc2_udc_ep0_zlp(dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 3/3] usb: gadget: add usb phy control to support fastboot for rk3036
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 1/3] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 2/3] usb: gadget: dwc2_udc_otg: fixed the error that the last packet transmission could not be terminated Frank Wang
@ 2015-12-22 8:25 ` Frank Wang
2015-12-23 0:10 ` [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Marek Vasut
2015-12-30 9:14 ` Lukasz Majewski
4 siblings, 0 replies; 11+ messages in thread
From: Frank Wang @ 2015-12-22 8:25 UTC (permalink / raw)
To: u-boot
Used dwc2 usb otg device driver frame and added USB PHY handle function.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++++
drivers/usb/gadget/Makefile | 1 +
drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 ++++
drivers/usb/gadget/rk_otg_phy.c | 48 ++++++++++++++++++++++++++++++
include/configs/rk3036_common.h | 20 +++++++++++++
5 files changed, 104 insertions(+)
create mode 100644 drivers/usb/gadget/rk_otg_phy.c
diff --git a/board/evb_rk3036/evb_rk3036/evb_rk3036.c b/board/evb_rk3036/evb_rk3036/evb_rk3036.c
index f5758b1..ec3f973 100644
--- a/board/evb_rk3036/evb_rk3036/evb_rk3036.c
+++ b/board/evb_rk3036/evb_rk3036/evb_rk3036.c
@@ -10,6 +10,11 @@
#include <asm/arch/uart.h>
#include <asm/arch/sdram_rk3036.h>
+#ifdef CONFIG_USB_GADGET
+#include <usb.h>
+#include <usb/dwc2_udc.h>
+#endif
+
DECLARE_GLOBAL_DATA_PTR;
void get_ddr_config(struct rk3036_ddr_config *config)
@@ -47,3 +52,28 @@ void enable_caches(void)
dcache_enable();
}
#endif
+
+#ifdef CONFIG_USB_GADGET
+#define RKIO_GRF_PHYS 0x20008000
+#define RKIO_USBOTG_BASE 0x10180000
+#define RK_USB_PHY_CONTROL 0x10180e00
+
+static struct dwc2_plat_otg_data rk_otg_data = {
+ .regs_phy = RKIO_GRF_PHYS,
+ .regs_otg = RKIO_USBOTG_BASE,
+ .usb_phy_ctrl = RK_USB_PHY_CONTROL,
+ .usb_gusbcfg = 0x00001408
+};
+
+int board_usb_init(int index, enum usb_init_type init)
+{
+ debug("%s: performing dwc2_udc_probe\n", __func__);
+ return dwc2_udc_probe(&rk_otg_data);
+}
+
+int board_usb_cleanup(int index, enum usb_init_type init)
+{
+ debug("%s\n", __func__);
+ return 0;
+}
+#endif
diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
index c915c79..54eb89b 100644
--- a/drivers/usb/gadget/Makefile
+++ b/drivers/usb/gadget/Makefile
@@ -22,6 +22,7 @@ obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
+obj-$(CONFIG_USB_GADGET_RK_OTG_PHY) += rk_otg_phy.o
endif
ifdef CONFIG_USB_ETHER
obj-y += ether.o
diff --git a/drivers/usb/gadget/dwc2_udc_otg_regs.h b/drivers/usb/gadget/dwc2_udc_otg_regs.h
index 78ec90e..34a29be 100644
--- a/drivers/usb/gadget/dwc2_udc_otg_regs.h
+++ b/drivers/usb/gadget/dwc2_udc_otg_regs.h
@@ -130,8 +130,13 @@ struct dwc2_usbotg_reg {
#define HIGH_SPEED_CONTROL_PKT_SIZE 64
#define HIGH_SPEED_BULK_PKT_SIZE 512
+#ifndef CONFIG_ARCH_ROCKCHIP
#define RX_FIFO_SIZE (1024*4)
#define NPTX_FIFO_SIZE (1024*4)
+#else
+#define RX_FIFO_SIZE ((512+16)*4)
+#define NPTX_FIFO_SIZE (64)
+#endif
#define PTX_FIFO_SIZE (1536*1)
#define DEPCTL_TXFNUM_0 (0x0<<22)
diff --git a/drivers/usb/gadget/rk_otg_phy.c b/drivers/usb/gadget/rk_otg_phy.c
new file mode 100644
index 0000000..af45555
--- /dev/null
+++ b/drivers/usb/gadget/rk_otg_phy.c
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2015 Rockchip Electronics Co., Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <config.h>
+#include <common.h>
+#include <asm/io.h>
+
+#include "dwc2_udc_otg_regs.h"
+#include "dwc2_udc_otg_priv.h"
+
+/* UOC control */
+#define GRF_UOC0_CON5 0x017c
+
+void otg_phy_init(struct dwc2_udc *dev)
+{
+ struct dwc2_usbotg_reg *reg =
+ (struct dwc2_usbotg_reg *)dev->pdata->regs_otg;
+
+ /* Disable usb-uart bypass */
+ writel(0x34000000, (dev->pdata->regs_phy + GRF_UOC0_CON5));
+
+ /* soft disconnect */
+ writel(readl(®->dctl) | ~0x02, ®->dctl);
+
+ /* Phy PLL recovering */
+ writel(0x00030001, (dev->pdata->regs_phy + GRF_UOC0_CON5));
+ udelay(15);
+ writel(0x00030002, (dev->pdata->regs_phy + GRF_UOC0_CON5));
+ udelay(1500);
+
+ /* Restart the Phy Clock */
+ writel(0x00, (u32 *)dev->pdata->usb_phy_ctrl);
+
+ /* soft connect */
+ writel(readl(®->dctl) & ~0x02, ®->dctl);
+}
+
+void otg_phy_off(struct dwc2_udc *dev)
+{
+ /* usbphy0 bypass disable and otg enable */
+ writel(0x34000000, (dev->pdata->regs_phy + GRF_UOC0_CON5));
+
+ /* usb phy enter suspend */
+ writel(0x007f0055, (dev->pdata->regs_phy + GRF_UOC0_CON5));
+}
diff --git a/include/configs/rk3036_common.h b/include/configs/rk3036_common.h
index f753e68..d804b60 100644
--- a/include/configs/rk3036_common.h
+++ b/include/configs/rk3036_common.h
@@ -71,6 +71,26 @@
#define CONFIG_CMD_I2C
+/* FASTBOOT */
+#define CONFIG_CMD_FASTBOOT
+#define CONFIG_USB_GADGET
+#define CONFIG_USB_GADGET_DOWNLOAD
+#define CONFIG_USB_GADGET_DUALSPEED
+#define CONFIG_USB_GADGET_DWC2_OTG
+#define CONFIG_USB_GADGET_RK_OTG_PHY
+#define CONFIG_USB_FUNCTION_FASTBOOT
+#define CONFIG_USB_FUNCTION_MASS_STORAGE
+#define CONFIG_FASTBOOT_FLASH
+#define CONFIG_FASTBOOT_FLASH_MMC_DEV 0
+#define CONFIG_FASTBOOT_BUF_ADDR (CONFIG_SYS_SDRAM_BASE \
+ + SDRAM_BANK_SIZE)
+#define CONFIG_FASTBOOT_BUF_SIZE 0x07000000
+#define CONFIG_USB_GADGET_VBUS_DRAW 0
+#define CONFIG_SYS_CACHELINE_SIZE 64
+#define CONFIG_G_DNL_MANUFACTURER "Rockchip"
+#define CONFIG_G_DNL_VENDOR_NUM 0x2207
+#define CONFIG_G_DNL_PRODUCT_NUM 0x0006
+
#ifndef CONFIG_SPL_BUILD
#include <config_distro_defaults.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
` (2 preceding siblings ...)
2015-12-22 8:25 ` [U-Boot] [PATCH 3/3] usb: gadget: add usb phy control to support fastboot for rk3036 Frank Wang
@ 2015-12-23 0:10 ` Marek Vasut
2015-12-28 7:09 ` Frank Wang
2015-12-30 9:14 ` Lukasz Majewski
4 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2015-12-23 0:10 UTC (permalink / raw)
To: u-boot
On Tuesday, December 22, 2015 at 09:25:49 AM, Frank Wang wrote:
> [PATCH 1/3] Modified the check condition for max packet size of ep_in in
> high speed
>
> [PATCH 2/3] Fixed the error that the last packet transmission could not be
> terminated
>
> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>
> Tested on RK3036 SDK board, it works Okay.
>
> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
> drivers/usb/gadget/rk_otg_phy.c | 48
> ++++++++++++++++++++++++++++ include/configs/rk3036_common.h |
> 20 ++++++++++++
> 7 files changed, 107 insertions(+), 3 deletions(-)
> create mode 100644 drivers/usb/gadget/rk_otg_phy.c
Series looks sensible to me, but I'd like to have Lukasz take a look at it
and review it thoroughly too.
Thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2015-12-23 0:10 ` [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Marek Vasut
@ 2015-12-28 7:09 ` Frank Wang
0 siblings, 0 replies; 11+ messages in thread
From: Frank Wang @ 2015-12-28 7:09 UTC (permalink / raw)
To: u-boot
Hi Lukasz,
Friendly Ping!
Could you help to review this series of patches in your free time?
BR.
Frank
On 12/23/2015 08:10 AM, Marek Vasut wrote:
> On Tuesday, December 22, 2015 at 09:25:49 AM, Frank Wang wrote:
>> [PATCH 1/3] Modified the check condition for max packet size of ep_in in
>> high speed
>>
>> [PATCH 2/3] Fixed the error that the last packet transmission could not be
>> terminated
>>
>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>>
>> Tested on RK3036 SDK board, it works Okay.
>>
>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
>> drivers/usb/gadget/Makefile | 1 +
>> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
>> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
>> drivers/usb/gadget/rk_otg_phy.c | 48
>> ++++++++++++++++++++++++++++ include/configs/rk3036_common.h |
>> 20 ++++++++++++
>> 7 files changed, 107 insertions(+), 3 deletions(-)
>> create mode 100644 drivers/usb/gadget/rk_otg_phy.c
> Series looks sensible to me, but I'd like to have Lukasz take a look at it
> and review it thoroughly too.
>
> Thanks!
>
> Best regards,
> Marek Vasut
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
` (3 preceding siblings ...)
2015-12-23 0:10 ` [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Marek Vasut
@ 2015-12-30 9:14 ` Lukasz Majewski
2016-01-18 6:24 ` Eddie Cai
4 siblings, 1 reply; 11+ messages in thread
From: Lukasz Majewski @ 2015-12-30 9:14 UTC (permalink / raw)
To: u-boot
Hi Frank
> [PATCH 1/3] Modified the check condition for max packet size of
> ep_in in high speed
>
> [PATCH 2/3] Fixed the error that the last packet transmission could
> not be terminated
>
> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>
> Tested on RK3036 SDK board, it works Okay.
I'm out of office till the beginning of Jan 2016.
I will review and read your logs (with the max packet problem) when I
come back.
>
> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
> drivers/usb/gadget/rk_otg_phy.c | 48
> ++++++++++++++++++++++++++++
> include/configs/rk3036_common.h | 20 ++++++++++++ 7
> files changed, 107 insertions(+), 3 deletions(-) create mode 100644
> drivers/usb/gadget/rk_otg_phy.c
>
Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151230/4680e0a3/attachment.sig>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2015-12-30 9:14 ` Lukasz Majewski
@ 2016-01-18 6:24 ` Eddie Cai
2016-06-07 1:28 ` Eddie Cai
0 siblings, 1 reply; 11+ messages in thread
From: Eddie Cai @ 2016-01-18 6:24 UTC (permalink / raw)
To: u-boot
Hi Lukasz
Have you back to office? Much appreciate if you can review Frank's patch.
Thanks
Eddie
2015-12-30 17:14 GMT+08:00 Lukasz Majewski <l.majewski@majess.pl>:
> Hi Frank
>
>> [PATCH 1/3] Modified the check condition for max packet size of
>> ep_in in high speed
>>
>> [PATCH 2/3] Fixed the error that the last packet transmission could
>> not be terminated
>>
>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>>
>> Tested on RK3036 SDK board, it works Okay.
>
> I'm out of office till the beginning of Jan 2016.
>
> I will review and read your logs (with the max packet problem) when I
> come back.
>
>>
>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
>> drivers/usb/gadget/Makefile | 1 +
>> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
>> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
>> drivers/usb/gadget/rk_otg_phy.c | 48
>> ++++++++++++++++++++++++++++
>> include/configs/rk3036_common.h | 20 ++++++++++++ 7
>> files changed, 107 insertions(+), 3 deletions(-) create mode 100644
>> drivers/usb/gadget/rk_otg_phy.c
>>
>
> Best regards,
> Lukasz Majewski
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2016-01-18 6:24 ` Eddie Cai
@ 2016-06-07 1:28 ` Eddie Cai
2016-06-07 2:48 ` Marek Vasut
0 siblings, 1 reply; 11+ messages in thread
From: Eddie Cai @ 2016-06-07 1:28 UTC (permalink / raw)
To: u-boot
Hi Lukasz
I guess you missed this mail thread. So send it again. Can you help to
review this patch set?
2016-01-18 14:24 GMT+08:00 Eddie Cai <eddie.cai.kernel@gmail.com>:
> Hi Lukasz
>
> Have you back to office? Much appreciate if you can review Frank's patch.
>
> Thanks
> Eddie
>
> 2015-12-30 17:14 GMT+08:00 Lukasz Majewski <l.majewski@majess.pl>:
>> Hi Frank
>>
>>> [PATCH 1/3] Modified the check condition for max packet size of
>>> ep_in in high speed
>>>
>>> [PATCH 2/3] Fixed the error that the last packet transmission could
>>> not be terminated
>>>
>>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>>>
>>> Tested on RK3036 SDK board, it works Okay.
>>
>> I'm out of office till the beginning of Jan 2016.
>>
>> I will review and read your logs (with the max packet problem) when I
>> come back.
>>
>>>
>>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
>>> drivers/usb/gadget/Makefile | 1 +
>>> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
>>> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
>>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
>>> drivers/usb/gadget/rk_otg_phy.c | 48
>>> ++++++++++++++++++++++++++++
>>> include/configs/rk3036_common.h | 20 ++++++++++++ 7
>>> files changed, 107 insertions(+), 3 deletions(-) create mode 100644
>>> drivers/usb/gadget/rk_otg_phy.c
>>>
>>
>> Best regards,
>> Lukasz Majewski
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2016-06-07 1:28 ` Eddie Cai
@ 2016-06-07 2:48 ` Marek Vasut
2016-06-08 6:47 ` Lukasz Majewski
0 siblings, 1 reply; 11+ messages in thread
From: Marek Vasut @ 2016-06-07 2:48 UTC (permalink / raw)
To: u-boot
On 06/07/2016 03:28 AM, Eddie Cai wrote:
> Hi Lukasz
>
> I guess you missed this mail thread. So send it again. Can you help to
> review this patch set?
Hi,
please rebase the series and repost. Keep me on CC
> 2016-01-18 14:24 GMT+08:00 Eddie Cai <eddie.cai.kernel@gmail.com>:
>> Hi Lukasz
>>
>> Have you back to office? Much appreciate if you can review Frank's patch.
>>
>> Thanks
>> Eddie
>>
>> 2015-12-30 17:14 GMT+08:00 Lukasz Majewski <l.majewski@majess.pl>:
>>> Hi Frank
>>>
>>>> [PATCH 1/3] Modified the check condition for max packet size of
>>>> ep_in in high speed
>>>>
>>>> [PATCH 2/3] Fixed the error that the last packet transmission could
>>>> not be terminated
>>>>
>>>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
>>>>
>>>> Tested on RK3036 SDK board, it works Okay.
>>>
>>> I'm out of office till the beginning of Jan 2016.
>>>
>>> I will review and read your logs (with the max packet problem) when I
>>> come back.
>>>
>>>>
>>>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 +++++++++++++++++
>>>> drivers/usb/gadget/Makefile | 1 +
>>>> drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
>>>> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
>>>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
>>>> drivers/usb/gadget/rk_otg_phy.c | 48
>>>> ++++++++++++++++++++++++++++
>>>> include/configs/rk3036_common.h | 20 ++++++++++++ 7
>>>> files changed, 107 insertions(+), 3 deletions(-) create mode 100644
>>>> drivers/usb/gadget/rk_otg_phy.c
>>>>
>>>
>>> Best regards,
>>> Lukasz Majewski
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 11+ messages in thread
* [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
2016-06-07 2:48 ` Marek Vasut
@ 2016-06-08 6:47 ` Lukasz Majewski
0 siblings, 0 replies; 11+ messages in thread
From: Lukasz Majewski @ 2016-06-08 6:47 UTC (permalink / raw)
To: u-boot
Hi Marek, Eddie,
> On 06/07/2016 03:28 AM, Eddie Cai wrote:
> > Hi Lukasz
> >
> > I guess you missed this mail thread. So send it again. Can you help
> > to review this patch set?
>
> Hi,
>
> please rebase the series and repost. Keep me on CC
I'm currently out of office. I will review those patches ASAP when I
will come back.
>
> > 2016-01-18 14:24 GMT+08:00 Eddie Cai <eddie.cai.kernel@gmail.com>:
> >> Hi Lukasz
> >>
> >> Have you back to office? Much appreciate if you can review Frank's
> >> patch.
> >>
> >> Thanks
> >> Eddie
> >>
> >> 2015-12-30 17:14 GMT+08:00 Lukasz Majewski <l.majewski@majess.pl>:
> >>> Hi Frank
> >>>
> >>>> [PATCH 1/3] Modified the check condition for max packet size of
> >>>> ep_in in high speed
> >>>>
> >>>> [PATCH 2/3] Fixed the error that the last packet transmission
> >>>> could not be terminated
> >>>>
> >>>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036
> >>>>
> >>>> Tested on RK3036 SDK board, it works Okay.
> >>>
> >>> I'm out of office till the beginning of Jan 2016.
> >>>
> >>> I will review and read your logs (with the max packet problem)
> >>> when I come back.
> >>>
> >>>>
> >>>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30
> >>>> +++++++++++++++++ drivers/usb/gadget/Makefile
> >>>> | 1 + drivers/usb/gadget/dwc2_udc_otg.c | 4 +--
> >>>> drivers/usb/gadget/dwc2_udc_otg_regs.h | 5 +++
> >>>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 2 +-
> >>>> drivers/usb/gadget/rk_otg_phy.c | 48
> >>>> ++++++++++++++++++++++++++++
> >>>> include/configs/rk3036_common.h | 20 ++++++++++++ 7
> >>>> files changed, 107 insertions(+), 3 deletions(-) create mode
> >>>> 100644 drivers/usb/gadget/rk_otg_phy.c
> >>>>
> >>>
> >>> Best regards,
> >>> Lukasz Majewski
> >>>
> >>> _______________________________________________
> >>> U-Boot mailing list
> >>> U-Boot at lists.denx.de
> >>> http://lists.denx.de/mailman/listinfo/u-boot
> >>>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160608/558bbaf8/attachment.sig>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2016-06-08 6:47 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-22 8:25 [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 1/3] usb: gadget: dwc2_udc_otg: modified the check condition for max packet size of ep_in in high speed Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 2/3] usb: gadget: dwc2_udc_otg: fixed the error that the last packet transmission could not be terminated Frank Wang
2015-12-22 8:25 ` [U-Boot] [PATCH 3/3] usb: gadget: add usb phy control to support fastboot for rk3036 Frank Wang
2015-12-23 0:10 ` [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB Marek Vasut
2015-12-28 7:09 ` Frank Wang
2015-12-30 9:14 ` Lukasz Majewski
2016-01-18 6:24 ` Eddie Cai
2016-06-07 1:28 ` Eddie Cai
2016-06-07 2:48 ` Marek Vasut
2016-06-08 6:47 ` Lukasz Majewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.