* [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change
@ 2015-12-23 5:22 Nabendu Maiti
2015-12-23 7:20 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-05 14:43 ` [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Daniel Vetter
0 siblings, 2 replies; 3+ messages in thread
From: Nabendu Maiti @ 2015-12-23 5:22 UTC (permalink / raw)
To: intel-gfx
Recalculate watermark when there is a change in pixel format.
Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2d0b006..4bd5080 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11819,6 +11819,7 @@ static bool intel_wm_need_update(struct drm_plane *plane,
return false;
if (cur->base.fb->modifier[0] != new->base.fb->modifier[0] ||
+ cur->base.fb->pixel_format != new->base.fb->pixel_format ||
cur->base.rotation != new->base.rotation ||
drm_rect_width(&new->src) != drm_rect_width(&cur->src) ||
drm_rect_height(&new->src) != drm_rect_height(&cur->src) ||
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ warning: Fi.CI.BAT
2015-12-23 5:22 [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Nabendu Maiti
@ 2015-12-23 7:20 ` Patchwork
2016-01-05 14:43 ` [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2015-12-23 7:20 UTC (permalink / raw)
To: Nabendu Maiti; +Cc: intel-gfx
== Summary ==
Built on 7e671e69deffb88d60687dacffe6e34a5d046500 drm-intel-nightly: 2015y-12m-22d-13h-28m-34s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
dmesg-warn -> PASS (skl-i7k-2)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
dmesg-warn -> PASS (ilk-hp8440p)
Subgroup basic-flip-vs-modeset:
dmesg-warn -> PASS (bsw-nuc-2)
dmesg-warn -> PASS (ilk-hp8440p)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-a:
pass -> DMESG-WARN (snb-x220t)
pass -> DMESG-WARN (skl-i7k-2)
Subgroup read-crc-pipe-a-frame-sequence:
dmesg-warn -> PASS (byt-nuc)
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (snb-dellxps)
Test kms_setmode:
Subgroup basic-clone-single-crtc:
pass -> DMESG-WARN (snb-dellxps)
bdw-nuci7 total:132 pass:122 dwarn:1 dfail:0 fail:0 skip:9
bdw-ultra total:132 pass:124 dwarn:2 dfail:0 fail:0 skip:6
bsw-nuc-2 total:135 pass:114 dwarn:1 dfail:0 fail:0 skip:20
byt-nuc total:135 pass:119 dwarn:3 dfail:0 fail:0 skip:13
hsw-brixbox total:135 pass:127 dwarn:1 dfail:0 fail:0 skip:7
hsw-gt2 total:135 pass:130 dwarn:1 dfail:0 fail:0 skip:4
ilk-hp8440p total:135 pass:100 dwarn:0 dfail:0 fail:0 skip:35
ivb-t430s total:135 pass:127 dwarn:2 dfail:0 fail:0 skip:6
skl-i5k-2 total:135 pass:124 dwarn:3 dfail:0 fail:0 skip:8
skl-i7k-2 total:135 pass:124 dwarn:3 dfail:0 fail:0 skip:8
snb-dellxps total:135 pass:121 dwarn:2 dfail:0 fail:0 skip:12
snb-x220t total:135 pass:121 dwarn:2 dfail:0 fail:1 skip:11
Results at /archive/results/CI_IGT_test/Patchwork_798/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change
2015-12-23 5:22 [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Nabendu Maiti
2015-12-23 7:20 ` ✗ warning: Fi.CI.BAT Patchwork
@ 2016-01-05 14:43 ` Daniel Vetter
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-01-05 14:43 UTC (permalink / raw)
To: Nabendu Maiti; +Cc: intel-gfx
On Wed, Dec 23, 2015 at 10:52:36AM +0530, Nabendu Maiti wrote:
> Recalculate watermark when there is a change in pixel format.
>
> Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
This seems like something that's been broken recently in the watermark
shuffling. Please dig out the patch which broke this (using git blame
works best usually) and add a Fixes: line per
Documentation/SubmittingPatches. Please then also add the patch author,
reviwers and anyone else Cc'ed on that patch to your patch here using Cc:
lines in the s-o-b section, and then please resend.
Also, do we have an igt testcase for this issue? If not, we should
definitely have one.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 2d0b006..4bd5080 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -11819,6 +11819,7 @@ static bool intel_wm_need_update(struct drm_plane *plane,
> return false;
>
> if (cur->base.fb->modifier[0] != new->base.fb->modifier[0] ||
> + cur->base.fb->pixel_format != new->base.fb->pixel_format ||
> cur->base.rotation != new->base.rotation ||
> drm_rect_width(&new->src) != drm_rect_width(&cur->src) ||
> drm_rect_height(&new->src) != drm_rect_height(&cur->src) ||
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-05 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 5:22 [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Nabendu Maiti
2015-12-23 7:20 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-05 14:43 ` [PATCH] drm/i915/bxt: Fix wm calculation for pixel format change Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.