* [PATCH] mac802154: constify ieee802154_llsec_ops structure
@ 2015-12-23 21:36 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-12-23 21:36 UTC (permalink / raw)
To: Alexander Aring
Cc: kernel-janitors, linux-kernel, netdev, linux-wpan, David S. Miller
The ieee802154_llsec_ops structure is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
include/net/ieee802154_netdev.h | 2 +-
net/mac802154/mac_cmd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee802154_netdev.h
index a62a051..c4b3160 100644
--- a/include/net/ieee802154_netdev.h
+++ b/include/net/ieee802154_netdev.h
@@ -337,7 +337,7 @@ struct ieee802154_mlme_ops {
void (*get_mac_params)(struct net_device *dev,
struct ieee802154_mac_params *params);
- struct ieee802154_llsec_ops *llsec;
+ const struct ieee802154_llsec_ops *llsec;
};
static inline struct ieee802154_mlme_ops *
diff --git a/net/mac802154/mac_cmd.c b/net/mac802154/mac_cmd.c
index 8606da4..3db1634 100644
--- a/net/mac802154/mac_cmd.c
+++ b/net/mac802154/mac_cmd.c
@@ -126,7 +126,7 @@ static void mac802154_get_mac_params(struct net_device *dev,
params->lbt = wpan_dev->lbt;
}
-static struct ieee802154_llsec_ops mac802154_llsec_ops = {
+static const struct ieee802154_llsec_ops mac802154_llsec_ops = {
.get_params = mac802154_get_params,
.set_params = mac802154_set_params,
.add_key = mac802154_add_key,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mac802154: constify ieee802154_llsec_ops structure
@ 2015-12-23 21:36 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-12-23 21:36 UTC (permalink / raw)
To: Alexander Aring
Cc: kernel-janitors, linux-kernel, netdev, linux-wpan, David S. Miller
The ieee802154_llsec_ops structure is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
include/net/ieee802154_netdev.h | 2 +-
net/mac802154/mac_cmd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee802154_netdev.h
index a62a051..c4b3160 100644
--- a/include/net/ieee802154_netdev.h
+++ b/include/net/ieee802154_netdev.h
@@ -337,7 +337,7 @@ struct ieee802154_mlme_ops {
void (*get_mac_params)(struct net_device *dev,
struct ieee802154_mac_params *params);
- struct ieee802154_llsec_ops *llsec;
+ const struct ieee802154_llsec_ops *llsec;
};
static inline struct ieee802154_mlme_ops *
diff --git a/net/mac802154/mac_cmd.c b/net/mac802154/mac_cmd.c
index 8606da4..3db1634 100644
--- a/net/mac802154/mac_cmd.c
+++ b/net/mac802154/mac_cmd.c
@@ -126,7 +126,7 @@ static void mac802154_get_mac_params(struct net_device *dev,
params->lbt = wpan_dev->lbt;
}
-static struct ieee802154_llsec_ops mac802154_llsec_ops = {
+static const struct ieee802154_llsec_ops mac802154_llsec_ops = {
.get_params = mac802154_get_params,
.set_params = mac802154_set_params,
.add_key = mac802154_add_key,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure
2015-12-23 21:36 ` Julia Lawall
@ 2016-01-04 14:33 ` Alexander Aring
-1 siblings, 0 replies; 6+ messages in thread
From: Alexander Aring @ 2016-01-04 14:33 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-kernel, netdev, linux-wpan,
David S. Miller, marcel
Hi,
On Wed, Dec 23, 2015 at 10:36:32PM +0100, Julia Lawall wrote:
> The ieee802154_llsec_ops structure is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel, can you please apply this on bluetooth-next?
Thank you.
- Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure
@ 2016-01-04 14:33 ` Alexander Aring
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Aring @ 2016-01-04 14:33 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-kernel, netdev, linux-wpan,
David S. Miller, marcel
Hi,
On Wed, Dec 23, 2015 at 10:36:32PM +0100, Julia Lawall wrote:
> The ieee802154_llsec_ops structure is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel, can you please apply this on bluetooth-next?
Thank you.
- Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure
2015-12-23 21:36 ` Julia Lawall
@ 2016-01-04 19:41 ` Marcel Holtmann
-1 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2016-01-04 19:41 UTC (permalink / raw)
To: Julia Lawall
Cc: Alexander Aring, kernel-janitors, LKML, Network Development,
linux-wpan, David S. Miller
Hi Julia,
> The ieee802154_llsec_ops structure is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> include/net/ieee802154_netdev.h | 2 +-
> net/mac802154/mac_cmd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mac802154: constify ieee802154_llsec_ops structure
@ 2016-01-04 19:41 ` Marcel Holtmann
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2016-01-04 19:41 UTC (permalink / raw)
To: Julia Lawall
Cc: Alexander Aring, kernel-janitors, LKML, Network Development,
linux-wpan, David S. Miller
Hi Julia,
> The ieee802154_llsec_ops structure is never modified, so declare it as
> const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> include/net/ieee802154_netdev.h | 2 +-
> net/mac802154/mac_cmd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-04 19:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 21:36 [PATCH] mac802154: constify ieee802154_llsec_ops structure Julia Lawall
2015-12-23 21:36 ` Julia Lawall
2016-01-04 14:33 ` Alexander Aring
2016-01-04 14:33 ` Alexander Aring
2016-01-04 19:41 ` Marcel Holtmann
2016-01-04 19:41 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.