[PATCH] bitbake: BBUIHelper: Remove function findServerDetails

[PATCH] bitbake: BBUIHelper: Remove function findServerDetails

[Sujith H]

findServerDetails function can be removed safely
from the source tree. Couldn't find any files
calling this function.

Signed-off-by: Sujith H <sujith.h@gmail.com>
---
 lib/bb/ui/uihelper.py | 41 -----------------------------------------
 1 file changed, 41 deletions(-)

diff --git a/lib/bb/ui/uihelper.py b/lib/bb/ui/uihelper.py
index a703387..db70b76 100644
--- a/lib/bb/ui/uihelper.py
+++ b/lib/bb/ui/uihelper.py
@@ -57,44 +57,3 @@ class BBUIHelper:
         self.needUpdate = False
         return (self.running_tasks, self.failed_tasks)
 
-    def findServerDetails(self):
-        import sys
-        import optparse
-        from bb.server.xmlrpc import BitbakeServerInfo, BitBakeServerConnection
-        host = ""
-        port = 0
-        bind = ""
-        parser = optparse.OptionParser(
-            usage = """%prog -H host -P port -B bindaddr""")
-
-        parser.add_option("-H", "--host", help = "Bitbake server's IP address",
-                   action = "store", dest = "host", default = None)
-
-        parser.add_option("-P", "--port", help = "Bitbake server's Port number",
-                   action = "store", dest = "port", default = None)
-
-        parser.add_option("-B", "--bind", help = "Hob2 local bind address",
-                   action = "store", dest = "bind", default = None)
-
-        options, args = parser.parse_args(sys.argv)
-        for key, val in options.__dict__.items():
-            if key == 'host' and val:
-                host = val
-            elif key == 'port' and val:
-                port = int(val)
-            elif key == 'bind' and val:
-                bind = val
-
-        if not host or not port or not bind:
-            parser.print_usage()
-            sys.exit(1)
-
-        serverinfo = BitbakeServerInfo(host, port)
-        clientinfo = (bind, 0)
-        connection = BitBakeServerConnection(serverinfo, clientinfo)
-
-        server = connection.connection
-        eventHandler = connection.events
-
-        return server, eventHandler, host, bind
-
-- 
2.4.3

Re: [PATCH] bitbake: BBUIHelper: Remove function findServerDetails

[Paul Eggleton]

On Tue, 05 Jan 2016 18:30:15 Sujith H wrote:
> findServerDetails function can be removed safely
> from the source tree. Couldn't find any files
> calling this function.
> 
> Signed-off-by: Sujith H <sujith.h@gmail.com>
> ---
>  lib/bb/ui/uihelper.py | 41 -----------------------------------------
>  1 file changed, 41 deletions(-)
> 
> diff --git a/lib/bb/ui/uihelper.py b/lib/bb/ui/uihelper.py
> index a703387..db70b76 100644
> --- a/lib/bb/ui/uihelper.py
> +++ b/lib/bb/ui/uihelper.py
> @@ -57,44 +57,3 @@ class BBUIHelper:
>          self.needUpdate = False
>          return (self.running_tasks, self.failed_tasks)
> 
> -    def findServerDetails(self):
> -        import sys
> -        import optparse
> -        from bb.server.xmlrpc import BitbakeServerInfo,
> BitBakeServerConnection -        host = ""
> -        port = 0
> -        bind = ""
> -        parser = optparse.OptionParser(
> -            usage = """%prog -H host -P port -B bindaddr""")
> -
> -        parser.add_option("-H", "--host", help = "Bitbake server's IP
> address", -                   action = "store", dest = "host", default =
> None) -
> -        parser.add_option("-P", "--port", help = "Bitbake server's Port
> number", -                   action = "store", dest = "port", default =
> None) -
> -        parser.add_option("-B", "--bind", help = "Hob2 local bind address",
> -                   action = "store", dest = "bind", default = None) -
> -        options, args = parser.parse_args(sys.argv)
> -        for key, val in options.__dict__.items():
> -            if key == 'host' and val:
> -                host = val
> -            elif key == 'port' and val:
> -                port = int(val)
> -            elif key == 'bind' and val:
> -                bind = val
> -
> -        if not host or not port or not bind:
> -            parser.print_usage()
> -            sys.exit(1)
> -
> -        serverinfo = BitbakeServerInfo(host, port)
> -        clientinfo = (bind, 0)
> -        connection = BitBakeServerConnection(serverinfo, clientinfo)
> -
> -        server = connection.connection
> -        eventHandler = connection.events
> -
> -        return server, eventHandler, host, bind
> -

Looks like this was left over from the early days of Hob.

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre