From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] pc: allow raising low memory via max-ram-below-4g option
Date: Tue, 05 Jan 2016 14:32:05 +0100 [thread overview]
Message-ID: <1452000725.6030.7.camel@redhat.com> (raw)
In-Reply-To: <20160105151711-mutt-send-email-mst@redhat.com>
On Di, 2016-01-05 at 15:17 +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 05, 2016 at 12:59:51PM +0100, Gerd Hoffmann wrote:
> > This patch extends the functionality of the max-ram-below-4g option
> > to also allow increasing lowmem. While being at it also rework the
> > lowmem calculation logic and add a longish comment describing how it
> > works and what the compatibility constrains are.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Could you please add info about the motivation for this
> in the commit log?
> > + * - Finally max-ram-below-4g got updated to also allow raising lowmem,
> > + * so legacy non-PAE guests can get as much memory as possible in
> > + * the 32bit address space below 4G.
It's right here (where it imho is more useful for people looking at the
code).
Want me copy this into the commit message?
cheers,
Gerd
next prev parent reply other threads:[~2016-01-05 13:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 11:59 [Qemu-devel] [PATCH] pc: allow raising low memory via max-ram-below-4g option Gerd Hoffmann
2016-01-05 13:17 ` Michael S. Tsirkin
2016-01-05 13:32 ` Gerd Hoffmann [this message]
2016-01-05 13:35 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2015-10-22 6:49 Gerd Hoffmann
2015-10-22 8:03 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452000725.6030.7.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.