[PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

I have never seen auto handoff working on TI and RENESAS cards.
Eventually, we force handoff. This code forces the handoff
unconditionally. It saves 5 seconds boot time for each card.

Signed-off-by: Babu Moger <babu.moger@oracle.com>
---
 drivers/usb/host/pci-quirks.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index f940056..b7ee895 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
 	} while (1);
 
+	/* Auto handoff never worked for these devices. Force it and continue */
+	if (pdev->vendor == PCI_VENDOR_ID_TI ||
+			pdev->vendor == PCI_VENDOR_ID_RENESAS) {
+		val  =  (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
+		writel(val, base + ext_cap_offset);
+	}
+
 	/* If the BIOS owns the HC, signal that the OS wants it, and wait */
 	if (val & XHCI_HC_BIOS_OWNED) {
 		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
-- 
1.7.1

Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Greg KH]

On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
> 
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> ---
>  drivers/usb/host/pci-quirks.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..b7ee895 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>  		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
>  	} while (1);
>  
> +	/* Auto handoff never worked for these devices. Force it and continue */
> +	if (pdev->vendor == PCI_VENDOR_ID_TI ||
> +			pdev->vendor == PCI_VENDOR_ID_RENESAS) {
> +		val  =  (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;

odd spaces here, why this format?

And are you sure that all TI and Renesas host controllers have this
issue?  That's a very wide and broad test you are making here...

thanks,

greg k-h

Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

On 1/7/2016 11:29 AM, Greg KH wrote:
> On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote:
>> I have never seen auto handoff working on TI and RENESAS cards.
>> Eventually, we force handoff. This code forces the handoff
>> unconditionally. It saves 5 seconds boot time for each card.
>>
>> Signed-off-by: Babu Moger <babu.moger@oracle.com>
>> ---
>>  drivers/usb/host/pci-quirks.c |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index f940056..b7ee895 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>>  		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
>>  	} while (1);
>>  
>> +	/* Auto handoff never worked for these devices. Force it and continue */
>> +	if (pdev->vendor == PCI_VENDOR_ID_TI ||
>> +			pdev->vendor == PCI_VENDOR_ID_RENESAS) {
>> +		val  =  (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
> 
> odd spaces here, why this format?

 Thanks. I will fix this. checkpatch.pl did not catch it.

> 
> And are you sure that all TI and Renesas host controllers have this
> issue?  That's a very wide and broad test you are making here...

 True, that is broad. I have tested these cards. I can probably add both vendor
 and device id combination.
 # lspci  -nn |grep -i usb
 0002:03:00.0 USB controller [0c03]: Texas Instruments TUSB73x0 SuperSpeed USB 3.0 xHCI Host Controller [104c:8241] (rev 02)
 0000:05:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720201 USB 3.0 Host Controller [1912:0014] (rev 03)
 
> 
> thanks,
> 
> greg k-h
> 

Re: [PATCH] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Greg KH]

On Thu, Jan 07, 2016 at 11:51:21AM -0600, Babu Moger wrote:
> On 1/7/2016 11:29 AM, Greg KH wrote:
> > On Thu, Jan 07, 2016 at 09:23:27AM -0800, Babu Moger wrote:
> >> I have never seen auto handoff working on TI and RENESAS cards.
> >> Eventually, we force handoff. This code forces the handoff
> >> unconditionally. It saves 5 seconds boot time for each card.
> >>
> >> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> >> ---
> >>  drivers/usb/host/pci-quirks.c |    7 +++++++
> >>  1 files changed, 7 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> >> index f940056..b7ee895 100644
> >> --- a/drivers/usb/host/pci-quirks.c
> >> +++ b/drivers/usb/host/pci-quirks.c
> >> @@ -1003,6 +1003,13 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
> >>  		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
> >>  	} while (1);
> >>  
> >> +	/* Auto handoff never worked for these devices. Force it and continue */
> >> +	if (pdev->vendor == PCI_VENDOR_ID_TI ||
> >> +			pdev->vendor == PCI_VENDOR_ID_RENESAS) {
> >> +		val  =  (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
> > 
> > odd spaces here, why this format?
> 
>  Thanks. I will fix this. checkpatch.pl did not catch it.
> 
> > 
> > And are you sure that all TI and Renesas host controllers have this
> > issue?  That's a very wide and broad test you are making here...
> 
>  True, that is broad. I have tested these cards. I can probably add both vendor
>  and device id combination.
>  # lspci  -nn |grep -i usb
>  0002:03:00.0 USB controller [0c03]: Texas Instruments TUSB73x0 SuperSpeed USB 3.0 xHCI Host Controller [104c:8241] (rev 02)
>  0000:05:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720201 USB 3.0 Host Controller [1912:0014] (rev 03)

Please do so, only add the devices you _know_ need this.

thanks,

greg k-h

[PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

I have never seen auto handoff working on TI and RENESAS cards.
Eventually, we force handoff. This code forces the handoff
unconditionally. It saves 5 seconds boot time for each card.

Changes v0 -> v1
 Made changes per comments from Greg KH.
 Extra space removal in assignment
 Added both vendor and device id checks.

Signed-off-by: Babu Moger <babu.moger@oracle.com>
---
 drivers/usb/host/pci-quirks.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index f940056..0915f44 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -1003,6 +1003,14 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
 	} while (1);
 
+	/* Auto handoff never worked for these devices. Force it and continue */
+	if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
+			(pdev->vendor == PCI_VENDOR_ID_RENESAS
+			 && pdev->device == 0x0014)) {
+		val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
+		writel(val, base + ext_cap_offset);
+	}
+
 	/* If the BIOS owns the HC, signal that the OS wants it, and wait */
 	if (val & XHCI_HC_BIOS_OWNED) {
 		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
-- 
1.7.1

Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Greg KH]

On Thu, Jan 07, 2016 at 04:04:51PM -0800, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
> 
> Changes v0 -> v1
>  Made changes per comments from Greg KH.
>  Extra space removal in assignment
>  Added both vendor and device id checks.

This "changes" stuff goes below the --- line, not here in the body where
I would have to hand-edit the patch to remove it.

v2? :)

Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

On 1/7/2016 7:01 PM, Greg KH wrote:
> On Thu, Jan 07, 2016 at 04:04:51PM -0800, Babu Moger wrote:
>> I have never seen auto handoff working on TI and RENESAS cards.
>> Eventually, we force handoff. This code forces the handoff
>> unconditionally. It saves 5 seconds boot time for each card.
>>
>> Changes v0 -> v1
>>  Made changes per comments from Greg KH.
>>  Extra space removal in assignment
>>  Added both vendor and device id checks.
> 
> This "changes" stuff goes below the --- line, not here in the body where
> I would have to hand-edit the patch to remove it.
> 
> v2? :)
Sure. Re-posting it. Used the sample http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches
 

[PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

I have never seen auto handoff working on TI and RENESAS cards.
Eventually, we force handoff. This code forces the handoff
unconditionally. It saves 5 seconds boot time for each card.

Signed-off-by: Babu Moger <babu.moger@oracle.com>
---
v2: 
 Made changes per comments from Greg KH.
 Extra space removal in assignment
 Added both vendor and device id checks.

 drivers/usb/host/pci-quirks.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index f940056..0915f44 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -1003,6 +1003,14 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
 	} while (1);
 
+	/* Auto handoff never worked for these devices. Force it and continue */
+	if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
+			(pdev->vendor == PCI_VENDOR_ID_RENESAS
+			 && pdev->device == 0x0014)) {
+		val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
+		writel(val, base + ext_cap_offset);
+	}
+
 	/* If the BIOS owns the HC, signal that the OS wants it, and wait */
 	if (val & XHCI_HC_BIOS_OWNED) {
 		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
-- 
1.7.1

Re: [PATCH v2] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

[Babu Moger]

Its  been a while since I submit this patch. Ping 1. 

On 1/8/2016 9:39 AM, Babu Moger wrote:
> I have never seen auto handoff working on TI and RENESAS cards.
> Eventually, we force handoff. This code forces the handoff
> unconditionally. It saves 5 seconds boot time for each card.
> 
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> ---
> v2: 
>  Made changes per comments from Greg KH.
>  Extra space removal in assignment
>  Added both vendor and device id checks.
> 
>  drivers/usb/host/pci-quirks.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..0915f44 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1003,6 +1003,14 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>  		ext_cap_offset = xhci_find_next_cap_offset(base, ext_cap_offset);
>  	} while (1);
>  
> +	/* Auto handoff never worked for these devices. Force it and continue */
> +	if ((pdev->vendor == PCI_VENDOR_ID_TI && pdev->device == 0x8241) ||
> +			(pdev->vendor == PCI_VENDOR_ID_RENESAS
> +			 && pdev->device == 0x0014)) {
> +		val = (val | XHCI_HC_OS_OWNED) & ~XHCI_HC_BIOS_OWNED;
> +		writel(val, base + ext_cap_offset);
> +	}
> +
>  	/* If the BIOS owns the HC, signal that the OS wants it, and wait */
>  	if (val & XHCI_HC_BIOS_OWNED) {
>  		writel(val | XHCI_HC_OS_OWNED, base + ext_cap_offset);
>