[U-Boot] Asymmetry in setting of "fileaddr" variable

[U-Boot] Asymmetry in setting of "fileaddr" variable

[David Müller (ELSOFT AG)]

Hello

In net/net.c::net_loop(), the variables "fileaddr" and "filesize" are
both set in case of a successful transfer.

In fs/fs.c::do_load(), just the variable "filesize" is set in case of
success.

Is this asymmetry intentional or a mistake?

Dave

[U-Boot] [PATCH] fs: handle the fileaddr variable in the same way as in the network case

[David Müller]

---
 fs/fs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/fs.c b/fs/fs.c
index b2d6a53..a2f1bf5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[],
 	}
 	puts("\n");
 
+	setenv_hex("fileaddr", addr);
 	setenv_hex("filesize", len_read);
 
 	return 0;
-- 
1.8.4

[U-Boot] [PATCH v2] fs: handle the fileaddr variable in the same way as in the network case

[David Müller]

Signed-off-by: David M?ller <d.mueller@elsoft.ch>
---
 fs/fs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/fs.c b/fs/fs.c
index b2d6a53..a2f1bf5 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[],
 	}
 	puts("\n");
 
+	setenv_hex("fileaddr", addr);
 	setenv_hex("filesize", len_read);
 
 	return 0;
-- 
1.8.4

[U-Boot] [U-Boot, v2] fs: handle the fileaddr variable in the same way as in the network case

[Tom Rini]

On Fri, Jan 08, 2016 at 09:39:20AM +0100, David M?ller (ELSOFT AG) wrote:

> Signed-off-by: David M?ller <d.mueller@elsoft.ch>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160108/bac640bb/attachment.sig>