* [PATCH openbmc-test-automation 01/60] first commit
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 4:18 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 02/60] added files OpenBMC Patches
` (60 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: Manjunath Kumatagi
From: Manjunath Kumatagi <manjunath@oc1275007250.ibm.com>
---
README.md | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 README.md
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..e69de29
--
2.6.4
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [PATCH openbmc-test-automation 01/60] first commit
2016-01-11 16:49 ` [PATCH openbmc-test-automation 01/60] first commit OpenBMC Patches
@ 2016-01-12 4:18 ` Stewart Smith
0 siblings, 0 replies; 70+ messages in thread
From: Stewart Smith @ 2016-01-12 4:18 UTC (permalink / raw)
To: OpenBMC Patches, openbmc; +Cc: Manjunath Kumatagi
OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
> From: Manjunath Kumatagi <manjunath@oc1275007250.ibm.com>
A real email address should be used.
The oc127-blah thing there is an internal to IBM generated hostname.
Although, from that, i can deduce what Operating System they run....
> README.md | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
I'm pretty sure we could do better than zero lines too :)
--
Stewart Smith
OPAL Architect, IBM.
^ permalink raw reply [flat|nested] 70+ messages in thread
* [PATCH openbmc-test-automation 02/60] added files
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 01/60] first commit OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 4:20 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 03/60] Update README.md OpenBMC Patches
` (59 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
.project | 17 ++++++++
.pydevproject | 7 ++++
lib/resource.txt | 12 ++++++
lib/rest_client.robot | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++
requirements.txt | 4 ++
tests/data.json | 1 +
tests/test_fan.robot | 9 +++++
tests/test_ssh.robot | 55 +++++++++++++++++++++++++
tox.ini | 32 +++++++++++++++
9 files changed, 246 insertions(+)
create mode 100644 .project
create mode 100644 .pydevproject
create mode 100644 lib/resource.txt
create mode 100644 lib/rest_client.robot
create mode 100644 requirements.txt
create mode 100755 tests/data.json
create mode 100644 tests/test_fan.robot
create mode 100644 tests/test_ssh.robot
create mode 100644 tox.ini
diff --git a/.project b/.project
new file mode 100644
index 0000000..9b83158
--- /dev/null
+++ b/.project
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+ <name>openbmc-automation</name>
+ <comment></comment>
+ <projects>
+ </projects>
+ <buildSpec>
+ <buildCommand>
+ <name>org.python.pydev.PyDevBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ </buildSpec>
+ <natures>
+ <nature>org.python.pydev.pythonNature</nature>
+ </natures>
+</projectDescription>
diff --git a/.pydevproject b/.pydevproject
new file mode 100644
index 0000000..08ea93f
--- /dev/null
+++ b/.pydevproject
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?><?eclipse-pydev version="1.0"?><pydev_project>
+<pydev_pathproperty name="org.python.pydev.PROJECT_SOURCE_PATH">
+<path>/${PROJECT_DIR_NAME}</path>
+</pydev_pathproperty>
+<pydev_property name="org.python.pydev.PYTHON_PROJECT_VERSION">python 2.7</pydev_property>
+<pydev_property name="org.python.pydev.PYTHON_PROJECT_INTERPRETER">Default</pydev_property>
+</pydev_project>
\ No newline at end of file
diff --git a/lib/resource.txt b/lib/resource.txt
new file mode 100644
index 0000000..5acddcf
--- /dev/null
+++ b/lib/resource.txt
@@ -0,0 +1,12 @@
+*** Settings ***
+Library Collections
+Library String
+Library RequestsLibrary.RequestsKeywords
+Library OperatingSystem
+
+*** Variables ***
+${HOST} 192.168.122.100 # openbmc ip address
+${PORT} 3000
+${AUTH_URI} http://${HOST}:${PORT}
+${USERNAME} root
+${PASSWORD} abc123
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
new file mode 100644
index 0000000..1de2b77
--- /dev/null
+++ b/lib/rest_client.robot
@@ -0,0 +1,109 @@
+*** Settings ***
+Library Collections
+Library String
+Library RequestsLibrary.RequestsKeywords
+Library OperatingSystem
+
+*** Variables ***
+${HOST} 192.168.122.100 # openbmc ip address
+${DBUS_PREFIX} /bus/session
+${PORT} 3000
+${AUTH_URI} http://${HOST}:${PORT}
+${USERNAME} root
+${PASSWORD} abc123
+# Response codes
+${HTTP_CONTINUE} 100
+${HTTP_SWITCHING_PROTOCOLS} 101
+${HTTP_PROCESSING} 102
+${HTTP_OK} 200
+${HTTP_CREATED} 201
+${HTTP_ACCEPTED} 202
+${HTTP_NON_AUTHORITATIVE_INFORMATION} 203
+${HTTP_NO_CONTENT} 204
+${HTTP_RESET_CONTENT} 205
+${HTTP_PARTIAL_CONTENT} 206
+${HTTP_MULTI_STATUS} 207
+${HTTP_IM_USED} 226
+${HTTP_MULTIPLE_CHOICES} 300
+${HTTP_MOVED_PERMANENTLY} 301
+${HTTP_FOUND} 302
+${HTTP_SEE_OTHER} 303
+${HTTP_NOT_MODIFIED} 304
+${HTTP_USE_PROXY} 305
+${HTTP_TEMPORARY_REDIRECT} 307
+${HTTP_BAD_REQUEST} 400
+${HTTP_UNAUTHORIZED} 401
+${HTTP_PAYMENT_REQUIRED} 402
+${HTTP_FORBIDDEN} 403
+${HTTP_NOT_FOUND} 404
+${HTTP_METHOD_NOT_ALLOWED} 405
+${HTTP_NOT_ACCEPTABLE} 406
+${HTTP_PROXY_AUTHENTICATION_REQUIRED} 407
+${HTTP_REQUEST_TIMEOUT} 408
+${HTTP_CONFLICT} 409
+${HTTP_GONE} 410
+${HTTP_LENGTH_REQUIRED} 411
+${HTTP_PRECONDITION_FAILED} 412
+${HTTP_REQUEST_ENTITY_TOO_LARGE} 413
+${HTTP_REQUEST_URI_TOO_LONG} 414
+${HTTP_UNSUPPORTED_MEDIA_TYPE} 415
+${HTTP_REQUESTED_RANGE_NOT_SATISFIABLE} 416
+${HTTP_EXPECTATION_FAILED} 417
+${HTTP_UNPROCESSABLE_ENTITY} 422
+${HTTP_LOCKED} 423
+${HTTP_FAILED_DEPENDENCY} 424
+${HTTP_UPGRADE_REQUIRED} 426
+${HTTP_INTERNAL_SERVER_ERROR} 500
+${HTTP_NOT_IMPLEMENTED} 501
+${HTTP_BAD_GATEWAY} 502
+${HTTP_SERVICE_UNAVAILABLE} 503
+${HTTP_GATEWAY_TIMEOUT} 504
+${HTTP_HTTP_VERSION_NOT_SUPPORTED} 505
+${HTTP_INSUFFICIENT_STORAGE} 507
+${HTTP_NOT_EXTENDED} 510
+
+*** Keywords ***
+OpenBMC Get Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Get base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Get Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+OpenBMC Post Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Post base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Post Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+OpenBMC Put Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Put base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Put Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+Initialize OpenBMC
+ Create Session openbmc ${AUTH_URI}
+
+Log Request
+ [Arguments] &{kwargs}
+ ${msg}= Catenate SEPARATOR= URI: ${AUTH_URI} ${kwargs["base_uri"]} , method:
+ ... ${kwargs["method"]} , args: ${kwargs["args"]}
+ Logging ${msg} console=True
+
+Log Response
+ [Arguments] ${resp}
+ ${msg}= Catenate SEPARATOR= Response code: ${resp.status_code} , Content: ${resp.content}
+ Logging ${msg} console=True
+
+Logging
+ [Arguments] ${msg} ${console}=default False
+ Log ${msg} console=True
diff --git a/requirements.txt b/requirements.txt
new file mode 100644
index 0000000..8434d52
--- /dev/null
+++ b/requirements.txt
@@ -0,0 +1,4 @@
+robotframework
+requests
+robotframework-requests
+robotframework-sshlibrary
\ No newline at end of file
diff --git a/tests/data.json b/tests/data.json
new file mode 100755
index 0000000..7bfd886
--- /dev/null
+++ b/tests/data.json
@@ -0,0 +1 @@
+{"two": 2, "one": 1}
diff --git a/tests/test_fan.robot b/tests/test_fan.robot
new file mode 100644
index 0000000..61255e6
--- /dev/null
+++ b/tests/test_fan.robot
@@ -0,0 +1,9 @@
+*** Settings ***
+Documentation This testsuite is for testing fan interface for openbmc
+Suite Teardown Delete All Sessions
+Resource ../lib/rest_client.robot
+
+*** Test Cases ***
+List all the fans
+ ${resp} = OpenBMC Get Request /org.openbmc.control.Fan/
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
new file mode 100644
index 0000000..0801d8a
--- /dev/null
+++ b/tests/test_ssh.robot
@@ -0,0 +1,55 @@
+*** Settings ***
+Documentation This example demonstrates executing commands on a remote machine
+... and getting their output and the return code.
+...
+... Notice how connections are handled as part of the suite setup and
+... teardown. This saves some time when executing several test cases.
+Suite Setup Open Connection And Log In
+Suite Teardown Close All Connections
+Library SSHLibrary
+
+*** Variables ***
+${HOST} 192.168.122.100
+${USERNAME} manjunath
+${PASSWORD} passw0rd
+
+*** Test Cases ***
+Execute Command And Verify Output
+ [Documentation] Execute Command can be used to ran commands on the remote machine.
+ ... The keyword returns the standard output by default.
+ ${output}= Execute Command echo Hello SSHLibrary!
+ Should Be Equal ${output} Hello SSHLibrary!
+
+Execute Command And Verify Return Code
+ [Documentation] Often getting the return code of the command is enough.
+ ... This behaviour can be adjusted as Execute Command arguments.
+ ${rc}= Execute Command echo Success guaranteed. return_stdout=False return_rc=True
+ Should Be Equal ${rc} ${0}
+
+Executing Commands In An Interactive Session
+ [Documentation] Execute Command always executes the command in a new shell.
+ ... This means that changes to the environment are not persisted
+ ... between subsequent Execute Command keyword calls.
+ ... Write and Read Until variants can be used to operate in the same shell.
+ Write cd ..
+ Write echo Hello from the parent directory!
+ ${output}= Read Until directory!
+ Should End With ${output} Hello from the parent directory!
+
+List all the files
+ [Documentation] List all the files in the remote machine
+ ${output} ${stderr} ${rc}= Execute Command ls return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
+
+File Not Found
+ [Documentation] This testcase is for testing ls command with non existing file
+ ${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Should Be Equal ${rc} ${2}
+ Should Contain ${stderr} No such file or directory
+
+*** Keywords ***
+Open Connection And Log In
+ Open Connection ${HOST}
+ Login ${USERNAME} ${PASSWORD}
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..fc08416
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,32 @@
+[tox]
+skipsdist = True
+
+[openbmcenv]
+sitepackages = False
+setenv = VIRTUAL_ENV={envdir}
+deps = setuptools
+ -r{toxinidir}/requirements.txt
+
+[testenv]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run {posargs}
+
+[testenv:full]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run .
+
+[testenv:tests]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run tests
+
+[testenv:custom]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* Re: [PATCH openbmc-test-automation 02/60] added files
2016-01-11 16:49 ` [PATCH openbmc-test-automation 02/60] added files OpenBMC Patches
@ 2016-01-12 4:20 ` Stewart Smith
0 siblings, 0 replies; 70+ messages in thread
From: Stewart Smith @ 2016-01-12 4:20 UTC (permalink / raw)
To: OpenBMC Patches, openbmc
OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
> From: manjunath <manjunath@localhost.localdomain>
Needs real email address.
Otherwise we have *NO* audit trail that anyone was allowed to submit
this code.
Considering that there's no license information attached, one *MUST*
assume that this is *NOT* freely licensed code, and is, in fact, (C)
some random person/company and proprietary.
--
Stewart Smith
OPAL Architect, IBM.
^ permalink raw reply [flat|nested] 70+ messages in thread
* [PATCH openbmc-test-automation 03/60] Update README.md
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 01/60] first commit OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 02/60] added files OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 04/60] added log statement OpenBMC Patches
` (58 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: mkumatag <mkumatag@in.ibm.com>
---
README.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README.md b/README.md
index e69de29..f491b6c 100644
--- a/README.md
+++ b/README.md
@@ -0,0 +1,2 @@
+#openbmc-automation
+More information needs to be added.
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 04/60] added log statement
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (2 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 03/60] Update README.md OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 4:20 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 05/60] added testcase for etc passwd OpenBMC Patches
` (57 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
tests/test_ssh.robot | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
index 0801d8a..e9dcf9e 100644
--- a/tests/test_ssh.robot
+++ b/tests/test_ssh.robot
@@ -46,6 +46,7 @@ File Not Found
[Documentation] This testcase is for testing ls command with non existing file
${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
Should Be Equal ${rc} ${2}
Should Contain ${stderr} No such file or directory
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 05/60] added testcase for etc passwd
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (3 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 04/60] added log statement OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 4:20 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 06/60] Added git ignore file OpenBMC Patches
` (56 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
tests/test_ssh.robot | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
index e9dcf9e..cabcea0 100644
--- a/tests/test_ssh.robot
+++ b/tests/test_ssh.robot
@@ -50,6 +50,14 @@ File Not Found
Should Be Equal ${rc} ${2}
Should Contain ${stderr} No such file or directory
+etc passwd entry
+ [Documentation] This testcase is for testing /etc/passwd entry
+ ${output} ${stderr} ${rc}= Execute Command grep manjunath /etc/passwd return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
+ Should Be Equal ${rc} ${0}
+ Should Contain ${output} manjunath
+
*** Keywords ***
Open Connection And Log In
Open Connection ${HOST}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 06/60] Added git ignore file
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (4 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 05/60] added testcase for etc passwd OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 07/60] Use argumnet file with pyrobot and added instructions to READEME file OpenBMC Patches
` (55 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 .gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..9f23ed1
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+/log.html
+/output.xml
+/report.html
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 07/60] Use argumnet file with pyrobot and added instructions to READEME file.
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (5 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 06/60] Added git ignore file OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 08/60] Update README for better html display OpenBMC Patches
` (54 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 2 ++
README.md | 18 +++++++++++-
lib/resource.txt | 6 ++--
lib/rest_client.robot | 8 +++---
tests/test_ssh.robot | 64 ------------------------------------------
tools/generate_argumentfile.sh | 5 ++++
tox.ini | 30 +++++++++-----------
7 files changed, 45 insertions(+), 88 deletions(-)
delete mode 100644 tests/test_ssh.robot
create mode 100755 tools/generate_argumentfile.sh
diff --git a/.gitignore b/.gitignore
index 9f23ed1..8aea548 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,5 @@
/log.html
/output.xml
/report.html
+/.idea/
+/.tox/
\ No newline at end of file
diff --git a/README.md b/README.md
index f491b6c..589d693 100644
--- a/README.md
+++ b/README.md
@@ -1,2 +1,18 @@
#openbmc-automation
-More information needs to be added.
+
+Quickstart
+----------
+
+To run openbmc-automation first you need to install the prerequisite python
+packages which will help to invoke tests through tox.
+
+1. Install the python dependencies for tox
+ $ easy_install tox pip
+
+2. Initilize the following environment variable which will used while testing
+ $ export OPENBMC_HOST=<openbmc machine ip address>
+ $ export OPENBMC_PASSWORD=<openbmc username>
+ $ export OPENBMC_USERNAME=<openbmc password>
+
+3. Run tests
+ $ tox -e tests
diff --git a/lib/resource.txt b/lib/resource.txt
index 5acddcf..c34e026 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -5,8 +5,8 @@ Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
*** Variables ***
-${HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
${PORT} 3000
${AUTH_URI} http://${HOST}:${PORT}
-${USERNAME} root
-${PASSWORD} abc123
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} abc123
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 1de2b77..45c4226 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -5,12 +5,12 @@ Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
*** Variables ***
-${HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
${DBUS_PREFIX} /bus/session
${PORT} 3000
-${AUTH_URI} http://${HOST}:${PORT}
-${USERNAME} root
-${PASSWORD} abc123
+${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} abc123
# Response codes
${HTTP_CONTINUE} 100
${HTTP_SWITCHING_PROTOCOLS} 101
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
deleted file mode 100644
index cabcea0..0000000
--- a/tests/test_ssh.robot
+++ /dev/null
@@ -1,64 +0,0 @@
-*** Settings ***
-Documentation This example demonstrates executing commands on a remote machine
-... and getting their output and the return code.
-...
-... Notice how connections are handled as part of the suite setup and
-... teardown. This saves some time when executing several test cases.
-Suite Setup Open Connection And Log In
-Suite Teardown Close All Connections
-Library SSHLibrary
-
-*** Variables ***
-${HOST} 192.168.122.100
-${USERNAME} manjunath
-${PASSWORD} passw0rd
-
-*** Test Cases ***
-Execute Command And Verify Output
- [Documentation] Execute Command can be used to ran commands on the remote machine.
- ... The keyword returns the standard output by default.
- ${output}= Execute Command echo Hello SSHLibrary!
- Should Be Equal ${output} Hello SSHLibrary!
-
-Execute Command And Verify Return Code
- [Documentation] Often getting the return code of the command is enough.
- ... This behaviour can be adjusted as Execute Command arguments.
- ${rc}= Execute Command echo Success guaranteed. return_stdout=False return_rc=True
- Should Be Equal ${rc} ${0}
-
-Executing Commands In An Interactive Session
- [Documentation] Execute Command always executes the command in a new shell.
- ... This means that changes to the environment are not persisted
- ... between subsequent Execute Command keyword calls.
- ... Write and Read Until variants can be used to operate in the same shell.
- Write cd ..
- Write echo Hello from the parent directory!
- ${output}= Read Until directory!
- Should End With ${output} Hello from the parent directory!
-
-List all the files
- [Documentation] List all the files in the remote machine
- ${output} ${stderr} ${rc}= Execute Command ls return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
-
-File Not Found
- [Documentation] This testcase is for testing ls command with non existing file
- ${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
- Should Be Equal ${rc} ${2}
- Should Contain ${stderr} No such file or directory
-
-etc passwd entry
- [Documentation] This testcase is for testing /etc/passwd entry
- ${output} ${stderr} ${rc}= Execute Command grep manjunath /etc/passwd return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
- Should Be Equal ${rc} ${0}
- Should Contain ${output} manjunath
-
-*** Keywords ***
-Open Connection And Log In
- Open Connection ${HOST}
- Login ${USERNAME} ${PASSWORD}
diff --git a/tools/generate_argumentfile.sh b/tools/generate_argumentfile.sh
new file mode 100755
index 0000000..518a48f
--- /dev/null
+++ b/tools/generate_argumentfile.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+
+echo "--variable OPENBMC_HOST:$OPENBMC_HOST" > $ARG_FILE
+echo "--variable OPENBMC_USERNAME:$OPENBMC_USERNAME" >> $ARG_FILE
+echo "--variable OPENBMC_HOST:$OPENBMC_HOST" >> $ARG_FILE
diff --git a/tox.ini b/tox.ini
index fc08416..75ab527 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,32 +1,30 @@
[tox]
skipsdist = True
-[openbmcenv]
-sitepackages = False
-setenv = VIRTUAL_ENV={envdir}
-deps = setuptools
- -r{toxinidir}/requirements.txt
-
[testenv]
+passenv = *
+setenv = ARG_FILE={env:ARG_FILE:/tmp/argument_file.txt}
+whitelist_externals = *
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/requirements.txt
commands =
- python -m robot.run {posargs}
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
[testenv:full]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run .
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} .
[testenv:tests]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run tests
+ bash {toxinidir}/tools/generate_argumentfile.sh
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} tests
[testenv:custom]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run {posargs}
\ No newline at end of file
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 08/60] Update README for better html display
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (6 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 07/60] Use argumnet file with pyrobot and added instructions to READEME file OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 09/60] Added Inventory list testcase OpenBMC Patches
` (53 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
README.md | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index 589d693..5d869a0 100644
--- a/README.md
+++ b/README.md
@@ -6,13 +6,19 @@ Quickstart
To run openbmc-automation first you need to install the prerequisite python
packages which will help to invoke tests through tox.
-1. Install the python dependencies for tox
- $ easy_install tox pip
+Install the python dependencies for tox
+```shell
+ $easy_install tox pip
+```
-2. Initilize the following environment variable which will used while testing
+Initilize the following environment variable which will used while testing
+```shell
$ export OPENBMC_HOST=<openbmc machine ip address>
$ export OPENBMC_PASSWORD=<openbmc username>
$ export OPENBMC_USERNAME=<openbmc password>
+```
-3. Run tests
+Run tests
+```shell
$ tox -e tests
+```
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 09/60] Added Inventory list testcase
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (7 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 08/60] Update README for better html display OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 10/60] Added DIMM specific inventory tests OpenBMC Patches
` (52 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
data/variables.py | 31 +++++++++++++++++++++++++++++++
lib/resource.txt | 18 +++++++++++++-----
lib/rest_client.robot | 7 +------
tests/test_inventory.robot | 16 ++++++++++++++++
4 files changed, 61 insertions(+), 11 deletions(-)
create mode 100644 data/variables.py
create mode 100644 tests/test_inventory.robot
diff --git a/data/variables.py b/data/variables.py
new file mode 100644
index 0000000..099a21e
--- /dev/null
+++ b/data/variables.py
@@ -0,0 +1,31 @@
+INVENTORY={
+ "palmetto": ["/org/openbmc/inventory/system/chassis/io_board/pcie_slot0",
+ "/org/openbmc/inventory/system/chassis/io_board/pcie_slot1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core9",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core8",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core7",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core6",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core5",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core4",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core3",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core2",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core0",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm3",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm2",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm1",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm0",
+ "/org/openbmc/inventory/system/chassis/fan4",
+ "/org/openbmc/inventory/system/chassis/fan2",
+ "/org/openbmc/inventory/system",
+ "/org/openbmc/inventory/system/chassis/fan0",
+ "/org/openbmc/inventory/system/chassis/fan1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0",
+ "/org/openbmc/inventory/system/chassis",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core11",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core10",
+ "/org/openbmc/inventory/system/chassis/motherboard/centaur0",
+ "/org/openbmc/inventory/system/chassis/motherboard",
+ "/org/openbmc/inventory/system/chassis/motherboard/bmc",
+ "/org/openbmc/inventory/system/chassis/fan3"]
+}
\ No newline at end of file
diff --git a/lib/resource.txt b/lib/resource.txt
index c34e026..fd10050 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -3,10 +3,18 @@ Library Collections
Library String
Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
+Variables ../data/variables.py
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
-${PORT} 3000
-${AUTH_URI} http://${HOST}:${PORT}
-${OPENBMC_USERNAME} root
-${OPENBMC_PASSWORD} abc123
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
+${DBUS_PREFIX} ${EMPTY}
+${PORT} ${EMPTY}
+${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} 0penBmc
+${MACHINE_TYPE} palmetto
+
+*** Keywords ***
+Get Inventory Schema
+ [Arguments] ${machine}
+ [Return] &{INVENTORY}[${machine}]
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 45c4226..b972195 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -3,14 +3,9 @@ Library Collections
Library String
Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
+Resource ../lib/resource.txt
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
-${DBUS_PREFIX} /bus/session
-${PORT} 3000
-${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
-${OPENBMC_USERNAME} root
-${OPENBMC_PASSWORD} abc123
# Response codes
${HTTP_CONTINUE} 100
${HTTP_SWITCHING_PROTOCOLS} 101
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
new file mode 100644
index 0000000..2e5bfaa
--- /dev/null
+++ b/tests/test_inventory.robot
@@ -0,0 +1,16 @@
+*** Settings ***
+Documentation This testsuite is for testing inventory
+Suite Teardown Delete All Sessions
+Resource ../lib/rest_client.robot
+Resource ../lib/resource.txt
+
+*** Test Cases ***
+List Inventory
+ [Documentation] This testcase will get the inventory for the openbmc
+ ... machine and validates with the expected inventory
+ ${resp} = OpenBMC Get Request org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ ${ret}= Get Inventory Schema ${MACHINE_TYPE}
+ : FOR ${ELEMENT} IN @{ret}
+ \ Should Contain ${jsondata} ${ELEMENT}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 10/60] Added DIMM specific inventory tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (8 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 09/60] Added Inventory list testcase OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 11/60] base add for sensor tests OpenBMC Patches
` (51 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 28 ++++++++++++++++++++++++----
tests/test_inventory.robot | 43 ++++++++++++++++++++++++++++++++++++++++---
2 files changed, 64 insertions(+), 7 deletions(-)
diff --git a/data/variables.py b/data/variables.py
index 099a21e..a70367c 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -15,8 +15,8 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard/dimm2",
"/org/openbmc/inventory/system/chassis/motherboard/dimm1",
"/org/openbmc/inventory/system/chassis/motherboard/dimm0",
- "/org/openbmc/inventory/system/chassis/fan4",
- "/org/openbmc/inventory/system/chassis/fan2",
+ "/org/openbmc/inventory/system/chassis/fan4",
+ "/org/openbmc/inventory/system/chassis/fan2",
"/org/openbmc/inventory/system",
"/org/openbmc/inventory/system/chassis/fan0",
"/org/openbmc/inventory/system/chassis/fan1",
@@ -27,5 +27,25 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard/centaur0",
"/org/openbmc/inventory/system/chassis/motherboard",
"/org/openbmc/inventory/system/chassis/motherboard/bmc",
- "/org/openbmc/inventory/system/chassis/fan3"]
-}
\ No newline at end of file
+ "/org/openbmc/inventory/system/chassis/fan3"],
+
+ "DIMM" : [ "Asset Tag",
+ "Custom Field 1",
+ "Custom Field 2",
+ "Custom Field 3",
+ "Custom Field 4",
+ "Custom Field 5",
+ "Custom Field 6",
+ "Custom Field 7",
+ "Custom Field 8",
+ "FRU File ID",
+ "Manufacturer",
+ "Model Number",
+ "Name",
+ "Serial Number",
+ "Version",
+ "fault",
+ "fru_type",
+ "is_fru",
+ "present"],
+}
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index 2e5bfaa..f326a72 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -6,11 +6,48 @@ Resource ../lib/resource.txt
*** Test Cases ***
List Inventory
- [Documentation] This testcase will get the inventory for the openbmc
- ... machine and validates with the expected inventory
- ${resp} = OpenBMC Get Request org/openbmc/inventory/list
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/list
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
${ret}= Get Inventory Schema ${MACHINE_TYPE}
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${jsondata} ${ELEMENT}
+
+
+Verify dimm0 vpd
+ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fru_type
+ Should Be Equal ${value} "DIMM"
+
+
+Verify dimm1 vpd
+ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm1 fru_type
+ Should Be Equal ${value} "DIMM"
+
+Verify dimm0 properties
+ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm0
+ Should Be Valid Dimm Properties ${props}
+
+Verify dimm1 properties
+ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm1
+ Should Be Valid Dimm Properties ${props}
+
+
+
+*** Keywords ***
+Should Be Valid Dimm Properties
+ [arguments] ${props}
+ ${ret}= Get Inventory Schema DIMM
+ : FOR ${ELEMENT} IN @{ret}
+ \ Should Contain ${props} ${ELEMENT}
+
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
+
+
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ [return] ${resp.content}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 11/60] base add for sensor tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (9 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 10/60] Added DIMM specific inventory tests OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 12/60] fixed errors in tox and generate_argumentfile.sh script OpenBMC Patches
` (50 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 28 ++++++++++++++++++++++++
lib/resource.txt | 8 +++++--
tests/test_sensors.robot | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 90 insertions(+), 2 deletions(-)
create mode 100644 tests/test_sensors.robot
diff --git a/data/variables.py b/data/variables.py
index a70367c..820a251 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -49,3 +49,31 @@ INVENTORY={
"is_fru",
"present"],
}
+
+SENSORS={
+ "palmetto" : {
+ 0x2f : '<inventory_root>/system/chassis/motherboard/cpu0',
+ 0x22 : '<inventory_root>/system/chassis/motherboard/cpu0/core0',
+ 0x23 : '<inventory_root>/system/chassis/motherboard/cpu0/core1',
+ 0x24 : '<inventory_root>/system/chassis/motherboard/cpu0/core2',
+ 0x25 : '<inventory_root>/system/chassis/motherboard/cpu0/core3',
+ 0x26 : '<inventory_root>/system/chassis/motherboard/cpu0/core4',
+ 0x27 : '<inventory_root>/system/chassis/motherboard/cpu0/core5',
+ 0x28 : '<inventory_root>/system/chassis/motherboard/cpu0/core6',
+ 0x29 : '<inventory_root>/system/chassis/motherboard/cpu0/core7',
+ 0x2a : '<inventory_root>/system/chassis/motherboard/cpu0/core8',
+ 0x2b : '<inventory_root>/system/chassis/motherboard/cpu0/core9',
+ 0x2c : '<inventory_root>/system/chassis/motherboard/cpu0/core10',
+ 0x2d : '<inventory_root>/system/chassis/motherboard/cpu0/core11',
+ 0x2e : '<inventory_root>/system/chassis/motherboard/centaur0',
+ 0x1e : '<inventory_root>/system/chassis/motherboard/dimm0',
+ 0x1f : '<inventory_root>/system/chassis/motherboard/dimm1',
+ 0x20 : '<inventory_root>/system/chassis/motherboard/dimm2',
+ 0x21 : '<inventory_root>/system/chassis/motherboard/dimm3',
+ 0x09 : '/org/openbmc/sensor/virtual/BootCount',
+ 0x05 : '/org/openbmc/sensor/virtual/BootProgress',
+ 0x04 : '/org/openbmc/sensor/virtual/HostStatus',
+ 0x08 : '/org/openbmc/sensor/virtual/OccStatus',
+ 0x32 : '/org/openbmc/sensor/virtual/OperatingSystemStatus',
+ }
+}
diff --git a/lib/resource.txt b/lib/resource.txt
index fd10050..85bf2fd 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -6,10 +6,10 @@ Library OperatingSystem
Variables ../data/variables.py
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 9.3.164.161
${DBUS_PREFIX} ${EMPTY}
${PORT} ${EMPTY}
-${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${AUTH_URI} http://${OPENBMC_HOST}
${OPENBMC_USERNAME} root
${OPENBMC_PASSWORD} 0penBmc
${MACHINE_TYPE} palmetto
@@ -18,3 +18,7 @@ ${MACHINE_TYPE} palmetto
Get Inventory Schema
[Arguments] ${machine}
[Return] &{INVENTORY}[${machine}]
+
+Get Sensor Schema
+ [Arguments] ${machine}
+ [Return] &{SENSORS}[${machine}]
\ No newline at end of file
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
new file mode 100644
index 0000000..b36b059
--- /dev/null
+++ b/tests/test_sensors.robot
@@ -0,0 +1,56 @@
+*** Settings ***
+Documentation This example demonstrates executing commands on a remote machine
+... and getting their output and the return code.
+...
+... Notice how connections are handled as part of the suite setup and
+... teardown. This saves some time when executing several test cases.
+
+Resource ../lib/rest_client.robot
+
+
+Library SSHLibrary
+Suite Setup Open Connection And Log In
+Suite Teardown Close All Connections
+
+*** Variables ***
+${HOST} 9.3.164.147
+${USERNAME} root
+${PASSWORD} 0penBmc
+
+*** Test Cases ***
+Execute Command And Verify Output
+ [Documentation] Execute Command on the remote machine.
+ ${output}= Execute Command echo Hello
+ Should Be Equal ${output} Hello
+
+Execute Sending a file
+ put file ./tfile /home/root
+
+Execute ipmi BT capabilities command
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
+
+Execute Boot Sensoripmi BT capabilities command
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
+
+Execute Set Sensor boot count
+ Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
+ ${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
+ Should Be Equal ${value} "53"
+
+
+
+*** Keywords ***
+Open Connection And Log In
+ Open Connection ${HOST}
+ Login ${USERNAME} ${PASSWORD}
+
+Run IPMI Command
+ [arguments] ${args}
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 12/60] fixed errors in tox and generate_argumentfile.sh script
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (10 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 11/60] base add for sensor tests OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 13/60] fixed review comments OpenBMC Patches
` (49 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 1 +
tools/generate_argumentfile.sh | 2 +-
tox.ini | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 8aea548..eb901c8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+*.pyc
/log.html
/output.xml
/report.html
diff --git a/tools/generate_argumentfile.sh b/tools/generate_argumentfile.sh
index 518a48f..4869261 100755
--- a/tools/generate_argumentfile.sh
+++ b/tools/generate_argumentfile.sh
@@ -2,4 +2,4 @@
echo "--variable OPENBMC_HOST:$OPENBMC_HOST" > $ARG_FILE
echo "--variable OPENBMC_USERNAME:$OPENBMC_USERNAME" >> $ARG_FILE
-echo "--variable OPENBMC_HOST:$OPENBMC_HOST" >> $ARG_FILE
+echo "--variable OPENBMC_PASSWORD:$OPENBMC_PASSWORD" >> $ARG_FILE
diff --git a/tox.ini b/tox.ini
index 75ab527..fa0d198 100644
--- a/tox.ini
+++ b/tox.ini
@@ -8,12 +8,14 @@ whitelist_externals = *
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/requirements.txt
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
[testenv:full]
deps = {[testenv]deps}
setenv = {[testenv]setenv}
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} .
[testenv:tests]
@@ -27,4 +29,5 @@ commands =
deps = {[testenv]deps}
setenv = {[testenv]setenv}
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 13/60] fixed review comments
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (11 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 12/60] fixed errors in tox and generate_argumentfile.sh script OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 14/60] created loops for tests OpenBMC Patches
` (48 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
tests/test_sensors.robot | 33 ++++++++++-----------------------
1 file changed, 10 insertions(+), 23 deletions(-)
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index b36b059..79ba4d7 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -5,7 +5,7 @@ Documentation This example demonstrates executing commands on a remote
... Notice how connections are handled as part of the suite setup and
... teardown. This saves some time when executing several test cases.
-Resource ../lib/rest_client.robot
+Resource ../lib/rest_client.robot
Library SSHLibrary
@@ -13,42 +13,29 @@ Suite Setup Open Connection And Log In
Suite Teardown Close All Connections
*** Variables ***
-${HOST} 9.3.164.147
-${USERNAME} root
-${PASSWORD} 0penBmc
-*** Test Cases ***
-Execute Command And Verify Output
- [Documentation] Execute Command on the remote machine.
- ${output}= Execute Command echo Hello
- Should Be Equal ${output} Hello
-
-Execute Sending a file
- put file ./tfile /home/root
+*** Test Cases ***
Execute ipmi BT capabilities command
- ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
-
-Execute Boot Sensoripmi BT capabilities command
- ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
+ ${output}= Run IPMI command 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
- Should Be Equal ${value} "53"
+ Should Be Equal ${value} "53"
*** Keywords ***
Open Connection And Log In
- Open Connection ${HOST}
- Login ${USERNAME} ${PASSWORD}
+ Open connection ${OPENBMC_HOST}
+ Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
Run IPMI Command
- [arguments] ${args}
- ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+ [arguments] ${args}
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+ [return] ${output}
Read attribute
[arguments] ${uri} ${attr}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 14/60] created loops for tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (12 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 13/60] fixed review comments OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 15/60] Add initial rest test cases Support to test Null properties OpenBMC Patches
` (47 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 4 ++++
lib/resource.txt | 4 ++++
tests/test_inventory.robot | 26 +++++++++++++-------------
3 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/data/variables.py b/data/variables.py
index 820a251..a342701 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -28,6 +28,10 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard",
"/org/openbmc/inventory/system/chassis/motherboard/bmc",
"/org/openbmc/inventory/system/chassis/fan3"],
+}
+
+
+INVENTORY_ITEMS={
"DIMM" : [ "Asset Tag",
"Custom Field 1",
diff --git a/lib/resource.txt b/lib/resource.txt
index 85bf2fd..a8b8614 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -19,6 +19,10 @@ Get Inventory Schema
[Arguments] ${machine}
[Return] &{INVENTORY}[${machine}]
+Get Inventory Items Schema
+ [Arguments] ${machine}
+ [Return] &{INVENTORY_ITEMS}[${machine}]
+
Get Sensor Schema
[Arguments] ${machine}
[Return] &{SENSORS}[${machine}]
\ No newline at end of file
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index f326a72..fde52e1 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -4,6 +4,8 @@ Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
Resource ../lib/resource.txt
+Library String
+
*** Test Cases ***
List Inventory
${resp} = OpenBMC Get Request /org/openbmc/inventory/list
@@ -14,29 +16,27 @@ List Inventory
\ Should Contain ${jsondata} ${ELEMENT}
-Verify dimm0 vpd
- ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fru_type
- Should Be Equal ${value} "DIMM"
+Verify dimm vpd
+ : FOR ${INDEX} IN RANGE 0 4
+ \ log ${INDEX}
+ \ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
+ \ Should Be Equal ${value} "DIMM"
-Verify dimm1 vpd
- ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm1 fru_type
- Should Be Equal ${value} "DIMM"
+Verify dimm vpd properties
+ : FOR ${INDEX} IN RANGE 0 4
+ \ log ${INDEX}
+ \ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX}
+ \ Should Be Valid Dimm Properties ${props}
-Verify dimm0 properties
- ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm0
- Should Be Valid Dimm Properties ${props}
-Verify dimm1 properties
- ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm1
- Should Be Valid Dimm Properties ${props}
*** Keywords ***
Should Be Valid Dimm Properties
[arguments] ${props}
- ${ret}= Get Inventory Schema DIMM
+ ${ret}= Get Inventory Items Schema DIMM
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${props} ${ELEMENT}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 15/60] Add initial rest test cases Support to test Null properties
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (13 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 14/60] created loops for tests OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 16/60] Moved Read Attribute and Read Properties to rest_client OpenBMC Patches
` (46 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
tests/test_obmcrest.robot | 65 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
create mode 100644 tests/test_obmcrest.robot
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
new file mode 100644
index 0000000..0c3d5ea
--- /dev/null
+++ b/tests/test_obmcrest.robot
@@ -0,0 +1,65 @@
+*** Settings ***
+Documentation This suite will verifiy all OpenBMC rest interfaces
+... Details of valid interfaces can be found here...
+... https://github.com/openbmc/docs/blob/master/rest-api.md
+
+Resource ../lib/rest_client.robot
+
+
+*** Variables ***
+
+
+*** Test Cases ***
+Good connection for testing
+ ${resp} = Read Properties /
+ ${jdata}= To Json ${resp.content}
+ ${c}= get from List ${jdata} 0
+ Should Contain "/org" ${c}
+
+
+Get an object with no properties
+ ${resp} = Read Properties /org/openbmc/inventory
+ Should Be Empty ${resp.content}
+
+
+Get a Property
+ ${resp} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ Should Contain 1 ${resp}
+
+
+Get a null Property
+ ${resp} = Read attribute /org/openbmc/inventory is_fru
+ Should Contain 1 ${resp}
+
+
+Enumeration object
+
+
+List object
+
+
+Invoke a method without properties
+
+
+Invoke a method with properties
+
+
+Issue a POST
+
+
+Issue a PUT
+
+
+
+
+
+*** Keywords ***
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ [return] ${resp}
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 16/60] Moved Read Attribute and Read Properties to rest_client
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (14 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 15/60] Add initial rest test cases Support to test Null properties OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 17/60] fix review comment OpenBMC Patches
` (45 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 13 +++++++++++++
tests/test_inventory.robot | 14 +-------------
tests/test_obmcrest.robot | 24 +++++++-----------------
tests/test_sensors.robot | 7 +------
4 files changed, 22 insertions(+), 36 deletions(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index b972195..f0c1ba3 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -102,3 +102,16 @@ Log Response
Logging
[Arguments] ${msg} ${console}=default False
Log ${msg} console=True
+
+Read Attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
+
+
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${content}= To Json ${resp.content}
+ [return] ${content}
\ No newline at end of file
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index fde52e1..afe4613 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -19,7 +19,7 @@ List Inventory
Verify dimm vpd
: FOR ${INDEX} IN RANGE 0 4
\ log ${INDEX}
- \ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
+ \ ${value} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
\ Should Be Equal ${value} "DIMM"
@@ -39,15 +39,3 @@ Should Be Valid Dimm Properties
${ret}= Get Inventory Items Schema DIMM
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${props} ${ELEMENT}
-
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
-
-
-Read Properties
- [arguments] ${uri}
- ${resp} = OpenBMC Get Request ${uri}
- [return] ${resp.content}
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 0c3d5ea..75eb6d9 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -11,24 +11,23 @@ Resource ../lib/rest_client.robot
*** Test Cases ***
Good connection for testing
- ${resp} = Read Properties /
- ${jdata}= To Json ${resp.content}
- ${c}= get from List ${jdata} 0
- Should Contain "/org" ${c}
+ ${content} = Read Properties /
+ ${c}= get from List ${content} 0
+ Should Contain "/org" ${c}
Get an object with no properties
- ${resp} = Read Properties /org/openbmc/inventory
- Should Be Empty ${resp.content}
+ ${content} = Read Properties /org/openbmc/inventory
+ Should Not Be Empty ${content}
Get a Property
- ${resp} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ ${resp} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
Should Contain 1 ${resp}
Get a null Property
- ${resp} = Read attribute /org/openbmc/inventory is_fru
+ ${resp} = Read Attribute /org/openbmc/inventory is_fru
Should Contain 1 ${resp}
@@ -54,12 +53,3 @@ Issue a PUT
*** Keywords ***
-Read Properties
- [arguments] ${uri}
- ${resp} = OpenBMC Get Request ${uri}
- [return] ${resp}
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
\ No newline at end of file
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 79ba4d7..3d17360 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -22,7 +22,7 @@ Execute ipmi BT capabilities command
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
- ${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
+ ${value} = Read Attribute /org/openbmc/sensor/virtual/BootCount value
Should Be Equal ${value} "53"
@@ -36,8 +36,3 @@ Run IPMI Command
[arguments] ${args}
${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
[return] ${output}
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 17/60] fix review comment
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (15 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 16/60] Moved Read Attribute and Read Properties to rest_client OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 18/60] Added full sensor suite OpenBMC Patches
` (44 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_obmcrest.robot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 75eb6d9..caf9085 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -18,7 +18,7 @@ Good connection for testing
Get an object with no properties
${content} = Read Properties /org/openbmc/inventory
- Should Not Be Empty ${content}
+ Should Be Empty ${content}
Get a Property
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 18/60] Added full sensor suite
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (16 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 17/60] fix review comment OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 19/60] Update README.md OpenBMC Patches
` (43 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
corrected cpu sensor#
---
tests/test_sensors.robot | 188 ++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 177 insertions(+), 11 deletions(-)
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 3d17360..a50805a 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -5,34 +5,200 @@ Documentation This example demonstrates executing commands on a remote
... Notice how connections are handled as part of the suite setup and
... teardown. This saves some time when executing several test cases.
-Resource ../lib/rest_client.robot
+Resource ../lib/rest_client.robot
Library SSHLibrary
Suite Setup Open Connection And Log In
Suite Teardown Close All Connections
+
*** Variables ***
*** Test Cases ***
+Verify connection
+ Execute new Command echo "hello"
+ Response Should Be Equal "hello"
+
+
Execute ipmi BT capabilities command
- ${output}= Run IPMI command 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
+ Run IPMI command 0x06 0x36
+ response Should Be Equal " 01 3f 3f 0a 01"
+
Execute Set Sensor boot count
- Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
- ${value} = Read Attribute /org/openbmc/sensor/virtual/BootCount value
- Should Be Equal ${value} "53"
+ Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
+ Read the Attribute /org/openbmc/sensor/virtual/BootCount value
+ Response Should Be Equal "53"
+
+
+Set Sensor Boot progress
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x14 0x00
+ Read the Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Progress, Baseboard Init"
+
+
+
+Set Sensor Boot progress Longest string
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x0e 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Progress, Docking station attachment"
+
+
+BootProgress sensor FW Hang unspecified Error
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Hang, Unspecified"
+
+
+BootProgress fw hang state
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "POST Error, unknown"
+
+
+OperatingSystemStatus Sensor boot completed progress
+ Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
+ Response Should Be Equal "Boot completed (00)"
+
+
+OperatingSystemStatus Sensor progress
+ Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x04 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
+ Response Should Be Equal "PXE boot completed"
+
+
+OCC Active sensor on enabled
+ Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
+ Response Should Be Equal "Enabled"
+
+
+OCC Active sensor on disabled
+ Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
+ Response Should Be Equal "Disabled"
+
+
+CPU Present
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
+ Response Should Be Equal "True"
+
+CPU not Present
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
+ Response Should Be Equal "False"
+
+
+CPU fault
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
+ Response Should Be Equal "True"
+
+
+CPU no fault
+ Run IPMI command 0x04 0x30 0x2f 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
+ Response Should Be Equal ""
+
+
+core Present
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
+ Response Should Be Equal "True"
+
+core not Present
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
+ Response Should Be Equal "False"
+
+
+core fault
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
+ Response Should Be Equal "True"
+
+
+core no fault
+ Run IPMI command 0x04 0x30 0x2d 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
+ Response Should Be Equal ""
+
+
+DIMM3 Present
+ Run IPMI command 0x04 0x30 0x21 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
+ Response Should Be Equal "True"
+
+DIMM3 not Present
+ Run IPMI command 0x04 0x30 0x21 0xa9 0xff 0x00 0x00 0x40 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
+ Response Should Be Equal "False"
+
+
+DIMM0 fault
+ Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
+ Response Should Be Equal "True"
+
+
+DIMM0 no fault
+ Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
+ Response Should Be Equal ""
+
+
+
+Centaur0 Present
+ Run IPMI command 0x04 0x30 0x2e 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
+ Response Should Be Equal "True"
+
+Centaur0 not Present
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
+ Response Should Be Equal "False"
+
+
+Centaur0 fault
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
+ Response Should Be Equal "True"
+
+Centaur0 no fault
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
+ Response Should Be Equal ""
*** Keywords ***
+Execute new Command
+ [arguments] ${args}
+ ${output}= Execute Command ${args}
+ set test variable ${OUTPUT} "${output}"
+
+response Should Be Equal
+ [arguments] ${args}
+ Should Be Equal ${OUTPUT} ${args}
+
+
+Read the Attribute
+ [arguments] ${uri} ${parm}
+ ${output} = Read Attribute ${uri} ${parm}
+ set test variable ${OUTPUT} ${output}
+
+
Open Connection And Log In
- Open connection ${OPENBMC_HOST}
- Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
+ Open connection ${OPENBMC_HOST}
+ Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
Run IPMI Command
- [arguments] ${args}
- ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
- [return] ${output}
+ [arguments] ${args}
+ ${output}= Execute Command /usr/sbin/ipmitool -I dbus raw ${args}
+ set test variable ${OUTPUT} "${output}"
+
+
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 19/60] Update README.md
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (17 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 18/60] Added full sensor suite OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 4:21 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 20/60] Added SSL tests OpenBMC Patches
` (42 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: Chris Austen
From: Chris Austen <causten@users.noreply.github.com>
---
README.md | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/README.md b/README.md
index 5d869a0..cb8bd02 100644
--- a/README.md
+++ b/README.md
@@ -22,3 +22,8 @@ Run tests
```shell
$ tox -e tests
```
+
+It can also be run by pasing variables from the cli...
+```shell
+ $ pybot -v OPENBMC_HOST:<ip> -v OPENBMC_USERNAME:root -v OPENBMC_PASSWORD:0penBmc
+```
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 20/60] Added SSL tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (18 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 19/60] Update README.md OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 21/60] Handle new rest client from Brad OpenBMC Patches
` (41 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 tests/security/test_ssl.robot
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
new file mode 100644
index 0000000..e4eac40
--- /dev/null
+++ b/tests/security/test_ssl.robot
@@ -0,0 +1,28 @@
+*** Settings ***
+Documentation This testsuite is for testing SSL connection to OpenBMC
+Suite Teardown Delete All Sessions
+
+Resource ../lib/rest_client.robot
+Resource ../lib/resource.txt
+
+Library RequestsLibrary.RequestsKeywords
+
+*** Test Cases ***
+Test SSL Connection
+ [Documentation] This testcase is for testing the SSL connection to the
+ ... OpenBMC machine.
+ Create Session openbmc https://${OPENBMC_HOST}/
+ ${resp}= Get Request openbmc https://${OPENBMC_HOST}/org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ Should Not Be Empty ${jsondata}
+
+Test non-SSL Connection - Negative
+ [Documentation] This testcase is for test to check OpenBMC machine
+ ... will not accepts the non-secure connection that is with http.
+ ... Expected Response code is - 400
+ Create Session openbmc http://${OPENBMC_HOST}/
+ ${resp}= Get Request openbmc http://${OPENBMC_HOST}/org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ ${jsondata}= To Json ${resp.content}
+ Should Be Empty ${jsondata}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 21/60] Handle new rest client from Brad
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (19 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 20/60] Added SSL tests OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 22/60] Ran the tests and fixed errors in SSL tests OpenBMC Patches
` (40 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
lib/resource.txt | 2 +-
tests/test_sensors.robot | 7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/resource.txt b/lib/resource.txt
index a8b8614..9d865c3 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -9,7 +9,7 @@ Variables ../data/variables.py
${OPENBMC_HOST} 9.3.164.161
${DBUS_PREFIX} ${EMPTY}
${PORT} ${EMPTY}
-${AUTH_URI} http://${OPENBMC_HOST}
+${AUTH_URI} https://${OPENBMC_HOST}
${OPENBMC_USERNAME} root
${OPENBMC_PASSWORD} 0penBmc
${MACHINE_TYPE} palmetto
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index a50805a..3e84e44 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -188,8 +188,11 @@ response Should Be Equal
Read the Attribute
[arguments] ${uri} ${parm}
- ${output} = Read Attribute ${uri} ${parm}
- set test variable ${OUTPUT} ${output}
+ ${output} = Read Attribute ${uri} ${parm}
+ ${json} = to json ${output}
+ ${data} = get from dictionary ${json} data
+ set test variable ${OUTPUT} "${data}"
+
Open Connection And Log In
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 22/60] Ran the tests and fixed errors in SSL tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (20 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 21/60] Handle new rest client from Brad OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 23/60] Modified the doc OpenBMC Patches
` (39 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index e4eac40..0504567 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -2,8 +2,8 @@
Documentation This testsuite is for testing SSL connection to OpenBMC
Suite Teardown Delete All Sessions
-Resource ../lib/rest_client.robot
-Resource ../lib/resource.txt
+Resource ../../lib/rest_client.robot
+Resource ../../lib/resource.txt
Library RequestsLibrary.RequestsKeywords
@@ -12,7 +12,7 @@ Test SSL Connection
[Documentation] This testcase is for testing the SSL connection to the
... OpenBMC machine.
Create Session openbmc https://${OPENBMC_HOST}/
- ${resp}= Get Request openbmc https://${OPENBMC_HOST}/org/openbmc/inventory/list
+ ${resp}= Get Request openbmc /list
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
Should Not Be Empty ${jsondata}
@@ -22,7 +22,4 @@ Test non-SSL Connection - Negative
... will not accepts the non-secure connection that is with http.
... Expected Response code is - 400
Create Session openbmc http://${OPENBMC_HOST}/
- ${resp}= Get Request openbmc http://${OPENBMC_HOST}/org/openbmc/inventory/list
- Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
- ${jsondata}= To Json ${resp.content}
- Should Be Empty ${jsondata}
\ No newline at end of file
+ Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 23/60] Modified the doc
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (21 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 22/60] Ran the tests and fixed errors in SSL tests OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 24/60] Added firmware version validation test OpenBMC Patches
` (38 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index 0504567..3c098b0 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -20,6 +20,6 @@ Test SSL Connection
Test non-SSL Connection - Negative
[Documentation] This testcase is for test to check OpenBMC machine
... will not accepts the non-secure connection that is with http.
- ... Expected Response code is - 400
+ ... Expected a connection error when we try making a call
Create Session openbmc http://${OPENBMC_HOST}/
Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 24/60] Added firmware version validation test
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (22 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 23/60] Modified the doc OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 25/60] update readme file with tox version OpenBMC Patches
` (37 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_fw_version.robot | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 tests/test_fw_version.robot
diff --git a/tests/test_fw_version.robot b/tests/test_fw_version.robot
new file mode 100644
index 0000000..2c3337d
--- /dev/null
+++ b/tests/test_fw_version.robot
@@ -0,0 +1,22 @@
+*** Settings ***
+Documentation This suite will the firmware version exposed part of
+... system inventory
+
+Resource ../lib/rest_client.robot
+
+
+*** Variables ***
+
+
+*** Test Cases ***
+Test Firmware Version
+ [Documentation] This testcase is for testing the fw version.\n
+ ... Expected in following format:
+ ... $ git describe --dirty
+ ... v0.1-34-g95f7347
+ ... $
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/system
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ Should not be empty ${jsondata["data"]["Version"]}
+ Should Match Regexp ${jsondata["data"]["Version"]} ^v\\d+\.\\d+
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 25/60] update readme file with tox version
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (23 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 24/60] Added firmware version validation test OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 26/60] Fix errors OpenBMC Patches
` (36 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index cb8bd02..56048d7 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,8 @@ packages which will help to invoke tests through tox.
Install the python dependencies for tox
```shell
- $easy_install tox pip
+ $ easy_install tox==2.1.1
+ $ easy_install pip
```
Initilize the following environment variable which will used while testing
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 26/60] Fix errors
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (24 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 25/60] update readme file with tox version OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 27/60] Fix Errors in test_obmcrest.robot and removed the empty testcases OpenBMC Patches
` (35 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 5 +--
tests/test_fan.robot | 3 --
tests/test_inventory.robot | 4 +--
tests/test_sensors.robot | 84 ++++++++++++++++------------------------------
4 files changed, 33 insertions(+), 63 deletions(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index f0c1ba3..5cd71b2 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -106,7 +106,8 @@ Logging
Read Attribute
[arguments] ${uri} ${attr}
${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
+ ${content}= To Json ${resp.content}
+ [return] ${content["data"]}
Read Properties
@@ -114,4 +115,4 @@ Read Properties
${resp} = OpenBMC Get Request ${uri}
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${content}= To Json ${resp.content}
- [return] ${content}
\ No newline at end of file
+ [return] ${content["data"]}
\ No newline at end of file
diff --git a/tests/test_fan.robot b/tests/test_fan.robot
index 61255e6..2f593b5 100644
--- a/tests/test_fan.robot
+++ b/tests/test_fan.robot
@@ -4,6 +4,3 @@ Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
*** Test Cases ***
-List all the fans
- ${resp} = OpenBMC Get Request /org.openbmc.control.Fan/
- Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index afe4613..3bb8f9c 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -13,14 +13,14 @@ List Inventory
${jsondata}= To Json ${resp.content}
${ret}= Get Inventory Schema ${MACHINE_TYPE}
: FOR ${ELEMENT} IN @{ret}
- \ Should Contain ${jsondata} ${ELEMENT}
+ \ Should Contain ${jsondata["data"]} ${ELEMENT}
Verify dimm vpd
: FOR ${INDEX} IN RANGE 0 4
\ log ${INDEX}
\ ${value} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
- \ Should Be Equal ${value} "DIMM"
+ \ Should Be Equal ${value} DIMM
Verify dimm vpd properties
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 3e84e44..945fb47 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -21,158 +21,134 @@ Verify connection
Execute new Command echo "hello"
Response Should Be Equal "hello"
-
Execute ipmi BT capabilities command
Run IPMI command 0x06 0x36
response Should Be Equal " 01 3f 3f 0a 01"
-
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
Read the Attribute /org/openbmc/sensor/virtual/BootCount value
- Response Should Be Equal "53"
-
+ Response Should Be Equal 53
Set Sensor Boot progress
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x14 0x00
Read the Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Progress, Baseboard Init"
-
-
+ Response Should Be Equal FW Progress, Baseboard Init
Set Sensor Boot progress Longest string
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x0e 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Progress, Docking station attachment"
-
+ Response Should Be Equal FW Progress, Docking station attachment
BootProgress sensor FW Hang unspecified Error
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Hang, Unspecified"
-
+ Response Should Be Equal FW Hang, Unspecified
BootProgress fw hang state
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "POST Error, unknown"
-
+ Response Should Be Equal POST Error, unknown
OperatingSystemStatus Sensor boot completed progress
Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
- Response Should Be Equal "Boot completed (00)"
-
+ Response Should Be Equal Boot completed (00)
OperatingSystemStatus Sensor progress
Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x04 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
- Response Should Be Equal "PXE boot completed"
-
+ Response Should Be Equal PXE boot completed
OCC Active sensor on enabled
Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
- Response Should Be Equal "Enabled"
-
+ Response Should Be Equal Enabled
OCC Active sensor on disabled
Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
- Response Should Be Equal "Disabled"
-
+ Response Should Be Equal Disabled
CPU Present
Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
CPU not Present
Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
CPU fault
Run IPMI command 0x04 0x30 0x2f 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
CPU no fault
Run IPMI command 0x04 0x30 0x2f 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
core Present
Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
core not Present
Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
core fault
Run IPMI command 0x04 0x30 0x2d 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
core no fault
Run IPMI command 0x04 0x30 0x2d 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
DIMM3 Present
Run IPMI command 0x04 0x30 0x21 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
DIMM3 not Present
Run IPMI command 0x04 0x30 0x21 0xa9 0xff 0x00 0x00 0x40 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
DIMM0 fault
Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
DIMM0 no fault
Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
- Response Should Be Equal ""
-
-
+ Response Should Be Empty
Centaur0 Present
Run IPMI command 0x04 0x30 0x2e 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
Centaur0 not Present
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
Centaur0 fault
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
- Response Should Be Equal "True"
+ Response Should Be Equal True
Centaur0 no fault
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
*** Keywords ***
@@ -185,15 +161,13 @@ response Should Be Equal
[arguments] ${args}
Should Be Equal ${OUTPUT} ${args}
+Response Should Be Empty
+ Should Be Empty ${OUTPUT}
Read the Attribute
[arguments] ${uri} ${parm}
${output} = Read Attribute ${uri} ${parm}
- ${json} = to json ${output}
- ${data} = get from dictionary ${json} data
- set test variable ${OUTPUT} "${data}"
-
-
+ set test variable ${OUTPUT} ${output}
Open Connection And Log In
Open connection ${OPENBMC_HOST}
@@ -203,5 +177,3 @@ Run IPMI Command
[arguments] ${args}
${output}= Execute Command /usr/sbin/ipmitool -I dbus raw ${args}
set test variable ${OUTPUT} "${output}"
-
-
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 27/60] Fix Errors in test_obmcrest.robot and removed the empty testcases.
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (25 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 26/60] Fix errors OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 28/60] Added one more testcase to test non-ssl connection to port 443 OpenBMC Patches
` (34 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_obmcrest.robot | 47 +++++++++++------------------------------------
1 file changed, 11 insertions(+), 36 deletions(-)
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index caf9085..382107f 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -11,45 +11,20 @@ Resource ../lib/rest_client.robot
*** Test Cases ***
Good connection for testing
- ${content} = Read Properties /
- ${c}= get from List ${content} 0
- Should Contain "/org" ${c}
-
+ ${content}= Read Properties /
+ ${c}= get from List ${content} 0
+ Should Be Equal ${c} /org
Get an object with no properties
- ${content} = Read Properties /org/openbmc/inventory
- Should Be Empty ${content}
-
+ ${content}= Read Properties /org/openbmc/inventory
+ Should Be Empty ${content}
Get a Property
- ${resp} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
- Should Contain 1 ${resp}
-
+ ${resp}= Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ Should Be Equal ${resp} ${1}
Get a null Property
- ${resp} = Read Attribute /org/openbmc/inventory is_fru
- Should Contain 1 ${resp}
-
-
-Enumeration object
-
-
-List object
-
-
-Invoke a method without properties
-
-
-Invoke a method with properties
-
-
-Issue a POST
-
-
-Issue a PUT
-
-
-
-
-
-*** Keywords ***
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/attr/is_fru
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${jsondata}= To Json ${resp.content}
+ Should Be Equal ${jsondata['data']['description']} The specified property cannot be found: ''is_fru''
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 28/60] Added one more testcase to test non-ssl connection to port 443
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (26 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 27/60] Fix Errors in test_obmcrest.robot and removed the empty testcases OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 29/60] OpenBMC REST Testing OpenBMC Patches
` (33 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index 3c098b0..b376a62 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -17,9 +17,18 @@ Test SSL Connection
${jsondata}= To Json ${resp.content}
Should Not Be Empty ${jsondata}
-Test non-SSL Connection - Negative
+Test non-SSL Connection to port 80
[Documentation] This testcase is for test to check OpenBMC machine
- ... will not accepts the non-secure connection that is with http.
- ... Expected a connection error when we try making a call
+ ... will not accepts the non-secure connection that is with http to
+ ... port 80 and expect a connection error
Create Session openbmc http://${OPENBMC_HOST}/
Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
+
+Test non-SSL Connection to port 443
+ [Documentation] This testcase is for test to check OpenBMC machine
+ ... will not accepts the non-secure connection that is with http to
+ ... port 443 and expect 400 in response
+ Create Session openbmc http://${OPENBMC_HOST}:443/
+ ${resp}= Get Request openbmc /list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ Should Be Equal ${resp.content} Bad Request
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 29/60] OpenBMC REST Testing
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (27 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 28/60] Added one more testcase to test non-ssl connection to port 443 OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 30/60] updated the REST API for firmware version OpenBMC Patches
` (32 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 11 ++
requirements.txt | 2 +-
tests/test_obmcrest.robot | 283 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 295 insertions(+), 1 deletion(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 5cd71b2..02a7a11 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -70,6 +70,8 @@ OpenBMC Get Request
OpenBMC Post Request
[Arguments] ${uri} &{kwargs}
${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ ${headers}= Create Dictionary Content-Type=application/json
+ set to dictionary ${kwargs} headers ${headers}
Log Request method=Post base_uri=${base_uri} args=&{kwargs}
Initialize OpenBMC
${ret}= Post Request openbmc ${base_uri} &{kwargs}
@@ -85,6 +87,15 @@ OpenBMC Put Request
Log Response ${ret}
[Return] ${ret}
+OpenBMC Delete Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Delete base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Put Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
Initialize OpenBMC
Create Session openbmc ${AUTH_URI}
diff --git a/requirements.txt b/requirements.txt
index 8434d52..1459b74 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
robotframework
requests
-robotframework-requests
+robotframework-requests>=0.3.9
robotframework-sshlibrary
\ No newline at end of file
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 382107f..50fe6b2 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -28,3 +28,286 @@ Get a null Property
Should Be Equal As Strings ${resp.status_code} ${HTTP_NOT_FOUND}
${jsondata}= To Json ${resp.content}
Should Be Equal ${jsondata['data']['description']} The specified property cannot be found: ''is_fru''
+
+get directory listing /
+ ${resp} = openbmc get request /
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org
+ should be equal as strings ${json['status']} ok
+
+get directory listing /org/
+ ${resp} = openbmc get request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc
+ should be equal as strings ${json['status']} ok
+
+get invalid directory listing /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put directory listing /
+ ${resp} = openbmc put request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put directory listing /org/
+ ${resp} = openbmc put request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid directory listing /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post directory listing /
+ ${resp} = openbmc post request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post directory listing /org/
+ ${resp} = openbmc post request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid directory listing /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete directory listing /
+ ${resp} = openbmc delete request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete directory listing /org/
+ ${resp} = openbmc delete request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid directory listing /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get list names /
+ ${resp} = openbmc get request /list
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get list names /org/
+ ${resp} = openbmc get request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get invalid list names /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put list names /
+ ${resp} = openbmc put request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put list names /org/
+ ${resp} = openbmc put request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid list names /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post list names /
+ ${resp} = openbmc post request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post list names /org/
+ ${resp} = openbmc post request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid list names /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete list names /
+ ${resp} = openbmc delete request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete list names /org/
+ ${resp} = openbmc delete request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid list names /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get names /
+ ${resp} = openbmc get request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get names /org/
+ ${resp} = openbmc get request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get invalid names /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put names /
+ ${resp} = openbmc put request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put names /org/
+ ${resp} = openbmc put request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid names /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post names /
+ ${resp} = openbmc post request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post names /org/
+ ${resp} = openbmc post request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid names /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete names /
+ ${resp} = openbmc delete request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete names /org/
+ ${resp} = openbmc delete request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid names /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc get request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get invalid method /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/action/foo
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc put request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid method /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/action/foo
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post method /org/openbmc/control/fan0/action/getspeed no args
+ ${data} = create dictionary data=@{EMPTY}
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/getspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} ok
+
+post method /org/openbmc/control/fan0/action/setspeed invalid args
+ ${data} = create dictionary foo=bar
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/setspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post method /org/openbmc/control/fan0/action/setspeed with args
+ ${SPEED}= Set Variable ${200}
+ @{speed_list} = Create List ${SPEED}
+ ${data} = create dictionary data=@{speed_list}
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/setspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} ok
+ ${content}= Read Attribute /org/openbmc/control/fan0 speed
+ Should Be Equal ${content} ${SPEED}
+
+delete method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc delete request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid method /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/action/foomethod
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 30/60] updated the REST API for firmware version
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (28 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 29/60] OpenBMC REST Testing OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 31/60] first commit OpenBMC Patches
` (31 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_fw_version.robot | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test_fw_version.robot b/tests/test_fw_version.robot
index 2c3337d..90721b7 100644
--- a/tests/test_fw_version.robot
+++ b/tests/test_fw_version.robot
@@ -15,8 +15,8 @@ Test Firmware Version
... $ git describe --dirty
... v0.1-34-g95f7347
... $
- ${resp} = OpenBMC Get Request /org/openbmc/inventory/system
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/system/chassis/motherboard/bmc
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
- Should not be empty ${jsondata["data"]["Version"]}
- Should Match Regexp ${jsondata["data"]["Version"]} ^v\\d+\.\\d+
\ No newline at end of file
+ Should not be empty ${jsondata["data"]["version"]}
+ Should Match Regexp ${jsondata["data"]["version"]} ^v\\d+\.\\d+
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 31/60] first commit
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (29 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 30/60] updated the REST API for firmware version OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-12 5:07 ` Stewart Smith
2016-01-11 16:49 ` [PATCH openbmc-test-automation 32/60] added files OpenBMC Patches
` (30 subsequent siblings)
61 siblings, 1 reply; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: Manjunath Kumatagi
From: Manjunath Kumatagi <manjunath@oc1275007250.ibm.com>
---
README.md | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 README.md
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..e69de29
--
2.6.4
^ permalink raw reply [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 32/60] added files
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (30 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 31/60] first commit OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:49 ` [PATCH openbmc-test-automation 33/60] Update README.md OpenBMC Patches
` (29 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
.project | 17 ++++++++
.pydevproject | 7 ++++
lib/resource.txt | 12 ++++++
lib/rest_client.robot | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++
requirements.txt | 4 ++
tests/data.json | 1 +
tests/test_fan.robot | 9 +++++
tests/test_ssh.robot | 55 +++++++++++++++++++++++++
tox.ini | 32 +++++++++++++++
9 files changed, 246 insertions(+)
create mode 100644 .project
create mode 100644 .pydevproject
create mode 100644 lib/resource.txt
create mode 100644 lib/rest_client.robot
create mode 100644 requirements.txt
create mode 100755 tests/data.json
create mode 100644 tests/test_fan.robot
create mode 100644 tests/test_ssh.robot
create mode 100644 tox.ini
diff --git a/.project b/.project
new file mode 100644
index 0000000..9b83158
--- /dev/null
+++ b/.project
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+ <name>openbmc-automation</name>
+ <comment></comment>
+ <projects>
+ </projects>
+ <buildSpec>
+ <buildCommand>
+ <name>org.python.pydev.PyDevBuilder</name>
+ <arguments>
+ </arguments>
+ </buildCommand>
+ </buildSpec>
+ <natures>
+ <nature>org.python.pydev.pythonNature</nature>
+ </natures>
+</projectDescription>
diff --git a/.pydevproject b/.pydevproject
new file mode 100644
index 0000000..08ea93f
--- /dev/null
+++ b/.pydevproject
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?><?eclipse-pydev version="1.0"?><pydev_project>
+<pydev_pathproperty name="org.python.pydev.PROJECT_SOURCE_PATH">
+<path>/${PROJECT_DIR_NAME}</path>
+</pydev_pathproperty>
+<pydev_property name="org.python.pydev.PYTHON_PROJECT_VERSION">python 2.7</pydev_property>
+<pydev_property name="org.python.pydev.PYTHON_PROJECT_INTERPRETER">Default</pydev_property>
+</pydev_project>
\ No newline at end of file
diff --git a/lib/resource.txt b/lib/resource.txt
new file mode 100644
index 0000000..5acddcf
--- /dev/null
+++ b/lib/resource.txt
@@ -0,0 +1,12 @@
+*** Settings ***
+Library Collections
+Library String
+Library RequestsLibrary.RequestsKeywords
+Library OperatingSystem
+
+*** Variables ***
+${HOST} 192.168.122.100 # openbmc ip address
+${PORT} 3000
+${AUTH_URI} http://${HOST}:${PORT}
+${USERNAME} root
+${PASSWORD} abc123
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
new file mode 100644
index 0000000..1de2b77
--- /dev/null
+++ b/lib/rest_client.robot
@@ -0,0 +1,109 @@
+*** Settings ***
+Library Collections
+Library String
+Library RequestsLibrary.RequestsKeywords
+Library OperatingSystem
+
+*** Variables ***
+${HOST} 192.168.122.100 # openbmc ip address
+${DBUS_PREFIX} /bus/session
+${PORT} 3000
+${AUTH_URI} http://${HOST}:${PORT}
+${USERNAME} root
+${PASSWORD} abc123
+# Response codes
+${HTTP_CONTINUE} 100
+${HTTP_SWITCHING_PROTOCOLS} 101
+${HTTP_PROCESSING} 102
+${HTTP_OK} 200
+${HTTP_CREATED} 201
+${HTTP_ACCEPTED} 202
+${HTTP_NON_AUTHORITATIVE_INFORMATION} 203
+${HTTP_NO_CONTENT} 204
+${HTTP_RESET_CONTENT} 205
+${HTTP_PARTIAL_CONTENT} 206
+${HTTP_MULTI_STATUS} 207
+${HTTP_IM_USED} 226
+${HTTP_MULTIPLE_CHOICES} 300
+${HTTP_MOVED_PERMANENTLY} 301
+${HTTP_FOUND} 302
+${HTTP_SEE_OTHER} 303
+${HTTP_NOT_MODIFIED} 304
+${HTTP_USE_PROXY} 305
+${HTTP_TEMPORARY_REDIRECT} 307
+${HTTP_BAD_REQUEST} 400
+${HTTP_UNAUTHORIZED} 401
+${HTTP_PAYMENT_REQUIRED} 402
+${HTTP_FORBIDDEN} 403
+${HTTP_NOT_FOUND} 404
+${HTTP_METHOD_NOT_ALLOWED} 405
+${HTTP_NOT_ACCEPTABLE} 406
+${HTTP_PROXY_AUTHENTICATION_REQUIRED} 407
+${HTTP_REQUEST_TIMEOUT} 408
+${HTTP_CONFLICT} 409
+${HTTP_GONE} 410
+${HTTP_LENGTH_REQUIRED} 411
+${HTTP_PRECONDITION_FAILED} 412
+${HTTP_REQUEST_ENTITY_TOO_LARGE} 413
+${HTTP_REQUEST_URI_TOO_LONG} 414
+${HTTP_UNSUPPORTED_MEDIA_TYPE} 415
+${HTTP_REQUESTED_RANGE_NOT_SATISFIABLE} 416
+${HTTP_EXPECTATION_FAILED} 417
+${HTTP_UNPROCESSABLE_ENTITY} 422
+${HTTP_LOCKED} 423
+${HTTP_FAILED_DEPENDENCY} 424
+${HTTP_UPGRADE_REQUIRED} 426
+${HTTP_INTERNAL_SERVER_ERROR} 500
+${HTTP_NOT_IMPLEMENTED} 501
+${HTTP_BAD_GATEWAY} 502
+${HTTP_SERVICE_UNAVAILABLE} 503
+${HTTP_GATEWAY_TIMEOUT} 504
+${HTTP_HTTP_VERSION_NOT_SUPPORTED} 505
+${HTTP_INSUFFICIENT_STORAGE} 507
+${HTTP_NOT_EXTENDED} 510
+
+*** Keywords ***
+OpenBMC Get Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Get base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Get Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+OpenBMC Post Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Post base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Post Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+OpenBMC Put Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Put base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Put Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
+Initialize OpenBMC
+ Create Session openbmc ${AUTH_URI}
+
+Log Request
+ [Arguments] &{kwargs}
+ ${msg}= Catenate SEPARATOR= URI: ${AUTH_URI} ${kwargs["base_uri"]} , method:
+ ... ${kwargs["method"]} , args: ${kwargs["args"]}
+ Logging ${msg} console=True
+
+Log Response
+ [Arguments] ${resp}
+ ${msg}= Catenate SEPARATOR= Response code: ${resp.status_code} , Content: ${resp.content}
+ Logging ${msg} console=True
+
+Logging
+ [Arguments] ${msg} ${console}=default False
+ Log ${msg} console=True
diff --git a/requirements.txt b/requirements.txt
new file mode 100644
index 0000000..8434d52
--- /dev/null
+++ b/requirements.txt
@@ -0,0 +1,4 @@
+robotframework
+requests
+robotframework-requests
+robotframework-sshlibrary
\ No newline at end of file
diff --git a/tests/data.json b/tests/data.json
new file mode 100755
index 0000000..7bfd886
--- /dev/null
+++ b/tests/data.json
@@ -0,0 +1 @@
+{"two": 2, "one": 1}
diff --git a/tests/test_fan.robot b/tests/test_fan.robot
new file mode 100644
index 0000000..61255e6
--- /dev/null
+++ b/tests/test_fan.robot
@@ -0,0 +1,9 @@
+*** Settings ***
+Documentation This testsuite is for testing fan interface for openbmc
+Suite Teardown Delete All Sessions
+Resource ../lib/rest_client.robot
+
+*** Test Cases ***
+List all the fans
+ ${resp} = OpenBMC Get Request /org.openbmc.control.Fan/
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
new file mode 100644
index 0000000..0801d8a
--- /dev/null
+++ b/tests/test_ssh.robot
@@ -0,0 +1,55 @@
+*** Settings ***
+Documentation This example demonstrates executing commands on a remote machine
+... and getting their output and the return code.
+...
+... Notice how connections are handled as part of the suite setup and
+... teardown. This saves some time when executing several test cases.
+Suite Setup Open Connection And Log In
+Suite Teardown Close All Connections
+Library SSHLibrary
+
+*** Variables ***
+${HOST} 192.168.122.100
+${USERNAME} manjunath
+${PASSWORD} passw0rd
+
+*** Test Cases ***
+Execute Command And Verify Output
+ [Documentation] Execute Command can be used to ran commands on the remote machine.
+ ... The keyword returns the standard output by default.
+ ${output}= Execute Command echo Hello SSHLibrary!
+ Should Be Equal ${output} Hello SSHLibrary!
+
+Execute Command And Verify Return Code
+ [Documentation] Often getting the return code of the command is enough.
+ ... This behaviour can be adjusted as Execute Command arguments.
+ ${rc}= Execute Command echo Success guaranteed. return_stdout=False return_rc=True
+ Should Be Equal ${rc} ${0}
+
+Executing Commands In An Interactive Session
+ [Documentation] Execute Command always executes the command in a new shell.
+ ... This means that changes to the environment are not persisted
+ ... between subsequent Execute Command keyword calls.
+ ... Write and Read Until variants can be used to operate in the same shell.
+ Write cd ..
+ Write echo Hello from the parent directory!
+ ${output}= Read Until directory!
+ Should End With ${output} Hello from the parent directory!
+
+List all the files
+ [Documentation] List all the files in the remote machine
+ ${output} ${stderr} ${rc}= Execute Command ls return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
+
+File Not Found
+ [Documentation] This testcase is for testing ls command with non existing file
+ ${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Should Be Equal ${rc} ${2}
+ Should Contain ${stderr} No such file or directory
+
+*** Keywords ***
+Open Connection And Log In
+ Open Connection ${HOST}
+ Login ${USERNAME} ${PASSWORD}
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..fc08416
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,32 @@
+[tox]
+skipsdist = True
+
+[openbmcenv]
+sitepackages = False
+setenv = VIRTUAL_ENV={envdir}
+deps = setuptools
+ -r{toxinidir}/requirements.txt
+
+[testenv]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run {posargs}
+
+[testenv:full]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run .
+
+[testenv:tests]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run tests
+
+[testenv:custom]
+install_command = pip install -U {opts} {packages}
+deps = -r{toxinidir}/requirements.txt
+commands =
+ python -m robot.run {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 33/60] Update README.md
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (31 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 32/60] added files OpenBMC Patches
@ 2016-01-11 16:49 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 34/60] added log statement OpenBMC Patches
` (28 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:49 UTC (permalink / raw)
To: openbmc
From: mkumatag <mkumatag@in.ibm.com>
---
README.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README.md b/README.md
index e69de29..f491b6c 100644
--- a/README.md
+++ b/README.md
@@ -0,0 +1,2 @@
+#openbmc-automation
+More information needs to be added.
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 34/60] added log statement
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (32 preceding siblings ...)
2016-01-11 16:49 ` [PATCH openbmc-test-automation 33/60] Update README.md OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 35/60] added testcase for etc passwd OpenBMC Patches
` (27 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
tests/test_ssh.robot | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
index 0801d8a..e9dcf9e 100644
--- a/tests/test_ssh.robot
+++ b/tests/test_ssh.robot
@@ -46,6 +46,7 @@ File Not Found
[Documentation] This testcase is for testing ls command with non existing file
${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
Should Be Equal ${rc} ${2}
Should Contain ${stderr} No such file or directory
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 35/60] added testcase for etc passwd
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (33 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 34/60] added log statement OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 36/60] Added git ignore file OpenBMC Patches
` (26 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc; +Cc: manjunath
From: manjunath <manjunath@localhost.localdomain>
---
tests/test_ssh.robot | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
index e9dcf9e..cabcea0 100644
--- a/tests/test_ssh.robot
+++ b/tests/test_ssh.robot
@@ -50,6 +50,14 @@ File Not Found
Should Be Equal ${rc} ${2}
Should Contain ${stderr} No such file or directory
+etc passwd entry
+ [Documentation] This testcase is for testing /etc/passwd entry
+ ${output} ${stderr} ${rc}= Execute Command grep manjunath /etc/passwd return_stderr=True return_rc=True
+ ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
+ Log To Console ${msg}
+ Should Be Equal ${rc} ${0}
+ Should Contain ${output} manjunath
+
*** Keywords ***
Open Connection And Log In
Open Connection ${HOST}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 36/60] Added git ignore file
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (34 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 35/60] added testcase for etc passwd OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 37/60] Use argumnet file with pyrobot and added instructions to READEME file OpenBMC Patches
` (25 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
create mode 100644 .gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..9f23ed1
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+/log.html
+/output.xml
+/report.html
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 37/60] Use argumnet file with pyrobot and added instructions to READEME file.
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (35 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 36/60] Added git ignore file OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 38/60] Update README for better html display OpenBMC Patches
` (24 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 2 ++
README.md | 18 +++++++++++-
lib/resource.txt | 6 ++--
lib/rest_client.robot | 8 +++---
tests/test_ssh.robot | 64 ------------------------------------------
tools/generate_argumentfile.sh | 5 ++++
tox.ini | 30 +++++++++-----------
7 files changed, 45 insertions(+), 88 deletions(-)
delete mode 100644 tests/test_ssh.robot
create mode 100755 tools/generate_argumentfile.sh
diff --git a/.gitignore b/.gitignore
index 9f23ed1..8aea548 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,5 @@
/log.html
/output.xml
/report.html
+/.idea/
+/.tox/
\ No newline at end of file
diff --git a/README.md b/README.md
index f491b6c..589d693 100644
--- a/README.md
+++ b/README.md
@@ -1,2 +1,18 @@
#openbmc-automation
-More information needs to be added.
+
+Quickstart
+----------
+
+To run openbmc-automation first you need to install the prerequisite python
+packages which will help to invoke tests through tox.
+
+1. Install the python dependencies for tox
+ $ easy_install tox pip
+
+2. Initilize the following environment variable which will used while testing
+ $ export OPENBMC_HOST=<openbmc machine ip address>
+ $ export OPENBMC_PASSWORD=<openbmc username>
+ $ export OPENBMC_USERNAME=<openbmc password>
+
+3. Run tests
+ $ tox -e tests
diff --git a/lib/resource.txt b/lib/resource.txt
index 5acddcf..c34e026 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -5,8 +5,8 @@ Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
*** Variables ***
-${HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
${PORT} 3000
${AUTH_URI} http://${HOST}:${PORT}
-${USERNAME} root
-${PASSWORD} abc123
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} abc123
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 1de2b77..45c4226 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -5,12 +5,12 @@ Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
*** Variables ***
-${HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
${DBUS_PREFIX} /bus/session
${PORT} 3000
-${AUTH_URI} http://${HOST}:${PORT}
-${USERNAME} root
-${PASSWORD} abc123
+${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} abc123
# Response codes
${HTTP_CONTINUE} 100
${HTTP_SWITCHING_PROTOCOLS} 101
diff --git a/tests/test_ssh.robot b/tests/test_ssh.robot
deleted file mode 100644
index cabcea0..0000000
--- a/tests/test_ssh.robot
+++ /dev/null
@@ -1,64 +0,0 @@
-*** Settings ***
-Documentation This example demonstrates executing commands on a remote machine
-... and getting their output and the return code.
-...
-... Notice how connections are handled as part of the suite setup and
-... teardown. This saves some time when executing several test cases.
-Suite Setup Open Connection And Log In
-Suite Teardown Close All Connections
-Library SSHLibrary
-
-*** Variables ***
-${HOST} 192.168.122.100
-${USERNAME} manjunath
-${PASSWORD} passw0rd
-
-*** Test Cases ***
-Execute Command And Verify Output
- [Documentation] Execute Command can be used to ran commands on the remote machine.
- ... The keyword returns the standard output by default.
- ${output}= Execute Command echo Hello SSHLibrary!
- Should Be Equal ${output} Hello SSHLibrary!
-
-Execute Command And Verify Return Code
- [Documentation] Often getting the return code of the command is enough.
- ... This behaviour can be adjusted as Execute Command arguments.
- ${rc}= Execute Command echo Success guaranteed. return_stdout=False return_rc=True
- Should Be Equal ${rc} ${0}
-
-Executing Commands In An Interactive Session
- [Documentation] Execute Command always executes the command in a new shell.
- ... This means that changes to the environment are not persisted
- ... between subsequent Execute Command keyword calls.
- ... Write and Read Until variants can be used to operate in the same shell.
- Write cd ..
- Write echo Hello from the parent directory!
- ${output}= Read Until directory!
- Should End With ${output} Hello from the parent directory!
-
-List all the files
- [Documentation] List all the files in the remote machine
- ${output} ${stderr} ${rc}= Execute Command ls return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
-
-File Not Found
- [Documentation] This testcase is for testing ls command with non existing file
- ${output} ${stderr} ${rc}= Execute Command ls file_doesnotexist.txt return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
- Should Be Equal ${rc} ${2}
- Should Contain ${stderr} No such file or directory
-
-etc passwd entry
- [Documentation] This testcase is for testing /etc/passwd entry
- ${output} ${stderr} ${rc}= Execute Command grep manjunath /etc/passwd return_stderr=True return_rc=True
- ${msg}= Catenate output:${output} stderr:${stderr} rc:${rc}
- Log To Console ${msg}
- Should Be Equal ${rc} ${0}
- Should Contain ${output} manjunath
-
-*** Keywords ***
-Open Connection And Log In
- Open Connection ${HOST}
- Login ${USERNAME} ${PASSWORD}
diff --git a/tools/generate_argumentfile.sh b/tools/generate_argumentfile.sh
new file mode 100755
index 0000000..518a48f
--- /dev/null
+++ b/tools/generate_argumentfile.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+
+echo "--variable OPENBMC_HOST:$OPENBMC_HOST" > $ARG_FILE
+echo "--variable OPENBMC_USERNAME:$OPENBMC_USERNAME" >> $ARG_FILE
+echo "--variable OPENBMC_HOST:$OPENBMC_HOST" >> $ARG_FILE
diff --git a/tox.ini b/tox.ini
index fc08416..75ab527 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,32 +1,30 @@
[tox]
skipsdist = True
-[openbmcenv]
-sitepackages = False
-setenv = VIRTUAL_ENV={envdir}
-deps = setuptools
- -r{toxinidir}/requirements.txt
-
[testenv]
+passenv = *
+setenv = ARG_FILE={env:ARG_FILE:/tmp/argument_file.txt}
+whitelist_externals = *
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/requirements.txt
commands =
- python -m robot.run {posargs}
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
[testenv:full]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run .
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} .
[testenv:tests]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run tests
+ bash {toxinidir}/tools/generate_argumentfile.sh
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} tests
[testenv:custom]
-install_command = pip install -U {opts} {packages}
-deps = -r{toxinidir}/requirements.txt
+deps = {[testenv]deps}
+setenv = {[testenv]setenv}
commands =
- python -m robot.run {posargs}
\ No newline at end of file
+ python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 38/60] Update README for better html display
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (36 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 37/60] Use argumnet file with pyrobot and added instructions to READEME file OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 39/60] Added Inventory list testcase OpenBMC Patches
` (23 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
README.md | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
index 589d693..5d869a0 100644
--- a/README.md
+++ b/README.md
@@ -6,13 +6,19 @@ Quickstart
To run openbmc-automation first you need to install the prerequisite python
packages which will help to invoke tests through tox.
-1. Install the python dependencies for tox
- $ easy_install tox pip
+Install the python dependencies for tox
+```shell
+ $easy_install tox pip
+```
-2. Initilize the following environment variable which will used while testing
+Initilize the following environment variable which will used while testing
+```shell
$ export OPENBMC_HOST=<openbmc machine ip address>
$ export OPENBMC_PASSWORD=<openbmc username>
$ export OPENBMC_USERNAME=<openbmc password>
+```
-3. Run tests
+Run tests
+```shell
$ tox -e tests
+```
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 39/60] Added Inventory list testcase
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (37 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 38/60] Update README for better html display OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 40/60] Added DIMM specific inventory tests OpenBMC Patches
` (22 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
data/variables.py | 31 +++++++++++++++++++++++++++++++
lib/resource.txt | 18 +++++++++++++-----
lib/rest_client.robot | 7 +------
tests/test_inventory.robot | 16 ++++++++++++++++
4 files changed, 61 insertions(+), 11 deletions(-)
create mode 100644 data/variables.py
create mode 100644 tests/test_inventory.robot
diff --git a/data/variables.py b/data/variables.py
new file mode 100644
index 0000000..099a21e
--- /dev/null
+++ b/data/variables.py
@@ -0,0 +1,31 @@
+INVENTORY={
+ "palmetto": ["/org/openbmc/inventory/system/chassis/io_board/pcie_slot0",
+ "/org/openbmc/inventory/system/chassis/io_board/pcie_slot1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core9",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core8",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core7",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core6",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core5",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core4",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core3",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core2",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core0",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm3",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm2",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm1",
+ "/org/openbmc/inventory/system/chassis/motherboard/dimm0",
+ "/org/openbmc/inventory/system/chassis/fan4",
+ "/org/openbmc/inventory/system/chassis/fan2",
+ "/org/openbmc/inventory/system",
+ "/org/openbmc/inventory/system/chassis/fan0",
+ "/org/openbmc/inventory/system/chassis/fan1",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0",
+ "/org/openbmc/inventory/system/chassis",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core11",
+ "/org/openbmc/inventory/system/chassis/motherboard/cpu0/core10",
+ "/org/openbmc/inventory/system/chassis/motherboard/centaur0",
+ "/org/openbmc/inventory/system/chassis/motherboard",
+ "/org/openbmc/inventory/system/chassis/motherboard/bmc",
+ "/org/openbmc/inventory/system/chassis/fan3"]
+}
\ No newline at end of file
diff --git a/lib/resource.txt b/lib/resource.txt
index c34e026..fd10050 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -3,10 +3,18 @@ Library Collections
Library String
Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
+Variables ../data/variables.py
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
-${PORT} 3000
-${AUTH_URI} http://${HOST}:${PORT}
-${OPENBMC_USERNAME} root
-${OPENBMC_PASSWORD} abc123
+${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
+${DBUS_PREFIX} ${EMPTY}
+${PORT} ${EMPTY}
+${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${OPENBMC_USERNAME} root
+${OPENBMC_PASSWORD} 0penBmc
+${MACHINE_TYPE} palmetto
+
+*** Keywords ***
+Get Inventory Schema
+ [Arguments] ${machine}
+ [Return] &{INVENTORY}[${machine}]
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 45c4226..b972195 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -3,14 +3,9 @@ Library Collections
Library String
Library RequestsLibrary.RequestsKeywords
Library OperatingSystem
+Resource ../lib/resource.txt
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
-${DBUS_PREFIX} /bus/session
-${PORT} 3000
-${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
-${OPENBMC_USERNAME} root
-${OPENBMC_PASSWORD} abc123
# Response codes
${HTTP_CONTINUE} 100
${HTTP_SWITCHING_PROTOCOLS} 101
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
new file mode 100644
index 0000000..2e5bfaa
--- /dev/null
+++ b/tests/test_inventory.robot
@@ -0,0 +1,16 @@
+*** Settings ***
+Documentation This testsuite is for testing inventory
+Suite Teardown Delete All Sessions
+Resource ../lib/rest_client.robot
+Resource ../lib/resource.txt
+
+*** Test Cases ***
+List Inventory
+ [Documentation] This testcase will get the inventory for the openbmc
+ ... machine and validates with the expected inventory
+ ${resp} = OpenBMC Get Request org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ ${ret}= Get Inventory Schema ${MACHINE_TYPE}
+ : FOR ${ELEMENT} IN @{ret}
+ \ Should Contain ${jsondata} ${ELEMENT}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 40/60] Added DIMM specific inventory tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (38 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 39/60] Added Inventory list testcase OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 41/60] base add for sensor tests OpenBMC Patches
` (21 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 28 ++++++++++++++++++++++++----
tests/test_inventory.robot | 43 ++++++++++++++++++++++++++++++++++++++++---
2 files changed, 64 insertions(+), 7 deletions(-)
diff --git a/data/variables.py b/data/variables.py
index 099a21e..a70367c 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -15,8 +15,8 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard/dimm2",
"/org/openbmc/inventory/system/chassis/motherboard/dimm1",
"/org/openbmc/inventory/system/chassis/motherboard/dimm0",
- "/org/openbmc/inventory/system/chassis/fan4",
- "/org/openbmc/inventory/system/chassis/fan2",
+ "/org/openbmc/inventory/system/chassis/fan4",
+ "/org/openbmc/inventory/system/chassis/fan2",
"/org/openbmc/inventory/system",
"/org/openbmc/inventory/system/chassis/fan0",
"/org/openbmc/inventory/system/chassis/fan1",
@@ -27,5 +27,25 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard/centaur0",
"/org/openbmc/inventory/system/chassis/motherboard",
"/org/openbmc/inventory/system/chassis/motherboard/bmc",
- "/org/openbmc/inventory/system/chassis/fan3"]
-}
\ No newline at end of file
+ "/org/openbmc/inventory/system/chassis/fan3"],
+
+ "DIMM" : [ "Asset Tag",
+ "Custom Field 1",
+ "Custom Field 2",
+ "Custom Field 3",
+ "Custom Field 4",
+ "Custom Field 5",
+ "Custom Field 6",
+ "Custom Field 7",
+ "Custom Field 8",
+ "FRU File ID",
+ "Manufacturer",
+ "Model Number",
+ "Name",
+ "Serial Number",
+ "Version",
+ "fault",
+ "fru_type",
+ "is_fru",
+ "present"],
+}
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index 2e5bfaa..f326a72 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -6,11 +6,48 @@ Resource ../lib/resource.txt
*** Test Cases ***
List Inventory
- [Documentation] This testcase will get the inventory for the openbmc
- ... machine and validates with the expected inventory
- ${resp} = OpenBMC Get Request org/openbmc/inventory/list
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/list
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
${ret}= Get Inventory Schema ${MACHINE_TYPE}
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${jsondata} ${ELEMENT}
+
+
+Verify dimm0 vpd
+ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fru_type
+ Should Be Equal ${value} "DIMM"
+
+
+Verify dimm1 vpd
+ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm1 fru_type
+ Should Be Equal ${value} "DIMM"
+
+Verify dimm0 properties
+ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm0
+ Should Be Valid Dimm Properties ${props}
+
+Verify dimm1 properties
+ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm1
+ Should Be Valid Dimm Properties ${props}
+
+
+
+*** Keywords ***
+Should Be Valid Dimm Properties
+ [arguments] ${props}
+ ${ret}= Get Inventory Schema DIMM
+ : FOR ${ELEMENT} IN @{ret}
+ \ Should Contain ${props} ${ELEMENT}
+
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
+
+
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ [return] ${resp.content}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 41/60] base add for sensor tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (39 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 40/60] Added DIMM specific inventory tests OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 42/60] fixed errors in tox and generate_argumentfile.sh script OpenBMC Patches
` (20 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 28 ++++++++++++++++++++++++
lib/resource.txt | 8 +++++--
tests/test_sensors.robot | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 90 insertions(+), 2 deletions(-)
create mode 100644 tests/test_sensors.robot
diff --git a/data/variables.py b/data/variables.py
index a70367c..820a251 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -49,3 +49,31 @@ INVENTORY={
"is_fru",
"present"],
}
+
+SENSORS={
+ "palmetto" : {
+ 0x2f : '<inventory_root>/system/chassis/motherboard/cpu0',
+ 0x22 : '<inventory_root>/system/chassis/motherboard/cpu0/core0',
+ 0x23 : '<inventory_root>/system/chassis/motherboard/cpu0/core1',
+ 0x24 : '<inventory_root>/system/chassis/motherboard/cpu0/core2',
+ 0x25 : '<inventory_root>/system/chassis/motherboard/cpu0/core3',
+ 0x26 : '<inventory_root>/system/chassis/motherboard/cpu0/core4',
+ 0x27 : '<inventory_root>/system/chassis/motherboard/cpu0/core5',
+ 0x28 : '<inventory_root>/system/chassis/motherboard/cpu0/core6',
+ 0x29 : '<inventory_root>/system/chassis/motherboard/cpu0/core7',
+ 0x2a : '<inventory_root>/system/chassis/motherboard/cpu0/core8',
+ 0x2b : '<inventory_root>/system/chassis/motherboard/cpu0/core9',
+ 0x2c : '<inventory_root>/system/chassis/motherboard/cpu0/core10',
+ 0x2d : '<inventory_root>/system/chassis/motherboard/cpu0/core11',
+ 0x2e : '<inventory_root>/system/chassis/motherboard/centaur0',
+ 0x1e : '<inventory_root>/system/chassis/motherboard/dimm0',
+ 0x1f : '<inventory_root>/system/chassis/motherboard/dimm1',
+ 0x20 : '<inventory_root>/system/chassis/motherboard/dimm2',
+ 0x21 : '<inventory_root>/system/chassis/motherboard/dimm3',
+ 0x09 : '/org/openbmc/sensor/virtual/BootCount',
+ 0x05 : '/org/openbmc/sensor/virtual/BootProgress',
+ 0x04 : '/org/openbmc/sensor/virtual/HostStatus',
+ 0x08 : '/org/openbmc/sensor/virtual/OccStatus',
+ 0x32 : '/org/openbmc/sensor/virtual/OperatingSystemStatus',
+ }
+}
diff --git a/lib/resource.txt b/lib/resource.txt
index fd10050..85bf2fd 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -6,10 +6,10 @@ Library OperatingSystem
Variables ../data/variables.py
*** Variables ***
-${OPENBMC_HOST} 192.168.122.100 # openbmc ip address
+${OPENBMC_HOST} 9.3.164.161
${DBUS_PREFIX} ${EMPTY}
${PORT} ${EMPTY}
-${AUTH_URI} http://${OPENBMC_HOST}:${PORT}
+${AUTH_URI} http://${OPENBMC_HOST}
${OPENBMC_USERNAME} root
${OPENBMC_PASSWORD} 0penBmc
${MACHINE_TYPE} palmetto
@@ -18,3 +18,7 @@ ${MACHINE_TYPE} palmetto
Get Inventory Schema
[Arguments] ${machine}
[Return] &{INVENTORY}[${machine}]
+
+Get Sensor Schema
+ [Arguments] ${machine}
+ [Return] &{SENSORS}[${machine}]
\ No newline at end of file
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
new file mode 100644
index 0000000..b36b059
--- /dev/null
+++ b/tests/test_sensors.robot
@@ -0,0 +1,56 @@
+*** Settings ***
+Documentation This example demonstrates executing commands on a remote machine
+... and getting their output and the return code.
+...
+... Notice how connections are handled as part of the suite setup and
+... teardown. This saves some time when executing several test cases.
+
+Resource ../lib/rest_client.robot
+
+
+Library SSHLibrary
+Suite Setup Open Connection And Log In
+Suite Teardown Close All Connections
+
+*** Variables ***
+${HOST} 9.3.164.147
+${USERNAME} root
+${PASSWORD} 0penBmc
+
+*** Test Cases ***
+Execute Command And Verify Output
+ [Documentation] Execute Command on the remote machine.
+ ${output}= Execute Command echo Hello
+ Should Be Equal ${output} Hello
+
+Execute Sending a file
+ put file ./tfile /home/root
+
+Execute ipmi BT capabilities command
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
+
+Execute Boot Sensoripmi BT capabilities command
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
+
+Execute Set Sensor boot count
+ Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
+ ${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
+ Should Be Equal ${value} "53"
+
+
+
+*** Keywords ***
+Open Connection And Log In
+ Open Connection ${HOST}
+ Login ${USERNAME} ${PASSWORD}
+
+Run IPMI Command
+ [arguments] ${args}
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 42/60] fixed errors in tox and generate_argumentfile.sh script
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (40 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 41/60] base add for sensor tests OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 43/60] fixed review comments OpenBMC Patches
` (19 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
.gitignore | 1 +
tools/generate_argumentfile.sh | 2 +-
tox.ini | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 8aea548..eb901c8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+*.pyc
/log.html
/output.xml
/report.html
diff --git a/tools/generate_argumentfile.sh b/tools/generate_argumentfile.sh
index 518a48f..4869261 100755
--- a/tools/generate_argumentfile.sh
+++ b/tools/generate_argumentfile.sh
@@ -2,4 +2,4 @@
echo "--variable OPENBMC_HOST:$OPENBMC_HOST" > $ARG_FILE
echo "--variable OPENBMC_USERNAME:$OPENBMC_USERNAME" >> $ARG_FILE
-echo "--variable OPENBMC_HOST:$OPENBMC_HOST" >> $ARG_FILE
+echo "--variable OPENBMC_PASSWORD:$OPENBMC_PASSWORD" >> $ARG_FILE
diff --git a/tox.ini b/tox.ini
index 75ab527..fa0d198 100644
--- a/tox.ini
+++ b/tox.ini
@@ -8,12 +8,14 @@ whitelist_externals = *
install_command = pip install -U {opts} {packages}
deps = -r{toxinidir}/requirements.txt
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
[testenv:full]
deps = {[testenv]deps}
setenv = {[testenv]setenv}
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} .
[testenv:tests]
@@ -27,4 +29,5 @@ commands =
deps = {[testenv]deps}
setenv = {[testenv]setenv}
commands =
+ bash {toxinidir}/tools/generate_argumentfile.sh
python -m robot.run --argumentfile {env:ARG_FILE:/tmp/argument_file.txt} {posargs}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 43/60] fixed review comments
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (41 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 42/60] fixed errors in tox and generate_argumentfile.sh script OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 44/60] created loops for tests OpenBMC Patches
` (18 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
tests/test_sensors.robot | 33 ++++++++++-----------------------
1 file changed, 10 insertions(+), 23 deletions(-)
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index b36b059..79ba4d7 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -5,7 +5,7 @@ Documentation This example demonstrates executing commands on a remote
... Notice how connections are handled as part of the suite setup and
... teardown. This saves some time when executing several test cases.
-Resource ../lib/rest_client.robot
+Resource ../lib/rest_client.robot
Library SSHLibrary
@@ -13,42 +13,29 @@ Suite Setup Open Connection And Log In
Suite Teardown Close All Connections
*** Variables ***
-${HOST} 9.3.164.147
-${USERNAME} root
-${PASSWORD} 0penBmc
-*** Test Cases ***
-Execute Command And Verify Output
- [Documentation] Execute Command on the remote machine.
- ${output}= Execute Command echo Hello
- Should Be Equal ${output} Hello
-
-Execute Sending a file
- put file ./tfile /home/root
+*** Test Cases ***
Execute ipmi BT capabilities command
- ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
-
-Execute Boot Sensoripmi BT capabilities command
- ${output}= Execute Command /home/root/ipmitool -I dbus raw 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
+ ${output}= Run IPMI command 0x06 0x36
+ Should Be Equal "${output}" " 01 3f 3f 0a 01"
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
- Should Be Equal ${value} "53"
+ Should Be Equal ${value} "53"
*** Keywords ***
Open Connection And Log In
- Open Connection ${HOST}
- Login ${USERNAME} ${PASSWORD}
+ Open connection ${OPENBMC_HOST}
+ Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
Run IPMI Command
- [arguments] ${args}
- ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+ [arguments] ${args}
+ ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
+ [return] ${output}
Read attribute
[arguments] ${uri} ${attr}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 44/60] created loops for tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (42 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 43/60] fixed review comments OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 45/60] Add initial rest test cases Support to test Null properties OpenBMC Patches
` (17 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
data/variables.py | 4 ++++
lib/resource.txt | 4 ++++
tests/test_inventory.robot | 26 +++++++++++++-------------
3 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/data/variables.py b/data/variables.py
index 820a251..a342701 100644
--- a/data/variables.py
+++ b/data/variables.py
@@ -28,6 +28,10 @@ INVENTORY={
"/org/openbmc/inventory/system/chassis/motherboard",
"/org/openbmc/inventory/system/chassis/motherboard/bmc",
"/org/openbmc/inventory/system/chassis/fan3"],
+}
+
+
+INVENTORY_ITEMS={
"DIMM" : [ "Asset Tag",
"Custom Field 1",
diff --git a/lib/resource.txt b/lib/resource.txt
index 85bf2fd..a8b8614 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -19,6 +19,10 @@ Get Inventory Schema
[Arguments] ${machine}
[Return] &{INVENTORY}[${machine}]
+Get Inventory Items Schema
+ [Arguments] ${machine}
+ [Return] &{INVENTORY_ITEMS}[${machine}]
+
Get Sensor Schema
[Arguments] ${machine}
[Return] &{SENSORS}[${machine}]
\ No newline at end of file
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index f326a72..fde52e1 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -4,6 +4,8 @@ Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
Resource ../lib/resource.txt
+Library String
+
*** Test Cases ***
List Inventory
${resp} = OpenBMC Get Request /org/openbmc/inventory/list
@@ -14,29 +16,27 @@ List Inventory
\ Should Contain ${jsondata} ${ELEMENT}
-Verify dimm0 vpd
- ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fru_type
- Should Be Equal ${value} "DIMM"
+Verify dimm vpd
+ : FOR ${INDEX} IN RANGE 0 4
+ \ log ${INDEX}
+ \ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
+ \ Should Be Equal ${value} "DIMM"
-Verify dimm1 vpd
- ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm1 fru_type
- Should Be Equal ${value} "DIMM"
+Verify dimm vpd properties
+ : FOR ${INDEX} IN RANGE 0 4
+ \ log ${INDEX}
+ \ ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX}
+ \ Should Be Valid Dimm Properties ${props}
-Verify dimm0 properties
- ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm0
- Should Be Valid Dimm Properties ${props}
-Verify dimm1 properties
- ${props} = Read Properties /org/openbmc/inventory/system/chassis/motherboard/dimm1
- Should Be Valid Dimm Properties ${props}
*** Keywords ***
Should Be Valid Dimm Properties
[arguments] ${props}
- ${ret}= Get Inventory Schema DIMM
+ ${ret}= Get Inventory Items Schema DIMM
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${props} ${ELEMENT}
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 45/60] Add initial rest test cases Support to test Null properties
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (43 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 44/60] created loops for tests OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 46/60] Moved Read Attribute and Read Properties to rest_client OpenBMC Patches
` (16 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
tests/test_obmcrest.robot | 65 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
create mode 100644 tests/test_obmcrest.robot
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
new file mode 100644
index 0000000..0c3d5ea
--- /dev/null
+++ b/tests/test_obmcrest.robot
@@ -0,0 +1,65 @@
+*** Settings ***
+Documentation This suite will verifiy all OpenBMC rest interfaces
+... Details of valid interfaces can be found here...
+... https://github.com/openbmc/docs/blob/master/rest-api.md
+
+Resource ../lib/rest_client.robot
+
+
+*** Variables ***
+
+
+*** Test Cases ***
+Good connection for testing
+ ${resp} = Read Properties /
+ ${jdata}= To Json ${resp.content}
+ ${c}= get from List ${jdata} 0
+ Should Contain "/org" ${c}
+
+
+Get an object with no properties
+ ${resp} = Read Properties /org/openbmc/inventory
+ Should Be Empty ${resp.content}
+
+
+Get a Property
+ ${resp} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ Should Contain 1 ${resp}
+
+
+Get a null Property
+ ${resp} = Read attribute /org/openbmc/inventory is_fru
+ Should Contain 1 ${resp}
+
+
+Enumeration object
+
+
+List object
+
+
+Invoke a method without properties
+
+
+Invoke a method with properties
+
+
+Issue a POST
+
+
+Issue a PUT
+
+
+
+
+
+*** Keywords ***
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ [return] ${resp}
+
+Read attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 46/60] Moved Read Attribute and Read Properties to rest_client
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (44 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 45/60] Add initial rest test cases Support to test Null properties OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 47/60] fix review comment OpenBMC Patches
` (15 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 13 +++++++++++++
tests/test_inventory.robot | 14 +-------------
tests/test_obmcrest.robot | 24 +++++++-----------------
tests/test_sensors.robot | 7 +------
4 files changed, 22 insertions(+), 36 deletions(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index b972195..f0c1ba3 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -102,3 +102,16 @@ Log Response
Logging
[Arguments] ${msg} ${console}=default False
Log ${msg} console=True
+
+Read Attribute
+ [arguments] ${uri} ${attr}
+ ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
+ [return] ${resp.content}
+
+
+Read Properties
+ [arguments] ${uri}
+ ${resp} = OpenBMC Get Request ${uri}
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${content}= To Json ${resp.content}
+ [return] ${content}
\ No newline at end of file
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index fde52e1..afe4613 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -19,7 +19,7 @@ List Inventory
Verify dimm vpd
: FOR ${INDEX} IN RANGE 0 4
\ log ${INDEX}
- \ ${value} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
+ \ ${value} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
\ Should Be Equal ${value} "DIMM"
@@ -39,15 +39,3 @@ Should Be Valid Dimm Properties
${ret}= Get Inventory Items Schema DIMM
: FOR ${ELEMENT} IN @{ret}
\ Should Contain ${props} ${ELEMENT}
-
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
-
-
-Read Properties
- [arguments] ${uri}
- ${resp} = OpenBMC Get Request ${uri}
- [return] ${resp.content}
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 0c3d5ea..75eb6d9 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -11,24 +11,23 @@ Resource ../lib/rest_client.robot
*** Test Cases ***
Good connection for testing
- ${resp} = Read Properties /
- ${jdata}= To Json ${resp.content}
- ${c}= get from List ${jdata} 0
- Should Contain "/org" ${c}
+ ${content} = Read Properties /
+ ${c}= get from List ${content} 0
+ Should Contain "/org" ${c}
Get an object with no properties
- ${resp} = Read Properties /org/openbmc/inventory
- Should Be Empty ${resp.content}
+ ${content} = Read Properties /org/openbmc/inventory
+ Should Not Be Empty ${content}
Get a Property
- ${resp} = Read attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ ${resp} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
Should Contain 1 ${resp}
Get a null Property
- ${resp} = Read attribute /org/openbmc/inventory is_fru
+ ${resp} = Read Attribute /org/openbmc/inventory is_fru
Should Contain 1 ${resp}
@@ -54,12 +53,3 @@ Issue a PUT
*** Keywords ***
-Read Properties
- [arguments] ${uri}
- ${resp} = OpenBMC Get Request ${uri}
- [return] ${resp}
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
\ No newline at end of file
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 79ba4d7..3d17360 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -22,7 +22,7 @@ Execute ipmi BT capabilities command
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
- ${value} = Read attribute /org/openbmc/sensor/virtual/BootCount value
+ ${value} = Read Attribute /org/openbmc/sensor/virtual/BootCount value
Should Be Equal ${value} "53"
@@ -36,8 +36,3 @@ Run IPMI Command
[arguments] ${args}
${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
[return] ${output}
-
-Read attribute
- [arguments] ${uri} ${attr}
- ${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 47/60] fix review comment
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (45 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 46/60] Moved Read Attribute and Read Properties to rest_client OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 48/60] Added full sensor suite OpenBMC Patches
` (14 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_obmcrest.robot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 75eb6d9..caf9085 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -18,7 +18,7 @@ Good connection for testing
Get an object with no properties
${content} = Read Properties /org/openbmc/inventory
- Should Not Be Empty ${content}
+ Should Be Empty ${content}
Get a Property
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 48/60] Added full sensor suite
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (46 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 47/60] fix review comment OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 49/60] Update README.md OpenBMC Patches
` (13 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
corrected cpu sensor#
---
tests/test_sensors.robot | 188 ++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 177 insertions(+), 11 deletions(-)
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 3d17360..a50805a 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -5,34 +5,200 @@ Documentation This example demonstrates executing commands on a remote
... Notice how connections are handled as part of the suite setup and
... teardown. This saves some time when executing several test cases.
-Resource ../lib/rest_client.robot
+Resource ../lib/rest_client.robot
Library SSHLibrary
Suite Setup Open Connection And Log In
Suite Teardown Close All Connections
+
*** Variables ***
*** Test Cases ***
+Verify connection
+ Execute new Command echo "hello"
+ Response Should Be Equal "hello"
+
+
Execute ipmi BT capabilities command
- ${output}= Run IPMI command 0x06 0x36
- Should Be Equal "${output}" " 01 3f 3f 0a 01"
+ Run IPMI command 0x06 0x36
+ response Should Be Equal " 01 3f 3f 0a 01"
+
Execute Set Sensor boot count
- Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
- ${value} = Read Attribute /org/openbmc/sensor/virtual/BootCount value
- Should Be Equal ${value} "53"
+ Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
+ Read the Attribute /org/openbmc/sensor/virtual/BootCount value
+ Response Should Be Equal "53"
+
+
+Set Sensor Boot progress
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x14 0x00
+ Read the Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Progress, Baseboard Init"
+
+
+
+Set Sensor Boot progress Longest string
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x0e 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Progress, Docking station attachment"
+
+
+BootProgress sensor FW Hang unspecified Error
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "FW Hang, Unspecified"
+
+
+BootProgress fw hang state
+ Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
+ Response Should Be Equal "POST Error, unknown"
+
+
+OperatingSystemStatus Sensor boot completed progress
+ Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
+ Response Should Be Equal "Boot completed (00)"
+
+
+OperatingSystemStatus Sensor progress
+ Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x04 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
+ Response Should Be Equal "PXE boot completed"
+
+
+OCC Active sensor on enabled
+ Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
+ Response Should Be Equal "Enabled"
+
+
+OCC Active sensor on disabled
+ Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
+ Response Should Be Equal "Disabled"
+
+
+CPU Present
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
+ Response Should Be Equal "True"
+
+CPU not Present
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
+ Response Should Be Equal "False"
+
+
+CPU fault
+ Run IPMI command 0x04 0x30 0x2f 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
+ Response Should Be Equal "True"
+
+
+CPU no fault
+ Run IPMI command 0x04 0x30 0x2f 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
+ Response Should Be Equal ""
+
+
+core Present
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
+ Response Should Be Equal "True"
+
+core not Present
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
+ Response Should Be Equal "False"
+
+
+core fault
+ Run IPMI command 0x04 0x30 0x2d 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
+ Response Should Be Equal "True"
+
+
+core no fault
+ Run IPMI command 0x04 0x30 0x2d 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
+ Response Should Be Equal ""
+
+
+DIMM3 Present
+ Run IPMI command 0x04 0x30 0x21 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
+ Response Should Be Equal "True"
+
+DIMM3 not Present
+ Run IPMI command 0x04 0x30 0x21 0xa9 0xff 0x00 0x00 0x40 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
+ Response Should Be Equal "False"
+
+
+DIMM0 fault
+ Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
+ Response Should Be Equal "True"
+
+
+DIMM0 no fault
+ Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
+ Response Should Be Equal ""
+
+
+
+Centaur0 Present
+ Run IPMI command 0x04 0x30 0x2e 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
+ Response Should Be Equal "True"
+
+Centaur0 not Present
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
+ Response Should Be Equal "False"
+
+
+Centaur0 fault
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
+ Response Should Be Equal "True"
+
+Centaur0 no fault
+ Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
+ Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
+ Response Should Be Equal ""
*** Keywords ***
+Execute new Command
+ [arguments] ${args}
+ ${output}= Execute Command ${args}
+ set test variable ${OUTPUT} "${output}"
+
+response Should Be Equal
+ [arguments] ${args}
+ Should Be Equal ${OUTPUT} ${args}
+
+
+Read the Attribute
+ [arguments] ${uri} ${parm}
+ ${output} = Read Attribute ${uri} ${parm}
+ set test variable ${OUTPUT} ${output}
+
+
Open Connection And Log In
- Open connection ${OPENBMC_HOST}
- Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
+ Open connection ${OPENBMC_HOST}
+ Login ${OPENBMC_USERNAME} ${OPENBMC_PASSWORD}
Run IPMI Command
- [arguments] ${args}
- ${output}= Execute Command /home/root/ipmitool -I dbus raw ${args}
- [return] ${output}
+ [arguments] ${args}
+ ${output}= Execute Command /usr/sbin/ipmitool -I dbus raw ${args}
+ set test variable ${OUTPUT} "${output}"
+
+
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 49/60] Update README.md
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (47 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 48/60] Added full sensor suite OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 50/60] Added SSL tests OpenBMC Patches
` (12 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc; +Cc: Chris Austen
From: Chris Austen <causten@users.noreply.github.com>
---
README.md | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/README.md b/README.md
index 5d869a0..cb8bd02 100644
--- a/README.md
+++ b/README.md
@@ -22,3 +22,8 @@ Run tests
```shell
$ tox -e tests
```
+
+It can also be run by pasing variables from the cli...
+```shell
+ $ pybot -v OPENBMC_HOST:<ip> -v OPENBMC_USERNAME:root -v OPENBMC_PASSWORD:0penBmc
+```
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 50/60] Added SSL tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (48 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 49/60] Update README.md OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 51/60] Handle new rest client from Brad OpenBMC Patches
` (11 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 tests/security/test_ssl.robot
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
new file mode 100644
index 0000000..e4eac40
--- /dev/null
+++ b/tests/security/test_ssl.robot
@@ -0,0 +1,28 @@
+*** Settings ***
+Documentation This testsuite is for testing SSL connection to OpenBMC
+Suite Teardown Delete All Sessions
+
+Resource ../lib/rest_client.robot
+Resource ../lib/resource.txt
+
+Library RequestsLibrary.RequestsKeywords
+
+*** Test Cases ***
+Test SSL Connection
+ [Documentation] This testcase is for testing the SSL connection to the
+ ... OpenBMC machine.
+ Create Session openbmc https://${OPENBMC_HOST}/
+ ${resp}= Get Request openbmc https://${OPENBMC_HOST}/org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ Should Not Be Empty ${jsondata}
+
+Test non-SSL Connection - Negative
+ [Documentation] This testcase is for test to check OpenBMC machine
+ ... will not accepts the non-secure connection that is with http.
+ ... Expected Response code is - 400
+ Create Session openbmc http://${OPENBMC_HOST}/
+ ${resp}= Get Request openbmc http://${OPENBMC_HOST}/org/openbmc/inventory/list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ ${jsondata}= To Json ${resp.content}
+ Should Be Empty ${jsondata}
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 51/60] Handle new rest client from Brad
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (49 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 50/60] Added SSL tests OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 52/60] Ran the tests and fixed errors in SSL tests OpenBMC Patches
` (10 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Chris Austen <austenc@us.ibm.com>
---
lib/resource.txt | 2 +-
tests/test_sensors.robot | 7 +++++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/resource.txt b/lib/resource.txt
index a8b8614..9d865c3 100644
--- a/lib/resource.txt
+++ b/lib/resource.txt
@@ -9,7 +9,7 @@ Variables ../data/variables.py
${OPENBMC_HOST} 9.3.164.161
${DBUS_PREFIX} ${EMPTY}
${PORT} ${EMPTY}
-${AUTH_URI} http://${OPENBMC_HOST}
+${AUTH_URI} https://${OPENBMC_HOST}
${OPENBMC_USERNAME} root
${OPENBMC_PASSWORD} 0penBmc
${MACHINE_TYPE} palmetto
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index a50805a..3e84e44 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -188,8 +188,11 @@ response Should Be Equal
Read the Attribute
[arguments] ${uri} ${parm}
- ${output} = Read Attribute ${uri} ${parm}
- set test variable ${OUTPUT} ${output}
+ ${output} = Read Attribute ${uri} ${parm}
+ ${json} = to json ${output}
+ ${data} = get from dictionary ${json} data
+ set test variable ${OUTPUT} "${data}"
+
Open Connection And Log In
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 52/60] Ran the tests and fixed errors in SSL tests
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (50 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 51/60] Handle new rest client from Brad OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 53/60] Modified the doc OpenBMC Patches
` (9 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index e4eac40..0504567 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -2,8 +2,8 @@
Documentation This testsuite is for testing SSL connection to OpenBMC
Suite Teardown Delete All Sessions
-Resource ../lib/rest_client.robot
-Resource ../lib/resource.txt
+Resource ../../lib/rest_client.robot
+Resource ../../lib/resource.txt
Library RequestsLibrary.RequestsKeywords
@@ -12,7 +12,7 @@ Test SSL Connection
[Documentation] This testcase is for testing the SSL connection to the
... OpenBMC machine.
Create Session openbmc https://${OPENBMC_HOST}/
- ${resp}= Get Request openbmc https://${OPENBMC_HOST}/org/openbmc/inventory/list
+ ${resp}= Get Request openbmc /list
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
Should Not Be Empty ${jsondata}
@@ -22,7 +22,4 @@ Test non-SSL Connection - Negative
... will not accepts the non-secure connection that is with http.
... Expected Response code is - 400
Create Session openbmc http://${OPENBMC_HOST}/
- ${resp}= Get Request openbmc http://${OPENBMC_HOST}/org/openbmc/inventory/list
- Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
- ${jsondata}= To Json ${resp.content}
- Should Be Empty ${jsondata}
\ No newline at end of file
+ Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 53/60] Modified the doc
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (51 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 52/60] Ran the tests and fixed errors in SSL tests OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 54/60] Added firmware version validation test OpenBMC Patches
` (8 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index 0504567..3c098b0 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -20,6 +20,6 @@ Test SSL Connection
Test non-SSL Connection - Negative
[Documentation] This testcase is for test to check OpenBMC machine
... will not accepts the non-secure connection that is with http.
- ... Expected Response code is - 400
+ ... Expected a connection error when we try making a call
Create Session openbmc http://${OPENBMC_HOST}/
Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 54/60] Added firmware version validation test
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (52 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 53/60] Modified the doc OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 55/60] update readme file with tox version OpenBMC Patches
` (7 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_fw_version.robot | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 tests/test_fw_version.robot
diff --git a/tests/test_fw_version.robot b/tests/test_fw_version.robot
new file mode 100644
index 0000000..2c3337d
--- /dev/null
+++ b/tests/test_fw_version.robot
@@ -0,0 +1,22 @@
+*** Settings ***
+Documentation This suite will the firmware version exposed part of
+... system inventory
+
+Resource ../lib/rest_client.robot
+
+
+*** Variables ***
+
+
+*** Test Cases ***
+Test Firmware Version
+ [Documentation] This testcase is for testing the fw version.\n
+ ... Expected in following format:
+ ... $ git describe --dirty
+ ... v0.1-34-g95f7347
+ ... $
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/system
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
+ ${jsondata}= To Json ${resp.content}
+ Should not be empty ${jsondata["data"]["Version"]}
+ Should Match Regexp ${jsondata["data"]["Version"]} ^v\\d+\.\\d+
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 55/60] update readme file with tox version
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (53 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 54/60] Added firmware version validation test OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 56/60] Fix errors OpenBMC Patches
` (6 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index cb8bd02..56048d7 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,8 @@ packages which will help to invoke tests through tox.
Install the python dependencies for tox
```shell
- $easy_install tox pip
+ $ easy_install tox==2.1.1
+ $ easy_install pip
```
Initilize the following environment variable which will used while testing
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 56/60] Fix errors
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (54 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 55/60] update readme file with tox version OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 57/60] Fix Errors in test_obmcrest.robot and removed the empty testcases OpenBMC Patches
` (5 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 5 +--
tests/test_fan.robot | 3 --
tests/test_inventory.robot | 4 +--
tests/test_sensors.robot | 84 ++++++++++++++++------------------------------
4 files changed, 33 insertions(+), 63 deletions(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index f0c1ba3..5cd71b2 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -106,7 +106,8 @@ Logging
Read Attribute
[arguments] ${uri} ${attr}
${resp} = OpenBMC Get Request ${uri}/attr/${attr}
- [return] ${resp.content}
+ ${content}= To Json ${resp.content}
+ [return] ${content["data"]}
Read Properties
@@ -114,4 +115,4 @@ Read Properties
${resp} = OpenBMC Get Request ${uri}
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${content}= To Json ${resp.content}
- [return] ${content}
\ No newline at end of file
+ [return] ${content["data"]}
\ No newline at end of file
diff --git a/tests/test_fan.robot b/tests/test_fan.robot
index 61255e6..2f593b5 100644
--- a/tests/test_fan.robot
+++ b/tests/test_fan.robot
@@ -4,6 +4,3 @@ Suite Teardown Delete All Sessions
Resource ../lib/rest_client.robot
*** Test Cases ***
-List all the fans
- ${resp} = OpenBMC Get Request /org.openbmc.control.Fan/
- Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
diff --git a/tests/test_inventory.robot b/tests/test_inventory.robot
index afe4613..3bb8f9c 100644
--- a/tests/test_inventory.robot
+++ b/tests/test_inventory.robot
@@ -13,14 +13,14 @@ List Inventory
${jsondata}= To Json ${resp.content}
${ret}= Get Inventory Schema ${MACHINE_TYPE}
: FOR ${ELEMENT} IN @{ret}
- \ Should Contain ${jsondata} ${ELEMENT}
+ \ Should Contain ${jsondata["data"]} ${ELEMENT}
Verify dimm vpd
: FOR ${INDEX} IN RANGE 0 4
\ log ${INDEX}
\ ${value} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm${INDEX} fru_type
- \ Should Be Equal ${value} "DIMM"
+ \ Should Be Equal ${value} DIMM
Verify dimm vpd properties
diff --git a/tests/test_sensors.robot b/tests/test_sensors.robot
index 3e84e44..945fb47 100644
--- a/tests/test_sensors.robot
+++ b/tests/test_sensors.robot
@@ -21,158 +21,134 @@ Verify connection
Execute new Command echo "hello"
Response Should Be Equal "hello"
-
Execute ipmi BT capabilities command
Run IPMI command 0x06 0x36
response Should Be Equal " 01 3f 3f 0a 01"
-
Execute Set Sensor boot count
Run IPMI command 0x04 0x30 0x09 0x01 0x00 0x35 0x00 0x00 0x00 0x00 0x00 0x00
Read the Attribute /org/openbmc/sensor/virtual/BootCount value
- Response Should Be Equal "53"
-
+ Response Should Be Equal 53
Set Sensor Boot progress
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x14 0x00
Read the Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Progress, Baseboard Init"
-
-
+ Response Should Be Equal FW Progress, Baseboard Init
Set Sensor Boot progress Longest string
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x04 0x00 0x00 0x00 0x00 0x0e 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Progress, Docking station attachment"
-
+ Response Should Be Equal FW Progress, Docking station attachment
BootProgress sensor FW Hang unspecified Error
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "FW Hang, Unspecified"
-
+ Response Should Be Equal FW Hang, Unspecified
BootProgress fw hang state
Run IPMI command 0x04 0x30 0x05 0xa9 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/BootProgress value
- Response Should Be Equal "POST Error, unknown"
-
+ Response Should Be Equal POST Error, unknown
OperatingSystemStatus Sensor boot completed progress
Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
- Response Should Be Equal "Boot completed (00)"
-
+ Response Should Be Equal Boot completed (00)
OperatingSystemStatus Sensor progress
Run IPMI command 0x04 0x30 0x32 0x00 0x00 0x04 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OperatingSystemStatus value
- Response Should Be Equal "PXE boot completed"
-
+ Response Should Be Equal PXE boot completed
OCC Active sensor on enabled
Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
- Response Should Be Equal "Enabled"
-
+ Response Should Be Equal Enabled
OCC Active sensor on disabled
Run IPMI command 0x04 0x30 0x08 0x00 0x00 0x01 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/sensor/virtual/OccStatus value
- Response Should Be Equal "Disabled"
-
+ Response Should Be Equal Disabled
CPU Present
Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
CPU not Present
Run IPMI command 0x04 0x30 0x2f 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
CPU fault
Run IPMI command 0x04 0x30 0x2f 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
CPU no fault
Run IPMI command 0x04 0x30 0x2f 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
core Present
Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x80 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
core not Present
Run IPMI command 0x04 0x30 0x2d 0xa9 0x00 0x00 0x00 0x80 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
core fault
Run IPMI command 0x04 0x30 0x2d 0xa9 0xff 0x00 0x01 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
core no fault
Run IPMI command 0x04 0x30 0x2d 0x00 0x00 0x00 0x00 0x00 0x01 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0/core11 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
DIMM3 Present
Run IPMI command 0x04 0x30 0x21 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
DIMM3 not Present
Run IPMI command 0x04 0x30 0x21 0xa9 0xff 0x00 0x00 0x40 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm3 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
DIMM0 fault
Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
- Response Should Be Equal "True"
-
+ Response Should Be Equal True
DIMM0 no fault
Run IPMI command 0x04 0x30 0x1e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/dimm0 fault
- Response Should Be Equal ""
-
-
+ Response Should Be Empty
Centaur0 Present
Run IPMI command 0x04 0x30 0x2e 0xa9 0x00 0x40 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
- Response Should Be Equal "True"
+ Response Should Be Equal True
Centaur0 not Present
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x40 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 present
- Response Should Be Equal "False"
-
+ Response Should Be Equal False
Centaur0 fault
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x10 0x00 0x00 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
- Response Should Be Equal "True"
+ Response Should Be Equal True
Centaur0 no fault
Run IPMI command 0x04 0x30 0x2e 0x00 0x00 0x00 0x00 0x10 0x00 0x00 0x20 0x00
Read The Attribute /org/openbmc/inventory/system/chassis/motherboard/centaur0 fault
- Response Should Be Equal ""
-
+ Response Should Be Empty
*** Keywords ***
@@ -185,15 +161,13 @@ response Should Be Equal
[arguments] ${args}
Should Be Equal ${OUTPUT} ${args}
+Response Should Be Empty
+ Should Be Empty ${OUTPUT}
Read the Attribute
[arguments] ${uri} ${parm}
${output} = Read Attribute ${uri} ${parm}
- ${json} = to json ${output}
- ${data} = get from dictionary ${json} data
- set test variable ${OUTPUT} "${data}"
-
-
+ set test variable ${OUTPUT} ${output}
Open Connection And Log In
Open connection ${OPENBMC_HOST}
@@ -203,5 +177,3 @@ Run IPMI Command
[arguments] ${args}
${output}= Execute Command /usr/sbin/ipmitool -I dbus raw ${args}
set test variable ${OUTPUT} "${output}"
-
-
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 57/60] Fix Errors in test_obmcrest.robot and removed the empty testcases.
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (55 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 56/60] Fix errors OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 58/60] Added one more testcase to test non-ssl connection to port 443 OpenBMC Patches
` (4 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_obmcrest.robot | 47 +++++++++++------------------------------------
1 file changed, 11 insertions(+), 36 deletions(-)
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index caf9085..382107f 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -11,45 +11,20 @@ Resource ../lib/rest_client.robot
*** Test Cases ***
Good connection for testing
- ${content} = Read Properties /
- ${c}= get from List ${content} 0
- Should Contain "/org" ${c}
-
+ ${content}= Read Properties /
+ ${c}= get from List ${content} 0
+ Should Be Equal ${c} /org
Get an object with no properties
- ${content} = Read Properties /org/openbmc/inventory
- Should Be Empty ${content}
-
+ ${content}= Read Properties /org/openbmc/inventory
+ Should Be Empty ${content}
Get a Property
- ${resp} = Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
- Should Contain 1 ${resp}
-
+ ${resp}= Read Attribute /org/openbmc/inventory/system/chassis/motherboard/cpu0 is_fru
+ Should Be Equal ${resp} ${1}
Get a null Property
- ${resp} = Read Attribute /org/openbmc/inventory is_fru
- Should Contain 1 ${resp}
-
-
-Enumeration object
-
-
-List object
-
-
-Invoke a method without properties
-
-
-Invoke a method with properties
-
-
-Issue a POST
-
-
-Issue a PUT
-
-
-
-
-
-*** Keywords ***
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/attr/is_fru
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${jsondata}= To Json ${resp.content}
+ Should Be Equal ${jsondata['data']['description']} The specified property cannot be found: ''is_fru''
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 58/60] Added one more testcase to test non-ssl connection to port 443
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (56 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 57/60] Fix Errors in test_obmcrest.robot and removed the empty testcases OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 59/60] OpenBMC REST Testing OpenBMC Patches
` (3 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/security/test_ssl.robot | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/tests/security/test_ssl.robot b/tests/security/test_ssl.robot
index 3c098b0..b376a62 100644
--- a/tests/security/test_ssl.robot
+++ b/tests/security/test_ssl.robot
@@ -17,9 +17,18 @@ Test SSL Connection
${jsondata}= To Json ${resp.content}
Should Not Be Empty ${jsondata}
-Test non-SSL Connection - Negative
+Test non-SSL Connection to port 80
[Documentation] This testcase is for test to check OpenBMC machine
- ... will not accepts the non-secure connection that is with http.
- ... Expected a connection error when we try making a call
+ ... will not accepts the non-secure connection that is with http to
+ ... port 80 and expect a connection error
Create Session openbmc http://${OPENBMC_HOST}/
Run Keyword And Expect Error ConnectionError* Get Request openbmc /list
+
+Test non-SSL Connection to port 443
+ [Documentation] This testcase is for test to check OpenBMC machine
+ ... will not accepts the non-secure connection that is with http to
+ ... port 443 and expect 400 in response
+ Create Session openbmc http://${OPENBMC_HOST}:443/
+ ${resp}= Get Request openbmc /list
+ Should Be Equal As Strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ Should Be Equal ${resp.content} Bad Request
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 59/60] OpenBMC REST Testing
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (57 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 58/60] Added one more testcase to test non-ssl connection to port 443 OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-11 16:50 ` [PATCH openbmc-test-automation 60/60] updated the REST API for firmware version OpenBMC Patches
` (2 subsequent siblings)
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
lib/rest_client.robot | 11 ++
requirements.txt | 2 +-
tests/test_obmcrest.robot | 283 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 295 insertions(+), 1 deletion(-)
diff --git a/lib/rest_client.robot b/lib/rest_client.robot
index 5cd71b2..02a7a11 100644
--- a/lib/rest_client.robot
+++ b/lib/rest_client.robot
@@ -70,6 +70,8 @@ OpenBMC Get Request
OpenBMC Post Request
[Arguments] ${uri} &{kwargs}
${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ ${headers}= Create Dictionary Content-Type=application/json
+ set to dictionary ${kwargs} headers ${headers}
Log Request method=Post base_uri=${base_uri} args=&{kwargs}
Initialize OpenBMC
${ret}= Post Request openbmc ${base_uri} &{kwargs}
@@ -85,6 +87,15 @@ OpenBMC Put Request
Log Response ${ret}
[Return] ${ret}
+OpenBMC Delete Request
+ [Arguments] ${uri} &{kwargs}
+ ${base_uri}= Catenate SEPARATOR= ${DBUS_PREFIX} ${uri}
+ Log Request method=Delete base_uri=${base_uri} args=&{kwargs}
+ Initialize OpenBMC
+ ${ret}= Put Request openbmc ${base_uri} &{kwargs}
+ Log Response ${ret}
+ [Return] ${ret}
+
Initialize OpenBMC
Create Session openbmc ${AUTH_URI}
diff --git a/requirements.txt b/requirements.txt
index 8434d52..1459b74 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
robotframework
requests
-robotframework-requests
+robotframework-requests>=0.3.9
robotframework-sshlibrary
\ No newline at end of file
diff --git a/tests/test_obmcrest.robot b/tests/test_obmcrest.robot
index 382107f..50fe6b2 100644
--- a/tests/test_obmcrest.robot
+++ b/tests/test_obmcrest.robot
@@ -28,3 +28,286 @@ Get a null Property
Should Be Equal As Strings ${resp.status_code} ${HTTP_NOT_FOUND}
${jsondata}= To Json ${resp.content}
Should Be Equal ${jsondata['data']['description']} The specified property cannot be found: ''is_fru''
+
+get directory listing /
+ ${resp} = openbmc get request /
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org
+ should be equal as strings ${json['status']} ok
+
+get directory listing /org/
+ ${resp} = openbmc get request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc
+ should be equal as strings ${json['status']} ok
+
+get invalid directory listing /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put directory listing /
+ ${resp} = openbmc put request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put directory listing /org/
+ ${resp} = openbmc put request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid directory listing /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post directory listing /
+ ${resp} = openbmc post request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post directory listing /org/
+ ${resp} = openbmc post request /org/
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid directory listing /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete directory listing /
+ ${resp} = openbmc delete request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete directory listing /org/
+ ${resp} = openbmc delete request /
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid directory listing /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get list names /
+ ${resp} = openbmc get request /list
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get list names /org/
+ ${resp} = openbmc get request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get invalid list names /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put list names /
+ ${resp} = openbmc put request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put list names /org/
+ ${resp} = openbmc put request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid list names /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post list names /
+ ${resp} = openbmc post request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post list names /org/
+ ${resp} = openbmc post request /org/list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid list names /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete list names /
+ ${resp} = openbmc delete request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete list names /org/
+ ${resp} = openbmc delete request /list
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid list names /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/list
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get names /
+ ${resp} = openbmc get request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get names /org/
+ ${resp} = openbmc get request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ list should contain value ${json['data']} /org/openbmc/inventory
+ should be equal as strings ${json['status']} ok
+
+get invalid names /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put names /
+ ${resp} = openbmc put request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put names /org/
+ ${resp} = openbmc put request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid names /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post names /
+ ${resp} = openbmc post request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post names /org/
+ ${resp} = openbmc post request /org/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post invalid names /i/dont/exist/
+ ${resp} = openbmc post request /i/dont/exist/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete names /
+ ${resp} = openbmc delete request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete names /org/
+ ${resp} = openbmc delete request /enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid names /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/enumerate
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc get request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+get invalid method /i/dont/exist/
+ ${resp} = openbmc get request /i/dont/exist/action/foo
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc put request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+put invalid method /i/dont/exist/
+ ${resp} = openbmc put request /i/dont/exist/action/foo
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post method /org/openbmc/control/fan0/action/getspeed no args
+ ${data} = create dictionary data=@{EMPTY}
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/getspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} ok
+
+post method /org/openbmc/control/fan0/action/setspeed invalid args
+ ${data} = create dictionary foo=bar
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/setspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_BAD_REQUEST}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+post method /org/openbmc/control/fan0/action/setspeed with args
+ ${SPEED}= Set Variable ${200}
+ @{speed_list} = Create List ${SPEED}
+ ${data} = create dictionary data=@{speed_list}
+ ${resp} = openbmc post request /org/openbmc/control/fan0/action/setspeed data=${data}
+ should be equal as strings ${resp.status_code} ${HTTP_OK}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} ok
+ ${content}= Read Attribute /org/openbmc/control/fan0 speed
+ Should Be Equal ${content} ${SPEED}
+
+delete method /org/openbmc/control/fan0/action/setspeed
+ ${resp} = openbmc delete request /org/openbmc/control/fan0/action/setspeed
+ should be equal as strings ${resp.status_code} ${HTTP_METHOD_NOT_ALLOWED}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
+
+delete invalid method /org/nothere/
+ ${resp} = openbmc delete request /org/nothere/action/foomethod
+ should be equal as strings ${resp.status_code} ${HTTP_NOT_FOUND}
+ ${json} = to json ${resp.content}
+ should be equal as strings ${json['status']} error
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* [PATCH openbmc-test-automation 60/60] updated the REST API for firmware version
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (58 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 59/60] OpenBMC REST Testing OpenBMC Patches
@ 2016-01-11 16:50 ` OpenBMC Patches
2016-01-12 0:00 ` [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository Daniel Axtens
2016-01-12 0:10 ` Cyril Bur
61 siblings, 0 replies; 70+ messages in thread
From: OpenBMC Patches @ 2016-01-11 16:50 UTC (permalink / raw)
To: openbmc
From: Manjunath A Kumatagi <mkumatag@in.ibm.com>
---
tests/test_fw_version.robot | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test_fw_version.robot b/tests/test_fw_version.robot
index 2c3337d..90721b7 100644
--- a/tests/test_fw_version.robot
+++ b/tests/test_fw_version.robot
@@ -15,8 +15,8 @@ Test Firmware Version
... $ git describe --dirty
... v0.1-34-g95f7347
... $
- ${resp} = OpenBMC Get Request /org/openbmc/inventory/system
+ ${resp} = OpenBMC Get Request /org/openbmc/inventory/system/chassis/motherboard/bmc
Should Be Equal As Strings ${resp.status_code} ${HTTP_OK}
${jsondata}= To Json ${resp.content}
- Should not be empty ${jsondata["data"]["Version"]}
- Should Match Regexp ${jsondata["data"]["Version"]} ^v\\d+\.\\d+
\ No newline at end of file
+ Should not be empty ${jsondata["data"]["version"]}
+ Should Match Regexp ${jsondata["data"]["version"]} ^v\\d+\.\\d+
\ No newline at end of file
--
2.6.4
^ permalink raw reply related [flat|nested] 70+ messages in thread* Re: [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (59 preceding siblings ...)
2016-01-11 16:50 ` [PATCH openbmc-test-automation 60/60] updated the REST API for firmware version OpenBMC Patches
@ 2016-01-12 0:00 ` Daniel Axtens
2016-01-12 0:10 ` Cyril Bur
61 siblings, 0 replies; 70+ messages in thread
From: Daniel Axtens @ 2016-01-12 0:00 UTC (permalink / raw)
To: OpenBMC Patches, openbmc
OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
I don't suppose there's any way we could get this cleaned up to make
review easier?
Maybe merging things like the commits below into commits they fix?
> fixed review comments
> fix review comment
> Modified the doc
> Fix errors
> fix review comment
> Fix errors
> first commit
> first commit
And giving these better names?
> added files
> added log statement
> added files
> added log statement
> Update README.md
> Update README.md
If not I guess tests > no tests regardless...
Regards,
Daniel
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository
2016-01-11 16:49 [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository OpenBMC Patches
` (60 preceding siblings ...)
2016-01-12 0:00 ` [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository Daniel Axtens
@ 2016-01-12 0:10 ` Cyril Bur
2016-01-12 9:35 ` Manjunath A Kumatagi
61 siblings, 1 reply; 70+ messages in thread
From: Cyril Bur @ 2016-01-12 0:10 UTC (permalink / raw)
To: OpenBMC Patches; +Cc: openbmc
On Mon, 11 Jan 2016 10:49:26 -0600
OpenBMC Patches <openbmc-patches@stwcx.xyz> wrote:
> Pull Manjunath's repository: https://github.com/mkumatag/openbmc-automation
> into openbmc.
>
Ummmm what happened here? It looks like the entire series is sent twice?
I've had an initial skim read and it looks to me like you can squash A LOT of
those patches together.
The commits don't need to be a story of how you got from no code to the
this point in time. Each commit should add a feature and associated
documentation. It looks like most of patches 0-6 can be one commit, same for
some subsequent patches.
Heres an example of some issues I've noticed:
In patch 2 you add tests/test_ssh.robot but then in patch 7 you delete
tests/test_ssh.robot. There are several examples of a patch adding a
significant chunk of work and then a later patch removing this chunk of work, if
after the series the chunk of work won't be in the repo then it shouldn't have
appeared in the series at all.
Patch 26 "Fix errors" should be squashed into the broken commit. Patch 22 looks
that way too and Patch 17. The reason we do this is that way when something
does go wrong and something doesn't work it makes it much easier to find the
broken patch, you should never submit a patches that is broken even if it is
fixed directly after this breaks the assumption that every commit we make is
good and therefore when chasing a bug if a broken patch is found, is it likely
to be that bug, much easier to automate.
Your patch 28 that "Adds one more ssl test" should be squashed into the patch
adding the ssl tests, add them all once for this series. You can always more
work on more later but this series you have one patch adding ssl tests, have
all the ssl tests you're adding in that patch.
Hopefully that makes sense, please ask if I've just rambled!
Cyril
> https://github.com/openbmc/openbmc-test-automation/pull/1
>
> Chris Austen (16):
> Added DIMM specific inventory tests
> base add for sensor tests
> fixed review comments
> created loops for tests
> Add initial rest test cases Support to test Null properties
> Added full sensor suite
> Update README.md
> Handle new rest client from Brad
> Added DIMM specific inventory tests
> base add for sensor tests
> fixed review comments
> created loops for tests
> Add initial rest test cases Support to test Null properties
> Added full sensor suite
> Update README.md
> Handle new rest client from Brad
>
> Manjunath A Kumatagi (34):
> Added git ignore file
> Use argumnet file with pyrobot and added instructions to READEME file.
> Update README for better html display
> Added Inventory list testcase
> fixed errors in tox and generate_argumentfile.sh script
> Moved Read Attribute and Read Properties to rest_client
> fix review comment
> Added SSL tests
> Ran the tests and fixed errors in SSL tests
> Modified the doc
> Added firmware version validation test
> update readme file with tox version
> Fix errors
> Fix Errors in test_obmcrest.robot and removed the empty testcases.
> Added one more testcase to test non-ssl connection to port 443
> OpenBMC REST Testing
> updated the REST API for firmware version
> Added git ignore file
> Use argumnet file with pyrobot and added instructions to READEME file.
> Update README for better html display
> Added Inventory list testcase
> fixed errors in tox and generate_argumentfile.sh script
> Moved Read Attribute and Read Properties to rest_client
> fix review comment
> Added SSL tests
> Ran the tests and fixed errors in SSL tests
> Modified the doc
> Added firmware version validation test
> update readme file with tox version
> Fix errors
> Fix Errors in test_obmcrest.robot and removed the empty testcases.
> Added one more testcase to test non-ssl connection to port 443
> OpenBMC REST Testing
> updated the REST API for firmware version
>
> Manjunath Kumatagi (2):
> first commit
> first commit
>
> manjunath (6):
> added files
> added log statement
> added testcase for etc passwd
> added files
> added log statement
> added testcase for etc passwd
>
> mkumatag (2):
> Update README.md
> Update README.md
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [PATCH openbmc-test-automation 00/60] Pull Manjunath's automation repository
2016-01-12 0:10 ` Cyril Bur
@ 2016-01-12 9:35 ` Manjunath A Kumatagi
0 siblings, 0 replies; 70+ messages in thread
From: Manjunath A Kumatagi @ 2016-01-12 9:35 UTC (permalink / raw)
To: Cyril Bur; +Cc: OpenBMC Patches, openbmc
[-- Attachment #1.1: Type: text/plain, Size: 5331 bytes --]
These code changes are done long back in my private repository, now part of
mirroring process into openbmc org - we are seeing all of these big list of
commits again in the PR. However all points mention below are very valid
observation and I'll make sure to follow those guidelines going forward.
Thanks,
Manjunath.
From: Cyril Bur <cyrilbur@gmail.com>
To: OpenBMC Patches <openbmc-patches@stwcx.xyz>
Cc: openbmc@lists.ozlabs.org
Date: 01/12/2016 05:41 AM
Subject: Re: [PATCH openbmc-test-automation 00/60] Pull Manjunath's
automation repository
Sent by: "openbmc" <openbmc-bounces
+mkumatag=in.ibm.com@lists.ozlabs.org>
On Mon, 11 Jan 2016 10:49:26 -0600
OpenBMC Patches <openbmc-patches@stwcx.xyz> wrote:
> Pull Manjunath's repository:
https://github.com/mkumatag/openbmc-automation
> into openbmc.
>
Ummmm what happened here? It looks like the entire series is sent twice?
I've had an initial skim read and it looks to me like you can squash A LOT
of
those patches together.
The commits don't need to be a story of how you got from no code to the
this point in time. Each commit should add a feature and associated
documentation. It looks like most of patches 0-6 can be one commit, same
for
some subsequent patches.
Heres an example of some issues I've noticed:
In patch 2 you add tests/test_ssh.robot but then in patch 7 you delete
tests/test_ssh.robot. There are several examples of a patch adding a
significant chunk of work and then a later patch removing this chunk of
work, if
after the series the chunk of work won't be in the repo then it shouldn't
have
appeared in the series at all.
Patch 26 "Fix errors" should be squashed into the broken commit. Patch 22
looks
that way too and Patch 17. The reason we do this is that way when something
does go wrong and something doesn't work it makes it much easier to find
the
broken patch, you should never submit a patches that is broken even if it
is
fixed directly after this breaks the assumption that every commit we make
is
good and therefore when chasing a bug if a broken patch is found, is it
likely
to be that bug, much easier to automate.
Your patch 28 that "Adds one more ssl test" should be squashed into the
patch
adding the ssl tests, add them all once for this series. You can always
more
work on more later but this series you have one patch adding ssl tests,
have
all the ssl tests you're adding in that patch.
Hopefully that makes sense, please ask if I've just rambled!
Cyril
> https://github.com/openbmc/openbmc-test-automation/pull/1
>
> Chris Austen (16):
> Added DIMM specific inventory tests
> base add for sensor tests
> fixed review comments
> created loops for tests
> Add initial rest test cases Support to test Null properties
> Added full sensor suite
> Update README.md
> Handle new rest client from Brad
> Added DIMM specific inventory tests
> base add for sensor tests
> fixed review comments
> created loops for tests
> Add initial rest test cases Support to test Null properties
> Added full sensor suite
> Update README.md
> Handle new rest client from Brad
>
> Manjunath A Kumatagi (34):
> Added git ignore file
> Use argumnet file with pyrobot and added instructions to READEME file.
> Update README for better html display
> Added Inventory list testcase
> fixed errors in tox and generate_argumentfile.sh script
> Moved Read Attribute and Read Properties to rest_client
> fix review comment
> Added SSL tests
> Ran the tests and fixed errors in SSL tests
> Modified the doc
> Added firmware version validation test
> update readme file with tox version
> Fix errors
> Fix Errors in test_obmcrest.robot and removed the empty testcases.
> Added one more testcase to test non-ssl connection to port 443
> OpenBMC REST Testing
> updated the REST API for firmware version
> Added git ignore file
> Use argumnet file with pyrobot and added instructions to READEME file.
> Update README for better html display
> Added Inventory list testcase
> fixed errors in tox and generate_argumentfile.sh script
> Moved Read Attribute and Read Properties to rest_client
> fix review comment
> Added SSL tests
> Ran the tests and fixed errors in SSL tests
> Modified the doc
> Added firmware version validation test
> update readme file with tox version
> Fix errors
> Fix Errors in test_obmcrest.robot and removed the empty testcases.
> Added one more testcase to test non-ssl connection to port 443
> OpenBMC REST Testing
> updated the REST API for firmware version
>
> Manjunath Kumatagi (2):
> first commit
> first commit
>
> manjunath (6):
> added files
> added log statement
> added testcase for etc passwd
> added files
> added log statement
> added testcase for etc passwd
>
> mkumatag (2):
> Update README.md
> Update README.md
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
_______________________________________________
openbmc mailing list
openbmc@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/openbmc
[-- Attachment #1.2: Type: text/html, Size: 7416 bytes --]
[-- Attachment #2: graycol.gif --]
[-- Type: image/gif, Size: 105 bytes --]
^ permalink raw reply [flat|nested] 70+ messages in thread
![[-- Attachment #2: graycol.gif --] [-- Type: image/gif, Size: 105 bytes --]](../../201601120936.u0C9aFdW000730@d28av06.in.ibm.com/2-graycol.gif){kind=link}