All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-11 17:00 ` Guenter Roeck
  0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-11 17:00 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: Krzysztof Kozlowski, Russell King, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, Guenter Roeck, Linus Walleij

Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
all users of struct bgpio_pdata depend on GPIO_GENERIC.

This results in the following build error.

arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
	excess elements in struct initializer
arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
	(near initialization for '(anonymous)')
arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
	invalid use of undefined type 'struct bgpio_pdata'

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I don't know if this is the correct way to fix this problem.
If not, please consider this to be a bug report.

 arch/arm/mach-s3c64xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 7c0c420c3016..98d2aa9393f1 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
 	depends on I2C=y
 	select CPU_S3C6410
 	select LEDS_GPIO_REGISTER
+	select GPIO_GENERIC_PLATFORM
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
 	select S3C64XX_SETUP_I2C1
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-11 17:00 ` Guenter Roeck
  0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-11 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
all users of struct bgpio_pdata depend on GPIO_GENERIC.

This results in the following build error.

arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
	excess elements in struct initializer
arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
	(near initialization for '(anonymous)')
arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
	invalid use of undefined type 'struct bgpio_pdata'

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
I don't know if this is the correct way to fix this problem.
If not, please consider this to be a bug report.

 arch/arm/mach-s3c64xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 7c0c420c3016..98d2aa9393f1 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410
 	depends on I2C=y
 	select CPU_S3C6410
 	select LEDS_GPIO_REGISTER
+	select GPIO_GENERIC_PLATFORM
 	select S3C64XX_DEV_SPI0
 	select S3C64XX_SETUP_FB_24BPP
 	select S3C64XX_SETUP_I2C1
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
  2016-01-11 17:00 ` Guenter Roeck
@ 2016-01-12  0:52   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-12  0:52 UTC (permalink / raw)
  To: Guenter Roeck, Kukjin Kim
  Cc: Russell King, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	Linus Walleij

On 12.01.2016 02:00, Guenter Roeck wrote:
> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
> 
> This results in the following build error.
> 
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	(near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
> 	invalid use of undefined type 'struct bgpio_pdata'
> 
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.
> 
>  arch/arm/mach-s3c64xx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks for the report! I think that:

1. Other boards using the bgpio_pdata might be also affected:
mach-clps711x/board-autcpu12.c
mach-clps711x/board-p720t.c
mach-imx/mach-mx21ads.c

2. The boards does not directly depend on the GPIO_GENERIC.
If GPIO_GENERIC is not selected then it still might create
a basic-mmio-gpio device. The device of course won't be in
such case supported by any driver.


Instead to solve the error the structure should be
always visible so:


-- >8 --
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Date: Tue, 12 Jan 2016 09:46:06 +0900
Subject: [PATCH] gpio: generic: Fix build error of missing bgpio_pdata
 declaration

Commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
introduced struct bgpio_pdata along with users but made the declaration
hidden by CONFIG_GPIO_GENERIC.

This results in the following build error:

arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: 	excess elements in struct initializer
arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:	(near initialization for '(anonymous)')
arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:	invalid use of undefined type 'struct bgpio_pdata'

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 include/linux/gpio/driver.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index e2d05fd0e6e3..7b9054366e7a 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -220,14 +220,13 @@ static inline void *gpiochip_get_data(struct gpio_chip *chip)
 
 struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
 
-#if IS_ENABLED(CONFIG_GPIO_GENERIC)
-
 struct bgpio_pdata {
 	const char *label;
 	int base;
 	int ngpio;
 };
 
+#if IS_ENABLED(CONFIG_GPIO_GENERIC)
 int bgpio_init(struct gpio_chip *gc, struct device *dev,
 	       unsigned long sz, void __iomem *dat, void __iomem *set,
 	       void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-12  0:52   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-01-12  0:52 UTC (permalink / raw)
  To: linux-arm-kernel

On 12.01.2016 02:00, Guenter Roeck wrote:
> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
> 
> This results in the following build error.
> 
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
> 	(near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
> 	invalid use of undefined type 'struct bgpio_pdata'
> 
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.
> 
>  arch/arm/mach-s3c64xx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks for the report! I think that:

1. Other boards using the bgpio_pdata might be also affected:
mach-clps711x/board-autcpu12.c
mach-clps711x/board-p720t.c
mach-imx/mach-mx21ads.c

2. The boards does not directly depend on the GPIO_GENERIC.
If GPIO_GENERIC is not selected then it still might create
a basic-mmio-gpio device. The device of course won't be in
such case supported by any driver.


Instead to solve the error the structure should be
always visible so:


-- >8 --
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Date: Tue, 12 Jan 2016 09:46:06 +0900
Subject: [PATCH] gpio: generic: Fix build error of missing bgpio_pdata
 declaration

Commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
introduced struct bgpio_pdata along with users but made the declaration
hidden by CONFIG_GPIO_GENERIC.

This results in the following build error:

arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: 	excess elements in struct initializer
arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:	(near initialization for '(anonymous)')
arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:	invalid use of undefined type 'struct bgpio_pdata'

Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 include/linux/gpio/driver.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index e2d05fd0e6e3..7b9054366e7a 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -220,14 +220,13 @@ static inline void *gpiochip_get_data(struct gpio_chip *chip)
 
 struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
 
-#if IS_ENABLED(CONFIG_GPIO_GENERIC)
-
 struct bgpio_pdata {
 	const char *label;
 	int base;
 	int ngpio;
 };
 
+#if IS_ENABLED(CONFIG_GPIO_GENERIC)
 int bgpio_init(struct gpio_chip *gc, struct device *dev,
 	       unsigned long sz, void __iomem *dat, void __iomem *set,
 	       void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
  2016-01-12  0:52   ` Krzysztof Kozlowski
@ 2016-01-12  1:24     ` Guenter Roeck
  -1 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-12  1:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Kukjin Kim
  Cc: Russell King, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	Linus Walleij

On 01/11/2016 04:52 PM, Krzysztof Kozlowski wrote:
> On 12.01.2016 02:00, Guenter Roeck wrote:
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>> 	excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>> 	(near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>> 	invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>>
>>   arch/arm/mach-s3c64xx/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>
> Thanks for the report! I think that:
>
> 1. Other boards using the bgpio_pdata might be also affected:
> mach-clps711x/board-autcpu12.c
> mach-clps711x/board-p720t.c
> mach-imx/mach-mx21ads.c
>
> 2. The boards does not directly depend on the GPIO_GENERIC.
> If GPIO_GENERIC is not selected then it still might create
> a basic-mmio-gpio device. The device of course won't be in
> such case supported by any driver.
>
>
> Instead to solve the error the structure should be
> always visible so:
>
>
> -- >8 --
> From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Date: Tue, 12 Jan 2016 09:46:06 +0900
> Subject: [PATCH] gpio: generic: Fix build error of missing bgpio_pdata
>   declaration
>
> Commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> introduced struct bgpio_pdata along with users but made the declaration
> hidden by CONFIG_GPIO_GENERIC.
>
> This results in the following build error:
>
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: 	excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:	(near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:	invalid use of undefined type 'struct bgpio_pdata'
>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Reported-by: Guenter Roeck <linux@roeck-us.net>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>   include/linux/gpio/driver.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index e2d05fd0e6e3..7b9054366e7a 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -220,14 +220,13 @@ static inline void *gpiochip_get_data(struct gpio_chip *chip)
>
>   struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
>
> -#if IS_ENABLED(CONFIG_GPIO_GENERIC)
> -
>   struct bgpio_pdata {
>   	const char *label;
>   	int base;
>   	int ngpio;
>   };
>
> +#if IS_ENABLED(CONFIG_GPIO_GENERIC)
>   int bgpio_init(struct gpio_chip *gc, struct device *dev,
>   	       unsigned long sz, void __iomem *dat, void __iomem *set,
>   	       void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-12  1:24     ` Guenter Roeck
  0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-12  1:24 UTC (permalink / raw)
  To: linux-arm-kernel

On 01/11/2016 04:52 PM, Krzysztof Kozlowski wrote:
> On 12.01.2016 02:00, Guenter Roeck wrote:
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>> 	excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>> 	(near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>> 	invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>>
>>   arch/arm/mach-s3c64xx/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>
> Thanks for the report! I think that:
>
> 1. Other boards using the bgpio_pdata might be also affected:
> mach-clps711x/board-autcpu12.c
> mach-clps711x/board-p720t.c
> mach-imx/mach-mx21ads.c
>
> 2. The boards does not directly depend on the GPIO_GENERIC.
> If GPIO_GENERIC is not selected then it still might create
> a basic-mmio-gpio device. The device of course won't be in
> such case supported by any driver.
>
>
> Instead to solve the error the structure should be
> always visible so:
>
>
> -- >8 --
> From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Date: Tue, 12 Jan 2016 09:46:06 +0900
> Subject: [PATCH] gpio: generic: Fix build error of missing bgpio_pdata
>   declaration
>
> Commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> introduced struct bgpio_pdata along with users but made the declaration
> hidden by CONFIG_GPIO_GENERIC.
>
> This results in the following build error:
>
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: 	excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:	(near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:	invalid use of undefined type 'struct bgpio_pdata'
>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Reported-by: Guenter Roeck <linux@roeck-us.net>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>   include/linux/gpio/driver.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index e2d05fd0e6e3..7b9054366e7a 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -220,14 +220,13 @@ static inline void *gpiochip_get_data(struct gpio_chip *chip)
>
>   struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc);
>
> -#if IS_ENABLED(CONFIG_GPIO_GENERIC)
> -
>   struct bgpio_pdata {
>   	const char *label;
>   	int base;
>   	int ngpio;
>   };
>
> +#if IS_ENABLED(CONFIG_GPIO_GENERIC)
>   int bgpio_init(struct gpio_chip *gc, struct device *dev,
>   	       unsigned long sz, void __iomem *dat, void __iomem *set,
>   	       void __iomem *clr, void __iomem *dirout, void __iomem *dirin,
>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
  2016-01-11 17:00 ` Guenter Roeck
  (?)
@ 2016-01-14  9:02   ` Linus Walleij
  -1 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2016-01-14  9:02 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Kukjin Kim, Krzysztof Kozlowski, Russell King, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>
> This results in the following build error.
>
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         (near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>         invalid use of undefined type 'struct bgpio_pdata'
>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.

I think this is fixed by Arnds patch:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2

Can you verify that?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-14  9:02   ` Linus Walleij
  0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2016-01-14  9:02 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Kukjin Kim, Krzysztof Kozlowski, Russell King, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>
> This results in the following build error.
>
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         (near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>         invalid use of undefined type 'struct bgpio_pdata'
>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.

I think this is fixed by Arnds patch:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2

Can you verify that?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-14  9:02   ` Linus Walleij
  0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2016-01-14  9:02 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:

> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>
> This results in the following build error.
>
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         excess elements in struct initializer
> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>         (near initialization for '(anonymous)')
> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>         invalid use of undefined type 'struct bgpio_pdata'
>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I don't know if this is the correct way to fix this problem.
> If not, please consider this to be a bug report.

I think this is fixed by Arnds patch:
http://marc.info/?l=linux-gpio&m=145237423205247&w=2

Can you verify that?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
  2016-01-14  9:02   ` Linus Walleij
  (?)
@ 2016-01-14  9:54     ` Guenter Roeck
  -1 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-14  9:54 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Kukjin Kim, Krzysztof Kozlowski, Russell King, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 01/14/2016 01:02 AM, Linus Walleij wrote:
> On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          (near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>>          invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>
> I think this is fixed by Arnds patch:
> http://marc.info/?l=linux-gpio&m=145237423205247&w=2
>
> Can you verify that?
>

Correct.

Guenter

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-14  9:54     ` Guenter Roeck
  0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-14  9:54 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Kukjin Kim, Krzysztof Kozlowski, Russell King, linux-arm-kernel,
	linux-samsung-soc, linux-kernel

On 01/14/2016 01:02 AM, Linus Walleij wrote:
> On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          (near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>>          invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>
> I think this is fixed by Arnds patch:
> http://marc.info/?l=linux-gpio&m=145237423205247&w=2
>
> Can you verify that?
>

Correct.

Guenter

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410
@ 2016-01-14  9:54     ` Guenter Roeck
  0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2016-01-14  9:54 UTC (permalink / raw)
  To: linux-arm-kernel

On 01/14/2016 01:02 AM, Linus Walleij wrote:
> On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"),
>> all users of struct bgpio_pdata depend on GPIO_GENERIC.
>>
>> This results in the following build error.
>>
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          excess elements in struct initializer
>> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning:
>>          (near initialization for '(anonymous)')
>> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error:
>>          invalid use of undefined type 'struct bgpio_pdata'
>>
>> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I don't know if this is the correct way to fix this problem.
>> If not, please consider this to be a bug report.
>
> I think this is fixed by Arnds patch:
> http://marc.info/?l=linux-gpio&m=145237423205247&w=2
>
> Can you verify that?
>

Correct.

Guenter

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-01-14  9:54 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-11 17:00 [PATCH -next] arm: Select GPIO_GENERIC_PLATFORM for CRAGG_6410 Guenter Roeck
2016-01-11 17:00 ` Guenter Roeck
2016-01-12  0:52 ` Krzysztof Kozlowski
2016-01-12  0:52   ` Krzysztof Kozlowski
2016-01-12  1:24   ` Guenter Roeck
2016-01-12  1:24     ` Guenter Roeck
2016-01-14  9:02 ` Linus Walleij
2016-01-14  9:02   ` Linus Walleij
2016-01-14  9:02   ` Linus Walleij
2016-01-14  9:54   ` Guenter Roeck
2016-01-14  9:54     ` Guenter Roeck
2016-01-14  9:54     ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.