* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 13:31 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-01-12 13:31 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: kernel, maxime.coquelin, mmarek, linux-kbuild, Lee Jones, Arnd Bergmann
Ideally, a kernel compile with W=1 enabled should complete cleanly;
however, when we run one currently we are presented with ~25k warnings.
'sign-compare' accounts for ~22k of those ~25k.
In this patch we're demoting 'sign-compare' warnings to W=2, with a view
to fixing the remaining 3k W=1 warnings required for a clean build.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
| 2 ++
1 file changed, 2 insertions(+)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 4efedcb..f9e47a7 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition
warning-1 += $(call cc-option, -Wmissing-include-dirs)
warning-1 += $(call cc-option, -Wunused-but-set-variable)
warning-1 += $(call cc-disable-warning, missing-field-initializers)
+warning-1 += $(call cc-disable-warning, sign-compare)
warning-2 := -Waggregate-return
warning-2 += -Wcast-align
@@ -33,6 +34,7 @@ warning-2 += -Wnested-externs
warning-2 += -Wshadow
warning-2 += $(call cc-option, -Wlogical-op)
warning-2 += $(call cc-option, -Wmissing-field-initializers)
+warning-2 += $(call cc-option, -Wsign-compare)
warning-3 := -Wbad-function-cast
warning-3 += -Wcast-qual
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 13:31 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-01-12 13:31 UTC (permalink / raw)
To: linux-arm-kernel
Ideally, a kernel compile with W=1 enabled should complete cleanly;
however, when we run one currently we are presented with ~25k warnings.
'sign-compare' accounts for ~22k of those ~25k.
In this patch we're demoting 'sign-compare' warnings to W=2, with a view
to fixing the remaining 3k W=1 warnings required for a clean build.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
| 2 ++
1 file changed, 2 insertions(+)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 4efedcb..f9e47a7 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition
warning-1 += $(call cc-option, -Wmissing-include-dirs)
warning-1 += $(call cc-option, -Wunused-but-set-variable)
warning-1 += $(call cc-disable-warning, missing-field-initializers)
+warning-1 += $(call cc-disable-warning, sign-compare)
warning-2 := -Waggregate-return
warning-2 += -Wcast-align
@@ -33,6 +34,7 @@ warning-2 += -Wnested-externs
warning-2 += -Wshadow
warning-2 += $(call cc-option, -Wlogical-op)
warning-2 += $(call cc-option, -Wmissing-field-initializers)
+warning-2 += $(call cc-option, -Wsign-compare)
warning-3 := -Wbad-function-cast
warning-3 += -Wcast-qual
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2
2016-01-12 13:31 ` Lee Jones
@ 2016-01-12 14:05 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:05 UTC (permalink / raw)
To: Lee Jones
Cc: linux-arm-kernel, linux-kernel, kernel, maxime.coquelin, mmarek,
linux-kbuild, Behan Webster, Jan-Simon Möller
On Tuesday 12 January 2016 13:31:59 Lee Jones wrote:
> Ideally, a kernel compile with W=1 enabled should complete cleanly;
> however, when we run one currently we are presented with ~25k warnings.
> 'sign-compare' accounts for ~22k of those ~25k.
>
> In this patch we're demoting 'sign-compare' warnings to W=2, with a view
> to fixing the remaining 3k W=1 warnings required for a clean build.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
As per our discussion, I'd add that this was inadvertedly introduced
by Behan when he moved the clang specific warnings into an ifdef block
and did not notice that -Wsign-compare was interpreted by both gcc
and clang.
Earlier, it was introduced in just the same way by Jan-Simon as part
of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation with clang").
The new patch looks good to me, please add
Acked-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
I've started looking into building the kernel with clang, and will likely
follow up with further unrelated changes to the list, as clang-3.9
seems to generate a couple of extra warnings we want to suppress.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 14:05 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 12 January 2016 13:31:59 Lee Jones wrote:
> Ideally, a kernel compile with W=1 enabled should complete cleanly;
> however, when we run one currently we are presented with ~25k warnings.
> 'sign-compare' accounts for ~22k of those ~25k.
>
> In this patch we're demoting 'sign-compare' warnings to W=2, with a view
> to fixing the remaining 3k W=1 warnings required for a clean build.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
As per our discussion, I'd add that this was inadvertedly introduced
by Behan when he moved the clang specific warnings into an ifdef block
and did not notice that -Wsign-compare was interpreted by both gcc
and clang.
Earlier, it was introduced in just the same way by Jan-Simon as part
of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation with clang").
The new patch looks good to me, please add
Acked-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
I've started looking into building the kernel with clang, and will likely
follow up with further unrelated changes to the list, as clang-3.9
seems to generate a couple of extra warnings we want to suppress.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 14:24 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-01-12 14:24 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: kernel, maxime.coquelin, mmarek, linux-kbuild, arnd, Lee Jones
Ideally, a kernel compile with W=1 enabled should complete cleanly;
however, when we run one currently we are presented with ~25k warnings.
'sign-compare' accounts for ~22k of those ~25k.
In this patch we're demoting 'sign-compare' warnings to W=2, with a view
to fixing the remaining 3k W=1 warnings required for a clean build.
Arnd adds:
"As per our discussion, I'd add that this was inadvertedly introduced
by Behan when he moved the clang specific warnings into an ifdef block
and did not notice that -Wsign-compare was interpreted by both gcc
and clang.
Earlier, it was introduced in just the same way by Jan-Simon as part
of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation
with clang")."
Acked-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
| 2 ++
1 file changed, 2 insertions(+)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 4efedcb..f9e47a7 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition
warning-1 += $(call cc-option, -Wmissing-include-dirs)
warning-1 += $(call cc-option, -Wunused-but-set-variable)
warning-1 += $(call cc-disable-warning, missing-field-initializers)
+warning-1 += $(call cc-disable-warning, sign-compare)
warning-2 := -Waggregate-return
warning-2 += -Wcast-align
@@ -33,6 +34,7 @@ warning-2 += -Wnested-externs
warning-2 += -Wshadow
warning-2 += $(call cc-option, -Wlogical-op)
warning-2 += $(call cc-option, -Wmissing-field-initializers)
+warning-2 += $(call cc-option, -Wsign-compare)
warning-3 := -Wbad-function-cast
warning-3 += -Wcast-qual
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 14:24 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-01-12 14:24 UTC (permalink / raw)
To: linux-arm-kernel
Ideally, a kernel compile with W=1 enabled should complete cleanly;
however, when we run one currently we are presented with ~25k warnings.
'sign-compare' accounts for ~22k of those ~25k.
In this patch we're demoting 'sign-compare' warnings to W=2, with a view
to fixing the remaining 3k W=1 warnings required for a clean build.
Arnd adds:
"As per our discussion, I'd add that this was inadvertedly introduced
by Behan when he moved the clang specific warnings into an ifdef block
and did not notice that -Wsign-compare was interpreted by both gcc
and clang.
Earlier, it was introduced in just the same way by Jan-Simon as part
of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation
with clang")."
Acked-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
| 2 ++
1 file changed, 2 insertions(+)
--git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 4efedcb..f9e47a7 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition
warning-1 += $(call cc-option, -Wmissing-include-dirs)
warning-1 += $(call cc-option, -Wunused-but-set-variable)
warning-1 += $(call cc-disable-warning, missing-field-initializers)
+warning-1 += $(call cc-disable-warning, sign-compare)
warning-2 := -Waggregate-return
warning-2 += -Wcast-align
@@ -33,6 +34,7 @@ warning-2 += -Wnested-externs
warning-2 += -Wshadow
warning-2 += $(call cc-option, -Wlogical-op)
warning-2 += $(call cc-option, -Wmissing-field-initializers)
+warning-2 += $(call cc-option, -Wsign-compare)
warning-3 := -Wbad-function-cast
warning-3 += -Wcast-qual
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: Demote 'sign-compare' warning to W=2
2016-01-12 14:24 ` Lee Jones
@ 2016-01-12 15:08 ` Michal Marek
-1 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2016-01-12 15:08 UTC (permalink / raw)
To: Lee Jones
Cc: linux-arm-kernel, linux-kernel, kernel, maxime.coquelin,
linux-kbuild, arnd
On 2016-01-12 15:24, Lee Jones wrote:
> Ideally, a kernel compile with W=1 enabled should complete cleanly;
> however, when we run one currently we are presented with ~25k warnings.
> 'sign-compare' accounts for ~22k of those ~25k.
>
> In this patch we're demoting 'sign-compare' warnings to W=2, with a view
> to fixing the remaining 3k W=1 warnings required for a clean build.
>
> Arnd adds:
> "As per our discussion, I'd add that this was inadvertedly introduced
> by Behan when he moved the clang specific warnings into an ifdef block
> and did not notice that -Wsign-compare was interpreted by both gcc
> and clang.
>
> Earlier, it was introduced in just the same way by Jan-Simon as part
> of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation
> with clang")."
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to kbuild.git#kbuild.
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] kbuild: Demote 'sign-compare' warning to W=2
@ 2016-01-12 15:08 ` Michal Marek
0 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2016-01-12 15:08 UTC (permalink / raw)
To: linux-arm-kernel
On 2016-01-12 15:24, Lee Jones wrote:
> Ideally, a kernel compile with W=1 enabled should complete cleanly;
> however, when we run one currently we are presented with ~25k warnings.
> 'sign-compare' accounts for ~22k of those ~25k.
>
> In this patch we're demoting 'sign-compare' warnings to W=2, with a view
> to fixing the remaining 3k W=1 warnings required for a clean build.
>
> Arnd adds:
> "As per our discussion, I'd add that this was inadvertedly introduced
> by Behan when he moved the clang specific warnings into an ifdef block
> and did not notice that -Wsign-compare was interpreted by both gcc
> and clang.
>
> Earlier, it was introduced in just the same way by Jan-Simon as part
> of 3d3d6b847420 ("kbuild: LLVMLinux: Adapt warnings for compilation
> with clang")."
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to kbuild.git#kbuild.
Michal
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-12 15:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 13:31 [PATCH] kbuild: Demote 'sign-compare' warning to W=2 Lee Jones
2016-01-12 13:31 ` Lee Jones
2016-01-12 14:05 ` Arnd Bergmann
2016-01-12 14:05 ` Arnd Bergmann
2016-01-12 14:24 Lee Jones
2016-01-12 14:24 ` Lee Jones
2016-01-12 15:08 ` Michal Marek
2016-01-12 15:08 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.