* [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
@ 2016-01-12 14:08 Christophe Fergeau
2016-01-12 14:27 ` Gerd Hoffmann
2016-01-15 23:33 ` Eric Blake
0 siblings, 2 replies; 5+ messages in thread
From: Christophe Fergeau @ 2016-01-12 14:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
spice_server_init() will get called without a previous call to
spice_server_set_sasl_appname(), which will cause cyrus-sasl to
try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
default appname) rather than the expected /etc/sasl2/qemu.conf.
This commit unconditionnally calls spice_server_set_sasl_appname()
before calling spice_server_init() in order to use the correct appname
even if SPICE without SASL was requested on qemu command line.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
ui/spice-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3322bf2..77b209f 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -743,8 +743,7 @@ void qemu_spice_init(void)
qemu_spice_set_passwd(password, false, false);
}
if (qemu_opt_get_bool(opts, "sasl", 0)) {
- if (spice_server_set_sasl_appname(spice_server, "qemu") == -1 ||
- spice_server_set_sasl(spice_server, 1) == -1) {
+ if (spice_server_set_sasl(spice_server, 1) == -1) {
error_report("spice: failed to enable sasl");
exit(1);
}
@@ -810,6 +809,7 @@ void qemu_spice_init(void)
seamless_migration = qemu_opt_get_bool(opts, "seamless-migration", 0);
spice_server_set_seamless_migration(spice_server, seamless_migration);
+ spice_server_set_sasl_appname(spice_server, "qemu");
if (spice_server_init(spice_server, &core_interface) != 0) {
error_report("failed to initialize spice server");
exit(1);
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
2016-01-12 14:08 [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE Christophe Fergeau
@ 2016-01-12 14:27 ` Gerd Hoffmann
2016-01-15 23:33 ` Eric Blake
1 sibling, 0 replies; 5+ messages in thread
From: Gerd Hoffmann @ 2016-01-12 14:27 UTC (permalink / raw)
To: Christophe Fergeau; +Cc: qemu-devel
On Di, 2016-01-12 at 15:08 +0100, Christophe Fergeau wrote:
> Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
> QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
> spice_server_init() will get called without a previous call to
> spice_server_set_sasl_appname(), which will cause cyrus-sasl to
> try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
> default appname) rather than the expected /etc/sasl2/qemu.conf.
>
> This commit unconditionnally calls spice_server_set_sasl_appname()
> before calling spice_server_init() in order to use the correct appname
> even if SPICE without SASL was requested on qemu command line.
Added to patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
2016-01-12 14:08 [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE Christophe Fergeau
2016-01-12 14:27 ` Gerd Hoffmann
@ 2016-01-15 23:33 ` Eric Blake
2016-01-18 10:11 ` Gerd Hoffmann
1 sibling, 1 reply; 5+ messages in thread
From: Eric Blake @ 2016-01-15 23:33 UTC (permalink / raw)
To: Christophe Fergeau, qemu-devel; +Cc: Gerd Hoffmann
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
On 01/12/2016 07:08 AM, Christophe Fergeau wrote:
> Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting
> QEMU with SPICE but no SASL, and at the same time VNC with SASL, then
> spice_server_init() will get called without a previous call to
> spice_server_set_sasl_appname(), which will cause cyrus-sasl to
> try to use /etc/sasl2/spice.conf (spice-server uses "spice" as its
> default appname) rather than the expected /etc/sasl2/qemu.conf.
>
> This commit unconditionnally calls spice_server_set_sasl_appname()
s/unconditionnally/unconditionally/
> before calling spice_server_init() in order to use the correct appname
> even if SPICE without SASL was requested on qemu command line.
>
> Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> ---
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
2016-01-15 23:33 ` Eric Blake
@ 2016-01-18 10:11 ` Gerd Hoffmann
2016-01-18 10:41 ` Christophe Fergeau
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2016-01-18 10:11 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, Christophe Fergeau
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote:
> > This commit unconditionnally calls spice_server_set_sasl_appname()
>
> s/unconditionnally/unconditionally/
Fixed up, no need to resend.
cheers,
Gerd
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE
2016-01-18 10:11 ` Gerd Hoffmann
@ 2016-01-18 10:41 ` Christophe Fergeau
0 siblings, 0 replies; 5+ messages in thread
From: Christophe Fergeau @ 2016-01-18 10:41 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
On Mon, Jan 18, 2016 at 11:11:42AM +0100, Gerd Hoffmann wrote:
> On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote:
> > > This commit unconditionnally calls spice_server_set_sasl_appname()
> >
> > s/unconditionnally/unconditionally/
>
> Fixed up, no need to resend.
Thanks!
Christophe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-18 10:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 14:08 [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE Christophe Fergeau
2016-01-12 14:27 ` Gerd Hoffmann
2016-01-15 23:33 ` Eric Blake
2016-01-18 10:11 ` Gerd Hoffmann
2016-01-18 10:41 ` Christophe Fergeau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.