* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:17 Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 15:17 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lothar Waßmann, Lucas Stach, Nimrod Andy,
Philippe Reynes, Richard Cochran, Russell King, Sascha Hauer,
Stefan Agner, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, Jeff Kirsher,
Uwe Kleine-König, Ian Campbell, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring
This patchset fixes a regression introduced by
commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
Changes vs. v1:
- fixed reference to the commit that introduced the regression.
- dropped patch to use gpiod framework. This should be added later,
after the affected DTBs have been updated to specify the correct
gpio_flags.
Patch overview:
1. cleanup patch to remove redundant NULL checks
2. call fec_reset_phy() after the ENET_OUT clock has been enabled
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
2016-01-12 20:30 ` Uwe Kleine-König
(?)
@ 2016-09-26 15:37 ` Jörg Krause
-1 siblings, 0 replies; 16+ messages in thread
From: Jörg Krause @ 2016-09-26 15:37 UTC (permalink / raw)
To: Uwe Kleine-König, Lothar Waßmann
Cc: Mark Rutland, Andrew Lunn, Stefan Agner, Greg Ungerer,
Nimrod Andy, Jeff Kirsher, Richard Cochran, devicetree,
Pawel Moll, Ian Campbell, Sascha Hauer, Rob Herring,
Russell King - ARM Linux, linux-arm-kernel, Fabio Estevam,
Kevin Hao, netdev, linux-kernel, Sascha Hauer, Kumar Gala,
Philippe Reynes, Shawn Guo, David S. Miller, Lucas Stach
Hi all,
On Tue, 2016-01-12 at 21:30 +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Waßmann wrote:
> >
> > >
> > > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> > > >
> > > > This patchset fixes a regression introduced by
> > > > commit e8fcfcd5684a ("net: fec: optimize the clock management
> > > > to save power")
> > > > for ethernet PHYs that are using ENET_OUT as reference clock
> > > > (on i.MX6 or i.MX28)
> > > >
> > > > Changes vs. v1:
> > > > - fixed reference to the commit that introduced the regression.
> > > > - dropped patch to use gpiod framework. This should be added
> > > > later,
> > > > after the affected DTBs have been updated to specify the
> > > > correct
> > > > gpio_flags.
> > > >
> > > > Patch overview:
> > > > 1. cleanup patch to remove redundant NULL checks
> > > > 2. call fec_reset_phy() after the ENET_OUT clock has been
> > > > enabled
> > >
> > > I definitely want to test these on my SolidRun boards before
> > > these get
> > > merged: the AR8035 on there is configured via pin-straps, and
> > > then
> > > further tweaked with PHY quirks. Resetting with the iMX6 in the
> > > wrong state may result in the AR8035 being reconfigured (even
> > > jumping
> > > to a different MDIO address) and certainly would need the PHY
> > > quirks
> > > re-running.
> > >
> > As far as I can tell, all SolidRun boards do not specify the
> > enet_out
> > clock in the dtb, so the PHY reset behaviour should be unaffected
> > by
> > this patch on those boards, since the additional fec_reset_phy()
> > call is
> > framed by:
> > if (fep->clk_enet_out) {
> > ...
> > }
> >
> > But verifying this explicitly is of course a good idea.
>
> If the SolidRun boards don't do this, this doesn't mean it's safe in
> general. The problem is real, isn't it?
Anything new on this topic? I am facing the same issue with Linux
Kernel 4.7 and the MCSC LAN8720A on an i.MX28 board.
I found this patch on patchwork and it works for me.
Best regard
Jörg Krause
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-09-26 15:37 ` Jörg Krause
0 siblings, 0 replies; 16+ messages in thread
From: Jörg Krause @ 2016-09-26 15:37 UTC (permalink / raw)
To: Uwe Kleine-König, Lothar Waßmann
Cc: Mark Rutland, Andrew Lunn, Stefan Agner, Greg Ungerer,
Nimrod Andy, Jeff Kirsher, Sascha Hauer, devicetree, Pawel Moll,
Ian Campbell, Richard Cochran, Rob Herring,
Russell King - ARM Linux, linux-arm-kernel, Fabio Estevam,
Kevin Hao, netdev, linux-kernel, Sascha Hauer, Kumar Gala,
Lucas Stach, Shawn Guo, David S. Miller, Philippe Reynes
Hi all,
On Tue, 2016-01-12 at 21:30 +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Waßmann wrote:
> >
> > >
> > > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> > > >
> > > > This patchset fixes a regression introduced by
> > > > commit e8fcfcd5684a ("net: fec: optimize the clock management
> > > > to save power")
> > > > for ethernet PHYs that are using ENET_OUT as reference clock
> > > > (on i.MX6 or i.MX28)
> > > >
> > > > Changes vs. v1:
> > > > - fixed reference to the commit that introduced the regression.
> > > > - dropped patch to use gpiod framework. This should be added
> > > > later,
> > > > after the affected DTBs have been updated to specify the
> > > > correct
> > > > gpio_flags.
> > > >
> > > > Patch overview:
> > > > 1. cleanup patch to remove redundant NULL checks
> > > > 2. call fec_reset_phy() after the ENET_OUT clock has been
> > > > enabled
> > >
> > > I definitely want to test these on my SolidRun boards before
> > > these get
> > > merged: the AR8035 on there is configured via pin-straps, and
> > > then
> > > further tweaked with PHY quirks. Resetting with the iMX6 in the
> > > wrong state may result in the AR8035 being reconfigured (even
> > > jumping
> > > to a different MDIO address) and certainly would need the PHY
> > > quirks
> > > re-running.
> > >
> > As far as I can tell, all SolidRun boards do not specify the
> > enet_out
> > clock in the dtb, so the PHY reset behaviour should be unaffected
> > by
> > this patch on those boards, since the additional fec_reset_phy()
> > call is
> > framed by:
> > if (fep->clk_enet_out) {
> > ...
> > }
> >
> > But verifying this explicitly is of course a good idea.
>
> If the SolidRun boards don't do this, this doesn't mean it's safe in
> general. The problem is real, isn't it?
Anything new on this topic? I am facing the same issue with Linux
Kernel 4.7 and the MCSC LAN8720A on an i.MX28 board.
I found this patch on patchwork and it works for me.
Best regard
Jörg Krause
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-09-26 15:37 ` Jörg Krause
0 siblings, 0 replies; 16+ messages in thread
From: Jörg Krause @ 2016-09-26 15:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
On Tue, 2016-01-12 at 21:30 +0100, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Wa?mann wrote:
> >
> > >
> > > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Wa?mann wrote:
> > > >
> > > > This patchset fixes a regression introduced by
> > > > commit e8fcfcd5684a ("net: fec: optimize the clock management
> > > > to save power")
> > > > for ethernet PHYs that are using ENET_OUT as reference clock
> > > > (on i.MX6 or i.MX28)
> > > >
> > > > Changes vs. v1:
> > > > - fixed reference to the commit that introduced the regression.
> > > > - dropped patch to use gpiod framework. This should be added
> > > > later,
> > > > ? after the affected DTBs have been updated to specify the
> > > > correct
> > > > ? gpio_flags.
> > > >
> > > > Patch overview:
> > > > 1. cleanup patch to remove redundant NULL checks
> > > > 2. call fec_reset_phy() after the ENET_OUT clock has been
> > > > enabled
> > >
> > > I definitely want to test these on my SolidRun boards before
> > > these get
> > > merged: the AR8035 on there is configured via pin-straps, and
> > > then
> > > further tweaked with PHY quirks.??Resetting with the iMX6 in the
> > > wrong state may result in the AR8035 being reconfigured (even
> > > jumping
> > > to a different MDIO address) and certainly would need the PHY
> > > quirks
> > > re-running.
> > >
> > As far as I can tell, all SolidRun boards do not specify the
> > enet_out
> > clock in the dtb, so the PHY reset behaviour should be unaffected
> > by
> > this patch on those boards, since the additional fec_reset_phy()
> > call is
> > framed by:
> > if (fep->clk_enet_out) {
> > ...
> > }
> >
> > But verifying this explicitly is of course a good idea.
>
> If the SolidRun boards don't do this, this doesn't mean it's safe in
> general. The problem is real, isn't it?
Anything new on this topic? I am facing the same issue with Linux
Kernel 4.7 and the MCSC LAN8720A on an i.MX28 board.
I found this patch on patchwork and it works for me.
Best regard
J?rg Krause
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
2016-01-12 16:04 ` Lothar Waßmann
@ 2016-01-12 20:30 ` Uwe Kleine-König
-1 siblings, 0 replies; 16+ messages in thread
From: Uwe Kleine-König @ 2016-01-12 20:30 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Russell King - ARM Linux, Mark Rutland, Andrew Lunn,
Stefan Agner, Greg Ungerer, Nimrod Andy, Jeff Kirsher,
Sascha Hauer, devicetree, Pawel Moll, Ian Campbell,
Richard Cochran, Rob Herring, linux-arm-kernel, Fabio Estevam,
Kevin Hao, netdev, linux-kernel, Sascha Hauer, Kumar Gala,
Lucas Stach, Shawn Guo, David S. Miller, Philippe Reynes
Hello,
On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Waßmann wrote:
> > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> > > This patchset fixes a regression introduced by
> > > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> > > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> > >
> > > Changes vs. v1:
> > > - fixed reference to the commit that introduced the regression.
> > > - dropped patch to use gpiod framework. This should be added later,
> > > after the affected DTBs have been updated to specify the correct
> > > gpio_flags.
> > >
> > > Patch overview:
> > > 1. cleanup patch to remove redundant NULL checks
> > > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
> >
> > I definitely want to test these on my SolidRun boards before these get
> > merged: the AR8035 on there is configured via pin-straps, and then
> > further tweaked with PHY quirks. Resetting with the iMX6 in the
> > wrong state may result in the AR8035 being reconfigured (even jumping
> > to a different MDIO address) and certainly would need the PHY quirks
> > re-running.
> >
> As far as I can tell, all SolidRun boards do not specify the enet_out
> clock in the dtb, so the PHY reset behaviour should be unaffected by
> this patch on those boards, since the additional fec_reset_phy() call is
> framed by:
> if (fep->clk_enet_out) {
> ...
> }
>
> But verifying this explicitly is of course a good idea.
If the SolidRun boards don't do this, this doesn't mean it's safe in
general. The problem is real, isn't it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 20:30 ` Uwe Kleine-König
0 siblings, 0 replies; 16+ messages in thread
From: Uwe Kleine-König @ 2016-01-12 20:30 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Tue, Jan 12, 2016 at 05:04:44PM +0100, Lothar Wa?mann wrote:
> > On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Wa?mann wrote:
> > > This patchset fixes a regression introduced by
> > > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> > > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> > >
> > > Changes vs. v1:
> > > - fixed reference to the commit that introduced the regression.
> > > - dropped patch to use gpiod framework. This should be added later,
> > > after the affected DTBs have been updated to specify the correct
> > > gpio_flags.
> > >
> > > Patch overview:
> > > 1. cleanup patch to remove redundant NULL checks
> > > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
> >
> > I definitely want to test these on my SolidRun boards before these get
> > merged: the AR8035 on there is configured via pin-straps, and then
> > further tweaked with PHY quirks. Resetting with the iMX6 in the
> > wrong state may result in the AR8035 being reconfigured (even jumping
> > to a different MDIO address) and certainly would need the PHY quirks
> > re-running.
> >
> As far as I can tell, all SolidRun boards do not specify the enet_out
> clock in the dtb, so the PHY reset behaviour should be unaffected by
> this patch on those boards, since the additional fec_reset_phy() call is
> framed by:
> if (fep->clk_enet_out) {
> ...
> }
>
> But verifying this explicitly is of course a good idea.
If the SolidRun boards don't do this, this doesn't mean it's safe in
general. The problem is real, isn't it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
2016-01-12 15:24 ` Russell King - ARM Linux
(?)
@ 2016-01-12 16:04 ` Lothar Waßmann
-1 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 16:04 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lucas Stach, Nimrod Andy, Philippe Reynes,
Richard Cochran, Sascha Hauer, Stefan Agner, linux-kernel,
netdev, Jeff Kirsher, Uwe Kleine-König, Ian Campbell,
Kumar Gala, Mark Rutland, Pawel Moll, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree, linux-arm-kernel
Hi,
> On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> > This patchset fixes a regression introduced by
> > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> >
> > Changes vs. v1:
> > - fixed reference to the commit that introduced the regression.
> > - dropped patch to use gpiod framework. This should be added later,
> > after the affected DTBs have been updated to specify the correct
> > gpio_flags.
> >
> > Patch overview:
> > 1. cleanup patch to remove redundant NULL checks
> > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
>
> I definitely want to test these on my SolidRun boards before these get
> merged: the AR8035 on there is configured via pin-straps, and then
> further tweaked with PHY quirks. Resetting with the iMX6 in the
> wrong state may result in the AR8035 being reconfigured (even jumping
> to a different MDIO address) and certainly would need the PHY quirks
> re-running.
>
As far as I can tell, all SolidRun boards do not specify the enet_out
clock in the dtb, so the PHY reset behaviour should be unaffected by
this patch on those boards, since the additional fec_reset_phy() call is
framed by:
if (fep->clk_enet_out) {
...
}
But verifying this explicitly is of course a good idea.
Lothar Waßmann
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 16:04 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 16:04 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lucas Stach, Nimrod Andy, Philippe Reynes,
Richard Cochran, Sascha Hauer, Stefan Agner, linux-kernel,
netdev, Jeff Kirsher, Uwe Kleine-König, Ian Campbell,
Kumar Gala, Mark Rutland, Pawel Moll, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree
Hi,
> On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> > This patchset fixes a regression introduced by
> > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> >
> > Changes vs. v1:
> > - fixed reference to the commit that introduced the regression.
> > - dropped patch to use gpiod framework. This should be added later,
> > after the affected DTBs have been updated to specify the correct
> > gpio_flags.
> >
> > Patch overview:
> > 1. cleanup patch to remove redundant NULL checks
> > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
>
> I definitely want to test these on my SolidRun boards before these get
> merged: the AR8035 on there is configured via pin-straps, and then
> further tweaked with PHY quirks. Resetting with the iMX6 in the
> wrong state may result in the AR8035 being reconfigured (even jumping
> to a different MDIO address) and certainly would need the PHY quirks
> re-running.
>
As far as I can tell, all SolidRun boards do not specify the enet_out
clock in the dtb, so the PHY reset behaviour should be unaffected by
this patch on those boards, since the additional fec_reset_phy() call is
framed by:
if (fep->clk_enet_out) {
...
}
But verifying this explicitly is of course a good idea.
Lothar Waßmann
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 16:04 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 16:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
> On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Wa?mann wrote:
> > This patchset fixes a regression introduced by
> > commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> > for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
> >
> > Changes vs. v1:
> > - fixed reference to the commit that introduced the regression.
> > - dropped patch to use gpiod framework. This should be added later,
> > after the affected DTBs have been updated to specify the correct
> > gpio_flags.
> >
> > Patch overview:
> > 1. cleanup patch to remove redundant NULL checks
> > 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
>
> I definitely want to test these on my SolidRun boards before these get
> merged: the AR8035 on there is configured via pin-straps, and then
> further tweaked with PHY quirks. Resetting with the iMX6 in the
> wrong state may result in the AR8035 being reconfigured (even jumping
> to a different MDIO address) and certainly would need the PHY quirks
> re-running.
>
As far as I can tell, all SolidRun boards do not specify the enet_out
clock in the dtb, so the PHY reset behaviour should be unaffected by
this patch on those boards, since the additional fec_reset_phy() call is
framed by:
if (fep->clk_enet_out) {
...
}
But verifying this explicitly is of course a good idea.
Lothar Wa?mann
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
2016-01-12 15:17 ` Lothar Waßmann
(?)
@ 2016-01-12 15:24 ` Russell King - ARM Linux
-1 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2016-01-12 15:24 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lucas Stach, Nimrod Andy, Philippe Reynes,
Richard Cochran, Sascha Hauer, Stefan Agner, linux-kernel,
netdev, Jeff Kirsher, Uwe Kleine-König, Ian Campbell,
Kumar Gala, Mark Rutland, Pawel Moll, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree, linux-arm-kernel
On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> This patchset fixes a regression introduced by
> commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
>
> Changes vs. v1:
> - fixed reference to the commit that introduced the regression.
> - dropped patch to use gpiod framework. This should be added later,
> after the affected DTBs have been updated to specify the correct
> gpio_flags.
>
> Patch overview:
> 1. cleanup patch to remove redundant NULL checks
> 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
I definitely want to test these on my SolidRun boards before these get
merged: the AR8035 on there is configured via pin-straps, and then
further tweaked with PHY quirks. Resetting with the iMX6 in the
wrong state may result in the AR8035 being reconfigured (even jumping
to a different MDIO address) and certainly would need the PHY quirks
re-running.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:24 ` Russell King - ARM Linux
0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2016-01-12 15:24 UTC (permalink / raw)
To: Lothar Waßmann
Cc: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lucas Stach, Nimrod Andy, Philippe Reynes,
Richard Cochran, Sascha Hauer, Stefan Agner, linux-kernel,
netdev, Jeff Kirsher, Uwe Kleine-König, Ian Campbell,
Kumar Gala, Mark Rutland, Pawel Moll, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree
On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Waßmann wrote:
> This patchset fixes a regression introduced by
> commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
>
> Changes vs. v1:
> - fixed reference to the commit that introduced the regression.
> - dropped patch to use gpiod framework. This should be added later,
> after the affected DTBs have been updated to specify the correct
> gpio_flags.
>
> Patch overview:
> 1. cleanup patch to remove redundant NULL checks
> 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
I definitely want to test these on my SolidRun boards before these get
merged: the AR8035 on there is configured via pin-straps, and then
further tweaked with PHY quirks. Resetting with the iMX6 in the
wrong state may result in the AR8035 being reconfigured (even jumping
to a different MDIO address) and certainly would need the PHY quirks
re-running.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:24 ` Russell King - ARM Linux
0 siblings, 0 replies; 16+ messages in thread
From: Russell King - ARM Linux @ 2016-01-12 15:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 12, 2016 at 04:17:54PM +0100, Lothar Wa?mann wrote:
> This patchset fixes a regression introduced by
> commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
> for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
>
> Changes vs. v1:
> - fixed reference to the commit that introduced the regression.
> - dropped patch to use gpiod framework. This should be added later,
> after the affected DTBs have been updated to specify the correct
> gpio_flags.
>
> Patch overview:
> 1. cleanup patch to remove redundant NULL checks
> 2. call fec_reset_phy() after the ENET_OUT clock has been enabled
I definitely want to test these on my SolidRun boards before these get
merged: the AR8035 on there is configured via pin-straps, and then
further tweaked with PHY quirks. Resetting with the iMX6 in the
wrong state may result in the AR8035 being reconfigured (even jumping
to a different MDIO address) and certainly would need the PHY quirks
re-running.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:17 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 15:17 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lothar Waßmann, Lucas Stach, Nimrod Andy,
Philippe Reynes, Richard Cochran, Russell King, Sascha Hauer,
Stefan Agner, linux-kernel, netdev, Jeff Kirsher,
Uwe Kleine-König, Ian Campbell, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring, Russell King, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel
This patchset fixes a regression introduced by
commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
Changes vs. v1:
- fixed reference to the commit that introduced the regression.
- dropped patch to use gpiod framework. This should be added later,
after the affected DTBs have been updated to specify the correct
gpio_flags.
Patch overview:
1. cleanup patch to remove redundant NULL checks
2. call fec_reset_phy() after the ENET_OUT clock has been enabled
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:17 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 15:17 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lothar Waßmann, Lucas Stach, Nimrod Andy,
Philippe Reynes, Richard Cochran, Russell King, Sascha Hauer,
Stefan Agner, linux-kernel, netdev, Jeff Kirsher,
Uwe Kleine-König, Ian Campbell, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring
This patchset fixes a regression introduced by
commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
Changes vs. v1:
- fixed reference to the commit that introduced the regression.
- dropped patch to use gpiod framework. This should be added later,
after the affected DTBs have been updated to specify the correct
gpio_flags.
Patch overview:
1. cleanup patch to remove redundant NULL checks
2. call fec_reset_phy() after the ENET_OUT clock has been enabled
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:17 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 15:17 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Fabio Estevam, Greg Ungerer,
Kevin Hao, Lothar Waßmann, Lucas Stach, Nimrod Andy,
Philippe Reynes, Richard Cochran, Russell King, Sascha Hauer,
Stefan Agner, linux-kernel, netdev, Jeff Kirsher,
Uwe Kleine-König, Ian Campbell, Kumar Gala, Mark Rutland,
Pawel Moll, Rob Herring, Russell King, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel
This patchset fixes a regression introduced by
commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
Changes vs. v1:
- fixed reference to the commit that introduced the regression.
- dropped patch to use gpiod framework. This should be added later,
after the affected DTBs have been updated to specify the correct
gpio_flags.
Patch overview:
1. cleanup patch to remove redundant NULL checks
2. call fec_reset_phy() after the ENET_OUT clock has been enabled
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled
@ 2016-01-12 15:17 ` Lothar Waßmann
0 siblings, 0 replies; 16+ messages in thread
From: Lothar Waßmann @ 2016-01-12 15:17 UTC (permalink / raw)
To: linux-arm-kernel
This patchset fixes a regression introduced by
commit e8fcfcd5684a ("net: fec: optimize the clock management to save power")
for ethernet PHYs that are using ENET_OUT as reference clock (on i.MX6 or i.MX28)
Changes vs. v1:
- fixed reference to the commit that introduced the regression.
- dropped patch to use gpiod framework. This should be added later,
after the affected DTBs have been updated to specify the correct
gpio_flags.
Patch overview:
1. cleanup patch to remove redundant NULL checks
2. call fec_reset_phy() after the ENET_OUT clock has been enabled
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-09-26 15:45 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 15:17 [PATCHv2 0/2] net: fec: Reset ethernet PHY whenever the enet_out clock is being enabled Lothar Waßmann
-- strict thread matches above, loose matches on Subject: below --
2016-01-12 15:17 Lothar Waßmann
2016-01-12 15:17 ` Lothar Waßmann
2016-01-12 15:17 ` Lothar Waßmann
2016-01-12 15:17 ` Lothar Waßmann
2016-01-12 15:24 ` Russell King - ARM Linux
2016-01-12 15:24 ` Russell King - ARM Linux
2016-01-12 15:24 ` Russell King - ARM Linux
2016-01-12 16:04 ` Lothar Waßmann
2016-01-12 16:04 ` Lothar Waßmann
2016-01-12 16:04 ` Lothar Waßmann
2016-01-12 20:30 ` Uwe Kleine-König
2016-01-12 20:30 ` Uwe Kleine-König
2016-09-26 15:37 ` Jörg Krause
2016-09-26 15:37 ` Jörg Krause
2016-09-26 15:37 ` Jörg Krause
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.