* [Buildroot] [PATCH v2] rabbitmq-c: needs a toolchain with posix_spawn support
@ 2016-01-14 8:47 Joris Lijssens
2016-01-14 9:15 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Joris Lijssens @ 2016-01-14 8:47 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/a6c3e79c61c5a535970d03bf37b068349f766a7f/
Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
package/rabbitmq-c/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/rabbitmq-c/Config.in b/package/rabbitmq-c/Config.in
index b330c90..73e3909 100644
--- a/package/rabbitmq-c/Config.in
+++ b/package/rabbitmq-c/Config.in
@@ -1,6 +1,10 @@
config BR2_PACKAGE_RABBITMQ_C
bool "rabbitmq-c"
depends on BR2_TOOLCHAIN_HAS_THREADS
+ # disable rabbitmq-c on blackfin, because it doesn't support
+ # posix_spawn :
+ # http://autobuild.buildroot.net/results/a6c3e79c61c5a535970d03bf37b068349f766a7f/
+ depends on !BR2_bfin
help
This is a C-language AMQP client library for use with v2.0+
of the RabbitMQ broker.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2] rabbitmq-c: needs a toolchain with posix_spawn support
2016-01-14 8:47 [Buildroot] [PATCH v2] rabbitmq-c: needs a toolchain with posix_spawn support Joris Lijssens
@ 2016-01-14 9:15 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-01-14 9:15 UTC (permalink / raw)
To: buildroot
Joris,
On Thu, 14 Jan 2016 09:47:57 +0100, Joris Lijssens wrote:
> Fixes:
> http://autobuild.buildroot.net/results/a6c3e79c61c5a535970d03bf37b068349f766a7f/
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
The empty line separating the commit log from the SoB line is still
missing.
> ---
> package/rabbitmq-c/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/rabbitmq-c/Config.in b/package/rabbitmq-c/Config.in
> index b330c90..73e3909 100644
> --- a/package/rabbitmq-c/Config.in
> +++ b/package/rabbitmq-c/Config.in
> @@ -1,6 +1,10 @@
> config BR2_PACKAGE_RABBITMQ_C
> bool "rabbitmq-c"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> + # disable rabbitmq-c on blackfin, because it doesn't support
> + # posix_spawn :
> + # http://autobuild.buildroot.net/results/a6c3e79c61c5a535970d03bf37b068349f766a7f/
> + depends on !BR2_bfin
I think this should rather be:
# too old uClibc, not providing posix_spawn functions
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX
because theoretically, a different Blackfin toolchain using a newer
uClibc version would have spawn.h.
Also, the rabbitmq-c package has a comment that you need to update:
comment "rabbitmq-c needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
should be changed to:
comment "rabbitmq-c needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX
depends on !BR2_TOOLCHAIN_HAS_THREADS
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-14 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-14 8:47 [Buildroot] [PATCH v2] rabbitmq-c: needs a toolchain with posix_spawn support Joris Lijssens
2016-01-14 9:15 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.