* [U-Boot] [PATCH] powerpc/83xx: fix build failure @ 2016-01-14 10:45 Shengzhou Liu 2016-01-14 15:00 ` Bin Meng 2016-01-20 21:01 ` [U-Boot] " Tom Rini 0 siblings, 2 replies; 7+ messages in thread From: Shengzhou Liu @ 2016-01-14 10:45 UTC (permalink / raw) To: u-boot Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, which has been defined in fsl_ddr_sdram.h Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> --- include/mpc83xx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/mpc83xx.h b/include/mpc83xx.h index a6d721a..b5a0bbf 100644 --- a/include/mpc83xx.h +++ b/include/mpc83xx.h @@ -1297,7 +1297,6 @@ */ #define SDRAM_INTERVAL_REFINT 0x3FFF0000 #define SDRAM_INTERVAL_REFINT_SHIFT 16 -#define SDRAM_INTERVAL_BSTOPRE 0x00003FFF #define SDRAM_INTERVAL_BSTOPRE_SHIFT 0 /* -- 2.1.0.27.g96db324 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] powerpc/83xx: fix build failure 2016-01-14 10:45 [U-Boot] [PATCH] powerpc/83xx: fix build failure Shengzhou Liu @ 2016-01-14 15:00 ` Bin Meng 2016-01-14 16:33 ` Tom Rini 2016-01-20 21:01 ` [U-Boot] " Tom Rini 1 sibling, 1 reply; 7+ messages in thread From: Bin Meng @ 2016-01-14 15:00 UTC (permalink / raw) To: u-boot Hi Shengzhou, On Thu, Jan 14, 2016 at 6:45 PM, Shengzhou Liu <Shengzhou.Liu@freescale.com> wrote: > Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, > which has been defined in fsl_ddr_sdram.h I don't see SDRAM_INTERVAL_BSTOPRE is defined in fsl_ddr_sdram.h? > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> > --- > include/mpc83xx.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/mpc83xx.h b/include/mpc83xx.h > index a6d721a..b5a0bbf 100644 > --- a/include/mpc83xx.h > +++ b/include/mpc83xx.h > @@ -1297,7 +1297,6 @@ > */ > #define SDRAM_INTERVAL_REFINT 0x3FFF0000 > #define SDRAM_INTERVAL_REFINT_SHIFT 16 > -#define SDRAM_INTERVAL_BSTOPRE 0x00003FFF > #define SDRAM_INTERVAL_BSTOPRE_SHIFT 0 > > /* > -- Regards, Bin ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] powerpc/83xx: fix build failure 2016-01-14 15:00 ` Bin Meng @ 2016-01-14 16:33 ` Tom Rini 0 siblings, 0 replies; 7+ messages in thread From: Tom Rini @ 2016-01-14 16:33 UTC (permalink / raw) To: u-boot On Thu, Jan 14, 2016 at 11:00:01PM +0800, Bin Meng wrote: > Hi Shengzhou, > > On Thu, Jan 14, 2016 at 6:45 PM, Shengzhou Liu > <Shengzhou.Liu@freescale.com> wrote: > > Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, > > which has been defined in fsl_ddr_sdram.h > > I don't see SDRAM_INTERVAL_BSTOPRE is defined in fsl_ddr_sdram.h? Indeed, I assume this is supposed to be against some internal or work in progress tree? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160114/0a9e44c3/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] powerpc/83xx: fix build failure 2016-01-14 10:45 [U-Boot] [PATCH] powerpc/83xx: fix build failure Shengzhou Liu 2016-01-14 15:00 ` Bin Meng @ 2016-01-20 21:01 ` Tom Rini 2016-01-21 1:22 ` Bin Meng 1 sibling, 1 reply; 7+ messages in thread From: Tom Rini @ 2016-01-20 21:01 UTC (permalink / raw) To: u-boot On Thu, Jan 14, 2016 at 06:45:30PM +0800, Shengzhou Liu wrote: > Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, > which has been defined in fsl_ddr_sdram.h > > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160120/03c14346/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] powerpc/83xx: fix build failure 2016-01-20 21:01 ` [U-Boot] " Tom Rini @ 2016-01-21 1:22 ` Bin Meng 2016-01-21 1:27 ` Tom Rini 0 siblings, 1 reply; 7+ messages in thread From: Bin Meng @ 2016-01-21 1:22 UTC (permalink / raw) To: u-boot Hi Tom, On Thu, Jan 21, 2016 at 5:01 AM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Jan 14, 2016 at 06:45:30PM +0800, Shengzhou Liu wrote: > >> Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, >> which has been defined in fsl_ddr_sdram.h >> >> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> > > Applied to u-boot/master, thanks! > > -- IMHO, if it is a WIP, this patch should be squashed into the patch which broke the build as it has not been merged upstream yet. Am I missing anything? Regards, Bin ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] powerpc/83xx: fix build failure 2016-01-21 1:22 ` Bin Meng @ 2016-01-21 1:27 ` Tom Rini 2016-01-21 1:38 ` Bin Meng 0 siblings, 1 reply; 7+ messages in thread From: Tom Rini @ 2016-01-21 1:27 UTC (permalink / raw) To: u-boot On Thu, Jan 21, 2016 at 09:22:43AM +0800, Bin Meng wrote: > Hi Tom, > > On Thu, Jan 21, 2016 at 5:01 AM, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Jan 14, 2016 at 06:45:30PM +0800, Shengzhou Liu wrote: > > > >> Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, > >> which has been defined in fsl_ddr_sdram.h > >> > >> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> > > > > Applied to u-boot/master, thanks! > > IMHO, if it is a WIP, this patch should be squashed into the patch > which broke the build as it has not been merged upstream yet. Am I > missing anything? Mess-up on my part, but... SDRAM_INTERVAL_BSTOPRE isn't used _anywhere_ only SDRAM_INTERVAL_BSTOPRE_SHIFT so nothing broke. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160120/d2090d5b/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] powerpc/83xx: fix build failure 2016-01-21 1:27 ` Tom Rini @ 2016-01-21 1:38 ` Bin Meng 0 siblings, 0 replies; 7+ messages in thread From: Bin Meng @ 2016-01-21 1:38 UTC (permalink / raw) To: u-boot Hi Tom, On Thu, Jan 21, 2016 at 9:27 AM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Jan 21, 2016 at 09:22:43AM +0800, Bin Meng wrote: >> Hi Tom, >> >> On Thu, Jan 21, 2016 at 5:01 AM, Tom Rini <trini@konsulko.com> wrote: >> > On Thu, Jan 14, 2016 at 06:45:30PM +0800, Shengzhou Liu wrote: >> > >> >> Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h, >> >> which has been defined in fsl_ddr_sdram.h >> >> >> >> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com> >> > >> > Applied to u-boot/master, thanks! >> >> IMHO, if it is a WIP, this patch should be squashed into the patch >> which broke the build as it has not been merged upstream yet. Am I >> missing anything? > > Mess-up on my part, but... SDRAM_INTERVAL_BSTOPRE isn't used _anywhere_ > only SDRAM_INTERVAL_BSTOPRE_SHIFT so nothing broke. > Yep, I just grep this and found nothing, which is different from what I grepped last time. Something must have been merged upstream recently. But if this is the case, then the commit title should really say: powerpc/83xx: Remove useless SDRAM_INTERVAL_BSTOPRE instead of saying 'fix build failure'. Regards, Bin ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-01-21 1:38 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-01-14 10:45 [U-Boot] [PATCH] powerpc/83xx: fix build failure Shengzhou Liu 2016-01-14 15:00 ` Bin Meng 2016-01-14 16:33 ` Tom Rini 2016-01-20 21:01 ` [U-Boot] " Tom Rini 2016-01-21 1:22 ` Bin Meng 2016-01-21 1:27 ` Tom Rini 2016-01-21 1:38 ` Bin Meng
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.