* [PATCH 0/1] gpio: gpio-altera: Remove gpiochip on probe failure.
@ 2016-01-15 3:32 Phil Reid
2016-01-15 3:32 ` [PATCH 1/1] " Phil Reid
0 siblings, 1 reply; 4+ messages in thread
From: Phil Reid @ 2016-01-15 3:32 UTC (permalink / raw)
To: thloh, linus.walleij, gnurou, linux-gpio; +Cc: Phil Reid
Kernel fault occured because dt entry altr,interrupt-type was not defined.
Phil Reid (1):
gpio: gpio-altera: Remove gpiochip on probe failure.
drivers/gpio/gpio-altera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] gpio: gpio-altera: Remove gpiochip on probe failure.
2016-01-15 3:32 [PATCH 0/1] gpio: gpio-altera: Remove gpiochip on probe failure Phil Reid
@ 2016-01-15 3:32 ` Phil Reid
2016-01-27 9:50 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Phil Reid @ 2016-01-15 3:32 UTC (permalink / raw)
To: thloh, linus.walleij, gnurou, linux-gpio; +Cc: Phil Reid
On failure to setup the irq altera_gpio_probe would return an error
but not call altera_gpio_probe. This resulted in kernel fault
"Unable to handle kernel paging request at virtual address xxxxxxxx"
later on in of_gpiochip_find_and_xlate.
Signed-off-by: Phil Reid <preid@electromag.com.au>
---
drivers/gpio/gpio-altera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index 3e6661b..7ed30f2 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -317,8 +317,8 @@ static int altera_gpio_probe(struct platform_device *pdev)
handle_simple_irq, IRQ_TYPE_NONE);
if (ret) {
- dev_info(&pdev->dev, "could not add irqchip\n");
- return ret;
+ dev_err(&pdev->dev, "could not add irqchip\n");
+ goto teardown;
}
gpiochip_set_chained_irqchip(&altera_gc->mmchip.gc,
@@ -331,6 +331,7 @@ static int altera_gpio_probe(struct platform_device *pdev)
skip_irq:
return 0;
teardown:
+ of_mm_gpiochip_remove(&altera_gc->mmchip);
pr_err("%s: registration failed with status %d\n",
node->full_name, ret);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] gpio: gpio-altera: Remove gpiochip on probe failure.
2016-01-15 3:32 ` [PATCH 1/1] " Phil Reid
@ 2016-01-27 9:50 ` Linus Walleij
2016-02-01 3:07 ` Phil Reid
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2016-01-27 9:50 UTC (permalink / raw)
To: Phil Reid; +Cc: Tien Hock Loh, Alexandre Courbot, linux-gpio
On Fri, Jan 15, 2016 at 4:32 AM, Phil Reid <preid@electromag.com.au> wrote:
> On failure to setup the irq altera_gpio_probe would return an error
> but not call altera_gpio_probe. This resulted in kernel fault
> "Unable to handle kernel paging request at virtual address xxxxxxxx"
> later on in of_gpiochip_find_and_xlate.
>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
Fixed up commit message and patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] gpio: gpio-altera: Remove gpiochip on probe failure.
2016-01-27 9:50 ` Linus Walleij
@ 2016-02-01 3:07 ` Phil Reid
0 siblings, 0 replies; 4+ messages in thread
From: Phil Reid @ 2016-02-01 3:07 UTC (permalink / raw)
To: Linus Walleij; +Cc: Tien Hock Loh, Alexandre Courbot, linux-gpio
On 27/01/2016 5:50 PM, Linus Walleij wrote:
> On Fri, Jan 15, 2016 at 4:32 AM, Phil Reid <preid@electromag.com.au> wrote:
>
>> On failure to setup the irq altera_gpio_probe would return an error
>> but not call altera_gpio_probe. This resulted in kernel fault
>> "Unable to handle kernel paging request at virtual address xxxxxxxx"
>> later on in of_gpiochip_find_and_xlate.
>>
>> Signed-off-by: Phil Reid <preid@electromag.com.au>
>
> Fixed up commit message and patch applied.
>
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
Thanks for fixing that.
Regards
Phil Reid
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-01 3:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-15 3:32 [PATCH 0/1] gpio: gpio-altera: Remove gpiochip on probe failure Phil Reid
2016-01-15 3:32 ` [PATCH 1/1] " Phil Reid
2016-01-27 9:50 ` Linus Walleij
2016-02-01 3:07 ` Phil Reid
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.