* [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
@ 2015-12-11 13:56 Ian Campbell
2015-12-11 15:16 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-12-11 13:56 UTC (permalink / raw)
To: ian.jackson, xen-devel; +Cc: Ian Campbell
This is useful for standalone or adhoc use as well as (presumably)
bisection.
There is no ap-* or cr-daily-* integration here because I didn't need
it (i.e. I'm not intending to create a new mini-os branch here).
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
mfi-common | 4 +++-
ts-xen-build | 8 ++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/mfi-common b/mfi-common
index 4ed040e..7b41553 100644
--- a/mfi-common
+++ b/mfi-common
@@ -187,6 +187,7 @@ create_build_jobs () {
tree_xen=$TREE_XEN \
tree_seabios=$TREE_SEABIOS \
tree_ovmf=$TREE_OVMF \
+ tree_minios=$TREE_MINIOS \
$RUNVARS $BUILD_RUNVARS $BUILD_XEN_RUNVARS $arch_runvars \
$suite_runvars \
host_hostflags=$build_hostflags \
@@ -194,7 +195,8 @@ create_build_jobs () {
revision_qemu=$REVISION_QEMU \
revision_qemuu=$REVISION_QEMU_UPSTREAM \
revision_seabios=$REVISION_SEABIOS \
- revision_ovmf=$REVISION_OVMF
+ revision_ovmf=$REVISION_OVMF \
+ revision_minios=$REVISION_MINIOS
done
if [ x$want_prevxen = xy ] ; then
diff --git a/ts-xen-build b/ts-xen-build
index b02e737..f421dfa 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -81,6 +81,12 @@ END
(nonempty($r{revision_ovmf}) ? <<END : '').
echo >>.config OVMF_UPSTREAM_REVISION='$r{revision_ovmf}'
END
+ (nonempty($r{tree_minios}) ? <<END : '').
+ echo >>.config MINIOS_UPSTREAM_URL='$r{tree_minios}'
+END
+ (nonempty($r{revision_minios}) ? <<END : '').
+ echo >>.config MINIOS_UPSTREAM_REVISION='$r{revision_minios}'
+END
(nonempty($earlyprintk) ? <<END : '').
echo >>.config CONFIG_EARLY_PRINTK=$earlyprintk
END
@@ -140,11 +146,13 @@ END
sub collectversions () {
my $tools="$builddir/xen/tools";
+ my $extras="$builddir/xen/extras";
store_revision($ho, 'qemu', "$tools/ioemu-dir", 1);
store_revision($ho, 'qemu', "$tools/qemu-xen-traditional-dir", 1);
store_revision($ho, 'qemuu', "$tools/qemu-xen-dir", 1);
store_revision($ho, 'seabios', "$tools/firmware/seabios-dir", 1);
store_revision($ho, 'ovmf', "$tools/firmware/ovmf-dir", 1);
+ store_revision($ho, 'minios', "$extras/mini-os", 1);
}
sub divide () {
--
2.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
2015-12-11 13:56 [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision Ian Campbell
@ 2015-12-11 15:16 ` Ian Jackson
2015-12-16 9:32 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2015-12-11 15:16 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("[PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision"):
> This is useful for standalone or adhoc use as well as (presumably)
> bisection.
>
> There is no ap-* or cr-daily-* integration here because I didn't need
> it (i.e. I'm not intending to create a new mini-os branch here).
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
2015-12-11 15:16 ` Ian Jackson
@ 2015-12-16 9:32 ` Ian Campbell
2016-01-15 16:28 ` Ian Campbell
2016-01-15 17:07 ` Ian Jackson
0 siblings, 2 replies; 6+ messages in thread
From: Ian Campbell @ 2015-12-16 9:32 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Fri, 2015-12-11 at 15:16 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] make-flight: Support specifying a
> mini-os tree+revision"):
> > This is useful for standalone or adhoc use as well as (presumably)
> > bisection.
> >
> > There is no ap-* or cr-daily-* integration here because I didn't need
> > it (i.e. I'm not intending to create a new mini-os branch here).
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
This patch fails when building 4.5 and earlier because extras/mini-os
exists but is part of xen.git not a separate repo, so dir_identify_vcs
goes:
2015-12-15 17:21:50 Z executing ssh ... osstest@10.80.229.171 cd /home/osstest/build.38523.build-amd64/xen/tools/firmware/ovmf-dir && git rev-parse HEAD^0
2015-12-15 17:21:50 Z runvar store: built_vcs_ovmf=git
2015-12-15 17:21:50 Z runvar store: built_revision_ovmf=cb9a7ebabcd6b8a49dc0854b2f9592d732b5afbd
2015-12-15 17:21:50 Z executing ssh ... osstest@10.80.229.171 set -e
if ! test -e /home/osstest/build.38523.build-amd64/xen/extras/mini-os; then echo none; exit 0; fi
cd /home/osstest/build.38523.build-amd64/xen/extras/mini-os
(test -e .git && echo git) ||
(test -d .hg && echo hg) ||
(echo >&2 'unable to determine vcs'; fail)
unable to determine vcs
bash: line 5: fail: command not found
I'm not sure if this is a bug (i.e. it was intended to be "echo fail") or
if it is deliberately using a non-existent command (which seems risky to
me).
All the other store_revisions refer to the symlink rather than the -remote
which is the actual clone (when one is made), so I don't think
s#extras/mini-os#extras/mini-os-remote# is the answer. Perhaps "fail"
should become "echo fail" and store_revision should treat that like it does
fail (which is to accept it if $optional).
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
2015-12-16 9:32 ` Ian Campbell
@ 2016-01-15 16:28 ` Ian Campbell
2016-01-15 17:07 ` Ian Jackson
1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2016-01-15 16:28 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Wed, 2015-12-16 at 09:32 +0000, Ian Campbell wrote:
> On Fri, 2015-12-11 at 15:16 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST] make-flight: Support specifying a
> > mini-os tree+revision"):
> > > This is useful for standalone or adhoc use as well as (presumably)
> > > bisection.
> > >
> > > There is no ap-* or cr-daily-* integration here because I didn't need
> > > it (i.e. I'm not intending to create a new mini-os branch here).
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> This patch fails when building 4.5 and earlier because
Any thoughts on what to do here? i.e. the plan in the second half of the
final paragraph.
> extras/mini-os
> exists but is part of xen.git not a separate repo, so dir_identify_vcs
> goes:
>
> 2015-12-15 17:21:50 Z executing ssh ... osstest@10.80.229.171
> cd /home/osstest/build.38523.build-amd64/xen/tools/firmware/ovmf-dir &&
> git rev-parse HEAD^0
> 2015-12-15 17:21:50 Z runvar store: built_vcs_ovmf=git
> 2015-12-15 17:21:50 Z runvar store:
> built_revision_ovmf=cb9a7ebabcd6b8a49dc0854b2f9592d732b5afbd
> 2015-12-15 17:21:50 Z executing ssh ... osstest@10.80.229.171
> set -e
> if ! test -e /home/osstest/build.38523.build-
> amd64/xen/extras/mini-os; then echo none; exit 0; fi
> cd /home/osstest/build.38523.build-amd64/xen/extras/mini-os
> (test -e .git && echo git) ||
> (test -d .hg && echo hg) ||
> (echo >&2 'unable to determine vcs'; fail)
>
> unable to determine vcs
> bash: line 5: fail: command not found
>
> I'm not sure if this is a bug (i.e. it was intended to be "echo fail") or
> if it is deliberately using a non-existent command (which seems risky to
> me).
>
> All the other store_revisions refer to the symlink rather than the -remote
> which is the actual clone (when one is made), so I don't think
> s#extras/mini-os#extras/mini-os-remote# is the answer. Perhaps "fail"
> should become "echo fail" and store_revision should treat that like it does
> fail (which is to accept it if $optional).
>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
2015-12-16 9:32 ` Ian Campbell
2016-01-15 16:28 ` Ian Campbell
@ 2016-01-15 17:07 ` Ian Jackson
2016-01-15 17:40 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2016-01-15 17:07 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel
Ian Campbell writes ("Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision"):
> On Fri, 2015-12-11 at 15:16 +0000, Ian Jackson wrote:
> unable to determine vcs
> bash: line 5: fail: command not found
>
> I'm not sure if this is a bug (i.e. it was intended to be "echo fail") or
> if it is deliberately using a non-existent command (which seems risky to
> me).
It's deliberately using the command `fail' which is supposed to be in
scope and fail. I think this is harmless.
> All the other store_revisions refer to the symlink rather than the -remote
> which is the actual clone (when one is made), so I don't think
> s#extras/mini-os#extras/mini-os-remote# is the answer. Perhaps "fail"
> should become "echo fail" and store_revision should treat that like it does
> fail (which is to accept it if $optional).
That would be tolerable, I think. It's probably the best answer.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision
2016-01-15 17:07 ` Ian Jackson
@ 2016-01-15 17:40 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2016-01-15 17:40 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Fri, 2016-01-15 at 17:07 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST] make-flight: Support specifying
> a mini-os tree+revision"):
> > On Fri, 2015-12-11 at 15:16 +0000, Ian Jackson wrote:
> > unable to determine vcs
> > bash: line 5: fail: command not found
> >
> > I'm not sure if this is a bug (i.e. it was intended to be "echo fail")
> > or
> > if it is deliberately using a non-existent command (which seems risky
> > to
> > me).
>
> It's deliberately using the command `fail' which is supposed to be in
> scope and fail. I think this is harmless.
Where does that command come into scope from?
Are you thinking of the sub fail() in Perl (from Osstest::TestSupport)?
The fail quoted above is from:
sub dir_identify_vcs ($$) {
my ($ho,$dir) = @_;
return target_cmd_output($ho, <<END);
set -e
if ! test -e $dir; then echo none; exit 0; fi
cd $dir
(test -e .git && echo git) ||
(test -d .hg && echo hg) ||
(echo >&2 'unable to determine vcs'; fail)
END
}
i.e. it is in a shell snippet run on the target. I'm not sure where fail
would come into scope in that context. I don't see it in the tcmd
infrastructure.
> > All the other store_revisions refer to the symlink rather than the
> > -remote
> > which is the actual clone (when one is made), so I don't think
> > s#extras/mini-os#extras/mini-os-remote# is the answer. Perhaps "fail"
> > should become "echo fail" and store_revision should treat that like it
> > does
> > fail (which is to accept it if $optional).
>
> That would be tolerable, I think. It's probably the best answer.
I'll wait and check I'm not terribly confused above before moving in this
direction.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-15 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 13:56 [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision Ian Campbell
2015-12-11 15:16 ` Ian Jackson
2015-12-16 9:32 ` Ian Campbell
2016-01-15 16:28 ` Ian Campbell
2016-01-15 17:07 ` Ian Jackson
2016-01-15 17:40 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.