* [PATCH] [coreutils]: Add xattr PACKAGECONFIG
@ 2016-01-16 14:41 Scott Ellis
2016-01-16 17:47 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: Scott Ellis @ 2016-01-16 14:41 UTC (permalink / raw)
To: openembedded-devel
From Yocto poky where it also stops this warning
WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
---
meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
index f042346..6a09c59 100644
--- a/meta/recipes-core/coreutils/coreutils_8.24.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
@@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
EXTRA_OECONF_class-native = "--without-gmp"
EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"
-# acl is not a default feature
+# acl and xattr are not default features
#
-PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-target ??= "\
+ ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
+"
+
PACKAGECONFIG_class-native ??= ""
# with, without, depends, rdepends
#
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
+PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
# [ df mktemp base64 gets a special treatment and is not included in this
bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [coreutils]: Add xattr PACKAGECONFIG
2016-01-16 14:41 [PATCH] [coreutils]: Add xattr PACKAGECONFIG Scott Ellis
@ 2016-01-16 17:47 ` Martin Jansa
2016-01-16 17:48 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2016-01-16 17:47 UTC (permalink / raw)
To: openembedded-devel
This belongs to openembedded-core ML. Please resend.
On Sat, Jan 16, 2016 at 3:41 PM, Scott Ellis <scott@jumpnowtek.com> wrote:
> From Yocto poky where it also stops this warning
>
> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
> dependency? [build-deps]
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
> ---
> meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
> b/meta/recipes-core/coreutils/coreutils_8.24.bb
> index f042346..6a09c59 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
> @@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] =
> "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
> EXTRA_OECONF_class-native = "--without-gmp"
> EXTRA_OECONF_class-target = "--enable-install-program=arch
> --libexecdir=${libdir}"
>
> -# acl is not a default feature
> +# acl and xattr are not default features
> #
> -PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES',
> 'acl', 'acl', '', d)}"
> +PACKAGECONFIG_class-target ??= "\
> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
> +"
> +
> PACKAGECONFIG_class-native ??= ""
>
> # with, without, depends, rdepends
> #
> PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
> +PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
>
> # [ df mktemp base64 gets a special treatment and is not included in this
> bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors
> dirname du \
> --
> 2.5.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [coreutils]: Add xattr PACKAGECONFIG
2016-01-16 17:47 ` Martin Jansa
@ 2016-01-16 17:48 ` Martin Jansa
0 siblings, 0 replies; 5+ messages in thread
From: Martin Jansa @ 2016-01-16 17:48 UTC (permalink / raw)
To: openembedded-devel
And coreutils should be in commit summary line, not as [coreutils] which is
removed when applied with git am.
On Sat, Jan 16, 2016 at 6:47 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> This belongs to openembedded-core ML. Please resend.
>
> On Sat, Jan 16, 2016 at 3:41 PM, Scott Ellis <scott@jumpnowtek.com> wrote:
>
>> From Yocto poky where it also stops this warning
>>
>> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
>> dependency? [build-deps]
>>
>> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>> ---
>> meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb
>> b/meta/recipes-core/coreutils/coreutils_8.24.bb
>> index f042346..6a09c59 100644
>> --- a/meta/recipes-core/coreutils/coreutils_8.24.bb
>> +++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
>> @@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] =
>> "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
>> EXTRA_OECONF_class-native = "--without-gmp"
>> EXTRA_OECONF_class-target = "--enable-install-program=arch
>> --libexecdir=${libdir}"
>>
>> -# acl is not a default feature
>> +# acl and xattr are not default features
>> #
>> -PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES',
>> 'acl', 'acl', '', d)}"
>> +PACKAGECONFIG_class-target ??= "\
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
>> +"
>> +
>> PACKAGECONFIG_class-native ??= ""
>>
>> # with, without, depends, rdepends
>> #
>> PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
>> +PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
>>
>> # [ df mktemp base64 gets a special treatment and is not included in this
>> bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors
>> dirname du \
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] coreutils: Add xattr PACKAGECONFIG
2016-01-18 10:42 [PATCH] coreutils: " Scott Ellis
@ 2016-01-18 11:16 ` Burton, Ross
0 siblings, 0 replies; 5+ messages in thread
From: Burton, Ross @ 2016-01-18 11:16 UTC (permalink / raw)
To: Scott Ellis; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
Hi Scott,
On 18 January 2016 at 10:42, Scott Ellis <scott@jumpnowtek.com> wrote:
> From Yocto poky where it also stops this warning
>
> WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build
> dependency? [build-deps]
>
> Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
>
In the future can you not submit patches by copying and pasting the patch
into your webmail client unless you know that it doesn't mangle the patch.
In this case it appears that your client removed all the leading
whitespace, which meant the patch was malformed. It was trivial enough to
fix in this case, but in the future it's best if you can just configure
git-send-email to send emails directly so they don't get messed up.
Thanks,
Ross
[-- Attachment #2: Type: text/html, Size: 1382 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] coreutils: Add xattr PACKAGECONFIG
@ 2016-01-18 10:42 Scott Ellis
2016-01-18 11:16 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Scott Ellis @ 2016-01-18 10:42 UTC (permalink / raw)
To: openembedded-core
From Yocto poky where it also stops this warning
WARNING: QA Issue: coreutils rdepends on libattr, but it isn't a build dependency? [build-deps]
Signed-off-by: Scott Ellis <scott@jumpnowtek.com>
---
meta/recipes-core/coreutils/coreutils_8.24.bb | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/coreutils/coreutils_8.24.bb b/meta/recipes-core/coreutils/coreutils_8.24.bb
index f042346..6a09c59 100644
--- a/meta/recipes-core/coreutils/coreutils_8.24.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.24.bb
@@ -28,14 +28,19 @@ SRC_URI[manpages.sha256sum] = "cf0333b5f134a331e0b46e2ddf90666f8bdc3281c1ca2c7cc
EXTRA_OECONF_class-native = "--without-gmp"
EXTRA_OECONF_class-target = "--enable-install-program=arch --libexecdir=${libdir}"
-# acl is not a default feature
+# acl and xattr are not default features
#
-PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_class-target ??= "\
+ ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
+"
+
PACKAGECONFIG_class-native ??= ""
# with, without, depends, rdepends
#
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
+PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
# [ df mktemp base64 gets a special treatment and is not included in this
bindir_progs = "arch basename chcon cksum comm csplit cut dir dircolors dirname du \
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-18 11:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-16 14:41 [PATCH] [coreutils]: Add xattr PACKAGECONFIG Scott Ellis
2016-01-16 17:47 ` Martin Jansa
2016-01-16 17:48 ` Martin Jansa
2016-01-18 10:42 [PATCH] coreutils: " Scott Ellis
2016-01-18 11:16 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.