All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fixing io-pgtable-arm build failure
@ 2016-01-13 14:48 ` Lada Trimasova
  0 siblings, 0 replies; 5+ messages in thread
From: Lada Trimasova @ 2016-01-13 14:48 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: linux-snps-arc, linux-kernel, linux-arch, Lada Trimasova,
	Alexey Brodkin, Vineet Gupta, Will Deacon, Joerg Roedel

Trying to build kernel for ARC with both options
CONFIG_COMPILE_TEST and CONFIG_IOMMU_IO_PGTABLE_LPAE enabled
(which happened really in "allyesconfig") I'm seeing this:
---------------->8----------------
$ make ARCH=arc
...sic...
CC drivers/iommu/io-pgtable-arm.o
linux/drivers/iommu/io-pgtable-arm.c: In
function ‘__arm_lpae_alloc_pages’:
linux/drivers/iommu/io-pgtable-arm.c:221:3:
error: implicit declaration of function ‘dma_map_single’
[-Werror=implicit-function-declaration]
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
linux/drivers/iommu/io-pgtable-arm.c:221:42:
error: ‘DMA_TO_DEVICE’ undeclared (first use in this function)
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
---------------->8----------------
and so on.

IOMMU_IO_PGTABLE_LPAE depends on DMA API.
So io-pgtable-arm.c should include linux/dma-mapping.h.

Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Joerg Roedel <joro@8bytes.org>
---
 drivers/iommu/io-pgtable-arm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
index 7df9777..0b1aca0 100644
--- a/drivers/iommu/io-pgtable-arm.c
+++ b/drivers/iommu/io-pgtable-arm.c
@@ -25,6 +25,7 @@
 #include <linux/sizes.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/dma-mapping.h>
 
 #include <asm/barrier.h>
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Fixing io-pgtable-arm build failure
@ 2016-01-13 14:48 ` Lada Trimasova
  0 siblings, 0 replies; 5+ messages in thread
From: Lada Trimasova @ 2016-01-13 14:48 UTC (permalink / raw)
  To: linux-snps-arc

Trying to build kernel for ARC with both options
CONFIG_COMPILE_TEST and CONFIG_IOMMU_IO_PGTABLE_LPAE enabled
(which happened really in "allyesconfig") I'm seeing this:
---------------->8----------------
$ make ARCH=arc
...sic...
CC drivers/iommu/io-pgtable-arm.o
linux/drivers/iommu/io-pgtable-arm.c: In
function ?__arm_lpae_alloc_pages?:
linux/drivers/iommu/io-pgtable-arm.c:221:3:
error: implicit declaration of function ?dma_map_single?
[-Werror=implicit-function-declaration]
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
linux/drivers/iommu/io-pgtable-arm.c:221:42:
error: ?DMA_TO_DEVICE? undeclared (first use in this function)
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
---------------->8----------------
and so on.

IOMMU_IO_PGTABLE_LPAE depends on DMA API.
So io-pgtable-arm.c should include linux/dma-mapping.h.

Signed-off-by: Lada Trimasova <ltrimas at synopsys.com>
Cc: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Vineet Gupta <vgupta at synopsys.com>
Cc: Will Deacon <will.deacon at arm.com>
Cc: Joerg Roedel <joro at 8bytes.org>
---
 drivers/iommu/io-pgtable-arm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
index 7df9777..0b1aca0 100644
--- a/drivers/iommu/io-pgtable-arm.c
+++ b/drivers/iommu/io-pgtable-arm.c
@@ -25,6 +25,7 @@
 #include <linux/sizes.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/dma-mapping.h>
 
 #include <asm/barrier.h>
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Fixing io-pgtable-arm build failure
@ 2016-01-13 14:48 ` Lada Trimasova
  0 siblings, 0 replies; 5+ messages in thread
From: Lada Trimasova @ 2016-01-13 14:48 UTC (permalink / raw)
  To: linux-arm-kernel

Trying to build kernel for ARC with both options
CONFIG_COMPILE_TEST and CONFIG_IOMMU_IO_PGTABLE_LPAE enabled
(which happened really in "allyesconfig") I'm seeing this:
---------------->8----------------
$ make ARCH=arc
...sic...
CC drivers/iommu/io-pgtable-arm.o
linux/drivers/iommu/io-pgtable-arm.c: In
function ?__arm_lpae_alloc_pages?:
linux/drivers/iommu/io-pgtable-arm.c:221:3:
error: implicit declaration of function ?dma_map_single?
[-Werror=implicit-function-declaration]
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
linux/drivers/iommu/io-pgtable-arm.c:221:42:
error: ?DMA_TO_DEVICE? undeclared (first use in this function)
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
---------------->8----------------
and so on.

IOMMU_IO_PGTABLE_LPAE depends on DMA API.
So io-pgtable-arm.c should include linux/dma-mapping.h.

Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Joerg Roedel <joro@8bytes.org>
---
 drivers/iommu/io-pgtable-arm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
index 7df9777..0b1aca0 100644
--- a/drivers/iommu/io-pgtable-arm.c
+++ b/drivers/iommu/io-pgtable-arm.c
@@ -25,6 +25,7 @@
 #include <linux/sizes.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/dma-mapping.h>
 
 #include <asm/barrier.h>
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Fixing io-pgtable-arm build failure
  2016-01-13 14:48 ` Lada Trimasova
  (?)
  (?)
@ 2016-01-19 14:53 ` Lada Trimasova
  2016-01-20  1:15   ` Will Deacon
  -1 siblings, 1 reply; 5+ messages in thread
From: Lada Trimasova @ 2016-01-19 14:53 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Will,

On Wed, 2016-01-13 at 17:48 +0300, Lada Trimasova wrote:

Trying to build kernel for ARC with both options
CONFIG_COMPILE_TEST and CONFIG_IOMMU_IO_PGTABLE_LPAE enabled
(which happened really in "allyesconfig") I'm seeing this:
---------------->8----------------
$ make ARCH=arc
...sic...
CC drivers/iommu/io-pgtable-arm.o
linux/drivers/iommu/io-pgtable-arm.c: In
function ?__arm_lpae_alloc_pages?:
linux/drivers/iommu/io-pgtable-arm.c:221:3:
error: implicit declaration of function ?dma_map_single?
[-Werror=implicit-function-declaration]
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
linux/drivers/iommu/io-pgtable-arm.c:221:42:
error: ?DMA_TO_DEVICE? undeclared (first use in this function)
dma = dma_map_single(dev, pages, size, DMA_TO_DEVICE);
^
---------------->8----------------
and so on.

IOMMU_IO_PGTABLE_LPAE depends on DMA API.
So io-pgtable-arm.c should include linux/dma-mapping.h.

Signed-off-by: Lada Trimasova <ltrimas at synopsys.com<mailto:ltrimas@synopsys.com>>
Cc: Alexey Brodkin <abrodkin at synopsys.com<mailto:abrodkin@synopsys.com>>
Cc: Vineet Gupta <vgupta at synopsys.com<mailto:vgupta@synopsys.com>>
Cc: Will Deacon <will.deacon at arm.com<mailto:will.deacon@arm.com>>
Cc: Joerg Roedel <joro at 8bytes.org<mailto:joro@8bytes.org>>
---
 drivers/iommu/io-pgtable-arm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
index 7df9777..0b1aca0 100644
--- a/drivers/iommu/io-pgtable-arm.c
+++ b/drivers/iommu/io-pgtable-arm.c
@@ -25,6 +25,7 @@
 #include <linux/sizes.h>
 #include <linux/slab.h>
 #include <linux/types.h>
+#include <linux/dma-mapping.h>

 #include <asm/barrier.h>



Please treat this as a polite reminder to review that patch sometime soon.

Regards,
Lada Trimasova.

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] Fixing io-pgtable-arm build failure
  2016-01-19 14:53 ` Lada Trimasova
@ 2016-01-20  1:15   ` Will Deacon
  0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2016-01-20  1:15 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jan 19, 2016 at 02:53:57PM +0000, Lada Trimasova wrote:
> Please treat this as a polite reminder to review that patch sometime soon.

It's queued on my fixes branch, so please sit tight (I'm out at a conference
at the moment).

Will

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-20  1:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13 14:48 [PATCH] Fixing io-pgtable-arm build failure Lada Trimasova
2016-01-13 14:48 ` Lada Trimasova
2016-01-13 14:48 ` Lada Trimasova
2016-01-19 14:53 ` Lada Trimasova
2016-01-20  1:15   ` Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.