[PATCH] iommu/amd: Correct the wrong setting of alias DTE in do_attach

[PATCH] iommu/amd: Correct the wrong setting of alias DTE in do_attach

[Baoquan He]

In below commit alias DTE is set when its peripheral is
setting DTE. However there's a code bug here to wrongly
set the alias DTE, correct it in this patch.

commit e25bfb56ea7f046b71414e02f80f620deb5c6362
Author: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
Date:   Tue Oct 20 17:33:38 2015 +0200

    iommu/amd: Set alias DTE in do_attach/do_detach

Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Tested-by: Mark Hounschell <markh-n2QNKt385d+sTnJN9+BGXg@public.gmane.org>
---
 drivers/iommu/amd_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 539b0de..e5e2239 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2049,7 +2049,7 @@ static void do_attach(struct iommu_dev_data *dev_data,
 	/* Update device table */
 	set_dte_entry(dev_data->devid, domain, ats);
 	if (alias != dev_data->devid)
-		set_dte_entry(dev_data->devid, domain, ats);
+		set_dte_entry(alias, domain, ats);
 
 	device_flush_dte(dev_data);
 }
-- 
2.5.0

Re: [PATCH] iommu/amd: Correct the wrong setting of alias DTE in do_attach

[Joerg Roedel]

On Wed, Jan 20, 2016 at 10:01:19PM +0800, Baoquan He wrote:
> In below commit alias DTE is set when its peripheral is
> setting DTE. However there's a code bug here to wrongly
> set the alias DTE, correct it in this patch.
> 
> commit e25bfb56ea7f046b71414e02f80f620deb5c6362
> Author: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
> Date:   Tue Oct 20 17:33:38 2015 +0200
> 
>     iommu/amd: Set alias DTE in do_attach/do_detach
> 
> Signed-off-by: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Tested-by: Mark Hounschell <markh-n2QNKt385d+sTnJN9+BGXg@public.gmane.org>

Applied, thanks.