* [PATCH v3 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string
@ 2016-01-21 7:09 ` Yuan Yao
0 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
new compatible string: "fsl,ls2080a-qspi".
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
Add the modifier for new compatible string like:
"fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
index fa77f87..1ad0fe3 100644
--- a/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt
@@ -1,7 +1,10 @@
ARM Freescale DSPI controller
Required properties:
-- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi", "fsl,ls2085a-dspi"
+- compatible : "fsl,vf610-dspi", "fsl,ls1021a-v1.0-dspi",
+ "fsl,ls2085a-dspi"
+ or
+ "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
- reg : Offset and length of the register set for the device
- interrupts : Should contain SPI controller interrupt
- clocks: from common clock binding: handle to dspi clock.
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi compatible string
2016-01-21 7:09 ` Yuan Yao
@ 2016-01-21 7:09 ` Yuan Yao
-1 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
new compatible string: "fsl,ls2080a-qspi".
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
Add the modifier for new compatible string like:
"fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi"
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
index 00c587b..0df2f3a 100644
--- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
@@ -3,7 +3,9 @@
Required properties:
- compatible : Should be "fsl,vf610-qspi", "fsl,imx6sx-qspi",
"fsl,imx7d-qspi", "fsl,imx6ul-qspi",
- "fsl,ls1021-qspi"
+ "fsl,ls1021a-qspi"
+ or
+ "fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi"
- reg : the first contains the register location and length,
the second contains the memory mapping address and length
- reg-names: Should contain the reg names "QuadSPI" and "QuadSPI-memory"
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi compatible string
@ 2016-01-21 7:09 ` Yuan Yao
0 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
new compatible string: "fsl,ls2080a-qspi".
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
Add the modifier for new compatible string like:
"fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi"
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
index 00c587b..0df2f3a 100644
--- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
@@ -3,7 +3,9 @@
Required properties:
- compatible : Should be "fsl,vf610-qspi", "fsl,imx6sx-qspi",
"fsl,imx7d-qspi", "fsl,imx6ul-qspi",
- "fsl,ls1021-qspi"
+ "fsl,ls1021a-qspi"
+ or
+ "fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi"
- reg : the first contains the register location and length,
the second contains the memory mapping address and length
- reg-names: Should contain the reg names "QuadSPI" and "QuadSPI-memory"
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 2/4] Documentation: fsl-quadspi: Add fsl, ls2080a-qspi compatible string
2016-01-21 7:09 ` Yuan Yao
(?)
@ 2016-01-21 23:11 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2016-01-21 23:11 UTC (permalink / raw)
To: Yuan Yao
Cc: mark.rutland, pawel.moll, galak, linux-kernel, devicetree, yao.yuan
On Thu, Jan 21, 2016 at 03:09:16PM +0800, Yuan Yao wrote:
> new compatible string: "fsl,ls2080a-qspi".
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Changed in v3:
> Add the modifier for new compatible string like:
> "fsl,ls2080a-qspi" followed by "fsl,ls1021a-qspi"
>
> Changed in v2:
> Update my email to <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 3/4] dts/ls2080a: update the DTS for QSPI and DSPI support
2016-01-21 7:09 ` Yuan Yao
@ 2016-01-21 7:09 ` Yuan Yao
-1 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
No changes.
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 9 ++++++++-
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
index 4cb996d..e8801fa 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
@@ -178,7 +178,14 @@
&qspi {
status = "okay";
- qflash0: s25fl008k {
+ flash0: s25fl256s1@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "st,m25p80";
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ };
+ flash2: s25fl256s1@2 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,m25p80";
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
index 2b23d03..65e612a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
@@ -318,7 +318,7 @@
dspi: dspi@2100000 {
status = "disabled";
- compatible = "fsl,vf610-dspi";
+ compatible = "fsl,ls2080a-dspi", "fsl,ls2085a-dspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2100000 0x0 0x10000>;
@@ -444,7 +444,7 @@
qspi: quadspi@20c0000 {
status = "disabled";
- compatible = "fsl,vf610-qspi";
+ compatible = "fsl,ls2080a-qspi", "fsl,ls1021a-qspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x20c0000 0x0 0x10000>,
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 3/4] dts/ls2080a: update the DTS for QSPI and DSPI support
@ 2016-01-21 7:09 ` Yuan Yao
0 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
No changes.
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 9 ++++++++-
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
index 4cb996d..e8801fa 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
@@ -178,7 +178,14 @@
&qspi {
status = "okay";
- qflash0: s25fl008k {
+ flash0: s25fl256s1@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "st,m25p80";
+ spi-max-frequency = <20000000>;
+ reg = <0>;
+ };
+ flash2: s25fl256s1@2 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "st,m25p80";
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
index 2b23d03..65e612a 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
@@ -318,7 +318,7 @@
dspi: dspi@2100000 {
status = "disabled";
- compatible = "fsl,vf610-dspi";
+ compatible = "fsl,ls2080a-dspi", "fsl,ls2085a-dspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x2100000 0x0 0x10000>;
@@ -444,7 +444,7 @@
qspi: quadspi@20c0000 {
status = "disabled";
- compatible = "fsl,vf610-qspi";
+ compatible = "fsl,ls2080a-qspi", "fsl,ls1021a-qspi";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x0 0x20c0000 0x0 0x10000>,
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 4/4] Documentation: fsl-quadspi: Add optional properties
2016-01-21 7:09 ` Yuan Yao
@ 2016-01-21 7:09 ` Yuan Yao
-1 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
Add optional properties for QSPI:
big-endian
if the register is big endian on this platform.
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
No changes.
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
index 0df2f3a..0333ec8 100644
--- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
@@ -21,6 +21,7 @@ Optional properties:
But if there are two NOR flashes connected to the
bus, you should enable this property.
(Please check the board's schematic.)
+ - big-endian : That means the IP register is big endian
Example:
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v3 4/4] Documentation: fsl-quadspi: Add optional properties
@ 2016-01-21 7:09 ` Yuan Yao
0 siblings, 0 replies; 12+ messages in thread
From: Yuan Yao @ 2016-01-21 7:09 UTC (permalink / raw)
To: robh+dt, robh, mark.rutland, pawel.moll, galak
Cc: linux-kernel, devicetree, yao.yuan
Add optional properties for QSPI:
big-endian
if the register is big endian on this platform.
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Changed in v3:
No changes.
Changed in v2:
Update my email to <yao.yuan@nxp.com>
---
Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
index 0df2f3a..0333ec8 100644
--- a/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
+++ b/Documentation/devicetree/bindings/mtd/fsl-quadspi.txt
@@ -21,6 +21,7 @@ Optional properties:
But if there are two NOR flashes connected to the
bus, you should enable this property.
(Please check the board's schematic.)
+ - big-endian : That means the IP register is big endian
Example:
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v3 4/4] Documentation: fsl-quadspi: Add optional properties
2016-01-21 7:09 ` Yuan Yao
(?)
@ 2016-01-21 23:10 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2016-01-21 23:10 UTC (permalink / raw)
To: Yuan Yao
Cc: mark.rutland, pawel.moll, galak, linux-kernel, devicetree, yao.yuan
On Thu, Jan 21, 2016 at 03:09:18PM +0800, Yuan Yao wrote:
> Add optional properties for QSPI:
> big-endian
> if the register is big endian on this platform.
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Changed in v3:
> No changes.
>
> Changed in v2:
> Update my email to <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v3 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string
2016-01-21 7:09 ` Yuan Yao
` (3 preceding siblings ...)
(?)
@ 2016-01-21 23:12 ` Rob Herring
2016-01-25 10:55 ` Yao Yuan
-1 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2016-01-21 23:12 UTC (permalink / raw)
To: Yuan Yao
Cc: mark.rutland, pawel.moll, galak, linux-kernel, devicetree, yao.yuan
On Thu, Jan 21, 2016 at 03:09:15PM +0800, Yuan Yao wrote:
> new compatible string: "fsl,ls2080a-qspi".
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Changed in v3:
> Add the modifier for new compatible string like:
> "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
>
> Changed in v2:
> Update my email to <yao.yuan@nxp.com>
> ---
> Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread* RE: [PATCH v3 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string
2016-01-21 23:12 ` [PATCH v3 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string Rob Herring
@ 2016-01-25 10:55 ` Yao Yuan
0 siblings, 0 replies; 12+ messages in thread
From: Yao Yuan @ 2016-01-25 10:55 UTC (permalink / raw)
To: Rob Herring, Yuan Yao
Cc: mark.rutland, pawel.moll, galak, linux-kernel, devicetree
On Fri, Jan 22, 2016 at 07:13 AM, Rob Herring wrote:
> On Thu, Jan 21, 2016 at 03:09:15PM +0800, Yuan Yao wrote:
> > new compatible string: "fsl,ls2080a-qspi".
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Changed in v3:
> > Add the modifier for new compatible string like:
> > "fsl,ls2080a-dspi" followed by "fsl,ls2085a-dspi"
> >
> > Changed in v2:
> > Update my email to <yao.yuan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/spi-fsl-dspi.txt | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
Hi Rob,
Thanks for your review and help.
How about this rest:
[PATCH v3 3/4] dts/ls2080a: update the DTS for QSPI and DSPI support
And I also want to send some patches for SPI driver soon.
But those patches depend on this four dts binging patches.
So I should also send this four patches to the SPI driver maintainers.
And they can refer to review my patch for SPI driver.
Can I also send this "dts/ls2080a: update the DTS for QSPI and DSPI support" patch with your Acked-by?
Or can you give me a ACK for this patch?
Thanks.
Yuan Yao.
^ permalink raw reply [flat|nested] 12+ messages in thread