All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	jasowang@redhat.com, zhangchen.fnst@cn.fujitsu.com,
	hongyang.yang@easystack.cn
Subject: [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets
Date: Fri, 22 Jan 2016 16:36:47 +0800	[thread overview]
Message-ID: <1453451811-11860-4-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1453451811-11860-1-git-send-email-zhang.zhanghailiang@huawei.com>

If the filter is disabled, don't go through it.

Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
 include/net/filter.h | 5 +++++
 net/net.c            | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/include/net/filter.h b/include/net/filter.h
index 9ed5ec6..d797ee4 100644
--- a/include/net/filter.h
+++ b/include/net/filter.h
@@ -74,6 +74,11 @@ ssize_t qemu_netfilter_pass_to_next(NetClientState *sender,
                                     int iovcnt,
                                     void *opaque);
 
+static inline bool qemu_need_skip_netfilter(NetFilterState *nf)
+{
+    return nf->enabled ? false : true;
+}
+
 void netfilter_print_info(NetFilterState *nf, char *output_str, int size);
 
 #endif /* QEMU_NET_FILTER_H */
diff --git a/net/net.c b/net/net.c
index 87de7c0..ec43105 100644
--- a/net/net.c
+++ b/net/net.c
@@ -581,6 +581,10 @@ static ssize_t filter_receive_iov(NetClientState *nc,
     NetFilterState *nf = NULL;
 
     QTAILQ_FOREACH(nf, &nc->filters, next) {
+        /* Don't go through filter if it is off */
+        if (qemu_need_skip_netfilter(nf)) {
+            continue;
+        }
         ret = qemu_netfilter_receive(nf, direction, sender, flags, iov,
                                      iovcnt, sent_cb);
         if (ret) {
-- 
1.8.3.1

  parent reply	other threads:[~2016-01-22  8:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  8:36 [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter zhanghailiang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network' zhanghailiang
2016-01-25  5:01   ` Jason Wang
2016-01-25  5:58     ` Hailiang Zhang
2016-01-26  3:05       ` Jason Wang
2016-01-26  3:34         ` Hailiang Zhang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 2/7] net/filter: Add a 'status' property for filter object zhanghailiang
2016-01-25  5:05   ` Jason Wang
2016-01-25  6:00     ` Hailiang Zhang
2016-01-22  8:36 ` zhanghailiang [this message]
2016-01-22  9:32   ` [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets Wen Congyang
2016-01-25  5:04     ` Jason Wang
2016-01-25  5:59       ` Hailiang Zhang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 4/7] net/filter: Introduce a helper to add a filter to the netdev zhanghailiang
2016-01-25  5:20   ` Jason Wang
2016-01-25  7:42     ` Hailiang Zhang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval zhanghailiang
2016-01-25  5:19   ` Jason Wang
2016-01-25  7:41     ` Hailiang Zhang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev zhanghailiang
2016-01-25  5:18   ` Jason Wang
2016-01-25  7:22     ` Hailiang Zhang
2016-01-25 11:19       ` Hailiang Zhang
2016-01-27  3:29         ` Jason Wang
2016-01-26  3:18       ` Jason Wang
2016-01-26  3:39         ` Hailiang Zhang
2016-01-27  0:37         ` Hailiang Zhang
2016-01-27  5:59           ` Jason Wang
2016-01-27  6:41             ` Hailiang Zhang
2016-01-22  8:36 ` [Qemu-devel] [PATCH RFC 7/7] net/filter: prevent the default filter to be deleted zhanghailiang
2016-01-25  5:25   ` Jason Wang
2016-01-25  7:43     ` Hailiang Zhang
2016-01-22  8:53 ` [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter Hailiang Zhang
2016-01-22 10:07 ` Daniel P. Berrange
2016-01-22 10:35   ` Hailiang Zhang
2016-01-22 10:38     ` Daniel P. Berrange
2016-01-25  1:59       ` Hailiang Zhang
2016-01-25  5:24         ` Hailiang Zhang
2016-01-25  3:32   ` Jason Wang
2016-01-25  5:49     ` Hailiang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453451811-11860-4-git-send-email-zhang.zhanghailiang@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.