From: Jason Wang <jasowang@redhat.com>
To: Hailiang Zhang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: peter.huangpeng@huawei.com, zhangchen.fnst@cn.fujitsu.com,
hongyang.yang@easystack.cn
Subject: Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network'
Date: Tue, 26 Jan 2016 11:05:39 +0800 [thread overview]
Message-ID: <56A6E283.7050906@redhat.com> (raw)
In-Reply-To: <56A5B98B.8060609@huawei.com>
On 01/25/2016 01:58 PM, Hailiang Zhang wrote:
> On 2016/1/25 13:01, Jason Wang wrote:
>>
>>
>> On 01/22/2016 04:36 PM, zhanghailiang wrote:
>>> The properties of netfilter object could be changed by 'qom-set'
>>> command, but the output of 'info network' command is not updated,
>>> because it got the old information through nf->info_str, it will
>>> not be updated while we change the value of netfilter's property.
>>>
>>> Here we split a the helper function that could colletct the output
>>> information for filter, and also remove the useless member
>>> 'info_str' from struct NetFilterState.
>>>
>>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>>> ---
>>
>> Looks like a bug fix. Please send as a independent formal patch and
>> better cc Markus and Eric for better reviewing.
>>
>
> OK, by the way, i didn't see there was a corresponding qmp command
> for 'info network', is the hmp_info_network just an experimental
> command ?
It's for debugging I think , and if you want it to be used by
management, probably need a qmp version.
Thanks
next prev parent reply other threads:[~2016-01-26 3:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 8:36 [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter zhanghailiang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network' zhanghailiang
2016-01-25 5:01 ` Jason Wang
2016-01-25 5:58 ` Hailiang Zhang
2016-01-26 3:05 ` Jason Wang [this message]
2016-01-26 3:34 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 2/7] net/filter: Add a 'status' property for filter object zhanghailiang
2016-01-25 5:05 ` Jason Wang
2016-01-25 6:00 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 3/7] net/filter: Skip the disabled filter when delivering packets zhanghailiang
2016-01-22 9:32 ` Wen Congyang
2016-01-25 5:04 ` Jason Wang
2016-01-25 5:59 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 4/7] net/filter: Introduce a helper to add a filter to the netdev zhanghailiang
2016-01-25 5:20 ` Jason Wang
2016-01-25 7:42 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval zhanghailiang
2016-01-25 5:19 ` Jason Wang
2016-01-25 7:41 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev zhanghailiang
2016-01-25 5:18 ` Jason Wang
2016-01-25 7:22 ` Hailiang Zhang
2016-01-25 11:19 ` Hailiang Zhang
2016-01-27 3:29 ` Jason Wang
2016-01-26 3:18 ` Jason Wang
2016-01-26 3:39 ` Hailiang Zhang
2016-01-27 0:37 ` Hailiang Zhang
2016-01-27 5:59 ` Jason Wang
2016-01-27 6:41 ` Hailiang Zhang
2016-01-22 8:36 ` [Qemu-devel] [PATCH RFC 7/7] net/filter: prevent the default filter to be deleted zhanghailiang
2016-01-25 5:25 ` Jason Wang
2016-01-25 7:43 ` Hailiang Zhang
2016-01-22 8:53 ` [Qemu-devel] [PATCH RFC 0/7] Netfilter: Add each netdev a default filter Hailiang Zhang
2016-01-22 10:07 ` Daniel P. Berrange
2016-01-22 10:35 ` Hailiang Zhang
2016-01-22 10:38 ` Daniel P. Berrange
2016-01-25 1:59 ` Hailiang Zhang
2016-01-25 5:24 ` Hailiang Zhang
2016-01-25 3:32 ` Jason Wang
2016-01-25 5:49 ` Hailiang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6E283.7050906@redhat.com \
--to=jasowang@redhat.com \
--cc=hongyang.yang@easystack.cn \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.